upstream/terraform
1
0
Fork 0
mirror of https://github.com/hashicorp/terraform.git synced 2026-02-18 18:29:44 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

avoid unknowns in OpenEphemeralResource

Browse source 
Ephemeral resources can't be opened if the configuration contains
unknown values.
This commit is contained in:
James Bardin 2024-11-06 12:55:51 -05:00
parent f0b00c45f7
commit 4a9d46f9df
2 changed files with 26 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
internal/resources/ephemeral/ephemeral_resources.go
View file

@ -212,6 +212,11 @@ type resourceInstanceInternal struct {
func (r *resourceInstanceInternal) close(ctx context.Context) tfdiags.Diagnostics {
var diags tfdiags.Diagnostics
// if the resource could not be opened, there will not be anything to close either
if r.impl == nil {
return diags
}
// Stop renewing, if indeed we are. If we previously saw any errors during
// renewing then they finally get returned here, to be reported along with
// any errors during close.

21
internal/terraform/node_resource_ephemeral.go
View file

@ -73,6 +73,27 @@ func ephemeralResourceOpen(ctx EvalContext, inp ephemeralResourceInput) (*provid
}
unmarkedConfigVal, configMarks := configVal.UnmarkDeepWithPaths()
if !unmarkedConfigVal.IsWhollyKnown() {
log.Printf("[DEBUG] ehpemeralResourceOpen: configuration for %s contains unknown values, cannot open resource", inp.addr)
// We don't know what the result will be, but we need to keep the
// configured attributes for consistent evaluation. We can use the same
// technique we used for data sources to create the plan-time value.
unknownResult := objchange.PlannedDataResourceObject(schema, unmarkedConfigVal)
// add back any configured marks
unknownResult = unknownResult.MarkWithPaths(configMarks)
// and mark the entire value as ephemeral, since it's coming from an ephemeral context.
unknownResult = unknownResult.Mark(marks.Ephemeral)
// The state of ephemerals all comes from the registered instances, so
// we still need to register something so evaluation doesn't fail.
ephemerals.RegisterInstance(ctx.StopCtx(), inp.addr, ephemeral.ResourceInstanceRegistration{
Value: unknownResult,
ConfigBody: config.Config,
})
return nil, diags
}
validateResp := provider.ValidateEphemeralResourceConfig(providers.ValidateEphemeralResourceConfigRequest{
TypeName: inp.addr.Resource.Resource.Type,
Config: unmarkedConfigVal,