From 1b8fb4083a129c04bbbb835ed1c504bb589edccf Mon Sep 17 00:00:00 2001 From: James Bardin Date: Tue, 28 Apr 2020 17:14:15 -0400 Subject: [PATCH] allow depends_on in module call --- configs/module_call.go | 8 -------- configs/module_call_test.go | 1 - 2 files changed, 9 deletions(-) diff --git a/configs/module_call.go b/configs/module_call.go index cf6d1acbd9..25f0481362 100644 --- a/configs/module_call.go +++ b/configs/module_call.go @@ -87,14 +87,6 @@ func decodeModuleBlock(block *hcl.Block, override bool) (*ModuleCall, hcl.Diagno deps, depsDiags := decodeDependsOn(attr) diags = append(diags, depsDiags...) mc.DependsOn = append(mc.DependsOn, deps...) - - // We currently parse this, but don't yet do anything with it. - diags = append(diags, &hcl.Diagnostic{ - Severity: hcl.DiagError, - Summary: "Reserved argument name in module block", - Detail: fmt.Sprintf("The name %q is reserved for use in a future version of Terraform.", attr.Name), - Subject: &attr.NameRange, - }) } if attr, exists := content.Attributes["providers"]; exists { diff --git a/configs/module_call_test.go b/configs/module_call_test.go index d1164635ee..79ad89e626 100644 --- a/configs/module_call_test.go +++ b/configs/module_call_test.go @@ -20,7 +20,6 @@ func TestLoadModuleCall(t *testing.T) { file, diags := parser.LoadConfigFile("module-calls.tf") assertExactDiagnostics(t, diags, []string{ - `module-calls.tf:22,3-13: Reserved argument name in module block; The name "depends_on" is reserved for use in a future version of Terraform.`, `module-calls.tf:20,3-11: Invalid combination of "count" and "for_each"; The "count" and "for_each" meta-arguments are mutually-exclusive, only one should be used to be explicit about the number of resources to be created.`, })