From fdd628e915a2797da40b6110e28c44feabc54dd5 Mon Sep 17 00:00:00 2001
From: Martin <Junkern@users.noreply.github.com>
Date: Mon, 1 Aug 2022 08:44:47 +0200
Subject: [PATCH] fix: Add ForceTrue to docker_image name attribute. (#421)

* fix: Add ForceTrue to docker_image name attribute.

* fix: Test for docker_image name attribute change does not need to check for specific sha sums.
---
 internal/provider/resource_docker_image.go    |  1 +
 .../provider/resource_docker_image_test.go    | 26 +++++++++++++++++++
 .../docker_image/testAccDockerImageName.tf    | 12 +++++++++
 3 files changed, 39 insertions(+)
 create mode 100644 testdata/resources/docker_image/testAccDockerImageName.tf

diff --git a/internal/provider/resource_docker_image.go b/internal/provider/resource_docker_image.go
index c87ac44a..a7181321 100644
--- a/internal/provider/resource_docker_image.go
+++ b/internal/provider/resource_docker_image.go
@@ -18,6 +18,7 @@ func resourceDockerImage() *schema.Resource {
 				Type:        schema.TypeString,
 				Description: "The name of the Docker image, including any tags or SHA256 repo digests.",
 				Required:    true,
+				ForceNew:    true,
 			},
 
 			"latest": {
diff --git a/internal/provider/resource_docker_image_test.go b/internal/provider/resource_docker_image_test.go
index 0b8c3fe8..8ed76a2d 100644
--- a/internal/provider/resource_docker_image_test.go
+++ b/internal/provider/resource_docker_image_test.go
@@ -233,6 +233,32 @@ func TestAccDockerImage_data_private_config_file_content(t *testing.T) {
 	})
 }
 
+// Changing the name attribute should also force a change of the dependent docker container
+// This test fails, if we remove the ForceTrue: true from the name attribute
+func TestAccDockerImage_name_attr_change(t *testing.T) {
+	resource.Test(t, resource.TestCase{
+		PreCheck:                  func() { testAccPreCheck(t) },
+		ProviderFactories:         providerFactories,
+		PreventPostDestroyRefresh: true,
+		Steps: []resource.TestStep{
+			{
+				Config: fmt.Sprintf(loadTestConfiguration(t, RESOURCE, "docker_image", "testAccDockerImageName"), "ubuntu:precise@sha256:18305429afa14ea462f810146ba44d4363ae76e4c8dfc38288cf73aa07485005"),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestMatchResourceAttr("docker_image.ubuntu", "latest", contentDigestRegexp),
+					resource.TestMatchResourceAttr("docker_image.ubuntu", "repo_digest", imageRepoDigestRegexp),
+				),
+			},
+			{
+				Config: fmt.Sprintf(loadTestConfiguration(t, RESOURCE, "docker_image", "testAccDockerImageName"), "ubuntu:jammy@sha256:b6b83d3c331794420340093eb706a6f152d9c1fa51b262d9bf34594887c2c7ac"),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestMatchResourceAttr("docker_image.ubuntu", "latest", contentDigestRegexp),
+					resource.TestMatchResourceAttr("docker_image.ubuntu", "repo_digest", imageRepoDigestRegexp),
+				),
+			},
+		},
+	})
+}
+
 func TestAccDockerImage_sha265(t *testing.T) {
 	ctx := context.Background()
 	resource.Test(t, resource.TestCase{
diff --git a/testdata/resources/docker_image/testAccDockerImageName.tf b/testdata/resources/docker_image/testAccDockerImageName.tf
new file mode 100644
index 00000000..76fa09e3
--- /dev/null
+++ b/testdata/resources/docker_image/testAccDockerImageName.tf
@@ -0,0 +1,12 @@
+resource "docker_image" "ubuntu" {
+  name = "%s"
+}
+
+resource "docker_container" "foo" {
+  depends_on = [
+    docker_image.ubuntu
+  ]
+  image   = docker_image.ubuntu.latest
+  name    = "foobar"
+  command = ["sh", "-c", "while true ;do wait ;done"]
+}