mirror of
https://github.com/kreuzwerker/terraform-provider-docker.git
synced 2025-12-24 00:29:46 -05:00
provider/docker network alias (#14710)
* Add Network Alias configuration with network options * Handle case where there's no network option * Handle use case where network option is not available * Handle use case where network option is not available * Network alias only on user defined network * Update documentation for docker provider on network aliases * Remove unused variable * Update documentation * add unit test for docker container network * fix unit test for docker container network
This commit is contained in:
parent
4e40753b5a
commit
7446f70146
3 changed files with 27 additions and 1 deletions
|
|
@ -376,6 +376,14 @@ func resourceDockerContainer() *schema.Resource {
|
|||
ForceNew: true,
|
||||
},
|
||||
|
||||
"network_alias": &schema.Schema{
|
||||
Type: schema.TypeSet,
|
||||
Optional: true,
|
||||
ForceNew: true,
|
||||
Elem: &schema.Schema{Type: schema.TypeString},
|
||||
Set: schema.HashString,
|
||||
},
|
||||
|
||||
"network_mode": &schema.Schema{
|
||||
Type: schema.TypeString,
|
||||
Optional: true,
|
||||
|
|
|
|||
|
|
@ -188,7 +188,14 @@ func resourceDockerContainerCreate(d *schema.ResourceData, meta interface{}) err
|
|||
d.SetId(retContainer.ID)
|
||||
|
||||
if v, ok := d.GetOk("networks"); ok {
|
||||
connectionOpts := dc.NetworkConnectionOptions{Container: retContainer.ID}
|
||||
var connectionOpts dc.NetworkConnectionOptions
|
||||
if v, ok := d.GetOk("network_alias"); ok {
|
||||
endpointConfig := &dc.EndpointConfig{}
|
||||
endpointConfig.Aliases = stringSetToStringSlice(v.(*schema.Set))
|
||||
connectionOpts = dc.NetworkConnectionOptions{Container: retContainer.ID, EndpointConfig: endpointConfig}
|
||||
} else {
|
||||
connectionOpts = dc.NetworkConnectionOptions{Container: retContainer.ID}
|
||||
}
|
||||
|
||||
for _, rawNetwork := range v.(*schema.Set).List() {
|
||||
network := rawNetwork.(string)
|
||||
|
|
|
|||
|
|
@ -203,6 +203,10 @@ func TestAccDockerContainer_customized(t *testing.T) {
|
|||
return fmt.Errorf("Container has incorrect extra host string: %q", c.HostConfig.ExtraHosts[1])
|
||||
}
|
||||
|
||||
if _, ok := c.NetworkSettings.Networks["test"]; !ok {
|
||||
return fmt.Errorf("Container is not connected to the right user defined network: test")
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
|
|
@ -370,6 +374,9 @@ resource "docker_container" "foo" {
|
|||
}
|
||||
network_mode = "bridge"
|
||||
|
||||
networks = ["${docker_network.test_network.name}"]
|
||||
network_alias = ["tftest"]
|
||||
|
||||
host {
|
||||
host = "testhost"
|
||||
ip = "10.0.1.0"
|
||||
|
|
@ -380,6 +387,10 @@ resource "docker_container" "foo" {
|
|||
ip = "10.0.2.0"
|
||||
}
|
||||
}
|
||||
|
||||
resource "docker_network" "test_network" {
|
||||
name = "test"
|
||||
}
|
||||
`
|
||||
|
||||
const testAccDockerContainerUploadConfig = `
|
||||
|
|
|
|||
Loading…
Reference in a new issue