From 5d1e55cf1b87739eb4475f657c4b652ee8a770dd Mon Sep 17 00:00:00 2001 From: Nolan Woods Date: Thu, 8 Oct 2020 10:01:48 -0700 Subject: [PATCH] feat: conditionally adding port binding (#293). Set external = 0 to assign a random external port. Closes #255 Co-authored-by: Nolan Woods --- docker/resource_docker_container_funcs.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docker/resource_docker_container_funcs.go b/docker/resource_docker_container_funcs.go index ae451c05..2160323a 100644 --- a/docker/resource_docker_container_funcs.go +++ b/docker/resource_docker_container_funcs.go @@ -930,7 +930,9 @@ func portSetToDockerPorts(ports []interface{}) (map[nat.Port]struct{}, map[nat.P portBinding.HostIP = ip } - retPortBindings[exposedPort] = append(retPortBindings[exposedPort], portBinding) + if extOk || ipOk { + retPortBindings[exposedPort] = append(retPortBindings[exposedPort], portBinding) + } } return retExposedPorts, retPortBindings