upstream/terraform-provider-docker
1
0
Fork 0
mirror of https://github.com/kreuzwerker/terraform-provider-docker.git synced 2026-01-04 05:49:35 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #47 from captn3m0/docker-link-warning

Browse source 
deprecate and add warning about the link feature
This commit is contained in:
kt 2018-05-24 22:07:38 -07:00 committed by GitHub
commit 593272e037
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
docker/resource_docker_container.go
View file

@ -284,11 +284,12 @@ func resourceDockerContainer() *schema.Resource {
},
"links": &schema.Schema{
Type: schema.TypeSet,
Optional: true,
ForceNew: true,
Elem: &schema.Schema{Type: schema.TypeString},
Set: schema.HashString,
Type: schema.TypeSet,
Optional: true,
ForceNew: true,
Elem: &schema.Schema{Type: schema.TypeString},
Set: schema.HashString,
Deprecated: "The --link flag is a legacy feature of Docker. It may eventually be removed.",
},
"ip_address": &schema.Schema{

9
website/docs/r/container.html.markdown
View file

@ -53,6 +53,12 @@ The following arguments are supported:
container.
* `links` - (Optional, set of strings) Set of links for link based
connectivity between containers that are running on the same host.
~> **Warning** The --link flag is a legacy feature of Docker. It may eventually
be removed. It exposes _all_ environment variables originating from Docker to
any linked containers. This could have serious security implications if sensitive
data is stored in them. See [the docker documentation][linkdoc] for more details.
* `hostname` - (Optional, string) Hostname of the container.
* `domainname` - (Optional, string) Domain name of the container.
* `restart` - (Optional, string) The restart policy for the container. Must be
@ -205,3 +211,6 @@ The following attributes are exported:
NetworkSettings.
* `bridge` - The network bridge of the container as read from its
NetworkSettings.
[linkdoc] https://docs.docker.com/network/links/