From 1e5589471566f7bd08c87f489848cb052bf45838 Mon Sep 17 00:00:00 2001 From: Shunsuke Suzuki Date: Tue, 30 Nov 2021 15:51:49 +0900 Subject: [PATCH] fix(container): remove log_driver's default value and make log_driver `computed` (#270) * fix(container): remove log_driver's default value and make log_driver `computed` * fix: update the description * docs: make website-generation Co-authored-by: Manuel Vogel --- docs/resources/container.md | 2 +- internal/provider/resource_docker_container.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/resources/container.md b/docs/resources/container.md index 1c60ae2a..467adcdc 100644 --- a/docs/resources/container.md +++ b/docs/resources/container.md @@ -57,7 +57,7 @@ resource "docker_image" "ubuntu" { - **ipc_mode** (String) IPC sharing mode for the container. Possible values are: `none`, `private`, `shareable`, `container:` or `host`. - **labels** (Block Set) User-defined key/value metadata (see [below for nested schema](#nestedblock--labels)) - **links** (Set of String, Deprecated) Set of links for link based connectivity between containers that are running on the same host. -- **log_driver** (String) The logging driver to use for the container. Defaults to `json-file`. +- **log_driver** (String) The logging driver to use for the container. - **log_opts** (Map of String) Key/value pairs to use as options for the logging driver. - **logs** (Boolean) Save the container logs (`attach` must be enabled). Defaults to `false`. - **max_retry_count** (Number) The maximum amount of times to an attempt a restart when `restart` is set to 'on-failure'. diff --git a/internal/provider/resource_docker_container.go b/internal/provider/resource_docker_container.go index b69d22d2..82ec89b2 100644 --- a/internal/provider/resource_docker_container.go +++ b/internal/provider/resource_docker_container.go @@ -708,8 +708,8 @@ func resourceDockerContainer() *schema.Resource { "log_driver": { Type: schema.TypeString, - Description: "The logging driver to use for the container. Defaults to `json-file`.", - Default: "json-file", + Description: "The logging driver to use for the container.", + Computed: true, Optional: true, ForceNew: true, },