From 3ab68d4d11f16a7a1e62253da14b1bd1214f5d23 Mon Sep 17 00:00:00 2001 From: crazycatz00 Date: Sun, 16 Nov 2025 11:48:29 -0500 Subject: [PATCH] fs: Clarified documentation --- changelog/unreleased/pull-5424 | 4 ++-- internal/fs/priv_windows_test.go | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/changelog/unreleased/pull-5424 b/changelog/unreleased/pull-5424 index 044095914..43fbe7fdf 100644 --- a/changelog/unreleased/pull-5424 +++ b/changelog/unreleased/pull-5424 @@ -1,6 +1,6 @@ -Enhancement: Enable file system privileges before access +Enhancement: Enable file system privileges on Windows before access -Restic attempted to enable (Windows) file system privileges when +Restic attempted to enable Windows file system privileges when reading or writing security descriptors - after potentially being wholly denied access to previous items. It also read file extended attributes without using the privilege, possibly missing them and producing errors. diff --git a/internal/fs/priv_windows_test.go b/internal/fs/priv_windows_test.go index 01e94c8b2..7851194a6 100644 --- a/internal/fs/priv_windows_test.go +++ b/internal/fs/priv_windows_test.go @@ -50,6 +50,7 @@ func testGetRestrictedFilePath(t *testing.T) string { test.OK(t, testfile.Close()) // Set restricted permissions. + // Deny file read/write/execute to "Everyone" (all accounts); allow delete to "Everyone". sd, err := windows.SecurityDescriptorFromString("D:PAI(D;;FRFWFX;;;WD)(A;;SD;;;WD)") test.OK(t, errors.Wrap(err, "failed to parse SDDL: %s")) dacl, _, err := sd.DACL()