From 3270f2d54e76e5680d2a529c4dc30c86333c810e Mon Sep 17 00:00:00 2001 From: Valentino Geron Date: Sun, 7 Aug 2022 16:32:31 +0300 Subject: [PATCH] Tests: improve skip tags around resp3 (#11090) some skip tags were missing on some tests avoid using HELLO if denytags has resp3 (target server may not support it) Co-authored-by: Valentino Geron --- tests/unit/scripting.tcl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/unit/scripting.tcl b/tests/unit/scripting.tcl index cca24c1bd..e45c9f41c 100644 --- a/tests/unit/scripting.tcl +++ b/tests/unit/scripting.tcl @@ -677,7 +677,7 @@ start_server {tags {"scripting"}} { assert_equal $res $expected_list set res [run_script {redis.setresp(2); return redis.call('hgetall', KEYS[1])} 1 hash] assert_equal $res $expected_list - } + } {} {resp3} test {Script return recursive object} { r readraw 1 @@ -1231,8 +1231,12 @@ start_server {tags {"scripting needs:debug"}} { for {set i 2} {$i <= 3} {incr i} { for {set client_proto 2} {$client_proto <= 3} {incr client_proto} { + if {[lsearch $::denytags "resp3"] >= 0} { + if {$client_proto == 3} {continue} + } else { + r hello $client_proto + } set extra "RESP$i/$client_proto" - r hello $client_proto r readraw 1 test "test $extra big number protocol parsing" {