mirror of
https://github.com/prometheus/prometheus.git
synced 2026-05-28 04:02:21 -04:00
26088d01b9
The position range of nested aggregate expression was wrong, for the expression "(sum(foo))" the position of "sum(foo)" should be 1-9, but the parser could not decide the end of the expression on pos 9, instead it read ahead to pos 10 and then emitted the aggregate. But we only kept the last closing position (10) and wrote that into the aggregate. The reason for this is that the parser cannot know from "(sum(foo)" alone if the aggregate is finished. It could be finished as in "(sum(foo))" but equally it could continue with group modifier as "(sum(foo) by (bar))". The fix is to track ")" tokens in a stack in addition to the lastClosing position, which is overloaded with other things like offset number tracking. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> |
||
|---|---|---|
| .. | ||
| fuzz-data | ||
| parser | ||
| promqltest | ||
| bench_test.go | ||
| engine.go | ||
| engine_internal_test.go | ||
| engine_test.go | ||
| functions.go | ||
| functions_internal_test.go | ||
| functions_test.go | ||
| fuzz.go | ||
| fuzz_test.go | ||
| histogram_stats_iterator.go | ||
| histogram_stats_iterator_test.go | ||
| info.go | ||
| info_test.go | ||
| promql_test.go | ||
| quantile.go | ||
| quantile_test.go | ||
| query_logger.go | ||
| query_logger_test.go | ||
| value.go | ||
| value_test.go | ||