prometheus/discovery/aws
Will Bollock 4aa8941eb1
Some checks are pending
buf.build / lint and publish (push) Waiting to run
CI / Go tests (push) Waiting to run
CI / More Go tests (push) Waiting to run
CI / Go tests with previous Go version (push) Waiting to run
CI / UI tests (push) Waiting to run
CI / Go tests on Windows (push) Waiting to run
CI / Mixins tests (push) Waiting to run
CI / Build Prometheus for common architectures (push) Waiting to run
CI / Build Prometheus for all architectures (push) Waiting to run
CI / Report status of build Prometheus for all architectures (push) Blocked by required conditions
CI / Check generated parser (push) Waiting to run
CI / golangci-lint (push) Waiting to run
CI / fuzzing (push) Waiting to run
CI / codeql (push) Waiting to run
CI / Publish main branch artifacts (push) Blocked by required conditions
CI / Publish release artefacts (push) Blocked by required conditions
CI / Publish UI on npm Registry (push) Blocked by required conditions
Scorecards supply-chain security / Scorecards analysis (push) Waiting to run
fix(discovery): aws discovery test fix (#17527)
* fix: aws discovery test fix

Fixes a problem introduced after the merge of this https://github.com/prometheus/prometheus/pull/17138

PR didn't take into account another merged PR!

```
discovery/aws/aws.go:218:54: too many arguments in call to NewEC2Discovery
    have (*EC2SDConfig, *slog.Logger, *ec2Metrics)
    want (*EC2SDConfig, discovery.DiscovererOptions)
discovery/aws/aws.go:222:66: too many arguments in call to NewLightsailDiscovery
    have (*LightsailSDConfig, *slog.Logger, *lightsailMetrics)
    want (*LightsailSDConfig, discovery.DiscovererOptions)
```

Signed-off-by: Will Bollock <wbollock@linode.com>

* fix: align ecs style

ECS was a new service discovery tool added after this PR was merged: https://github.com/prometheus/prometheus/pull/17138

Aligns the style of passing a single "opts" to it like almost all the other
service discovery engines now use

Signed-off-by: Will Bollock <wbollock@linode.com>

---------

Signed-off-by: Will Bollock <wbollock@linode.com>
2025-11-16 10:28:50 +00:00
..
aws.go fix(discovery): aws discovery test fix (#17527) 2025-11-16 10:28:50 +00:00
aws_test.go feat: AWS ECS Service Discovery 2025-11-06 22:48:07 +00:00
ec2.go Merge pull request #17138 from wbollock/feat/prometheus_refresh_config_label 2025-11-13 14:51:39 +01:00
ec2_test.go Fix merge formatting 2025-08-07 21:17:21 -04:00
ecs.go fix(discovery): aws discovery test fix (#17527) 2025-11-16 10:28:50 +00:00
ecs_test.go feat: AWS ECS Service Discovery 2025-11-06 22:48:07 +00:00
lightsail.go Merge pull request #17138 from wbollock/feat/prometheus_refresh_config_label 2025-11-13 14:51:39 +01:00
metrics_aws.go feat: AWS ECS Service Discovery 2025-11-06 22:48:07 +00:00
metrics_ec2.go chore: enable unused-receiver rule from revive 2025-08-04 09:43:33 +00:00
metrics_ecs.go feat: AWS ECS Service Discovery 2025-11-06 22:48:07 +00:00
metrics_lightsail.go chore: enable unused-receiver rule from revive 2025-08-04 09:43:33 +00:00