16879 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Bartlomiej Plotka	d10d3df345	Merge pull request #17679 from bboreham/remove-labelvaluefor ... [CHORE] TSDB: Remove unused LabelValueFor function	2025-12-12 16:52:09 +00:00
bwplotka	763b935b45	refactor(tsdb/agent): 1:1 copy of db.go and db_test.go for starting point ... Signed-off-by: bwplotka <bwplotka@gmail.com>	2025-12-12 15:20:42 +00:00
Julien Pivotto	6efbb873c7	promql: Fix collision error with delayed name removal for non-overlapping series ... Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	2025-12-12 14:50:29 +01:00
Bryan Boreham	41665a4a55	[CHORE] TSDB: Remove unused LabelValueFor function ... The last use of this was removed 4 years ago. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2025-12-12 13:44:13 +00:00
Rushabh Mehta	c2b86775b6	scrape: Fix potential goroutine leak in scrapeAndReport (#17554) ... * [scrape] Fix potential goroutine leak in scrape loop Signed-off-by: Rushabh Mehta <mehtarushabh2005@gmail.com> * Use correct error var Signed-off-by: Rushabh Mehta <mehtarushabh2005@gmail.com> * Add regression test Signed-off-by: Rushabh Mehta <mehtarushabh2005@gmail.com> --------- Signed-off-by: Rushabh Mehta <mehtarushabh2005@gmail.com>	2025-12-12 14:01:57 +01:00
Bryan Boreham	583bc01cc9	Refactor: TSDB: small improvement to Postings (#17661) ... * [TESTS] TSDB: Check that ListPostings are sorted `newListPostings` is a convenient place to do this; move it into the test file because it's not needed for anything else. Also simplify the existing `SliceIsSorted` check. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * [COMMENTS] TSDB: Document that Postings are ordered. The description of `Seek()` implies they are, but it's better to be explicit. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * [REFACTOR] Unexport ListPostings type It's only used within the one package, and it would be surprising if some downstream code did rely on this type, given all of its members are unexported. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> --------- Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2025-12-11 08:14:35 +00:00
Hélia Barroso	952efe77ad	Merge pull request #17667 from heliapb/fix/changelog ... fix: add correct pr in unified AWS SD in prometheus changelog	2025-12-11 08:11:42 +00:00
Bartlomiej Plotka	285e6891ec	Merge pull request #17663 from prometheus/bwplotka-patch-7 ... docs: Add krajorama as TSDB maintainer	2025-12-11 07:57:39 +00:00
Julien Pivotto	d0b122a711	PromQL: duration expression: add range() ... Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	2025-12-10 16:27:18 +01:00
Julius Volz	19b794579b	Merge pull request #17668 from prometheus/fix-cmpop-many-to-one-tracking ... PromQL: Fix insufficient cardinality checking for filter ops	2025-12-10 15:06:05 +01:00
Julius Volz	4cad87cae8	PromQL: Fix insufficient cardinality checking for filter ops ... Generally, binary operations between two vectors fail if there is a many-to-one or one-to-many matching situation between series within a match group and no `group_left()` or `group_right()` modifier is present. For filter ops this is also generally the case, but there can be situations where multiple series on one side can match a single series on the other side, but only 0 or 1 of those multiple series remains after the filter operator has been applied. In this case, the PromQL engine does not produce a matching error, since it only tracks series matching for those series that survive the filtering. IMO this is incorrect behavior (which can also erratically make a query sometimes fail and sometimes succeed, depending on current sample values), and we should always produce an error if there is a match error prior to applying the filter op. This PR ensures that we do the cardinality / match tracking independently of the result of the filter operation. Signed-off-by: Julius Volz <julius.volz@gmail.com>	2025-12-10 11:31:46 +01:00
Julien	f73aba34cd	Merge pull request #17427 from roidelapluie/roidelapluie/ffapi ... API: Add a /api/v1/features endpoint	2025-12-10 10:14:03 +01:00
Julien Pivotto	a5671a002f	API: Add a /api/v1/features endpoint ... Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	2025-12-09 16:13:14 +01:00
Julien	e77dd5bec2	Merge pull request #17647 from roidelapluie/roidelapluie/resource-limit-fix ... web/api: Add maximum limit validation to TSDB status endpoint	2025-12-09 16:06:09 +01:00
Julien Pivotto	5b26619565	web/api: Add maximum limit validation to TSDB status endpoint ... Add a maximum limit of 10,000 to the TSDB status endpoint to prevent resource exhaustion from excessively large limit values, as we preallocate []Stat for up to the limit: `make([]Stat, 0, length)`. Note that the endpoint acquires a cardinality mutex during stats calculation, so this can not be run in parallel. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	2025-12-09 14:30:08 +01:00
Bartlomiej Plotka	be419d80dc	Merge pull request #17629 from prometheus/bwplotka/a2-tsdb ... refactor(appenderV2)[PART1]: add AppenderV2 interface; add TSDB AppenderV2 implementation	2025-12-09 11:41:00 +00:00
Bartlomiej Plotka	a1fcac9078	maintainers: Add krajoma as TSDB maintainer ... This is to help with interface switch we are doing https://github.com/prometheus/prometheus/issues/17632 See https://cloud-native.slack.com/archives/C01AUBA4PFE/p1765277201832839?thread_ts=1765199584.855979&cid=C01AUBA4PFE Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	2025-12-09 10:48:44 +00:00
bwplotka	e7e45090e4	refactor(appenderV2): port TSDB non-head tests ... Signed-off-by: bwplotka <bwplotka@gmail.com>	2025-12-09 10:39:45 +00:00
bwplotka	0b70a07572	refactor(appenderV2): add TSDB AppenderV2 implementation ... Signed-off-by: bwplotka <bwplotka@gmail.com> tmp Signed-off-by: bwplotka <bwplotka@gmail.com>	2025-12-09 10:39:43 +00:00
bwplotka	a41e1144dd	refactor(appenderV2): 1:1 copy of db_test.go to db_append_v2_test.go (starting point) ... Signed-off-by: bwplotka <bwplotka@gmail.com>	2025-12-09 09:53:39 +00:00
bwplotka	efdfb8fed6	refactor(appenderV2): 1:1 copy of head append test files for v2 (starting point) ... Signed-off-by: bwplotka <bwplotka@gmail.com>	2025-12-09 09:53:39 +00:00
bwplotka	129650df9d	refactor(appenderV2): 1:1 copy of head_append.go -> head_append_v2.go (starting point) ... Signed-off-by: bwplotka <bwplotka@gmail.com>	2025-12-09 09:53:39 +00:00
bwplotka	04696703fe	refactor(appenderV2): add AppenderV2 interface ... Signed-off-by: bwplotka <bwplotka@gmail.com>	2025-12-09 09:53:34 +00:00
Julius Volz	a4ed100874	Merge pull request #17657 from intojhanurag/discovery/unregister-refresh-metrics ... discovery: Add ability to unregister refresh metrics in tests	2025-12-08 19:09:28 +01:00
intojhanurag	1ccc0fed81	Revert triton_test.go and kuma_test.go to main version ... Signed-off-by: intojhanurag <aojharaj2004@gmail.com>	2025-12-08 16:51:22 +00:00
intojhanurag	ea072fd56a	Added cleanup closure in kuma test ... Signed-off-by: intojhanurag <aojharaj2004@gmail.com>	2025-12-08 08:35:52 +00:00
intojhanurag	0251e888f9	Refactor Triton tests to simplify metrics cleanup using cleanup closure ... Signed-off-by: intojhanurag <aojharaj2004@gmail.com>	2025-12-08 08:26:24 +00:00
intojhanurag	025628f272	unregistering RefreshMetrics instances ... Signed-off-by: intojhanurag <aojharaj2004@gmail.com>	2025-12-06 19:50:49 +00:00
dongjiang	3239723098	Update golangci-lint and add modernize check (#17640) ... * add modernize check Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * fix golangci lint Signed-off-by: dongjiang1989 <dongjiang1989@126.com> --------- Signed-off-by: dongjiang1989 <dongjiang1989@126.com>	2025-12-05 09:29:10 +01:00
Jorge Turrado	f0325c5875	apply feedback ... Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>	2025-12-04 16:00:18 +01:00
Julien	0279e14d4a	Merge pull request #17636 from roidelapluie/roidelapluie/starttime ... Add start_timestamp field for unit tests	2025-12-04 10:47:24 +01:00
Julien Pivotto	4620c8ac71	Simplify StartTime assignment in unit test setup. ... Remove redundant IsZero check since promqltest.LazyLoader already handles zero StartTime by defaulting to Unix epoch. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	2025-12-04 10:14:09 +01:00
Jan Fajerski	ac5bdd66d7	Merge pull request #17634 from jan--f/sync-release-3.8 ... Sync branch release-3.8	2025-12-03 21:26:45 +01:00
Julius Volz	22b3860e2a	Merge pull request #17643 from prometheus/fix-empty-ignoring-serialization ... Fix serialization for empty `ignoring()` in combination with `group_x()`	2025-12-03 15:43:04 +01:00
Julius Volz	39e11f50b2	Fix serialization for empty ignoring() in combination with group_x() ... Currently both the backend and frontend printers/formatters/serializers incorrectly transform the following expression: ``` up * ignoring() group_left(__name__) node_boot_time_seconds ``` ...into: ``` up * node_boot_time_seconds ``` ...which yields a different result (including the metric name in the result vs. no metric name). We need to keep empty `ignoring()` modifiers if there is a grouping modifier present. Signed-off-by: Julius Volz <julius.volz@gmail.com>	2025-12-03 14:15:16 +01:00
Julien Pivotto	1a853e23db	Add start_timestamp field for unit tests. ... This commit adds support for configuring a custom start timestamp for Prometheus unit tests, allowing tests to use realistic timestamps instead of starting at Unix epoch 0. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>	2025-12-03 11:20:23 +01:00
Bartlomiej Plotka	f6ca7145ca	refactor(tsdb): use one test newTestDB constructor (#17638) ... For tests only, we had various ways of opening DB. Reduced to one instead of: * Open * newTestDB * newTestDBOpts * openTestDB This so https://github.com/prometheus/prometheus/pull/17629 is smaller and bit easier. Also for test maintainability and consistency. Signed-off-by: bwplotka <bwplotka@gmail.com>	2025-12-03 07:55:48 +00:00
Jorge Turrado Ferrero	e69806289a	chore: Update docs to reflect new oauth parameters ... Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>	2025-12-02 22:52:46 +01:00
Gabriel Filion	9f0b52d73a	docs: Describe how time() is set to start at 0 in unit tests ... The return value of functions relating to the current time, e.g. time(), is set by promtool to start at timestamp 0 at the start of a test's evaluation. This has the very nice consequence that tests can run reliably without depending on when they are run. It does, however, mean that tests will give out results that can be unexpected by users. If this behaviour is documented, then users will be empowered to write tests for their rules that use time-dependent functions. (Closes: prometheus/docs#1464) Signed-off-by: Gabriel Filion <lelutin@torproject.org>	2025-12-02 16:57:01 +01:00
Julien	93edf912a7	Merge pull request #17630 from zjumathcode/main ... chore: Fix function name typo in createBatchSpan comment	2025-12-02 16:23:48 +01:00
Jan Fajerski	fae20b73ff	Merge branch 'release-3.8' into sync-release-3.8 ... Conflicts: storage/remote/write_handler.go storage/remote/write_handler_test.go Pick `main` Signed-off-by: Jan Fajerski <jfajersk@redhat.com>	2025-12-02 14:24:53 +01:00
Ben Edmunds	0e682a70a6	RW2: Allow custom scope in azuread (#17483) ... Signed-off-by: Ben Edmunds <sammybenblue2@gmail.com>	2025-12-02 11:45:23 +00:00
Łukasz Mierzwa	8a1086a128	feat: Add flag that blocks lvl 1 compactions until upload is confirmed in an external JSON file (#17435) ... * Delay compactions until Thanos uploads all blocks Using Thanos sidecar with Prometheus requires us to disable TSDB compactions on Prometheus side by setting --storage.tsdb.min-block-duration and --storage.tsdb.max-block-duration to the same value. See https://thanos.io/tip/components/sidecar.md. The main problem this avoids is that Prometheus might compact given block before Thanos uploads it, creating a gap in Thanos metrics. Thanos does not upload compacted blocks because that would upload the same sample multiple times. You can tell Thanos to upload compacted blocks but that is aimed at one time migrations. This patch creates a bridge between Thanos and Prometheus by allowing Prometheus to read the shipper file Thanos creates, where it tracks which blocks were already uploaded, and using that data delays compaction of blocks until they are marked as uploaded by Thanos. Thanks to this both services can coordinate with each other (in a way) and we can stop disabling compaction on Prometheus side when Thanos uploads are enabled. The reason to have this is that disabling compactions have very dramatic performance cost. Since most time series exist for longer than a single block duration (2h by default) large chunks of block index will reference the same series, so 10 * 2h blocks will each have an index that is usually fairly big and is almost the same for all 10 blocks. Compaction de-duplicates the index so merging 10 blocks together would leave us with a single index that is around the same size as each of these 10 2h blocks would have (plus some extra for series that only exists in some blocks, but not all). Every range query that iterates over all 10 blocks would then have to read each index and so we're doing 10x more work then if we had a single compacted block. Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com> * Rename structs and functions to make this more generic Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com> * Address review comments Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com> * Cache UploadMeta for 1 minute Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com> --------- Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>	2025-12-02 10:39:45 +00:00
Jan Fajerski	e44ed351cd	Merge pull request #17623 from jan--f/prep-rel-3.8.0 ... prepare release v3.8.0	2025-12-02 09:53:55 +01:00
zjumathcode	0ac2221a20	chore: Fix function name typo in createBatchSpan comment ... Signed-off-by: zjumathcode <pai314159@2980.com>	2025-12-01 19:14:19 +08:00
aviralgarg05	488466246f	promqltest: Fix test expectation for counter reset hint comparison ... The test at line 1283 for avg_over_time(nhcb_metric[13m]) incorrectly expected counter_reset_hint:gauge in the result. However, the actual avg_over_time implementation does not explicitly set the CounterResetHint to GaugeType on its output histogram. With the new counter reset hint comparison logic added to the promqltest framework (which compares hints when explicitly specified in expected results), this incorrect expectation was now being caught. This fix removes the incorrect counter_reset_hint:gauge from the expected result, allowing the test to correctly verify the avg_over_time behavior without asserting a specific hint value that the function does not set. The counter reset hint comparison logic works as designed: if the expected histogram has UnknownCounterReset (the default when not specified), no comparison is performed. Only when a hint is explicitly specified in the test expectation will it be compared against the actual result. Fixes the test failure introduced by the counter reset hint comparison feature in promqltest. Signed-off-by: Aviral Garg <aviralg2106@gmail.com> Signed-off-by: aviralgarg05 <gargaviral99@gmail.com>	2025-11-30 18:07:51 +05:30
aviralgarg05	e894d7a271	promqltest: Add optional counter reset hint comparison for native histograms ... This commit implements counter reset hint comparison in the promqltest framework to address issue #17615. Previously, while test definitions could specify a counter_reset_hint in expected native histogram results, the framework did not actually compare this hint between expected and actual results. The implementation adds optional comparison logic to the compareNativeHistogram function: - If the expected histogram has UnknownCounterReset (the default), the hint is not compared (meaning "don't care") - If the expected histogram explicitly specifies CounterReset, NotCounterReset, or GaugeType, it is verified against the actual histogram's hint This allows tests to verify that PromQL functions correctly set or preserve counter reset hints while maintaining backward compatibility with existing tests that don't specify explicit hints. Fixes #17615 Signed-off-by: aviralgarg05 <gargaviral99@gmail.com>	2025-11-30 13:34:19 +05:30
Jan Fajerski	73b1fda131	prepare release v3.8.0 ... Signed-off-by: Jan Fajerski <jfajersk@redhat.com>	2025-11-28 21:12:11 +01:00
Bryan Boreham	77ba5c5fbd	[PERF] Scraping: skip an unnecessary step when there are relabel rules ... Before it would do Builder->Labels->Builder, now we skip the conversions. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2025-11-28 15:07:40 +00:00
Nikos Angelopoulos	b0649e08c4	rules: replace error strings with sentinel errors for duplicate labelsets (#17620) ... Signed-off-by: Nikos Angelopoulos <nikolaos.angelopoulos@grafana.com>	2025-11-28 09:41:00 +00:00