Commit graph

16879 commits

Author SHA1 Message Date
Filip Petkovski
3e6155e596
Use CopyTo when resetting histogram in stats iterator
The histogram stats iterator does not fully clear the histogram object
and is not resilient to new fields being added to the histogram type.

To resolve the issue, the commit uses the CopyTo methods which should
be future proof to new fields being added.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
2024-07-31 11:18:47 +02:00
Charles Korn
7fab72a280
promqltest: add support for setting counter reset hint on histogram samples (#14537)
* promqltest: add support for setting counter reset hint on histogram samples

Signed-off-by: Charles Korn <charles.korn@grafana.com>
2024-07-31 09:53:05 +02:00
Bartlomiej Plotka
6816149852
Merge pull request #14525 from colega/merge-mmmaxtime-into-shardhash
Store `mmMaxTime` in same field as `seriesShard`
2024-07-31 08:39:38 +02:00
Matthieu MOREL
2880ee8e46 chore: provide OSSF security insight
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-07-31 06:36:02 +00:00
Callum Styan
1561815732
remote write: increase time threshold for resharding (#14450)
Don't reshard if we haven't successfully sent a sample in the last
shardUpdateDuration seconds.

Signed-off-by: Callum Styan <callumstyan@gmail.com>
Co-authored-by: kushagra Shukla <kushalshukla110@gmail.com>
2024-07-30 14:08:28 -07:00
Max Amin
84b819a69f
feat: add Google cloud roundtripper for remote write (#14346)
* feat: Google Auth for remote write

Signed-off-by: Max Amin <maxamin@google.com>

---------

Signed-off-by: Max Amin <maxamin@google.com>
2024-07-30 16:25:19 +01:00
pawarpranav83
2e0d4c6909 removed --enable-feature=remote-write-receiver flag
Signed-off-by: pawarpranav83 <pawar.pranav83@gmail.com>
2024-07-30 19:29:48 +05:30
Bryan Boreham
79a0ba9d64
Merge pull request #13503 from tylitianrui/chore/remove_redundance
remove redundant code
2024-07-30 12:44:03 +01:00
dependabot[bot]
6cef8698c2
build(deps-dev): bump @lezer/generator from 1.7.0 to 1.7.1 in /web/ui (#14382)
Bumps [@lezer/generator](https://github.com/lezer-parser/generator) from 1.7.0 to 1.7.1.
- [Changelog](https://github.com/lezer-parser/generator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/lezer-parser/generator/compare/1.7.0...1.7.1)

---
updated-dependencies:
- dependency-name: "@lezer/generator"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-07-30 13:30:49 +02:00
Julius Volz
c6d2ce8e7e Remove console.log() debug line
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-07-30 13:12:49 +02:00
Oleg Zaytsev
0300ad58a9
Revert the option regardless of error
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2024-07-30 11:31:31 +02:00
Bryan Boreham
2898d5d715 Add #14515 to CHANGELOG
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-07-30 10:15:23 +01:00
Bryan Boreham
03963b9ba0
Merge pull request #14515 from prometheus/revert-13777-remoteread2 (#14524)
Revert "Chunked remote read: close the querier earlier"

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-07-30 10:11:16 +01:00
Julius Volz
4343281c73 Show table alerts for limited series or disabled formatting
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-07-30 10:48:18 +02:00
Oleg Zaytsev
d8e1b6bdfd
Store mmMaxTime in same field as seriesShard
We don't use seriesShard during DB initialization, so we can use the
same 8 bytes to store mmMaxTime, and save those during the rest of the
lifetime of the database.

This doesn't affect CPU performance.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2024-07-30 10:20:29 +02:00
Oleg Zaytsev
b7f2f3c3ac
Add BenchmarkLoadRealWLs
This benchmark runs on real WLs rather than fake generated ones.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2024-07-30 10:19:56 +02:00
George Krajcsovits
395f7088c3
Merge pull request #14514 from fpetkovski/counter-reset-nan
Ignore stale histograms for counter reset detection
2024-07-30 08:43:06 +02:00
Bryan Boreham
3ee42e197a
Merge pull request #14499 from prometheus/rw1.0-clarify-deprecation
clarify that 1.0 will eventually be deprecated, it is not yet deprecated
2024-07-29 18:47:11 +01:00
Bryan Boreham
a7c8ff00c6
Merge pull request #14515 from prometheus/revert-13777-remoteread2
Revert "Chunked remote read: close the querier earlier"
2024-07-29 18:39:19 +01:00
Bryan Boreham
d186caead5
Merge pull request #14496 from bboreham/fix-nil-primary (#14509)
[BUGFIX] Storage: errors from a single secondary querier should be warnings.

This is a backport of #14496 to release-2.54 branch.

#13434 introduced an unwanted change in behaviour: if there was no primary querier and a single secondary querier, the secondary would be treated like a primary.  This PR restores the previous behaviour, that all secondary queriers report errors as warnings.

In order to test this behaviour, I changed `TestMergeQuerierWithSecondaries_ErrorHandling` so it now calls `NewMergeQuerier` rather than creating the internal data structure directly. 

This in turn required all the data types to change, so I merged  `mockGenericQuerier` into `mockQuerier`.
Also replaced `unwrapMockGenericQuerier` with a visitor pattern.

While I was there, I addressed the comment from https://github.com/prometheus/prometheus/pull/13434#pullrequestreview-2191058921 to short-circuit the merge of single querier with any number of no-op or nil queriers.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-07-29 14:41:10 +01:00
Filip Petkovski
2cd97c61e0
Add more test cases
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
2024-07-29 14:53:32 +02:00
Kushal shukla
fe12924638
promtool: JUnit-Format XML Test Results (#14506)
* Junit compatible output

Signed-off-by: Kushal Shukla <kushalshukla110@gmail.com>
2024-07-29 21:28:08 +10:00
Julius Volz
b06bb78543 Add filtering, limiting, and more to targets page
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-07-27 16:29:18 +02:00
Julius Volz
6321267996 Add missing ResolutionInput.tsx file to git
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-07-27 16:28:42 +02:00
Tomiwa
b6e06aca9f prometheus-agent-documentation
Signed-off-by: Tomiwa <tomiwaaribisala@gmail.com>
2024-07-27 14:25:03 +01:00
Tomiwa
1b75a67239 prometheus-agent-documentation
Signed-off-by: Tomiwa <tomiwaaribisala@gmail.com>
2024-07-27 14:21:24 +01:00
Seena Fallah
f253d36361 rule: allow merging labels from group level
Support merging labels from groups to rule labels

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
2024-07-26 20:18:05 +02:00
Marco Pracucci
d4f098ae80
Fix relabel.Regexp zero value marshalling (#14517)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
2024-07-26 12:55:39 +00:00
Sergey
9caba4be7d chore: use HumanizeDuration and ConvertToFloat from prometheus/common
Signed-off-by: Sergey <freak12techno@gmail.com>
2024-07-26 15:32:11 +03:00
Arve Knudsen
9af19ed856 Merge remote-tracking branch 'prometheus/main' into arve/wlog-histograms
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-07-26 11:51:29 +02:00
Arve Knudsen
7c873004c7 Merge remote-tracking branch 'prometheus/main' into arve/close-engine 2024-07-26 11:48:33 +02:00
Arve Knudsen
4fb2183437 Test a couple more cases without suffix gen
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-07-26 11:21:58 +02:00
Bryan Boreham
6e89250a5d Revert "Chunked remote read: close the querier earlier"
Believed to trigger segmentation faults due to memory-mapped block
data still being accessed by iterators after the querier is closed.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-07-26 09:56:38 +01:00
Filip Petkovski
be7a4c9b83
Ignore stale histograms for counter reset detection
The histogram stats decoder keeps track of the last seen histogram sample
in order to properly detect counter resets. We are seeing an issue where
a histogram with UnknownResetHint gets treated as a counter reset when it follows
a stale histogram sample.

I believe that this is incorrect since stale samples should be completely ignored
in PromQL. As a result, they should not be stored in the histogram stats iterator
and the counter reset detection needs to be done against the last non-stale sample.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
2024-07-26 10:08:31 +02:00
Bryan Boreham
7b5897a46d
Prepare release 2.54.0-rc.0 (#14498)
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-07-25 17:51:29 +01:00
Julius Volz
cacfc693c4 Point new UI local API proxying back to localhost Prometheus
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-07-25 14:28:56 +02:00
Callum Styan
a4a5994f69 clarify that 1.0 will eventually be deprecated, it is not yet deprecated
Signed-off-by: Callum Styan <callumstyan@gmail.com>
2024-07-24 09:24:48 -07:00
Arve Knudsen
c04924bc41 otlptranslator: Add tests for BuildCompliantName
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-07-24 18:17:56 +02:00
Bryan Boreham
71c90c71d4
Merge pull request #14470 from bboreham/label-sep-byte
Labels: use single byte as separator - small speedup
2024-07-24 13:54:59 +01:00
Bryan Boreham
4dd705d867
Merge pull request #14496 from bboreham/fix-nil-primary
[BUGFIX] Storage: errors from a single secondary querier should be warnings.
2024-07-24 10:15:39 +01:00
Julius Volz
f7a97417a5 Move resolution input into separate component + file
Also don't reload the graph on custom resolution input blur if the resolution
hasn't changed.

Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-07-23 23:13:06 +02:00
Julius Volz
a2a177a04c Clean up uPlot CSS rules a bit
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-07-23 21:22:23 +02:00
Julius Volz
90cf8b3082 Move uPlot plugins and glue code to separate file
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-07-23 21:21:34 +02:00
Julius Volz
89d18bf681 Minor comment/code cleanups
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-07-23 20:00:42 +02:00
Julius Volz
de1cb93cb1 More uPlot coloring improvements/fixes
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-07-23 20:00:10 +02:00
Julius Volz
3ecc13b330 Show single samples without neighbors as dots
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-07-23 19:59:10 +02:00
Julius Volz
7ea75c75c0 Show brighter graph line colors in dark mode
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-07-23 19:58:15 +02:00
Björn Rabenstein
91c05eed84
Merge pull request #14488 from jan--f/3.0-main-sync-24-07-18
3.0 main sync 24 07 18
2024-07-23 16:59:36 +02:00
Julius Volz
1b2290c131 Remove unused imports in new UI to fix build
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-07-23 11:35:37 +02:00
Julius Volz
d6f4d3a00b Implement dark theme for uPlot graphs
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2024-07-23 01:31:06 +02:00