Julius Volz
ef430074f3
Merge pull request #16567 from ryanwuer/optimize-target-pool-search-experience
...
UI: optimize pool searching in /targets page
2025-05-31 16:53:58 +02:00
Jan-Otto Kröpke
638dc8dbdc
Merge branch 'release-3.4' into release-3.4-main
...
# Conflicts:
# .github/workflows/ci.yml
# CHANGELOG.md
# RELEASE.md
# VERSION
# cmd/prometheus/main_test.go
# docs/configuration/configuration.md
# web/ui/mantine-ui/package.json
# web/ui/module/codemirror-promql/package.json
# web/ui/module/lezer-promql/package.json
# web/ui/package-lock.json
# web/ui/package.json
2025-05-31 12:48:16 +02:00
Jan-Otto Kröpke
aea6503d9b
Release 3.4.1 ( #16652 )
2025-05-31 08:41:19 +02:00
Ayoub Mrini
f1db64f4c5
fix(test): fall back to default direct I/O requirements in tests when statx isn't supported by using a higher lever util ( #16648 )
...
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2025-05-30 10:28:37 +02:00
Arthur Silva Sens
24057883a1
Update otlptranslator with new API ( #16626 )
...
* Update otlptranslator with new API
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
---------
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
2025-05-29 09:24:02 -03:00
machine424
5ac1e6a656
fix(test): fall back to default direct I/O requirements in tests when statx isn't supported by using a higher lever util
...
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2025-05-29 09:35:33 +02:00
Julius Volz
13564c03ef
Standardize doc page title handling
...
See https://groups.google.com/g/prometheus-developers/c/cwL3cM66Em8
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2025-05-28 21:37:27 +02:00
Charles Korn
ab1b1db128
tsdb: fix issue where a new segment file is created for every chunk if WithSegmentSize not called ( #16635 )
...
* tsdb: fix issue where a new segment file is created for every chunk
Signed-off-by: Charles Korn <charles.korn@grafana.com>
* Address PR feedback
Signed-off-by: Charles Korn <charles.korn@grafana.com>
---------
Signed-off-by: Charles Korn <charles.korn@grafana.com>
2025-05-28 18:21:59 +02:00
Anand Rajagopal
41d08003c5
refactor: Move 'for' state restoration metrics to defer block
...
Signed-off-by: Anand Rajagopal <anrajag@amazon.com>
2025-05-28 16:04:49 +00:00
Julius Volz
e597a5af92
Merge pull request #16640 from tongjicoder/main
...
chore: fix some comments
2025-05-27 17:32:00 +02:00
tongjicoder
4fe20fa340
chore: fix some comments
...
Signed-off-by: tongjicoder <tongjicoder@icloud.com>
2025-05-27 23:14:41 +08:00
Ayoub Mrini
89a72bf1b5
[BACKPORT-3.4] fix: add reproducer for a dangling-reference issue in parsers and fix ( #16633 )
2025-05-27 16:21:17 +02:00
Ayoub Mrini
317acb3d68
refactor: use the built-in max/min to simplify the code ( #16617 )
...
Signed-off-by: carrychair <linghuchong404@gmail.com>
2025-05-27 14:42:50 +02:00
Zhengke Zhou
45211dc72f
chore: Adjust test and add comment about DNS resolution issue for failing tests ( #16200 )
...
* chore: Add comment about DNS resolution issue for failing tests
Signed-off-by: zhengkezhou1 <madzhou1@gmail.com>
* remove unexported-return
Signed-off-by: zhengkezhou1 <madzhou1@gmail.com>
---------
Signed-off-by: zhengkezhou1 <madzhou1@gmail.com>
2025-05-27 14:40:09 +02:00
Ayoub Mrini
44f78bb3c8
Merge pull request #16623 from machine424/reprep
...
fix: add reproducer for a dangling-reference issue in parsers and fix
2025-05-27 05:24:48 +02:00
Subhramit Basu
44e27a876e
Add parse alerting for rules files ( #16601 )
...
Builds over https://github.com/prometheus/prometheus/pull/16462
Addresses comments, adds invalid rules file
Signed-off-by: subhramit <subhramit.bb@live.in>
Co-authored-by: marcodebba <marcodebonis74@gmail.com>
2025-05-26 18:29:34 +02:00
Antonio Jimenez
2834a665ed
Add support for promoting all OTel resource attributes ( #16426 )
...
Add support for promoting all OTel resource attributes via `promote_all_resource_attributes`,
except for those ignored using 'ignore_resource_attributes'.
---------
Signed-off-by: Antonio Jimenez <antonjim@thousandEyes.com>
Signed-off-by: Antonio Jimenez <123171955+antonjim-te@users.noreply.github.com>
2025-05-26 18:15:01 +02:00
Joe Harvey
79c9e9348f
ci: address zizmor gh action vulnerabilities ( #16530 )
...
* ci: address zizmor gh action vulnerabilities
---------
Signed-off-by: Joe Harvey <51208233+jharvey10@users.noreply.github.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-05-26 15:38:09 +00:00
bragi92
14fc57e4cf
remote_write azure auth : allow empty client_id to suppport system assigned managed identity ( #16421 )
...
* squash (#1 )
* remote-write: allow empty azure client_id to support system assigned managed identity
* add blank line for tests
* remote-write: allow empty azure client_id to support system assigned managed identity
Signed-off-by: Kaveesh Dubey <kadubey@microsoft.com>
* add blank line for tests
Signed-off-by: Kaveesh Dubey <kadubey@microsoft.com>
---------
Signed-off-by: Kaveesh Dubey <kadubey@microsoft.com>
* treat empty client_id as system-assigned identity; this is a valid case
Signed-off-by: Kaveesh Dubey <kadubey@microsoft.com>
* rename file
Signed-off-by: bragi92 <kadubey@microsoft.com>
---------
Signed-off-by: Kaveesh Dubey <kadubey@microsoft.com>
Signed-off-by: bragi92 <kadubey@microsoft.com>
2025-05-24 15:01:49 +02:00
dongjiang
8d9332c199
fix metric_name_escaping_scheme option ( #16625 )
2025-05-24 14:25:39 +02:00
machine424
50a6efd5ec
fix(model/textparse): Labels(): copy the input to avoid dangling references
...
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2025-05-23 11:03:48 +02:00
machine424
2bfbd8a714
fix: add reproducer for a dangling-reference issue in parsers
...
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2025-05-22 17:22:51 +02:00
Julien
1d9dfde989
Merge pull request #16041 from prymitive/parenExprEnd
...
Add a test for aggregation wrapped in ParenExpr
2025-05-22 09:32:17 +02:00
machine424
690c9da817
chore(config): add guidelines for adding a new RuntimeConfig field based on learnings from GoGC addition
...
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2025-05-21 16:16:05 +02:00
machine424
e809ccb90a
test(cmd/main/TestRuntimeGOGCConfig): add checks on reloads as well
...
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2025-05-21 16:16:05 +02:00
Ayoub Mrini
2edc3ed6c5
feat(tsdb): introduce --use-uncached-io feature flag and allow using it for chunks writing ( #15365 )
...
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
Signed-off-by: Ayoub Mrini <ayoubmrini424@gmail.com>
2025-05-21 14:42:30 +02:00
Ryan Wu
091e662f4d
refactor(endpointslice): use service cache.Indexer to achieve better iteration performance ( #16365 )
...
* refactor(endpointslice): use cache.Indexer to index endpointslices by LabelServiceName so not have to iterate over all endpoint objects.
Signed-off-by: Ryan Wu <rongjun0821@gmail.com>
* check the type and error early and add 'TestEndpointSliceDiscoveryWithUnrelatedServiceUpdate' unit test to give a regression test
Signed-off-by: Ryan Wu <rongjun0821@gmail.com>
* make service indexer namespaced
Signed-off-by: Ryan Wu <rongjun0821@gmail.com>
* remove unneeded test func
Signed-off-by: Ryan Wu <rongjun0821@gmail.com>
* Apply suggestions from code review
Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>
Signed-off-by: Ryan Wu <rongjun0821@gmail.com>
---------
Signed-off-by: Ryan Wu <rongjun0821@gmail.com>
Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>
2025-05-20 20:33:25 +02:00
George Krajcsovits
eb940d9c3b
Merge pull request #16565 from prometheus/krajo/intern-custom-values
...
perf(chunkenc): intern custom values for native histograms
2025-05-20 09:13:12 +02:00
carrychair
e83dc66bdb
refactor: use the built-in max/min to simplify the code
...
Signed-off-by: carrychair <linghuchong404@gmail.com>
2025-05-20 14:36:39 +08:00
György Krajcsovits
772d5ab433
Merge branch 'main' into krajo/intern-custom-values
2025-05-20 08:23:15 +02:00
Julius Volz
6c930e8506
Merge pull request #16605 from prometheus/rules-page-filters
...
Add health & text filtering on the /rules page
2025-05-19 23:22:25 +02:00
Ayoub Mrini
dd9e18c831
Merge pull request #16008 from jub0bs/cors
...
util/httputil: Always add Vary header in SetCORS (fixes #15406 )
2025-05-19 21:53:11 +02:00
Ayoub Mrini
f2fac45eaf
Merge pull request #16563 from zepellin/patch-1
...
docs: Fix `metric_name_escaping_scheme` config parameter
2025-05-19 16:31:57 +02:00
jub0bs
4bc8df0f54
util/httputil: Always add Vary header in SetCORS
...
Closes #15406
Signed-off-by: jub0bs <jcretel-infosec+github@protonmail.com>
2025-05-19 11:42:44 +02:00
Ayoub Mrini
eb8d34c2ad
Merge pull request #16587 from prymitive/discoveryLocks
...
discovery: Try fixing potential deadlocks in discovery
2025-05-19 11:09:49 +02:00
Ayoub Mrini
4b7321c8e8
Merge pull request #16607 from marcoderama/patch-3
...
docs: fix typo in operators.md
2025-05-19 10:55:42 +02:00
Bartlomiej Plotka
8e6b008608
feature: type-and-unit-labels (PROM-39 implementation) ( #16228 )
...
* feature: type-and-unit-labels (extended MetricIdentity)
Experimental implementation of https://github.com/prometheus/proposals/pull/39
Previous (unmerged) experiments:
* https://github.com/prometheus/prometheus/compare/main...dashpole:prometheus:type_and_unit_labels
* https://github.com/prometheus/prometheus/pull/16025
Signed-off-by: bwplotka <bwplotka@gmail.com>
feature: type-and-unit-labels (extended MetricIdentity)
Experimental implementation of https://github.com/prometheus/proposals/pull/39
Previous (unmerged) experiments:
* https://github.com/prometheus/prometheus/compare/main...dashpole:prometheus:type_and_unit_labels
* https://github.com/prometheus/prometheus/pull/16025
Signed-off-by: bwplotka <bwplotka@gmail.com>
* Fix compilation errors
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Lint
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Revert change made to protobuf 'Accept' header
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Fix compilation errors for 'dedupelabels' tag
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
* Rectored into schema.Metadata
Signed-off-by: bwplotka <bwplotka@gmail.com>
* texparse: Added tests for PromParse
Signed-off-by: bwplotka <bwplotka@gmail.com>
* add OM tests.
Signed-off-by: bwplotka <bwplotka@gmail.com>
* add proto tests
Signed-off-by: bwplotka <bwplotka@gmail.com>
* Addressed comments.
Signed-off-by: bwplotka <bwplotka@gmail.com>
* add schema label tests.
Signed-off-by: bwplotka <bwplotka@gmail.com>
* addressed comments.
Signed-off-by: bwplotka <bwplotka@gmail.com>
* fix tests.
Signed-off-by: bwplotka <bwplotka@gmail.com>
* add promql tests.
Signed-off-by: bwplotka <bwplotka@gmail.com>
* lint
Signed-off-by: bwplotka <bwplotka@gmail.com>
* Addressed comments.
Signed-off-by: bwplotka <bwplotka@gmail.com>
---------
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
2025-05-17 09:37:25 +00:00
Arthur Silva Sens
5a98246f50
Fix flakiness in TestOTLPWriteHandler ( #16608 )
2025-05-17 05:35:26 -03:00
Jan-Otto Kröpke
84a3acaf1b
Merge release-3.4 into main ( #16609 )
...
Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>
2025-05-17 10:04:22 +02:00
Jan-Otto Kröpke
546b1d242e
Adjust release date in CHANGELOG.md
...
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
2025-05-17 08:47:49 +02:00
Jan-Otto Kröpke
93f7c78211
Release 3.4.0 ( #16600 )
2025-05-17 08:40:29 +02:00
marcoderama
778d49bbfb
docs: fix typo in operators.md
...
Signed-off-by: marcoderama <marcoderamagit@gmail.com>
2025-05-16 12:03:24 -07:00
Julius Volz
69ed0a5794
Add health & text filtering on the /rules page
...
Addresses part of https://github.com/prometheus/prometheus/issues/16515
For now, I'm adding very similar filtering to the /rules page as we have on
the /alerts page, with the difference being:
* The state filter filters by rule health (ok/warn/unknown) instead of
alert state (firing/pending/inactive)
* We don't collect & show detailed stats on the different state counts as
we do on the /alerts page
There is a lot of copied / very similar code between those two pages (and
also some others) around filtering and pagination, so maybe there is an
opportunity for more code sharing in the future here.
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2025-05-16 17:50:46 +02:00
Julius Volz
77224a6ef1
Merge pull request #16604 from prometheus/fix-dropped-target-counts
...
SD UI: Better total target count display when using `keep_dropped_targets` option
2025-05-16 14:17:18 +02:00
Julius Volz
5f1c6226e2
SD UI: Better total target count display when using keep_dropped_targets option
...
Fixes https://github.com/prometheus/prometheus/issues/16586
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2025-05-16 11:07:55 +02:00
Ben Kochie
1eaf12e99b
Add golangci-lint fmt ( #16602 )
...
With golangci-lint v2, it now has "formatters" that can be configured.
Add `golangci-lint fmt` to the `make format` in Makefile.common.
* Enable goimports formatter.
Signed-off-by: SuperQ <superq@gmail.com>
2025-05-16 11:05:35 +02:00
Ben Kochie
3eb44003c6
Fixup make proto ( #16603 )
...
Use `common-` prefix for `make proto` so downstream projects like
client_golang can implement their own `make proto`.
Signed-off-by: SuperQ <superq@gmail.com>
2025-05-16 09:03:07 +00:00
Lukasz Mierzwa
59761f631b
Move m.targetsMtx.Lock down into the loop
...
Make sure the order of locks is always the same in all functions. In ApplyConfig() we have m.targetsMtx.Lock() after provider is locked, so replicate the same in allGroups().
Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>
2025-05-15 12:30:48 +01:00
Ayoub Mrini
2690761582
Merge pull request #16558 from wbh1/fix/GOGC-ENV-VAR
...
fix(config): respect GOGC environment variable if no "runtime" block exists
2025-05-13 23:34:08 +02:00
Julius Volz
df1b4da348
Merge pull request #16597 from prometheus/cleanup-docs-code-and-headers
...
Clean up codeboxes and headings in docs
2025-05-13 17:05:14 +02:00