upstream/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-05-28 04:02:21 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Merge pull request #16702 from bboreham/simpler-detect

Browse source 
[Refactor] PromQL: Simplify detectHistogramStatsDecoding
This commit is contained in:
Björn Rabenstein 2025-06-18 13:02:55 +02:00 committed by GitHub
commit f69c83f5f1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
promql/engine.go
View file

@ -3842,19 +3842,13 @@ func setOffsetForAtModifier(evalTime int64, expr parser.Expr) {
// required for correctness.
func detectHistogramStatsDecoding(expr parser.Expr) {
parser.Inspect(expr, func(node parser.Node, path []parser.Node) error {
if n, ok := node.(*parser.BinaryExpr); ok {
detectHistogramStatsDecoding(n.LHS)
detectHistogramStatsDecoding(n.RHS)
return errors.New("stop")
}
n, ok := (node).(*parser.VectorSelector)
if !ok {
return nil
}
for _, p := range path {
call, ok := p.(*parser.Call)
for i := len(path) - 1; i > 0; i-- { // Walk backwards up the path.
call, ok := path[i].(*parser.Call)
if !ok {
continue
}