upstream/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-05-28 04:02:21 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Manually manage db/rw to prevent windows test error

Browse source 
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
This commit is contained in:
Kyle Eckhart 2026-02-23 15:35:18 -05:00
parent 1e60d7fd3b
commit f4a15255e4
1 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
tsdb/agent/db_test.go
View file

@ -1325,7 +1325,9 @@ func TestDBStartTimestampSamplesIngestion(t *testing.T) {
func TestDuplicateSeriesRefsByHash(t *testing.T) {
dbDir := t.TempDir()
opts := DefaultOptions()
db := createTestAgentDB(t, nil, opts, dbDir)
rs1 := remote.NewStorage(promslog.NewNopLogger(), nil, startTime, dbDir, time.Second*30, nil, false)
db, err := Open(promslog.NewNopLogger(), nil, rs1, dbDir, opts)
require.NoError(t, err)
app := db.Appender(context.Background())
@ -1344,7 +1346,7 @@ func TestDuplicateSeriesRefsByHash(t *testing.T) {
require.NoError(t, app.Commit())
// Forcefully create a bunch of new segments to force a truncation.
for i := 0; i < 3; i++ {
for range 3 {
_, err := db.wal.NextSegmentSync()
require.NoError(t, err)
}
@ -1352,7 +1354,7 @@ func TestDuplicateSeriesRefsByHash(t *testing.T) {
require.Empty(t, db.deleted)
// Truncate at 1 ms higher than the highest timestamp.
err := db.truncate(11)
err = db.truncate(11)
require.NoError(t, err)
// The original SeriesRefs should be considered deleted.
@ -1376,9 +1378,17 @@ func TestDuplicateSeriesRefsByHash(t *testing.T) {
}
// Close the WAL before we have a chance to remove the original RefIDs.
// Both db and rs1 must be closed to release all file handles before
// reopening the same directory — important on Windows.
require.NoError(t, db.Close())
require.NoError(t, rs1.Close())
rs2 := remote.NewStorage(promslog.NewNopLogger(), nil, startTime, dbDir, time.Second*30, nil, false)
t.Cleanup(func() { require.NoError(t, rs2.Close()) })
db, err = Open(promslog.NewNopLogger(), nil, rs2, dbDir, opts)
require.NoError(t, err)
t.Cleanup(func() { require.NoError(t, db.Close()) })
db = createTestAgentDB(t, nil, opts, dbDir)
// The original SeriesRefs should be in series.
for _, ref := range originalSeriesRefs {
require.NotNil(t, db.series.GetByID(ref))