From dfea5ef01a21c7b9d873cd7157618175e1e4081a Mon Sep 17 00:00:00 2001 From: machine424 Date: Fri, 17 Oct 2025 14:32:04 +0200 Subject: [PATCH] chore(test): make failures in TestRemoteWrite_PerQueueMetricsAfterRelabeling more explicit to help with debugging the test when it flakes for GOARCH=386 tried to make it fail in the CI running the following, in vain: GOARCH=386 go test --timeout 4444444s --count=1000 --run=TestRemoteWrite_PerQueueMetricsAfterRelabeling ./cmd/prometheus/ Signed-off-by: machine424 --- cmd/prometheus/main_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cmd/prometheus/main_test.go b/cmd/prometheus/main_test.go index 38dfd3f2da..682f2e3213 100644 --- a/cmd/prometheus/main_test.go +++ b/cmd/prometheus/main_test.go @@ -890,8 +890,10 @@ func TestRemoteWrite_PerQueueMetricsAfterRelabeling(t *testing.T) { port := testutil.RandomUnprivilegedPort(t) targetPort := testutil.RandomUnprivilegedPort(t) - server := httptest.NewServer(http.HandlerFunc(func(http.ResponseWriter, *http.Request) { - panic("should never be reached") + server := httptest.NewServer(http.HandlerFunc(func(_ http.ResponseWriter, r *http.Request) { + body, err := io.ReadAll(r.Body) + require.NoError(t, err) + require.Fail(t, "should never be reached because the remote write relabeling shouldn't yield anything", "header: %v, body: %s", r.Header, body) })) t.Cleanup(server.Close)