upstream/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-02-20 00:10:23 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix TestScrapeLoopRun flakiness

Browse source 
Signed-off-by: bwplotka <bwplotka@gmail.com>
This commit is contained in:
bwplotka 2025-12-16 14:04:28 +00:00
parent 770dc3b69d
commit df47637d52
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
scrape/scrape_test.go
View file

@ -1041,10 +1041,11 @@ func TestScrapeLoopRun(t *testing.T) {
// scraper. The scraper has to respect the context.
scraper.offsetDur = 0
block := make(chan struct{})
blockCtx, blockCancel := context.WithCancel(t.Context())
scraper.scrapeFunc = func(ctx context.Context, _ io.Writer) error {
select {
case <-block:
case <-blockCtx.Done():
cancel()
case <-ctx.Done():
return ctx.Err()
}
@ -1066,9 +1067,7 @@ func TestScrapeLoopRun(t *testing.T) {
// We already caught the timeout error and are certainly in the loop.
// Let the scrapes returns immediately to cause no further timeout errors
// and check whether canceling the parent context terminates the loop.
close(block)
cancel()
blockCancel()
select {
case <-signal:
// Loop terminated as expected.