From dc34b90f93bf0265187ccec1dabdcc3db1a87ce0 Mon Sep 17 00:00:00 2001 From: Arve Knudsen Date: Wed, 28 Jan 2026 13:58:50 +0100 Subject: [PATCH] otlptranslator: fix silently swallowed error in addSumNumberDataPoints (#17954) The createAttributes error was incorrectly returning nil instead of err, causing errors to be silently discarded. This could lead to silent data loss for sum metrics during OTLP ingestion. Fixes #17953 Signed-off-by: Arve Knudsen --- .../otlptranslator/prometheusremotewrite/number_data_points.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/storage/remote/otlptranslator/prometheusremotewrite/number_data_points.go b/storage/remote/otlptranslator/prometheusremotewrite/number_data_points.go index 65d4fd70b2..e681bb352b 100644 --- a/storage/remote/otlptranslator/prometheusremotewrite/number_data_points.go +++ b/storage/remote/otlptranslator/prometheusremotewrite/number_data_points.go @@ -86,7 +86,7 @@ func (c *PrometheusConverter) addSumNumberDataPoints(ctx context.Context, dataPo meta.MetricFamilyName, ) if err != nil { - return nil + return err } var val float64 switch pt.ValueType() {