upstream/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-06-07 23:52:13 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Rewrite temporality logic to be clearer

Browse source 
Signed-off-by: Fiona Liao <fiona.liao@grafana.com>
This commit is contained in:
Fiona Liao 2025-04-17 19:26:19 +01:00
parent a48bee8c08
commit d5c4cdf9c2
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw.go
View file

@ -99,8 +99,11 @@ func (c *PrometheusConverter) FromMetrics(ctx context.Context, md pmetric.Metric
}
if hasTemporality &&
(temporality == pmetric.AggregationTemporalityUnspecified ||
(!settings.AllowDeltaTemporality && temporality == pmetric.AggregationTemporalityDelta)) {
// Cumulative temporality is always valid.
// Delta temporality is also valid if AllowDeltaTemporality is true.
// All other temporality values are invalid.
!(temporality == pmetric.AggregationTemporalityCumulative ||
(settings.AllowDeltaTemporality && temporality == pmetric.AggregationTemporalityDelta)) {
errs = multierr.Append(errs, fmt.Errorf("invalid temporality and type combination for metric %q", metric.Name()))
continue
}