From a99a12a1f15c3da4cf75852dd2561650666344fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gy=C3=B6rgy=20Krajcsovits?= Date: Fri, 4 Oct 2024 08:27:38 +0200 Subject: [PATCH] Needs to know if it is ok to unconditionally drop classic histogram series MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If we turn on NHCB, we need to parse classic values even if they are dropped as classic series, to be able to do NHCB Signed-off-by: György Krajcsovits --- model/textparse/interface.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/model/textparse/interface.go b/model/textparse/interface.go index 28b2abf432..3507d873a7 100644 --- a/model/textparse/interface.go +++ b/model/textparse/interface.go @@ -24,7 +24,9 @@ import ( // Parser parses samples from a byte slice of samples in the official // Prometheus and OpenMetrics text exposition formats. type Parser interface { - Next(v *ExposedValues, d DropperCache) (ExposedMetricType, error) + // Parse returns the next metric with all information collected about it, such as + // metric type, help text, unit, created timestamps, samples, etc. + Next(v *ExposedValues, d DropperCache, keepClassicHistogramSeries bool) (ExposedMetricType, error) } type DropperCache interface {