From 82895014200ddca3ca67e8bc1fe4eb6e5d6f3d8a Mon Sep 17 00:00:00 2001 From: Simon Pasquier Date: Wed, 12 Sep 2018 16:02:15 +0200 Subject: [PATCH] Address krasi's comments Signed-off-by: Simon Pasquier --- discovery/manager_test.go | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/discovery/manager_test.go b/discovery/manager_test.go index d16a8b5e32..8e8b2fd5ef 100644 --- a/discovery/manager_test.go +++ b/discovery/manager_test.go @@ -899,18 +899,7 @@ func TestCoordinationWithReceiver(t *testing.T) { expected []expect }{ { - title: "Receiver should get an empty map even when the provider sends nothing and closes the channel", - providers: map[string]Discoverer{ - "empty": &onceProvider{}, - }, - expected: []expect{ - { - tgs: map[string][]*targetgroup.Group{}, - }, - }, - }, - { - title: "Receiver should get updates even when one provider closes its channel", + title: "Receiver should get all updates even when one provider closes its channel", providers: map[string]Discoverer{ "once1": &onceProvider{ tgs: []*targetgroup.Group{ @@ -962,7 +951,7 @@ func TestCoordinationWithReceiver(t *testing.T) { }, }, { - title: "Receiver should get updates even when the channel is blocked", + title: "Receiver should get all updates even when the channel is blocked", providers: map[string]Discoverer{ "mock1": newMockDiscoveryProvider( update{