upstream/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-06-08 16:12:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix labels usage

Browse source 
Signed-off-by: Callum Styan <callumstyan@gmail.com>
This commit is contained in:
Callum Styan 2024-08-27 21:43:06 -07:00
parent e7a69ec50f
commit 696c3c0a3c
2 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
storage/remote/intern.go
View file

@ -102,8 +102,8 @@ func (p *pool) intern(ref chunks.HeadSeriesRef, lset labels.Labels) labels.Label
return interned.lset
}
if len(lset) == 0 {
return nil
if lset.Len() == 0 {
return labels.EmptyLabels()
}
p.pool[ref] = newEntry(lset)

16
storage/remote/queue_manager.go
View file

@ -704,11 +704,11 @@ outer:
t.seriesMtx.Lock()
var lbls labels.Labels
if t.interner.shouldIntern {
lbls = t.interner.intern(s.Ref, nil)
lbls = t.interner.intern(s.Ref, labels.EmptyLabels())
} else {
lbls = t.seriesLabels[s.Ref]
}
if len(lbls) == 0 {
if lbls.Len() == 0 {
t.dataDropped.incr(1)
if _, ok := t.droppedSeries[s.Ref]; !ok {
level.Info(t.logger).Log("msg", "Dropped sample for series that was not explicitly dropped via relabelling", "ref", s.Ref)
@ -771,11 +771,11 @@ outer:
t.seriesMtx.Lock()
var lbls labels.Labels
if t.interner.shouldIntern {
lbls = t.interner.intern(e.Ref, nil)
lbls = t.interner.intern(e.Ref, labels.EmptyLabels())
} else {
lbls = t.seriesLabels[e.Ref]
}
if len(lbls) == 0 {
if lbls.Len() == 0 {
// Track dropped exemplars in the same EWMA for sharding calc.
t.dataDropped.incr(1)
if _, ok := t.droppedSeries[e.Ref]; !ok {
@ -833,11 +833,11 @@ outer:
t.seriesMtx.Lock()
var lbls labels.Labels
if t.interner.shouldIntern {
lbls = t.interner.intern(h.Ref, nil)
lbls = t.interner.intern(h.Ref, labels.EmptyLabels())
} else {
lbls = t.seriesLabels[h.Ref]
}
if len(lbls) == 0 {
if lbls.Len() == 0 {
t.dataDropped.incr(1)
if _, ok := t.droppedSeries[h.Ref]; !ok {
level.Info(t.logger).Log("msg", "Dropped histogram for series that was not explicitly dropped via relabelling", "ref", h.Ref)
@ -893,11 +893,11 @@ outer:
t.seriesMtx.Lock()
var lbls labels.Labels
if t.interner.shouldIntern {
lbls = t.interner.intern(h.Ref, nil)
lbls = t.interner.intern(h.Ref, labels.EmptyLabels())
} else {
lbls = t.seriesLabels[h.Ref]
}
if len(lbls) == 0 {
if lbls.Len() == 0 {
t.dataDropped.incr(1)
if _, ok := t.droppedSeries[h.Ref]; !ok {
level.Info(t.logger).Log("msg", "Dropped histogram for series that was not explicitly dropped via relabelling", "ref", h.Ref)