From 618bceadb4a44ff8073605c8c983f469e0ccf081 Mon Sep 17 00:00:00 2001 From: Shubheksha Jalan Date: Sat, 13 Jan 2018 00:36:20 +0530 Subject: [PATCH] move version check into newReader() --- index/index.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/index/index.go b/index/index.go index 98ddb8da80..df8d7b5fea 100644 --- a/index/index.go +++ b/index/index.go @@ -577,10 +577,6 @@ func NewReader(b ByteSlice, version int) (*Reader, error) { // NewFileReader returns a new index reader against the given index file. func NewFileReader(path string, version int) (*Reader, error) { - if version != 1 && version != 2 { - return nil, errors.Errorf("unexpected file version %d", version) - - } f, err := fileutil.OpenMmapFile(path) if err != nil { return nil, err @@ -598,6 +594,11 @@ func newReader(b ByteSlice, c io.Closer, version int) (*Reader, error) { crc32: newCRC32(), version: version, } + + if version != 1 && version != 2 { + return nil, errors.Errorf("unexpected file version %d", version) + + } // Verify magic number. if b.Len() < 4 { return nil, errors.Wrap(errInvalidSize, "index header")