From 5cb0192626f750044cce179b40e279eab12eeb26 Mon Sep 17 00:00:00 2001 From: Patryk Prus Date: Fri, 8 Aug 2025 14:25:14 -0400 Subject: [PATCH] Address linter errors Signed-off-by: Patryk Prus --- tsdb/head.go | 4 ++-- tsdb/head_test.go | 1 - tsdb/head_wal.go | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/tsdb/head.go b/tsdb/head.go index 1377bb83be..cd2972dda1 100644 --- a/tsdb/head.go +++ b/tsdb/head.go @@ -781,7 +781,7 @@ func (h *Head) Init(minValidTime int64) error { // A corrupted checkpoint is a hard error for now and requires user // intervention. There's likely little data that can be recovered anyway. - if err := h.loadWAL(wlog.NewReader(sr), syms, multiRef, mmappedChunks, oooMmappedChunks, endAt); err != nil { + if err := h.loadWAL(wlog.NewReader(sr), syms, multiRef, mmappedChunks, oooMmappedChunks); err != nil { return fmt.Errorf("backfill checkpoint: %w", err) } h.updateWALReplayStatusRead(startFrom) @@ -815,7 +815,7 @@ func (h *Head) Init(minValidTime int64) error { if err != nil { return fmt.Errorf("segment reader (offset=%d): %w", offset, err) } - err = h.loadWAL(wlog.NewReader(sr), syms, multiRef, mmappedChunks, oooMmappedChunks, endAt) + err = h.loadWAL(wlog.NewReader(sr), syms, multiRef, mmappedChunks, oooMmappedChunks) if err := sr.Close(); err != nil { h.logger.Warn("Error while closing the wal segments reader", "err", err) } diff --git a/tsdb/head_test.go b/tsdb/head_test.go index 97a5a0cce8..ffe62de059 100644 --- a/tsdb/head_test.go +++ b/tsdb/head_test.go @@ -891,7 +891,6 @@ func TestHead_WALMultiRef(t *testing.T) { } func TestHead_WALCheckpointMultiRef(t *testing.T) { - cases := []struct { name string walEntries []interface{} diff --git a/tsdb/head_wal.go b/tsdb/head_wal.go index f648abe7ea..1d1fd89b15 100644 --- a/tsdb/head_wal.go +++ b/tsdb/head_wal.go @@ -75,7 +75,7 @@ func counterAddNonZero(v *prometheus.CounterVec, value float64, lvs ...string) { } } -func (h *Head) loadWAL(r *wlog.Reader, syms *labels.SymbolTable, multiRef map[chunks.HeadSeriesRef]chunks.HeadSeriesRef, mmappedChunks, oooMmappedChunks map[chunks.HeadSeriesRef][]*mmappedChunk, lastSegment int) (err error) { +func (h *Head) loadWAL(r *wlog.Reader, syms *labels.SymbolTable, multiRef map[chunks.HeadSeriesRef]chunks.HeadSeriesRef, mmappedChunks, oooMmappedChunks map[chunks.HeadSeriesRef][]*mmappedChunk) (err error) { // Track number of missing series records that were referenced by other records. unknownSeriesRefs := &seriesRefSet{refs: make(map[chunks.HeadSeriesRef]struct{}), mtx: sync.Mutex{}} // Track number of different records that referenced a series we don't know about