From 4e206c7c774a9b55d7b1c73ff10e721f51fc3f38 Mon Sep 17 00:00:00 2001 From: Ganesh Vernekar Date: Wed, 13 Oct 2021 20:23:31 +0530 Subject: [PATCH] Fix reviews Signed-off-by: Ganesh Vernekar --- tsdb/chunkenc/histogram.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tsdb/chunkenc/histogram.go b/tsdb/chunkenc/histogram.go index c0b8490561..fb5f3194a0 100644 --- a/tsdb/chunkenc/histogram.go +++ b/tsdb/chunkenc/histogram.go @@ -86,11 +86,10 @@ const ( CounterReset CounterResetHeader = 0b10000000 // NotCounterReset means there was definitely no counter reset when cutting this chunk. NotCounterReset CounterResetHeader = 0b01000000 - // GaugeType means the histograms represent a gauge instead of counters, hence we cannot make - // sense of counter reset in this case. + // GaugeType means this chunk contains a gauge histogram, where counter resets do not happen. GaugeType CounterResetHeader = 0b11000000 - // UnknownCounterReset means we cannot say if this was a counter reset or not and not sure - // if this is a gauge type histogram or not. + // UnknownCounterReset means we cannot say if this chunk was created due to a counter reset or not. + // An explicit counter reset detection needs to happen during query time. UnknownCounterReset CounterResetHeader = 0b00000000 )