From 1e7f2213832b96f7332ebc019d8bb9ba6f0d8fcf Mon Sep 17 00:00:00 2001 From: Fiona Liao Date: Thu, 17 Apr 2025 18:57:47 +0100 Subject: [PATCH] Correct type comment - not planning to add delta metric metadata type Signed-off-by: Fiona Liao --- .../prometheusremotewrite/otlp_to_openmetrics_metadata.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/storage/remote/otlptranslator/prometheusremotewrite/otlp_to_openmetrics_metadata.go b/storage/remote/otlptranslator/prometheusremotewrite/otlp_to_openmetrics_metadata.go index a748d147f6..716a6cd6f9 100644 --- a/storage/remote/otlptranslator/prometheusremotewrite/otlp_to_openmetrics_metadata.go +++ b/storage/remote/otlptranslator/prometheusremotewrite/otlp_to_openmetrics_metadata.go @@ -32,14 +32,14 @@ func otelMetricTypeToPromMetricType(otelMetric pmetric.Metric) prompb.MetricMeta metricType = prompb.MetricMetadata_COUNTER } // We're in an early phase of implementing delta support (proposal: https://github.com/prometheus/proposals/pull/48/) - // We don't have a metric metadata type for delta yet, therefore marking the metric type as unknown. + // We don't have a proper way to flag delta metrics yet, therefore marking the metric type as unknown for now. if otelMetric.Sum().AggregationTemporality() == pmetric.AggregationTemporalityDelta { metricType = prompb.MetricMetadata_UNKNOWN } return metricType case pmetric.MetricTypeHistogram: // We're in an early phase of implementing delta support (proposal: https://github.com/prometheus/proposals/pull/48/) - // We don't have a metric metadata type for delta yet, therefore marking the metric type as unknown. + // We don't have a proper way to flag delta metrics yet, therefore marking the metric type as unknown for now. if otelMetric.Histogram().AggregationTemporality() == pmetric.AggregationTemporalityDelta { return prompb.MetricMetadata_UNKNOWN } @@ -49,7 +49,7 @@ func otelMetricTypeToPromMetricType(otelMetric pmetric.Metric) prompb.MetricMeta case pmetric.MetricTypeExponentialHistogram: if otelMetric.ExponentialHistogram().AggregationTemporality() == pmetric.AggregationTemporalityDelta { // We're in an early phase of implementing delta support (proposal: https://github.com/prometheus/proposals/pull/48/) - // We don't have a metric metadata type for delta yet, therefore marking the metric type as unknown. + // We don't have a proper way to flag delta metrics yet, therefore marking the metric type as unknown for now. return prompb.MetricMetadata_UNKNOWN } return prompb.MetricMetadata_HISTOGRAM