From 7424aac088e1c4356b92d2673378dbdd50d1c888 Mon Sep 17 00:00:00 2001 From: Amit Kapila Date: Tue, 28 Apr 2026 12:51:25 +0530 Subject: [PATCH] Fix wrong datum conversion for subretentionactive in CreateSubscription. Use BoolGetDatum() instead of Int32GetDatum() when storing the boolean subretentionactive column in pg_subscription. This was an oversight in a850be2fe6. Author: Lakshmi N Reviewed-by: Nisha Moond Discussion: https://postgr.es/m/CA+3i_M98-XjE-_fw0p+8xOnw64y2_YLtJfcwvCfsVMn-z2ZjGg@mail.gmail.com --- src/backend/commands/subscriptioncmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c index d512e87cfe3..1e10d9d9a58 100644 --- a/src/backend/commands/subscriptioncmds.c +++ b/src/backend/commands/subscriptioncmds.c @@ -796,7 +796,7 @@ CreateSubscription(ParseState *pstate, CreateSubscriptionStmt *stmt, values[Anum_pg_subscription_submaxretention - 1] = Int32GetDatum(opts.maxretention); values[Anum_pg_subscription_subretentionactive - 1] = - Int32GetDatum(opts.retaindeadtuples); + BoolGetDatum(opts.retaindeadtuples); values[Anum_pg_subscription_subserver - 1] = ObjectIdGetDatum(serverid); if (!OidIsValid(serverid)) values[Anum_pg_subscription_subconninfo - 1] =