From 2849fe4c978540111748208ba96af7808602c567 Mon Sep 17 00:00:00 2001 From: John Naylor Date: Sun, 5 Apr 2026 08:49:47 +0700 Subject: [PATCH] Fix unused function warning on Arm platforms Guard definition pg_pmull_available() on compile-time availability of PMULL. Oversight in fbc57f2bc. In passing, remove "inline" hint for consistency. Reported-by: Tomas Vondra Discussion: https://postgr.es/m/f153d5a4-a9be-4211-b0b2-7e99b56d68d5@vondra.me --- src/port/pg_crc32c_armv8_choose.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/port/pg_crc32c_armv8_choose.c b/src/port/pg_crc32c_armv8_choose.c index 72d70aea1e1..591e23df44b 100644 --- a/src/port/pg_crc32c_armv8_choose.c +++ b/src/port/pg_crc32c_armv8_choose.c @@ -108,7 +108,8 @@ pg_crc32c_armv8_available(void) #endif } -static inline bool +#ifdef USE_PMULL_CRC32C_WITH_RUNTIME_CHECK +static bool pg_pmull_available(void) { #if defined(__aarch64__) && defined(HWCAP_PMULL) @@ -128,6 +129,7 @@ pg_pmull_available(void) return false; #endif } +#endif /* USE_PMULL_CRC32C_WITH_RUNTIME_CHECK */ /* * This gets called on the first call. It replaces the function pointer