From 0547aeae0fd6f6d03dd7499c84145ad9e3aa51b9 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Tue, 6 Jan 2026 20:24:17 +0900 Subject: [PATCH] Improve portability of new worker_spi test The new test 002_worker_terminate relies on the generation of a LOG entry to check that a worker has been started, but missed the fact that a node set with log_error_verbosity = verbose would add an error code. The regexp used for the matching check did not take this case into account, making the test fail on a timeout. The regexp is now fixed to handle the verbose case correctly. Per buildfarm member prion, that uses log_error_verbosity = verbose. The error was reproducible by setting this GUC the same way in the test. Oversight in f1e251be80a0. --- src/test/modules/worker_spi/t/002_worker_terminate.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/modules/worker_spi/t/002_worker_terminate.pl b/src/test/modules/worker_spi/t/002_worker_terminate.pl index cf262bcc2c5..6d379435598 100644 --- a/src/test/modules/worker_spi/t/002_worker_terminate.pl +++ b/src/test/modules/worker_spi/t/002_worker_terminate.pl @@ -30,7 +30,7 @@ sub launch_bgworker # Check that the bgworker is initialized. $node->wait_for_log( - qr/LOG: worker_spi dynamic worker $testcase initialized with .*\..*/, + qr/LOG: .*worker_spi dynamic worker $testcase initialized with .*\..*/, $offset); my $result = $node->safe_psql($database, "SELECT count(*) > 0 FROM pg_stat_activity WHERE pid = $pid;");