mirror of
https://github.com/hashicorp/packer.git
synced 2026-04-15 22:20:33 -04:00
68ddb2f89d
In azure templates, the shared_image_gallery was mistakenly considered an attribute while this is supposed to be a block. This is due to a heuristic we use for deciding whether a JSON object is to be translated to an attribute or a block that fell short as the shared_image_gallery does not contain complex types. This cannot be fixed trivially for the general case, so we add this entity to the list of workarounds until we can implement something more robust.
76 lines
2.3 KiB
Go
76 lines
2.3 KiB
Go
package command
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
)
|
|
|
|
func Test_hcl2_upgrade(t *testing.T) {
|
|
|
|
tc := []struct {
|
|
folder string
|
|
flags []string
|
|
exitCode int
|
|
exitEarly bool
|
|
}{
|
|
{folder: "unknown_builder", flags: []string{}, exitCode: 1},
|
|
{folder: "complete", flags: []string{"-with-annotations"}},
|
|
{folder: "without-annotations", flags: []string{}},
|
|
{folder: "minimal", flags: []string{"-with-annotations"}},
|
|
{folder: "source-name", flags: []string{"-with-annotations"}},
|
|
{folder: "error-cleanup-provisioner", flags: []string{"-with-annotations"}},
|
|
{folder: "aws-access-config", flags: []string{}},
|
|
{folder: "variables-only", flags: []string{}},
|
|
{folder: "variables-with-variables", flags: []string{}},
|
|
{folder: "complete-variables-with-template-engine", flags: []string{}},
|
|
{folder: "escaping", flags: []string{}},
|
|
{folder: "vsphere_linux_options_and_network_interface", exitCode: 1, flags: []string{}},
|
|
{folder: "nonexistent", flags: []string{}, exitCode: 1, exitEarly: true},
|
|
{folder: "placeholders", flags: []string{}, exitCode: 0},
|
|
{folder: "ami_test", flags: []string{}, exitCode: 0},
|
|
{folder: "azure_shg", flags: []string{}, exitCode: 0},
|
|
}
|
|
|
|
for _, tc := range tc {
|
|
t.Run(tc.folder, func(t *testing.T) {
|
|
inputPath := filepath.Join(testFixture("hcl2_upgrade", tc.folder, "input.json"))
|
|
outputPath := inputPath + ".pkr.hcl"
|
|
expectedPath := filepath.Join(testFixture("hcl2_upgrade", tc.folder, "expected.pkr.hcl"))
|
|
args := []string{"hcl2_upgrade"}
|
|
if len(tc.flags) > 0 {
|
|
args = append(args, tc.flags...)
|
|
}
|
|
args = append(args, inputPath)
|
|
p := helperCommand(t, args...)
|
|
err := p.Run()
|
|
defer os.Remove(outputPath)
|
|
if err != nil {
|
|
t.Logf("run returned an error: %s", err)
|
|
}
|
|
actualExitCode := p.ProcessState.ExitCode()
|
|
if tc.exitCode != actualExitCode {
|
|
t.Fatalf("unexpected exit code: %d found; expected %d ", actualExitCode, tc.exitCode)
|
|
}
|
|
if tc.exitEarly {
|
|
return
|
|
}
|
|
expected := string(mustBytes(ioutil.ReadFile(expectedPath)))
|
|
actual := string(mustBytes(ioutil.ReadFile(outputPath)))
|
|
|
|
if diff := cmp.Diff(expected, actual); diff != "" {
|
|
t.Fatalf("unexpected output: %s", diff)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func mustBytes(b []byte, e error) []byte {
|
|
if e != nil {
|
|
panic(e)
|
|
}
|
|
return b
|
|
}
|