Commit graph

15357 commits

Author SHA1 Message Date
DanHam
0821653256
Fix 'nil' dir in VMware artifact when building locally 2018-12-14 13:21:41 +00:00
Megan Marsh
2045390e74
Merge pull request #7108 from hashicorp/revert_hddorder_setting
Revert hddorder setting
2018-12-13 16:27:31 -08:00
Christopher Boumenot
f9230aeb95 azure: fix snapshot regression 2018-12-13 13:58:18 -08:00
Megan Marsh
e3895e9074
Merge pull request #7109 from hashicorp/revert-7107-patch-2
Revert "Fix previous change introduced in patch #7030"
2018-12-13 11:34:58 -08:00
Megan Marsh
6e09f1623f
Revert "Fix previous change introduced in patch #7030" 2018-12-13 11:34:37 -08:00
Megan Marsh
84e8adacc5
Merge pull request #7107 from pgrmega/patch-2
Fix previous change introduced in patch #7030
2018-12-13 11:25:52 -08:00
Megan Marsh
7d5ea43f41 revert the hddorder being added to the vmx template, since it's breaking things for some of our users. 2018-12-13 09:58:24 -08:00
pgrmega
954c6d2bdf
Fix previous change in patch #7030
The fix is to use -Copy option, not to delete this option which is equivalent to the original -Copy:$false
2018-12-13 18:45:14 +01:00
Megan Marsh
b95123f457 add new copy_in_compare flag so users can set the copy var to whatever they need in order to get the compatibility report to work. 2018-12-13 09:12:23 -08:00
Matt Dainty
845d29b458 s/provider/provisioner/ 2018-12-13 10:32:36 +00:00
Matt Dainty
451709b956 Elevated support for chef-client provisioner
Fixes #4661
2018-12-13 10:25:12 +00:00
Adrien Delorme
20029f0a12 Also update docs 2018-12-13 10:25:20 +01:00
Adrien Delorme
2718a5ed62 Revert "revert changes to docker entrypoint; since this is a backwards-breaking change it needs to wait for a minor release"
This reverts commit 2a79d64ae0.
2018-12-13 10:23:46 +01:00
Adrien Delorme
47257c0d07
Merge pull request #7104 from hashicorp/revert_docker_changes
revert changes to docker entrypoint; since this is a backwards-breaki…
2018-12-13 10:23:18 +01:00
Megan Marsh
ee2e5cc874
Merge pull request #7080 from hashicorp/do_6508
Move logging about aws waiters to the access config prepare() so that…
2018-12-12 15:42:37 -08:00
Megan Marsh
806ad60a64
Merge pull request #7103 from mmillican/patch-1
Add note about using ssh_interface for WinRM
2018-12-12 15:37:33 -08:00
Megan Marsh
2a79d64ae0 revert changes to docker entrypoint; since this is a backwards-breaking change it needs to wait for a minor release 2018-12-12 15:30:24 -08:00
Megan Marsh
e253892434
Merge pull request #7056 from hashicorp/fix_6799
Add registry key check for windows-restart provisioner
2018-12-12 13:14:05 -08:00
Matt Millican
15986a9d4f
Add note about using ssh_interface for WinRM 2018-12-12 15:10:57 -06:00
Megan Marsh
d5854a9574 add option to test registry for certain keys to make sure windows is done with a reboot cycle 2018-12-12 12:52:14 -08:00
Adrien Delorme
323db6350d be clearer in docker docs on TMP dirs 2018-12-12 19:17:39 +01:00
Megan Marsh
279949ddcc
Merge pull request #7090 from tomelliff/validate-kms-key-id
Check that the KMS key ID is valid
2018-12-12 10:04:22 -08:00
Adrien Delorme
cecf352aa7 remove any reference to TMPDIR_SUFFIX. Using system tempdir is enough 2018-12-12 18:52:25 +01:00
Adrien Delorme
b7222d1f56 Add tmp package that offers Dir & File funcs
this regroups the calls of tmp func calls into one package.
the tmp pkg allows to store tmp files under a common directory for easier managment

Squashed commit of the following:
commit 74b674c015
Merge: fc94b5714 66001525d
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Fri Nov 2 02:02:38 2018 -0400

    Merge branch 'remove_TMPDIR_docs' of github.com:tb3088/packer into remove_TMPDIR_docs

commit fc94b57142
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Fri Nov 2 01:42:38 2018 -0400

    update tests to honor configured temporary directory

commit 5a562359f4
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 18:52:38 2018 -0400

    sync straggler to refactor. implement tests at packer/configfile instead of buried in docker.

commit 9d5a4a0935
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 15:39:46 2018 -0400

    insert URL to GoLang API for os.TempDir()

commit fbae4c2e05
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 07:41:29 2018 -0400

    revise documentation to match code

commit 3590fae8bd
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 07:21:59 2018 -0400

    refacter config_file. replace all hard-coded os.TempDir with wrapper

commit d5c5306a97
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 20:11:36 2018 -0400

    close massive file overwrite hole with TempDir

commit 0a72297da8
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 01:06:00 2018 -0400

    adjust var declaration scope

commit 20f68228b6
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 00:54:35 2018 -0400

    use mktemp() equivalent to create temporary directory

commit c73ebe3d83
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 20:40:58 2018 -0400

    remove extraneous variable declaration, fix FOR loop

commit 63549b8bd7
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 19:30:44 2018 -0400

    match styistic convension with rest of docs

commit 9761010749
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 19:08:39 2018 -0400

    revert dangling config file change

commit 95159afbc0
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Fri Dec 29 23:53:43 2017 -0500

    replace invalid TMPDIR variable wth PACKER_TMP_DIR.
    update ConfigTmpDir() to try common temporary paths first and
    only write to configDir() as a last resort.

commit 66001525d7
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Fri Nov 2 01:42:38 2018 -0400

    update tests to honor configured temporary directory

commit e9b6adefea
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 18:52:38 2018 -0400

    sync straggler to refactor. implement tests at packer/configfile instead of buried in docker.

commit 852113ed07
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 15:39:46 2018 -0400

    insert URL to GoLang API for os.TempDir()

commit 54add38d1d
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 07:41:29 2018 -0400

    revise documentation to match code

commit 6b5b8f6d4e
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 07:21:59 2018 -0400

    refacter config_file. replace all hard-coded os.TempDir with wrapper

commit c22092c601
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 20:11:36 2018 -0400

    close massive file overwrite hole with TempDir

commit 7a73045091
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 01:06:00 2018 -0400

    adjust var declaration scope

commit 0f2933adb6
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 00:54:35 2018 -0400

    use mktemp() equivalent to create temporary directory

commit d74839ede0
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 20:40:58 2018 -0400

    remove extraneous variable declaration, fix FOR loop

commit eb65416619
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 19:30:44 2018 -0400

    match styistic convension with rest of docs

commit acaa2b31ed
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 19:08:39 2018 -0400

    revert dangling config file change

commit e573fde668
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Fri Dec 29 23:53:43 2017 -0500

    replace invalid TMPDIR variable wth PACKER_TMP_DIR.
    update ConfigTmpDir() to try common temporary paths first and
    only write to configDir() as a last resort.

commit 39a9874afc
Merge: 8a413cfe8 3315812c2
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 18:19:26 2018 -0400

    Merge branch 'master' of https://github.com/hashicorp/packer into prestine

commit 8a413cfe83
Merge: e07491de5 4e14710a6
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Mon Oct 1 20:18:10 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit e07491de59
Merge: 42610a35d a1fa35dff
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Aug 21 13:26:19 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit 42610a35d5
Merge: 5298142da 0d63cf7bc
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Tue Jun 19 22:45:05 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit 5298142da6
Merge: 7bb110bc7 9d9736552
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Mon Jun 11 15:10:09 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit 7bb110bc74
Merge: a61c869ca 6189d66e7
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Wed May 9 23:41:22 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit a61c869ca7
Merge: 098101dd9 4be5f072c
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Fri May 4 10:13:04 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit 098101dd99
Merge: fefaf0fa6 554b2b4a5
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Tue May 1 20:52:30 2018 -0400

    Merge branch 'EOL-handling' into prestine

Co-Authored-By: Matthew Patton <pattonme@yahoo.com>
2018-12-12 16:35:57 +01:00
Tom Elliff
12bf7fc4d6 Check that the KMS key ID is valid
KMS key IDs can be given as either a raw key ID, an alias (always prefixed with 'alias/'), the full ARN to the KMS key ID or the full ARN to the KMS key alias.

Should help with https://github.com/hashicorp/packer/issues/6599 but probably isn't enough to fully close it.
2018-12-12 11:41:58 +00:00
Megan Marsh
a17f33e494
Merge pull request #7099 from hashicorp/gomod_verify
go mod tidy/verify & go get github.com/hetznercloud/hcloud-go
2018-12-11 16:10:01 -08:00
Megan Marsh
a6956e4f30
Merge pull request #7100 from anish/comm_cleanup
Better fix for StepCleanupTempKeys #7095
2018-12-11 15:51:13 -08:00
Anish Bhatt
d5f88b154f
Better fix for #7095 2018-12-11 10:34:07 -08:00
Adrien Delorme
6b6bfac87e go mod verify & go get github.com/hetznercloud/hcloud-go 2018-12-11 17:46:54 +01:00
Adrien Delorme
82fb7aac5e
Merge pull request #7095 from anish/comm_cleanup
Don't run StepCleanupTempKeys when communicator is set to none
2018-12-11 17:41:21 +01:00
Adrien Delorme
dfa284c02b
Merge pull request #7094 from hashicorp/fix_7087
fix virtualbox 6.0 beta command options
2018-12-11 11:54:56 +01:00
Adrien Delorme
5e5ed9793f
Merge pull request #7092 from arizvisa/vmware-builders.halt-duplicate-code
Tiny fix to replace some duplicate code with usage of the already defined `halt` closure in the StepCloneVMX step for the vmware-vmx builder.
2018-12-11 11:53:26 +01:00
Anish Bhatt
916375183b
Don't run StepCleanupTempKeys when communicator is set to none 2018-12-10 15:33:19 -08:00
Megan Marsh
a819217c93 fix virtualbox 6.0 beta command options 2018-12-10 15:18:21 -08:00
Ali Rizvi-Santiago
1a36458e9e Tiny fix to replace some duplicate code with usage of the halt closure in the StepCloneVMX step for the vmware-vmx builder. 2018-12-10 16:24:27 -06:00
Megan Marsh
d367c1ba8b
Merge pull request #7091 from arizvisa/GH-6920
Proper fix to #6920 which ensures that entrypoint and arguments get passed to docker, not the image.
2018-12-10 13:25:34 -08:00
Ali Rizvi-Santiago
a6af04417e Moved the entrypoint argument for the docker builder in front of the image so it's passed correctly as an argument. 2018-12-10 15:09:56 -06:00
Megan Marsh
32f226eda0
Merge pull request #7069 from arizvisa/GH-6920
Updated docker's default config to use regular bourne shell instead of bourne again.
2018-12-10 11:29:27 -08:00
Adrien Delorme
9d32a75104
Merge pull request #7089 from aspectcapital/puppet-path-spaces
Document how to pass spaces in `puppet_bin_dir`
2018-12-10 12:58:31 +01:00
Adrien Delorme
ecc20cf816
Merge pull request #7084 from hashicorp/packer_inspect_sensitive
make packer inspect not print sensitive variables.
2018-12-10 12:16:55 +01:00
Matt Dainty
d7cd693680 Document how to pass spaces in puppet_bin_dir 2018-12-10 10:26:28 +00:00
chhaj5236
c4782807de
Merge pull request #7050 from chhaj5236/feature/force_delete_copied
alicloud: delete copied image and snapshots if corresponding options are specified
2018-12-09 19:39:14 +08:00
Megan Marsh
98e933ca54 make packer inspect not print sensitive variables. 2018-12-07 12:02:20 -08:00
Matt Dainty
19bd28cd72 Fix/add tests 2018-12-07 16:23:03 +00:00
Matt Dainty
3585b8023f Update docs for Puppet provisioners 2018-12-07 15:36:30 +00:00
Matt Dainty
2e4b00f59d Refactor powershell provisioner
Use the common elevated code instead.
2018-12-07 15:30:50 +00:00
Adrien Delorme
c42b3a41a9
Merge pull request #7059 from hashicorp/fix_6965
Fix 6965
2018-12-07 13:35:00 +01:00
Matt Dainty
a42f8fac4d Elevated support for puppet-masterless provisioner
This should fix #5478.
2018-12-07 11:08:11 +00:00
Adrien Delorme
2283efff79
Merge pull request #7071 from aspectcapital/ignore-pending-reboots
Ignore an already-scheduled reboot
2018-12-07 11:03:55 +01:00
Matt Dainty
0192289d68 Drop exit code 1717 2018-12-07 09:45:50 +00:00