Commit graph

5388 commits

Author SHA1 Message Date
Megan Marsh
eb98840f18
Merge pull request #7357 from e-mow/issue-7140
Issue 7140
2019-03-01 15:51:39 -08:00
Eric Mowry
cef3d0eb24 Ran make fmt per Megan's request. 2019-03-01 14:16:00 -05:00
Megan Marsh
ec3b0a5138 fix conflict from mergeing too many things to master at once 2019-03-01 11:13:32 -08:00
Megan Marsh
9d2b06bd61
Merge pull request #7342 from hashicorp/fix_7316
swap region copy and encryption steps
2019-03-01 10:26:43 -08:00
Megan Marsh
0abd16527e
Merge pull request #7337 from sargun/fix-chroot-builder
Amazon-chroot: Fix building PV images and where mount_partition is set
2019-03-01 10:25:04 -08:00
Stephen Fox
7e1cbc6d89 Rename references to key pair name to comment.
Per the OpenSSH manual, the field is for a comment.
2019-03-01 10:00:29 -05:00
Eric Mowry
109ba2c54c After testing a ISO and VMX clone along with setting the display_name option it was determined that having no name for the .vmxf file did not work either. Updating to check if displayName is not empty before using and falling back to VMName if displayName is empty. 2019-02-28 21:36:25 -05:00
Megan Marsh
3b6ff0fe3e
Merge pull request #7106 from hashicorp/revert_docker_changes
docker: user /bin/sh by default
2019-02-28 15:31:53 -08:00
Megan Marsh
0371e2a1b4
Merge pull request #7074 from hashicorp/fix_3329
vmware-iso (esxi) Add check that "format" is not being set when remote_type is empty.
2019-02-28 15:30:54 -08:00
Megan Marsh
424a6a3a7e
Merge pull request #6983 from hashicorp/revert-6979-revert-6925-organization_renaming
DONT MERGE YET: Revert "Revert "Rename attribute api_access_key to organization_id""
2019-02-28 15:30:25 -08:00
Stephen Fox
61a8968b22 Use 'os.OpenFile' to atomically create debug key file.
Per code review feedback.
2019-02-28 17:23:33 -05:00
Stephen Fox
094c87e395 Remove 'SSHPublicKeyUrlEncoded', use 'urlquery' instead.
Per code review feedback, the Go template library supports
encoding variables in URL query format. Instead of exposing
two different public key formats (unmodified string and a
URL encoded string), just have the user apply the 'urlquery'
modifier to their template.
2019-02-28 17:06:51 -05:00
Eric Mowry
e74a81e27b Deny the copying of .vmxf from the source VM to the target VM. If this file gets copied over to the new VM once the VM gets deleted the .vmxf and the folder for the VM stay on the datastore. This causes Packer to hang because the folder on the datastore does not go away during the cleanup process. 2019-02-28 16:47:46 -05:00
Eric Mowry
1127096beb Setting extendedconfigfile to the name of the VM so that when ESXi makes the vmxf it is named after the VM and ESXi will properly delete the file when the VM gets deleted. 2019-02-28 16:43:47 -05:00
Adrien Delorme
f535464097 up a test 2019-02-27 11:17:56 +01:00
Adrien Delorme
f03cbd8a10 aws: allow to pass nil bool as encryption parameter
to retain current encryption settings

this changes the fields :
* ami_config.encrypt_boot
* block_device.encrypted

This also removes StepCreateEncryptedAMICopy as this step is now done in StepAMIRegionCopy
2019-02-27 11:17:56 +01:00
Adrien Delorme
ce8532e94b aws: document ValidateRegion better 2019-02-27 11:17:08 +01:00
Adrien Delorme
6af621c37a aws: StepAMIRegionCopy call waitgroup.add only once 2019-02-27 11:17:08 +01:00
Michael F
01a0b0c766 kmsArnStartPattern - fix support for aws-us-gov
While the `kmsArnStartPattern` regexp supports `us-gov` as a region, it does not take the AWS partition into consideration.
For more info see https://docs.aws.amazon.com/govcloud-us/latest/ug-east/using-govcloud-arns.html

Added test case for AWS partition us-gov as well as a negative test case for a non-existing AWS partition.
2019-02-26 16:54:54 -08:00
Megan Marsh
026e543b24 move snapshot deletion to cleanup; this allows people with tag-specific permissions to perform snapshot deletion operation 2019-02-25 17:01:19 -08:00
Stephen Fox
2ef6b9247d Initial take on code review feedback from @azr.
Do not use builder pattern or interfaces; stick to structs and
some basic functions.
2019-02-25 17:16:24 -05:00
Megan Marsh
3b726e66c1 swap region copy and encryption steps 2019-02-25 11:03:03 -08:00
Sargun Dhillon
142a84ef43 amazon/chroot: Refactor step_register_ami for testing EBS-related behaviour
There is some logic around how EBS mappings are handled / generated depending
on whether an image if from scratch or not. There was no testing around
this behaviour before. This strips that logic out into a separate function,
to enable testing it independentlhy.
2019-02-25 10:45:23 -08:00
Megan Marsh
3f7c4f7406
Merge pull request #7341 from hashicorp/fix_7325
openstack WaitForImage: pass context for cancellation
2019-02-25 09:30:36 -08:00
Megan Marsh
05897c8653
Merge pull request #7294 from hyperonecom/hyperone
Add HyperOne builder
2019-02-25 08:30:04 -08:00
Adrien Delorme
b9411712eb builder/openstack/step_create_image.go: pass context for cancellation
fix #7325
2019-02-25 15:03:11 +01:00
Miłosz Smółka
94a7a07c87 Merge branch 'master' into hyperone 2019-02-24 15:16:21 +01:00
Miłosz Smółka
0673bb2c57 Add cleanup for stepCreateImage 2019-02-23 14:57:19 +01:00
Sargun Dhillon
d3c65ee77d builder/amazon/chroot: Fix building PV images with mount_partition
Right now, if we have a source image that's PV, and try to build an
image with mount_partition set to not 0, it does not get picked up.
This is because under PV we only had a filesystem, not partitions,
but you can convert a PV image to an HVM image during build time.
2019-02-22 18:21:01 -08:00
Joel Lopes
c8a60c77d1 Add comments 2019-02-21 18:12:57 -08:00
Joel Lopes
1c030cb54b Use IMDS to get subscription for Azure MSI 2019-02-21 09:35:14 -08:00
Megan Marsh
5cc442872e
Merge pull request #7314 from hashicorp/fix_7234
add noSSLVerify to ovftool args
2019-02-19 16:54:48 -08:00
Manuel Riezebosch
d79b54e46a feat(arm-builder): print warning on zone resiliency for currently not supported locations 2019-02-15 19:27:53 +01:00
Manuel Riezebosch
f31031f6b1 feat(arm-builder): zone resilient from config 2019-02-15 19:27:32 +01:00
Megan Marsh
75f574bd4b
Merge pull request #7221 from hashicorp/vagrant_builder
Vagrant builder
2019-02-15 10:05:44 -08:00
Megan Marsh
cb5c896c01
Merge pull request #7310 from hashicorp/fix_7286
also strip \r to work around windows file ending strangeness
2019-02-15 09:19:33 -08:00
Megan Marsh
9f702af6d9 we lost the skip_add step somewhere 2019-02-14 14:46:14 -08:00
Megan Marsh
bbc52f9a7d add noSSLVerify to ovftool args 2019-02-14 12:10:58 -08:00
Megan Marsh
be21850e32
Merge pull request #7060 from andrewsomething/do-post-processor
Add digitalocean-import post-processor.
2019-02-14 11:58:00 -08:00
Megan Marsh
bd3339f1f9 also strip \r to work around windows file ending strangeness 2019-02-13 15:41:37 -08:00
Megan Marsh
c7278e871c
Merge pull request #7038 from kmbulebu/openstack_deprecated_api
Replaced compute/v2/images with imageservice/v2/images.
2019-02-11 15:05:45 -08:00
Megan Marsh
f2439625bf
Merge pull request #7298 from hashicorp/fix_7256
Fix 7256
2019-02-11 14:24:01 -08:00
Megan Marsh
22e3f09db3
Merge pull request #7282 from hashicorp/do_6994
Allow amazon builders to read credentials from Vault.
2019-02-11 12:49:23 -08:00
Megan Marsh
2a613dd6e9 fix up the github suggestion 2019-02-11 11:49:17 -08:00
Adrien Delorme
3ae5a912d4
Update builder/amazon/common/step_pre_validate.go
Co-Authored-By: SwampDragons <megan@hashicorp.com>
2019-02-11 11:41:58 -08:00
Kevin Bulebush
cd1f1165ed Support reading app creds from packer config 2019-02-09 22:52:02 -05:00
Kevin Bulebush
2edf3d8b8e Openstack: Added application credential config 2019-02-09 22:52:02 -05:00
Megan Marsh
3fd589fa72 typos 2019-02-08 09:31:30 -08:00
Megan Marsh
e2d8c0bfd7 docs 2019-02-08 09:28:10 -08:00
Megan Marsh
07c0c599e0 attach guest additions via SATA when necessasry 2019-02-08 09:15:15 -08:00
Megan Marsh
5057220ad2 use VAGRANT_CWD rather than changing packer run directories 2019-02-07 14:35:01 -08:00
Megan Marsh
dc848ea5d7 just make vagrantfile instead of calling init 2019-02-07 12:39:56 -08:00
Miłosz Smółka
228829139b Merge branch 'master' into hyperone 2019-02-07 14:12:13 +01:00
Miłosz Smółka
1ee4517370 Update source_image names in tests 2019-02-07 09:22:30 +01:00
stephen-fox
b7719650ae
Merge pull request #1 from stephen-fox/parse-user-supplied-keypair
Parse user supplied keypair
2019-02-06 15:07:04 -05:00
chris marget
53c0376dfd don't print keypair to the user's screen 2019-02-06 13:54:05 -05:00
chris marget
13cc73d600 keypair parsing and testing 2019-02-06 13:46:55 -05:00
Miłosz Smółka
fdf028c463 Search SCSI device in /sys/bus due to issues with by-path 2019-02-06 12:30:14 +01:00
Megan Marsh
e56d7f7234 fix tests 2019-02-05 15:34:59 -08:00
Megan Marsh
608b7cb7a3 review comments 2019-02-05 15:16:47 -08:00
Megan Marsh
3704a053d0 move region validation and credential wait into step pre validate 2019-02-05 14:07:04 -08:00
Stephen Fox
354fcc5cc6 Merge branch 'master' into 'ephemeral-ssh-key-pair-issue-7225'. 2019-02-05 16:16:51 -05:00
Stephen Fox
f9d24ccda0 Allow user to get public key straight up, or URL encoded. 2019-02-05 11:59:13 -05:00
Miłosz Smółka
0d8e9f50bf Add proper SCSI search 2019-02-05 16:20:42 +01:00
Paul Meyer
68516fc05c Fix Azure interactive authentication
Builder looks up tenant ID before asking for token. Client config did
not allow that. Also found that token provider was not properly
initialized.

Fixes 7267
2019-02-05 02:35:12 +00:00
Megan Marsh
a7d9d62996 fix tests on windows 2019-02-04 16:11:25 -08:00
Megan Marsh
8add176ab7 finish first pass at vault code; needs testing and cleanup of error messages 2019-02-04 15:54:14 -08:00
Megan Marsh
7a78b47e83 make vault engine stuff into a little struct for easier management 2019-02-04 15:29:45 -08:00
Megan Marsh
af7131b169 tests, logic cleanup, docs for vagrant builder 2019-02-04 14:08:43 -08:00
Megan Marsh
52892699ca make it work with a local vagrant box 2019-02-04 14:08:43 -08:00
Megan Marsh
ad21367b21 vagrant builder 2019-02-04 14:08:43 -08:00
Stephen Fox
f2c11b55be Renamed authorized_keys public key function. 2019-02-04 14:27:14 -05:00
Stephen Fox
ea2a7c3fe9 Merge branch 'master' into 'ephemeral-ssh-key-pair-issue-7225'. 2019-02-04 12:47:42 -05:00
Stephen Fox
01c98f3d82 Tweaked debug SSH private key file name for vbox. 2019-02-04 12:47:18 -05:00
Stephen Fox
c6ae8654d9 Moved SSH key pair code into 'helper/ssh'. 2019-02-04 12:21:58 -05:00
Stephen Fox
25775886a8 Properly set SSH key pair name. 2019-02-04 12:12:18 -05:00
Stephen Fox
be081944b1 Moved new key pair funcs closer to builder funcs. 2019-02-04 12:09:23 -05:00
Stephen Fox
b1b67ecffa Added support for setting a name in SSH key pair.
Also refactored how new SSH key pairs are created, and how the
tests are structured.
2019-02-04 12:07:32 -05:00
Stephen Fox
5893134c61 Updated comment for 'PrivateKeyPemBlock()'. 2019-02-04 10:02:07 -05:00
Stephen Fox
cd4ae03324 Create / use SSH key pairs in vbox builders.
This follows the business logic for creating / using SSH key pairs
in the cloud-type builders (e.g., Amazon EC2).
2019-02-03 12:20:52 -05:00
Stephen Fox
72d1501551 Made SSH public key available in vbox boot command.
The SSH public key (in authorized_keys format) can be retreived in
the build template by specifying '{{ .SSHPublicKey }}'. The key is
URL encoded to escape spaces.
2019-02-03 12:20:42 -05:00
Stephen Fox
459bd1ea7a Added vbox step for SSH key pair business logic. 2019-02-03 12:07:57 -05:00
Stephen Fox
6824806e6f Allow caller to specify new line for SSH public key.
The default behavior of the various builders that create SSH key
pairs appears to be to add a trailing new line. This will be the
default behavior, but at least it can be customized if desired.
2019-02-03 10:37:32 -05:00
Stephen Fox
ad075ffac3 Added 'Description()' to 'sshKeyPair'.
Also cleaned up tests.
2019-02-03 09:17:18 -05:00
Miłosz Smółka
f7de056f23 Add proper cleanup of chroot disk
Closes #3
2019-02-03 00:30:56 +01:00
Miłosz Smółka
5e8eade205 Add support for custom API url of compatible service
Closes #4
2019-02-02 14:05:06 +01:00
Miłosz Smółka
6921cc93a9 Add acceptance tests for chroot 2019-02-01 18:58:16 +01:00
Miłosz Smółka
4704565869 Rename vm_flavour to vm_type 2019-02-01 18:57:43 +01:00
Miłosz Smółka
e7e84f04e7 Fix timestamp interpolation in mount path
Closes #1
2019-02-01 17:46:35 +01:00
Murcurio
60c7d22ffb
Change metadata url to FQDN
If instance has a different DNS/search domain then "metadata" alone won't work. The FQDN of "metadata.google.internal" is included in hosts file, and will work regardless of DNS configuration. Alternatively the IP 169.254.169.254 can be used.
2019-02-01 15:36:40 +11:00
Megan Marsh
eef4fc7a01
Merge pull request #7222 from Adezandee/gce-post-processors
googlecompute-postprocessors: service account and export configs
2019-01-31 16:58:42 -08:00
Megan Marsh
6ea64bc378
Merge pull request #7191 from arizvisa/GH-7190
Adds support to the vmware builders for specifying the number of cores per socket via the `cores` option.
2019-01-31 15:27:52 -08:00
Stephen Fox
f233e54992 Initial SSH key pair helper implementation. 2019-01-30 22:10:27 -05:00
Yaakov
0a08920816 Hyper-V: Fix integer overflows in 32-bit builds 2019-01-31 13:53:01 +11:00
Miłosz Smółka
3d3e933f48 Add host key hash verify 2019-01-29 10:44:23 +01:00
Miłosz Smółka
bd4ce90728 Add chroot disk build 2019-01-28 12:33:25 +01:00
Megan Marsh
035c3506ba manually set proxyfromenvironment in default http client for ec2 sessions 2019-01-25 12:33:25 -08:00
Megan Marsh
c63b54a1e7 move http with proxy call into a helper function 2019-01-25 12:32:52 -08:00
Megan Marsh
904c4b9adb
Merge pull request #7230 from hashicorp/up-aws-sdk-go
Don't try to guess region from metadata if not set + update aws-sdk-go
2019-01-25 10:06:11 -08:00
Adrien Delorme
4a2773f8fa remove default max retries config of 8, it will now be used from env
removing the code that wants to guess region from metadata allows us to change that setting, which can now be taken from environment.
2019-01-25 13:51:02 +01:00
Adrien Delorme
964b149df2 aws: remove now unused AccessConfig.metadataRegion 2019-01-25 13:03:14 +01:00
Adrien Delorme
335f442b51 aws: unwrap AccessConfig.region func
* it was used only in the Session() call.
* default region guessing from metadata should happen in the SDK, not 'manually'
2019-01-25 13:02:42 +01:00
Adrien Delorme
54af9951a8 make guard clauses to clearly see success pass 2019-01-25 13:00:21 +01:00
Adrien Delorme
0864b4d07b name unclear import 2019-01-25 12:59:43 +01:00
Arnaud Dezandee
91d2cb8c83
googlecompute-import: add service accounts 2019-01-25 11:36:18 +01:00
Megan Marsh
a0c238940e
Merge pull request #7223 from hashicorp/fix_7200
escape query as suggested in issue #7200
2019-01-24 09:48:38 -08:00
Megan Marsh
e4dca0016c
Merge pull request #7156 from vtolstov/qemu
qemu: Add configuration options to specify cpu count and memory size
2019-01-23 15:19:08 -08:00
Megan Marsh
d0e5c67dc3
Merge pull request #7205 from hashicorp/fix_7196
fix region stuff
2019-01-23 15:15:27 -08:00
Megan Marsh
ce8f5c31df escape query as suggested in issue #7200 2019-01-23 11:04:14 -08:00
Miłosz Smółka
3ce05c7c26 Add acceptance tests 2019-01-23 14:59:28 +01:00
Miłosz Smółka
be30415395 Add HyperOne builder 2019-01-23 14:04:05 +01:00
Vasiliy Tolstov
b6ebe00249 provide memory and cpus like other builders does
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
2019-01-23 13:21:52 +03:00
Adrien Delorme
f57953d4ff Docker needs a temporary dir that is inside the $HOME dir 2019-01-18 16:42:04 +01:00
Adrien Delorme
f19b7c0300 Revert "aws: test timeout when no credenrtials are set" Revert "aws: set max retries back to 20"
This reverts commits b8b3e64cff and 993af36f2e.
2019-01-18 12:40:02 +01:00
Adrien Delorme
b8b3e64cff aws: test timeout when no credenrtials are set 2019-01-18 11:43:52 +01:00
Adrien Delorme
993af36f2e aws: set max retries back to 20 2019-01-18 11:43:26 +01:00
Ali Rizvi-Santiago
9d2f98394e Revert "Renamed the terse option, cores, to to the less-terse version cores_per_socket."
This reverts commit 0c37a3c68f and avoids bikeshedding from other committers.
2019-01-17 14:49:07 -06:00
Ali Rizvi-Santiago
0c37a3c68f Renamed the terse option, cores, to to the less-terse version cores_per_socket. 2019-01-17 10:39:19 -06:00
Ali Rizvi-Santiago
4894873971 Added logic to the vmware-iso builder that appends the number of cores per socket to the vmx in stepCreateVmx. 2019-01-17 10:39:19 -06:00
Ali Rizvi-Santiago
062c62eed8 Added support for specifying the number of cores as cores to vmware-common. 2019-01-17 10:39:19 -06:00
Megan Marsh
e0543246fa remove commented code 2019-01-16 11:05:11 -08:00
Megan Marsh
783ed32e7e fix region stuff 2019-01-16 11:02:58 -08:00
Paul Meyer
e189db97d4 [azure] deallocate instead of just power-off
1. allegedly prevents error where  fails because VM still appears running
2. prevents left-behind VM's after failures from accumulating charges
2019-01-16 00:31:23 +00:00
Paul Meyer
aa29facdae Allow certificate bearer JWT client authentication
This allows certificate based authentication, both by just referencing
the certificate file as well as by providing a bearer JWT. This last
option allows authentication without exposing the private key to packer
using an expiring JWT containting the thumbprint (and sometimes the
whole certificate for subject/issuer based auth), signed using the
certificate private key.
2019-01-15 17:29:28 +00:00
Paul Meyer
7e34579b7e Factor out Azure client credential config 2019-01-15 17:23:57 +00:00
Adrien Delorme
9ddec470a0
Merge pull request #7188 from hashicorp/dedupe_step_output_dir
deduplicate step_output_dir and move to common folder
2019-01-15 17:28:21 +01:00
Megan Marsh
126ca2a877
Merge pull request #7158 from rickard-von-essen/fix-7155
WIP: parallels: Fix attaching prl tools
2019-01-11 15:30:37 -08:00
Megan Marsh
97a791389a deduplicate step_output_dir and move to common folder 2019-01-11 15:06:36 -08:00
Adrien Delorme
c8a39e939a
Merge pull request #7178 from edwardmlyte/simplify-version-check
Simplify version check for port count argument
2019-01-10 16:07:00 +01:00
Ed Maxwell-Lyte
e8e92fe6c6 rename clashing import 2019-01-09 16:30:54 +00:00
Ed Maxwell-Lyte
4437f8d8ba Use go-version for comparison 2019-01-09 16:22:33 +00:00
Ed Maxwell-Lyte
346f5d9bba Simplify version check for port count argument
Might be personal preference, but I think this reads more clearly
2019-01-09 09:46:24 +00:00
Adrien Delorme
9f7b4ffc17
Merge branch 'master' into pr/6950 2019-01-09 10:11:18 +01:00
Adrien Delorme
19cbb9cb24
Merge pull request #7136 from hashicorp/fix_5984
Add "version" option to hyperv calls
2019-01-09 10:06:49 +01:00
Adrien Delorme
1b84019a45
Merge pull request #7174 from edwardmlyte/reverse-default-vbox-portcount-arg
Make portcount default argument for storagectl
2019-01-08 17:35:43 +01:00
Ed Maxwell-Lyte
4fc02ea406 Assign to existing var 2019-01-08 16:19:11 +00:00
Adrien Delorme
f91b668617
Create portCountArg in the if statement
You can't assign to something that doesn't exist

Co-Authored-By: edwardmlyte <edwardmlyte@gmail.com>
2019-01-08 16:15:24 +00:00
Ed Maxwell-Lyte
a9eed311a6 Run gofmt on driver_4_2.go 2019-01-08 15:58:12 +00:00
Rickard von Essen
c8fab8c7a3
Merge pull request #7037 from kmbulebu/openstack_tags
openstack: `image_tags` - Adds support for tagging new images.
2019-01-08 16:53:21 +01:00
Ed Maxwell-Lyte
e5b1e0f4d9 Add version 0.x to the rule 2019-01-08 15:35:45 +00:00
Ed Maxwell-Lyte
e40c90423f Reverse default port count virtualbox argument
As we know the exact versions that used the old `sataportcount` option, it's safe to assume we want to use the newer `portcount` option for everything else.

Reversed the option check and use the `portcount` option by default. Prevents needing to update this for future major versions of VirtualBox.
2019-01-08 14:14:26 +00:00
Rickard von Essen
e3f82d3725
Merge pull request #6933 from cb-oath/openstack-v2-network-optional
openstack: Make the config.networkV2Client conditional in StepAllocateIp
2019-01-07 08:48:38 +01:00
Megan Marsh
16149844a7
Merge pull request #7151 from nelsonjchen/qemu-whpx-option
Add support for whpx accelerator to qemu builder
2019-01-04 12:37:03 -08:00
Megan Marsh
c789a68d89
Merge pull request #7154 from ladar/fix-hyperv-ssh-host-bug
Fix ssh_host bug in hyper-v builders.
2019-01-04 12:14:13 -08:00
Nelson Chen
b39f398fda Add support for whpx accelerator to qemu builder
Windows Hypervisor Platform (WHPX) is the Windows counterpart to HVF and
KVM. It's an operating system provided component that provides
virtualization acceleration support.

This is kind of the missing counterpart to https://github.com/hashicorp/packer/pull/6193.
QEMU 2.12 also added support for WHPX.

There's no support for libvirt on Windows so nothing was added in those
areas.

The popular QEMU for Windows distribution does not have WHPX support
built-in for legal reasons as the maintainer does not wish to use or
obtain any part of Microsoft's SDK to compile the distribution.
2019-01-03 15:20:37 -08:00
Adrien Delorme
7132037faa
Merge pull request #7137 from YuSungDuk/fix_to_get_ssh_password
Fix to get ssh password
2019-01-03 11:22:14 +01:00
Rickard von Essen
21a7a0a614
parallels: Fix attaching prl tools
Closes #7155
2019-01-02 21:33:58 +01:00
Ladar Levison
217028b902 Added comment regarding use of host param. 2018-12-27 03:34:08 -06:00
Ladar Levison
8a9962882c Use Printf not Println. D'oh. 2018-12-27 03:15:44 -06:00
Ladar Levison
35aaf44fa5 A properly formatted hyperv ssh.go file. 2018-12-27 02:55:14 -06:00
Ladar Levison
cb0011d665 Fix ssh_host bug in hyper-v builders. 2018-12-27 02:33:58 -06:00
유성덕
38c4e21563 Fix to get ssh password 2018-12-21 17:53:52 +09:00
Megan Marsh
141f3b29f3
Merge pull request #7127 from ladar/master
Added change support to docker-import post processor.
2018-12-20 14:44:05 -08:00
Adrien Delorme
7655d2efb2
Add tencent cloud builder (#7135 & #6839) 2018-12-20 17:09:44 +01:00
Megan Marsh
006682a09c add version option and also refactor powershell script to use golang templates for ease of testing and variable passing. 2018-12-19 16:30:57 -08:00
Adrien Delorme
e666b60d16
Merge pull request #7126 from hashicorp/fix_7125
fix packer crash that occurs when image is nil
2018-12-19 09:25:28 +01:00
Megan Marsh
56d722f779
Merge pull request #7130 from jo/openstack-add-volume-size-option
Openstack add volume size option
2018-12-18 16:35:25 -08:00
Megan Marsh
d288f94073
Merge pull request #7128 from ladar/hyperv-legacy-network-adapter
Updated support for legacy network adapters on Hyper-V.
2018-12-18 15:32:35 -08:00
Johannes J. Schmidt
a545caa24a use openstack volume_size option on creation
if present. Otherwise fallback to to source image min disk value (if
set) or calculated from the source image bytes size.

Note that in some cases this needs to be specified, if
`use_blockstorage_volume` is true. See #6957 for the discussion.
2018-12-18 23:59:54 +01:00
Johannes J. Schmidt
336c11c54a add openstack volume_size option
Adds an option to OpenStack, `volume_size` (int), which is the size of
the Block Storage service volume in GB.
2018-12-18 23:58:27 +01:00
Christopher Boumenot
acacf6e59c
Merge pull request #7111 from hashicorp/pr-7077-azure-regression
azure: fix snapshot regression
2018-12-18 09:53:52 -08:00
Ladar Levison
bdcbf61ade Fixed replace variable name. 2018-12-18 06:18:51 -06:00
Ladar Levison
fa154f5298 Fixed driver mock up formatting. 2018-12-18 06:14:38 -06:00
Ladar Levison
31d03fb48e Added legacy network adapter driver mock up. 2018-12-18 06:12:05 -06:00
Ladar Levison
da8b140bca Fix Hyper-V builder formatting. 2018-12-18 05:50:16 -06:00
Ladar Levison
348c267054 Updated support for legacy network adapters on Hyper-V. 2018-12-18 04:59:00 -06:00
Ladar Levison
6ac5971288 Fixed cmd order for docker driver. Added config to post proc. 2018-12-17 22:59:41 -06:00
Ladar Levison
10095678c8 Adding driver changes. 2018-12-17 22:37:32 -06:00
Ladar Levison
21fdbadf04 Adding changes to import prototype. 2018-12-17 22:35:59 -06:00
Ladar Levison
050f809a1c Add changes var to docker driver import func. 2018-12-17 22:04:43 -06:00
Megan Marsh
19144111dd fix packer crash that occurs when image is nil 2018-12-17 14:54:27 -08:00
wizurijyq
8184fcb99a
Make sure sshkey is not nil 2018-12-14 22:30:26 +01:00
DanHam
0821653256
Fix 'nil' dir in VMware artifact when building locally 2018-12-14 13:21:41 +00:00
Megan Marsh
2045390e74
Merge pull request #7108 from hashicorp/revert_hddorder_setting
Revert hddorder setting
2018-12-13 16:27:31 -08:00
Christopher Boumenot
f9230aeb95 azure: fix snapshot regression 2018-12-13 13:58:18 -08:00
Megan Marsh
7d5ea43f41 revert the hddorder being added to the vmx template, since it's breaking things for some of our users. 2018-12-13 09:58:24 -08:00
Megan Marsh
b95123f457 add new copy_in_compare flag so users can set the copy var to whatever they need in order to get the compatibility report to work. 2018-12-13 09:12:23 -08:00
Adrien Delorme
2718a5ed62 Revert "revert changes to docker entrypoint; since this is a backwards-breaking change it needs to wait for a minor release"
This reverts commit 2a79d64ae0.
2018-12-13 10:23:46 +01:00
Adrien Delorme
47257c0d07
Merge pull request #7104 from hashicorp/revert_docker_changes
revert changes to docker entrypoint; since this is a backwards-breaki…
2018-12-13 10:23:18 +01:00
Megan Marsh
ee2e5cc874
Merge pull request #7080 from hashicorp/do_6508
Move logging about aws waiters to the access config prepare() so that…
2018-12-12 15:42:37 -08:00
Megan Marsh
2a79d64ae0 revert changes to docker entrypoint; since this is a backwards-breaking change it needs to wait for a minor release 2018-12-12 15:30:24 -08:00
Megan Marsh
279949ddcc
Merge pull request #7090 from tomelliff/validate-kms-key-id
Check that the KMS key ID is valid
2018-12-12 10:04:22 -08:00
Adrien Delorme
b7222d1f56 Add tmp package that offers Dir & File funcs
this regroups the calls of tmp func calls into one package.
the tmp pkg allows to store tmp files under a common directory for easier managment

Squashed commit of the following:
commit 74b674c015
Merge: fc94b5714 66001525d
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Fri Nov 2 02:02:38 2018 -0400

    Merge branch 'remove_TMPDIR_docs' of github.com:tb3088/packer into remove_TMPDIR_docs

commit fc94b57142
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Fri Nov 2 01:42:38 2018 -0400

    update tests to honor configured temporary directory

commit 5a562359f4
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 18:52:38 2018 -0400

    sync straggler to refactor. implement tests at packer/configfile instead of buried in docker.

commit 9d5a4a0935
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 15:39:46 2018 -0400

    insert URL to GoLang API for os.TempDir()

commit fbae4c2e05
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 07:41:29 2018 -0400

    revise documentation to match code

commit 3590fae8bd
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 07:21:59 2018 -0400

    refacter config_file. replace all hard-coded os.TempDir with wrapper

commit d5c5306a97
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 20:11:36 2018 -0400

    close massive file overwrite hole with TempDir

commit 0a72297da8
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 01:06:00 2018 -0400

    adjust var declaration scope

commit 20f68228b6
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 00:54:35 2018 -0400

    use mktemp() equivalent to create temporary directory

commit c73ebe3d83
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 20:40:58 2018 -0400

    remove extraneous variable declaration, fix FOR loop

commit 63549b8bd7
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 19:30:44 2018 -0400

    match styistic convension with rest of docs

commit 9761010749
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 19:08:39 2018 -0400

    revert dangling config file change

commit 95159afbc0
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Fri Dec 29 23:53:43 2017 -0500

    replace invalid TMPDIR variable wth PACKER_TMP_DIR.
    update ConfigTmpDir() to try common temporary paths first and
    only write to configDir() as a last resort.

commit 66001525d7
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Fri Nov 2 01:42:38 2018 -0400

    update tests to honor configured temporary directory

commit e9b6adefea
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 18:52:38 2018 -0400

    sync straggler to refactor. implement tests at packer/configfile instead of buried in docker.

commit 852113ed07
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 15:39:46 2018 -0400

    insert URL to GoLang API for os.TempDir()

commit 54add38d1d
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 07:41:29 2018 -0400

    revise documentation to match code

commit 6b5b8f6d4e
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 07:21:59 2018 -0400

    refacter config_file. replace all hard-coded os.TempDir with wrapper

commit c22092c601
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 20:11:36 2018 -0400

    close massive file overwrite hole with TempDir

commit 7a73045091
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 01:06:00 2018 -0400

    adjust var declaration scope

commit 0f2933adb6
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 00:54:35 2018 -0400

    use mktemp() equivalent to create temporary directory

commit d74839ede0
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 20:40:58 2018 -0400

    remove extraneous variable declaration, fix FOR loop

commit eb65416619
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 19:30:44 2018 -0400

    match styistic convension with rest of docs

commit acaa2b31ed
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 19:08:39 2018 -0400

    revert dangling config file change

commit e573fde668
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Fri Dec 29 23:53:43 2017 -0500

    replace invalid TMPDIR variable wth PACKER_TMP_DIR.
    update ConfigTmpDir() to try common temporary paths first and
    only write to configDir() as a last resort.

commit 39a9874afc
Merge: 8a413cfe8 3315812c2
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 18:19:26 2018 -0400

    Merge branch 'master' of https://github.com/hashicorp/packer into prestine

commit 8a413cfe83
Merge: e07491de5 4e14710a6
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Mon Oct 1 20:18:10 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit e07491de59
Merge: 42610a35d a1fa35dff
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Aug 21 13:26:19 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit 42610a35d5
Merge: 5298142da 0d63cf7bc
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Tue Jun 19 22:45:05 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit 5298142da6
Merge: 7bb110bc7 9d9736552
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Mon Jun 11 15:10:09 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit 7bb110bc74
Merge: a61c869ca 6189d66e7
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Wed May 9 23:41:22 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit a61c869ca7
Merge: 098101dd9 4be5f072c
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Fri May 4 10:13:04 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit 098101dd99
Merge: fefaf0fa6 554b2b4a5
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Tue May 1 20:52:30 2018 -0400

    Merge branch 'EOL-handling' into prestine

Co-Authored-By: Matthew Patton <pattonme@yahoo.com>
2018-12-12 16:35:57 +01:00
Tom Elliff
12bf7fc4d6 Check that the KMS key ID is valid
KMS key IDs can be given as either a raw key ID, an alias (always prefixed with 'alias/'), the full ARN to the KMS key ID or the full ARN to the KMS key alias.

Should help with https://github.com/hashicorp/packer/issues/6599 but probably isn't enough to fully close it.
2018-12-12 11:41:58 +00:00
Adrien Delorme
dfa284c02b
Merge pull request #7094 from hashicorp/fix_7087
fix virtualbox 6.0 beta command options
2018-12-11 11:54:56 +01:00
Adrien Delorme
5e5ed9793f
Merge pull request #7092 from arizvisa/vmware-builders.halt-duplicate-code
Tiny fix to replace some duplicate code with usage of the already defined `halt` closure in the StepCloneVMX step for the vmware-vmx builder.
2018-12-11 11:53:26 +01:00
Megan Marsh
a819217c93 fix virtualbox 6.0 beta command options 2018-12-10 15:18:21 -08:00
Ali Rizvi-Santiago
1a36458e9e Tiny fix to replace some duplicate code with usage of the halt closure in the StepCloneVMX step for the vmware-vmx builder. 2018-12-10 16:24:27 -06:00
Megan Marsh
d367c1ba8b
Merge pull request #7091 from arizvisa/GH-6920
Proper fix to #6920 which ensures that entrypoint and arguments get passed to docker, not the image.
2018-12-10 13:25:34 -08:00
Ali Rizvi-Santiago
a6af04417e Moved the entrypoint argument for the docker builder in front of the image so it's passed correctly as an argument. 2018-12-10 15:09:56 -06:00
Megan Marsh
32f226eda0
Merge pull request #7069 from arizvisa/GH-6920
Updated docker's default config to use regular bourne shell instead of bourne again.
2018-12-10 11:29:27 -08:00
chhaj5236
c4782807de
Merge pull request #7050 from chhaj5236/feature/force_delete_copied
alicloud: delete copied image and snapshots if corresponding options are specified
2018-12-09 19:39:14 +08:00
Adrien Delorme
c42b3a41a9
Merge pull request #7059 from hashicorp/fix_6965
Fix 6965
2018-12-07 13:35:00 +01:00
Megan Marsh
ce71932f95
Merge pull request #7061 from boumenot/pr-6773-caching-type
azure: configuration for disk caching
2018-12-06 15:06:21 -08:00
Megan Marsh
042e9ad14b Move logging about aws waiters to the access config prepare() so that it's only spit out once per builder. 2018-12-06 14:37:31 -08:00
Megan Marsh
dbfc1b5aff fix tests 2018-12-06 09:36:16 -08:00
Megan Marsh
0058422a5c also for vmx 2018-12-05 15:58:44 -08:00
Megan Marsh
0fe4d79bbf add validation to prevent users from being confused about format functionality 2018-12-05 15:57:45 -08:00
Ali Rizvi-Santiago
2e977019e4 Modified the docker builder's default run_command to specify the shell via the entrypoint command line argument as suggested by @vrubiolo in #6920. 2018-12-04 23:52:17 -06:00
bozhi.ch
0174a502eb support -force option and update docs 2018-12-05 11:50:35 +08:00
Ali Rizvi-Santiago
310ea6c006 Updated docker's default config to use regular bourne shell instead of bourne again. Closes #6920. 2018-12-04 18:28:48 -06:00
Ali Rizvi-Santiago
040a33567e Trying again one more time to prevent import cycles.. Moved common.ExpandUser into packer.ExpandUser.. 2018-12-04 16:54:47 -06:00
Ali Rizvi-Santiago
79b68fb89c Replaced the previous incorrect logic with an re-implementation of common.ExpandUser. 2018-12-04 16:53:33 -06:00
Ali Rizvi-Santiago
e04986659a Changed the logic for when to actually prefix a path with a u.HomeDir so that it's only done when a non-absolute path is specified. 2018-12-04 16:53:33 -06:00
Ali Rizvi-Santiago
1a3c3f2ffc Replaced all instances of mitchellh/go-homedir with an implementation based on os/user. 2018-12-04 16:53:33 -06:00
Megan Marsh
152f6fed8f
Merge pull request #7066 from arizvisa/vmware-temporary-devices
Add a "temporaryDevices" key to the statebag for the VMware builder
2018-12-04 10:34:37 -08:00
Ali Rizvi-Santiago
96bdf17d2e Added knowledge of the "temporaryDevices" statebag to the StepCleanVMX tests for the VMware builders. 2018-12-03 18:03:02 -06:00
Megan Marsh
65124985d1 don't set DetectZeroes if it's off, because some versions of QEMU don't support this option 2018-12-03 15:52:13 -08:00
Ali Rizvi-Santiago
fa4998e1ec Modified StepCleanVMX to walk through the "temporaryDevices" statebag so that we can disable or remove its devices cleanly. This gets rid of the regex hack that was previously used to identify a cdrom-image. 2018-12-03 17:50:40 -06:00
Ali Rizvi-Santiago
e0d3861e81 Updated StepCreateVMX to add the CDROM device that packer uses to the "temporaryDevices" statebag so that StepCleanVMX can unmount its ISO later. 2018-12-03 17:48:05 -06:00
Ali Rizvi-Santiago
3512c3c5ea Updated StepConfigureVMX to add the floppy disk device to the "temporaryDevices" statebag so that StepCleanVMX can remove it later. 2018-12-03 17:48:05 -06:00
Ali Rizvi-Santiago
27b16cee0a Added a new "temporaryDevices" key to the VMware builders' statebag in order to keep track of devices that were temporarily added during build and need to be removed later by StepCleanVMX. 2018-12-03 17:47:45 -06:00
Christopher Boumenot
c7d8f4e150 azure: configuration for disk caching
Export a configuration knob to change the disk caching setting. The
default value remains ReadWrite.  This seems the most appropriate value
given Packer.  Certain disk sizes require that disk caching be disable,
and this knob allows the user to do just that.
2018-11-30 14:14:43 -08:00
Andrew Starr-Bochicchio
c0c5c6afac Add DigitalOcean post-processor. 2018-11-29 21:00:57 -05:00
Megan Marsh
c03894c05d fix bad interpolation exemption for volume_size 2018-11-29 16:39:43 -08:00
Adrien Delorme
c29268a5d2
Merge pull request #7046 from nferch/hcloud_snapshot_labels
add snapshot_labels to hcloud builder
2018-11-29 13:48:57 +01:00
Megan Marsh
a2c3b35bff
Merge pull request #7032 from hashicorp/fix_region_validation
move region validation to run so that we don't break validation when no creds are set
2018-11-28 15:02:18 -08:00
Megan Marsh
11ef407b4d
Merge pull request #7016 from rickard-von-essen/vmware-tech-prev
vmware: Correctly parse version for VMware Fusion Tech Preview
2018-11-28 14:59:53 -08:00
PORTE Loïc
bf97557abf Backport VNC log from vmware to qemu 2018-11-28 19:13:29 +01:00
bozhi.ch
a485bcfdf3 delete copied image and snapshots if corresponding options are specified 2018-11-28 21:34:21 +08:00
Megan Marsh
ec75913412 fix crash that occurs when dir is nil 2018-11-27 16:34:26 -08:00
Megan Marsh
89fb8f0d3e fix defaulting/lack thereof for cpu count and memory in vmware template 2018-11-27 15:43:48 -08:00
Nathan A. Ferch
fccd7d0692 add snapshot_labels to hcloud builder 2018-11-27 14:41:32 -05:00
Megan Marsh
6728244480 simplify for loop logic 2018-11-27 09:33:29 -08:00
Andrew Pennebaker
c05ac784d3 fix tests 2018-11-27 09:31:01 -08:00
Andrew Pennebaker
5ada3376b8 fix test 2018-11-27 09:31:01 -08:00
Andrew Pennebaker
2c989157e4 gofmt 2018-11-27 09:31:01 -08:00
Andrew Pennebaker
5b6cbeed1d expose --iso option down in VBoxManage export --iso up to virtualbox-iso configuration as "bundle_iso"; ensure ISOs are not removed when this is enabled. 2018-11-27 09:31:01 -08:00
Megan Marsh
8cc3320977
Merge pull request #7034 from zenjoy/hcloud/rescue_mode
[Hetzner Cloud] Support for builds using rescue mode
2018-11-26 11:39:34 -08:00
bozhi.ch
7704ff2f24 apply tags to relevant snapshots 2018-11-26 16:58:32 +08:00
dedene
1aaa998b02 Revert back to reset server 2018-11-26 09:49:45 +01:00
dedene
6589bfaaab Small code improvements and fixes 2018-11-26 09:10:17 +01:00
zhuzhih2017
53bfe7179f
Merge pull request #7022 from chhaj5236/feature/image_without_datadisks
alicloud: support creating image without data disks
2018-11-26 13:13:51 +08:00
Kevin Bulebush
76d1bf567e Replaced compute/v2/images with imageservice/v2/images.
Removed usage of a deprecated API.
Standardized clientService naming.
2018-11-25 14:30:31 -05:00
bozhi.ch
3c1395eb04 support wait_snapshot_ready_timeout for much bigger disk 2018-11-25 16:05:26 +08:00
dedene
0f3bfbf8e6 Fix timing issues by updating to hcloud-go v1.11.0 2018-11-24 17:56:09 +01:00
Kevin Bulebush
802e7d467d openstack: Add support for tagging new images. 2018-11-23 20:22:10 -05:00
dedene
064e6c7e08 Add support for builds using rescue mode 2018-11-23 20:35:32 +01:00
Adrien Delorme
e539133d8c
Merge pull request #7019 from arizvisa/vmware.cpu-memory
Add configuration options to vmware builder to specify cpu count and memory size
2018-11-23 10:53:46 +01:00
Adrien Delorme
24510907be
Merge pull request #7018 from arizvisa/parallels.cpu-memory
Add configuration options to parallels builder to specify cpu count and memory size
2018-11-23 10:50:01 +01:00
Adrien Delorme
174c811c1e
Merge pull request #7017 from arizvisa/virtualbox.cpu-memory
Add configuration options to virtualbox builder to specify cpu count and memory size
2018-11-23 10:27:14 +01:00
Ali Rizvi-Santiago
f8c23c1808 Updated things related to the vmware-iso builder to include @azr's suggestions. 2018-11-22 21:03:06 -06:00
Ali Rizvi-Santiago
0f019407d6 Updated things related to the general hw config in the virtualbox builders to correspond to @azr's suggestions. 2018-11-22 20:48:00 -06:00
Ali Rizvi-Santiago
784535a4e3 Updated things related to the parallels-iso builder to correspond to @azr's suggestions. 2018-11-22 20:19:00 -06:00
Ali Rizvi-Santiago
61ee3a44f5 Modified the cpus and memory options for the vmware builders to only apply them if they were specified. 2018-11-21 00:43:14 -06:00
Megan Marsh
da6e350949 fix tests 2018-11-20 15:20:01 -08:00
Megan Marsh
fbb3d526e3 move region validation to run so that we don't break validation when we don't have aws creds set 2018-11-20 15:01:28 -08:00
Nathan A. Ferch
849a6ed353 add ssh_keys config to hcloud builder 2018-11-20 13:58:17 -05:00
bozhi.ch
3c2c13a021 support creating image without data disks 2018-11-19 15:25:12 +08:00
Ali Rizvi-Santiago
fb7ce9f2b5 Renamed both cpu_count and memory_size to cpus and memory (respective). 2018-11-17 06:36:02 -06:00
Ali Rizvi-Santiago
eca26f43f2 Renamed both cpu_count and memory_size to cpus and memory (respective). 2018-11-17 06:34:22 -06:00
Ali Rizvi-Santiago
24140131c7 Renamed both cpu_count and memory_size to cpus and memory (respective). 2018-11-17 06:32:11 -06:00
Ali Rizvi-Santiago
51948daf92 Added options for the cpu count, memory, audio, and usb to the virtualbox builder. 2018-11-17 06:19:54 -06:00
Ali Rizvi-Santiago
71d15d05c0 Added support for the cpu_count, memory_size, sound, and usb options to the parallels builder. 2018-11-17 06:13:59 -06:00
Ali Rizvi-Santiago
cd45248eaa Moved common hardware config options used by the vmware-iso builder into common/hw_config and added options for the CpuCount and MemorySize. 2018-11-17 06:08:08 -06:00
Rickard von Essen
4ea3d1567a
vmware: Correctly parse version for VMware Fusion Tech Preview
Closes #5317
2018-11-17 09:32:15 +01:00
Ali Rizvi-Santiago
4e73c85e22 Re-sorted, grouped, and commented the options in the template VMX for the VMWare builder to keep things organized. 2018-11-16 22:20:00 -06:00
Christopher Boumenot
06c2c35e4c
Merge pull request #6980 from amydutta/amdut/snapshot
Adding options for Managed Image OS Disk and Data Disk(s) snapshot(s)
2018-11-16 15:51:52 -08:00
Amrita Dutta
b8def0b3fb Added test to check for missing OS disk snapshot name and data disk snapshot prefix 2018-11-15 22:01:16 +00:00
Amrita Dutta
67342750a3 Addressed PR comments 2018-11-14 01:47:48 +00:00
Megan Marsh
dca02c7b07
Merge pull request #6962 from hashicorp/fix_6940
escape vSphere username when putting it into the query
2018-11-13 10:15:25 -08:00
Megan Marsh
3b413d2e5e fix rebase conflicts 2018-11-12 13:24:03 -08:00
Megan Marsh
89184ae384 rework if/else to simplify main code body. 2018-11-12 13:21:25 -08:00
Megan Marsh
536e0501ac Validate username/password for ovftool during prepare.
Add template option skip_validate_credentials allowing users to skip this validation if they don't want it.
Refactor vmware-iso builder to separate out config so that it matches the vmware-vmx builder and simplifies the builder.go file
2018-11-12 13:21:25 -08:00
Megan Marsh
7643ccc67d
Merge pull request #6982 from hashicorp/fix_6161
azure builder: allow to auth with managed identities ( MSI )
2018-11-12 09:03:41 -08:00
Megan Marsh
49b40e0789
Merge pull request #6984 from hashicorp/add_display_name_vmware
add new display_name template option
2018-11-12 08:49:38 -08:00
Adrien Delorme
f1fa28847f
remove debug line.
Co-Authored-By: SwampDragons <megan@hashicorp.com>
2018-11-12 08:07:08 -08:00
Adrien Delorme
78ac943679
Merge pull request #6987 from hashicorp/6624
6624
2018-11-12 15:31:36 +01:00
Adrien Delorme
175b6a7971 add test for MSI configuration 2018-11-12 12:04:57 +01:00
Adrien Delorme
1958ef6e81 remove unecessary check 2018-11-12 11:32:49 +01:00
Adrien Delorme
08e8b1850e
remove unnecessary parenthesis 2018-11-12 10:49:39 +01:00
Amrita Dutta
2d6b18e63e Fix tests after bug fix 2018-11-10 00:05:25 +00:00
Megan Marsh
2e2b2cea82 add a warning that checks for collisions between packer-generated values in the default vmx file and the vmx_data 2018-11-09 15:46:52 -08:00
Amrita Dutta
213fbbae00 Updated go version and reformatted 2018-11-09 22:41:48 +00:00
Megan Marsh
3cf4c63a87 Change antiquated Master/Slave terminology for disk drives to more appropriate Primary/Secondary. 2018-11-09 14:00:07 -08:00
Megan Marsh
e5c4a4a6fb create export directories for vmx and ovf file types, too. 2018-11-09 11:45:36 -08:00
Amrita Dutta
a297d73b98 correcting wrong log message 2018-11-09 19:29:57 +00:00
Amrita Dutta
06525dd885 adding logs in the steps 2018-11-09 19:28:37 +00:00
Megan Marsh
68c9e34bfe add new display_name template option 2018-11-09 10:54:31 -08:00
Megan Marsh
be0959004a
Revert "Revert "Rename attribute api_access_key to organization_id"" 2018-11-09 08:47:22 -08:00
Adrien Delorme
1ab0173e69 azure builder: allow to auth with managed identities ( MSI ) 2018-11-09 17:39:03 +01:00
Amrita Dutta
8881bc2d64 Fix bug in snapshot client creation 2018-11-09 03:30:57 +00:00
Megan Marsh
c1c929164f
Revert "Rename attribute api_access_key to organization_id" 2018-11-08 16:34:23 -08:00
Megan Marsh
210d62de2c
Merge pull request #6925 from sieben/organization_renaming
Rename attribute api_access_key to organization_id
2018-11-08 16:33:15 -08:00
Rémy Léone
e54d2e3591 Rename attribute api_access_key to organization 2018-11-08 13:45:32 +01:00
Mikhail Ushanov
536252683e builders: reuse private key file reading function
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-11-08 14:25:50 +03:00
Amrita Dutta
8d8c86366b Config tests + typo fix 2018-11-07 22:23:22 +00:00
Amrita Dutta
1fa9f1ef11 formatting changes in stateBag.go 2018-11-07 18:11:48 +00:00
Amrita Dutta
8c326dbab7 Formatting changes 2018-11-07 18:08:15 +00:00
Amrita Dutta
b2d1675d39 Added tests 2018-11-07 03:23:17 +00:00
Amrita Dutta
369b2dae5e Inlining suggested functions 2018-11-06 21:50:53 +00:00
Megan Marsh
790d5661c5 escape username 2018-11-06 11:30:45 -08:00
Amrita Dutta
593363c5be fix typo in last commit 2018-11-06 19:23:15 +00:00
Amrita Dutta
1266d5146d addressed PR comments + add file for data disk snapshots 2018-11-06 19:17:03 +00:00
Megan Marsh
8567be43d9
Merge pull request #6927 from hashicorp/rebased_4591
Extend vmware-vmx builder to allow esxi builds. (Rebase of PR #4591)
2018-11-06 09:59:26 -08:00
Megan Marsh
96d628eef1 fix silliness with pointers 2018-11-06 09:50:28 -08:00
Amrita Dutta
d12d23d34b OS disk snapshot 2018-11-05 23:48:22 +00:00
Megan Marsh
79862f1bbb
Merge pull request #6931 from hashicorp/fix_6919
aws: better error handling of region/credential guessing from metadata
2018-11-05 11:24:09 -08:00
Megan Marsh
5c2ca450bd fix tests 2018-11-02 15:44:27 -07:00
Megan Marsh
5815b376b4 remove unnecessary checks; we always default format to ovf if it is unset.
fix exportoutputdir
2018-11-02 14:22:01 -07:00
Megan Marsh
c3144c2d0a add some missing template validation (copied from iso builder) and revert to current use of displayName for parsing vm ssh IP; using VMName was breaking chained builds that hadn't updated the display name from the previous build. 2018-11-02 14:22:01 -07:00
Megan Marsh
c3d6d45696 modify test so that it accesses CommConfig the same way we really do within the driver 2018-11-02 14:22:01 -07:00
Megan Marsh
f18bb19f96 remove redundant config; CommConfig was already a part of the SSSHConfig struct 2018-11-02 14:22:01 -07:00
Megan Marsh
fa12113eaf remove unused NewLocalArtifact
consolidate artifacts
entirely remove local artifact object and get artifacts in the vmx builder the same way we do in the vmware iso builder
2018-11-02 14:22:01 -07:00
Adrien Delorme
3f288fc6ca aws client: config.WithMaxRetries(8) 2018-11-01 15:09:07 +01:00
Megan Marsh
daf1f39930
Merge pull request #6918 from hashicorp/oracle_classic_volumes
Parameterized volume size support for Oracle classic builder
2018-10-31 16:03:40 -07:00
Matthew Hooker
3ff038d4d1
remove todo 2018-10-31 12:00:33 -07:00
bozhi.ch
c3a60ad0ce add options for system disk properties 2018-10-30 21:09:59 +08:00
Matthew Hooker
42cd3e4bf7
Warn if not a pv build but builder image entry is set. cleanup 2018-10-29 15:23:58 -07:00
chbell43
653fa2298f use guard clauses
* just return early if no FloatingIP is required

* move the instanceIP declaration up and store in the state bag to avoid
errors in ssh.go
2018-10-29 18:36:08 +00:00
Mikhail Ushanov
4608b5d39d amazon: add option for skipping TLS verification
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-29 21:35:29 +03:00
chbell43
ea78cb62fd Make the config.networkV2Client conditional
In cases where the OpenStack environment does not contain a v2 network, the
builder will error out.  We only need the networkV2Client when using floating
IPs.  This will allow packer to work in environments where a v2 network is not
available.
2018-10-29 18:32:09 +00:00
Matthew Hooker
eb976894fc
cleanup 2018-10-27 02:04:36 -07:00
Matthew Hooker
c697c9d3de
cleanup 2018-10-26 21:59:26 -07:00
Matthew Hooker
f322397413
add config tests 2018-10-26 21:56:39 -07:00
Matthew Hooker
6d6d262308
some final fixes and documentation work 2018-10-26 21:56:00 -07:00
Matthew Hooker
4eba1ee724
remove unused config key 2018-10-26 20:02:51 -07:00
Matthew Hooker
03932f1157
Clean up volumes 2018-10-26 20:02:13 -07:00
Matthew Hooker
e2a0cbf7df
move upload script to const 2018-10-26 16:59:23 -07:00
Matthew Hooker
7331d6fc7f
some final clean up 2018-10-26 16:59:23 -07:00
Matthew Hooker
ab4f205bf6
correctly building linux/windows now 2018-10-26 16:59:23 -07:00
Matthew Hooker
09de194d8e
trying to wrap the base communicator config but it needs to be prepared 2018-10-26 16:59:22 -07:00
Matthew Hooker
ab5e964ca6
Connecting to master instance but not builder 2018-10-26 16:59:22 -07:00
Matthew Hooker
ade396e140
don't echo image creation commands 2018-10-26 16:59:22 -07:00
Matthew Hooker
3e966ae38d
make fmt 2018-10-26 16:59:22 -07:00
Matthew Hooker
86f6cf478a
cleanup 2018-10-26 16:59:22 -07:00
Matthew Hooker
6f729d0265
Adding some missing configuration 2018-10-26 16:59:22 -07:00
Matthew Hooker
c42be62d90
fix identifier changes from oracle sdk 2018-10-26 16:59:22 -07:00
Matthew Hooker
bbb0d450f1
todo 2018-10-26 16:59:22 -07:00
Matthew Hooker
be91c99d29
warn about dangling segments.
The client offers no way to bulk delete keys, so for now let's just warn users.
The issue is tracked upstream here: https://github.com/hashicorp/go-oracle-terraform/issues/172
2018-10-26 16:59:22 -07:00
Matthew Hooker
ce30e1053e
wip 2018-10-26 16:59:22 -07:00
Matthew Hooker
9f310045fc
split image upload/creation. clean up 2018-10-26 16:59:22 -07:00
Matthew Hooker
420d0ebe3e
fix artifact generation 2018-10-26 16:59:21 -07:00
Matthew Hooker
84bb5d2f6f
create image list 2018-10-26 16:59:21 -07:00
Matthew Hooker
fa54a64d28
WIP 2018-10-26 16:59:21 -07:00
Matthew Hooker
b84c7df9da
Segments going into per-run subfolder 2018-10-26 16:59:21 -07:00
Matthew Hooker
b5c6beb8a3
don't delete segments. registering works now. 2018-10-26 16:59:21 -07:00
Matthew Hooker
705fa976a8
more debugging 2018-10-26 16:59:21 -07:00
Matthew Hooker
2536790e0a
todo 2018-10-26 16:59:21 -07:00
Matthew Hooker
7a35e2408f
fix pty, some todo and refactor of bash scri[t 2018-10-26 16:59:21 -07:00
Matthew Hooker
fc301601e1
actually delete temp container 2018-10-26 16:59:21 -07:00
Matthew Hooker
cd77d00fd8
delete temporary image container 2018-10-26 16:59:21 -07:00
Matthew Hooker
21f786d686
todo and some clean up. correct values for machine image 2018-10-26 16:59:21 -07:00
Matthew Hooker
b222d36669
use 2x volume size 2018-10-26 16:59:21 -07:00
Matthew Hooker
7c577abbcb
WIP: register machine image.
remove passwords
2018-10-26 16:59:21 -07:00
Matthew Hooker
8207ba4fa4
Use jq to create manifest. Upload to compute_images 2018-10-26 16:59:20 -07:00
Matthew Hooker
96e62236ec
upload volume WIP
check upload for error
increase builder volume size to account for chunking
2018-10-26 16:59:20 -07:00
Matthew Hooker
8598e2d0a3
WIP 2018-10-26 16:59:20 -07:00
Matthew Hooker
bf7c4a7ad6
wip 2018-10-26 16:59:20 -07:00
Matthew Hooker
445c3fb5bb
cleanup temp keys 2018-10-26 16:59:20 -07:00
Matthew Hooker
098764d8ac
WIP 2018-10-26 16:59:20 -07:00
Matthew Hooker
2db0a03142
image upload WIP 2018-10-26 16:59:20 -07:00
Matthew Hooker
265ee0b0b8
add whitespace 2018-10-26 16:59:20 -07:00
Matthew Hooker
7c26ffef9c
builder instance now runs and is connected to 2018-10-26 16:59:20 -07:00
Matthew Hooker
b3ffa975c3
Revert "add boot volume to builder instance"
This reverts commit cbce7b42079d2087bc622fd8c6f65d1339b735d1.
2018-10-26 16:59:20 -07:00
Matthew Hooker
2febfa2c7d
attach volume after instance booted 2018-10-26 16:59:20 -07:00
Matthew Hooker
b68f214ca4
add boot volume to builder instance 2018-10-26 16:59:20 -07:00
Matthew Hooker
ca3bffcb0d
bugfix and some debug logging 2018-10-26 16:59:19 -07:00
Matthew Hooker
00ff187d77
master instance working 2018-10-26 16:59:19 -07:00
Matthew Hooker
e271e88b49
oracle-classic variable volume size WIP 2018-10-26 16:59:19 -07:00
Adrien Delorme
f4fbf45349 remove duplicate region check error 2018-10-26 17:44:56 +02:00
Adrien Delorme
16aa21dffe aws: better error handling of region guessing from metadata
* this will fix #6919
2018-10-26 12:24:10 +02:00
Megan Marsh
2ae235a28a fix tests 2018-10-25 14:41:01 -07:00
Megan Marsh
290f4a7c4c cleanup to make it actually build after that monstrous rebase 2018-10-25 14:17:35 -07:00
Alexander Laamanen
3193f50f17 Support export with the vmx builder. 2018-10-25 13:02:37 -07:00
Alexander Laamanen
a68a639a1a Move step_export to common. 2018-10-25 12:55:10 -07:00
Alexander Laamanen
63054fb808 Fix the test. 2018-10-25 12:45:44 -07:00
Stuart Miller
da5f322484 Add quotes around all filenames to prevent issues with spaces 2018-10-25 12:45:44 -07:00
Alexander Laamanen
f42f5a8ad3 Remove some extra logging. 2018-10-25 12:44:29 -07:00
Alexander Laamanen
e7e6a80587 No need to make upload public. 2018-10-25 12:39:51 -07:00
Alexander Laamanen
c294e65c36 A separate driver file is not really needed anymore 2018-10-25 12:39:51 -07:00
Alexander Laamanen
2ed6c3ef5e Set output dir always according to the config. 2018-10-25 12:37:47 -07:00
Alexander Laamanen
c940f7e754 Conditional reload. 2018-10-25 12:37:47 -07:00
Alexander Laamanen
17845beadc Fix the CommHost tests 2018-10-25 12:37:47 -07:00
Alexander Laamanen
5e74bcfb88 Fix tests, move remote_ default values to driver_config. 2018-10-25 12:30:57 -07:00
Alexander Laamanen
4d9cb19012 Refactor artifacts and output_dir implementations. 2018-10-25 12:21:24 -07:00
Alexander Laamanen
2d00dc6756 Add VMName to the vmx mods. 2018-10-25 11:17:09 -07:00
Alexander Laamanen
7b5943160b Re-enable the CommHost() call. Use common's driver factory. 2018-10-25 11:17:09 -07:00
Alexander Laamanen
ba22090bc9 Move step_register and step_uload_vmx from iso to common. 2018-10-25 11:07:02 -07:00
Alexander Laamanen
b5298464c5 Move the remote_driver from iso to common. 2018-10-25 11:01:22 -07:00
Alexander Laamanen
91c7089455 Implement the first version of the remote Clone(). 2018-10-25 10:37:45 -07:00
Alexander Laamanen
46cfb5a30c Move driver_esx5 to commons and allow it to be instantiated wtih NewDriver() 2018-10-25 10:33:37 -07:00
Megan Marsh
c7b938c9d4
Merge pull request #6904 from hashicorp/fix_6890
Fix 6890
2018-10-24 10:43:34 -07:00
Adrien Delorme
8908a72fa9 builder/hyperv/vmcx: allow to set generation from buildfile
this commit fixes #6908
2018-10-24 12:20:52 +02:00
Adrien Delorme
ed793a8fb8 make ValidateRegion a member of *AccessConfig and make it variadic 2018-10-24 11:26:53 +02:00
Megan Marsh
fe044d8ff7 fix tests 2018-10-23 13:31:56 -07:00
Megan Marsh
340009009d Revert "Revert "Merge pull request #6892 from hashicorp/fix_6890""
This reverts commit 0cd3f36d50.
2018-10-23 09:58:27 -07:00
Megan Marsh
0cd3f36d50 Revert "Merge pull request #6892 from hashicorp/fix_6890"
This reverts commit 1c4062c316, reversing
changes made to 9bc41a23b9.
2018-10-23 09:34:05 -07:00
Megan Marsh
1c4062c316
Merge pull request #6892 from hashicorp/fix_6890
fix template-set credentials
2018-10-22 13:55:48 -07:00
Megan Marsh
0924a316b7 fix template-set credentials
update tests with mocked session
2018-10-22 13:53:40 -07:00
Megan Marsh
cdd99564fd
Merge pull request #6891 from hashicorp/fix_6794
Fix 6794
2018-10-22 11:10:05 -07:00
Megan Marsh
091efae8bb
Merge branch 'master' into misc 2018-10-22 11:07:30 -07:00
Megan Marsh
fd8a85042d use strconv.Quote instead of fmt.Sprint 2018-10-22 10:59:47 -07:00
Megan Marsh
18c5e8deb8 fix 2018-10-19 13:46:55 -07:00
Megan Marsh
1e4133cbf9 quote upload path 2018-10-19 13:43:13 -07:00
Megan Marsh
3f591d78f3 quote vmx path in register function 2018-10-19 13:42:40 -07:00
Megan Marsh
8cba32d526 escape all the d.sh calls that contain paths 2018-10-19 13:42:40 -07:00
Megan Marsh
5b9adc0c48 single quotes 2018-10-19 13:42:40 -07:00
Megan Marsh
9573013d3a
Merge pull request #6872 from aspectcapital/disable-ena-support
Add support to explicitly disable ENA support
2018-10-19 10:54:38 -07:00
Megan Marsh
9fe27c225b
Merge pull request #6703 from shield-9/wait_volume
OpenStack: wait for volume availability when cleaning up
2018-10-19 10:25:51 -07:00
Matt Dainty
feb8067c7d Convert ena_support to a pointer
This means it now has three states, `true`, `false`, & `nil`. The
default state is now `nil` which does nothing instead of `false` which
now will explicitly disable ENA support instead of just not enabling it.
2018-10-19 12:40:43 +01:00
Josh Soref
b68168807a Miscellaneous doc improvements
backticks, spaces, commas

In general, a list of items should have a space after each comma.
While there are editorial styles that suggest commas inside quotations,
they're horrible advice when the backticks are describing specific
character for a user to enter.

one off indent filters section

singular

backticks...

word wrap long lines...

spelling: macOS

contributing: clarify closing case
contributing: link to changelog
contributing: point to git remote...
contributing: split commands from descriptions
contributing: grammar
spelling: github
grammar: comma after etc.
spelling: macOS
grammar: i.e.
alicloud: use relative link
alicloud: use backticks
alicloud: bits
alicloud: such as
grammar: comma after etc.
avoid linking periods
grammar: period
amazon-chroot: IOPS
amazon-chroot: use backticks
amazon-chroot: link to section
amazon-chroot: whether-or-not; period
amazon-ebs: period
amazon-ebs: use relative link
amazon-ebs: use backticks
amazon-ebs: comma
amazon-ebs: bold
amazon-ebssurrogate: comma after etc.
amazon-ebssurrogate: this builder
amazon-instance: this builder
amazon-ebssurrogate: set this
amazon-ebssurrogate: whether-or-not
amazon-ebssurrogate: period
amazon-ebssurrogate: bold section reference
amazon-ebssurrogate: backticks...
amazon-ebssurrogate: commas around e.g.
spelling: precedence
spelling: i.e.
amazon-ebssurrogate: backticks...
2018-10-18 19:09:49 -04:00
Megan Marsh
57f87f58b9
Merge pull request #6374 from rickard-von-essen/aws-filters
builder/amazon: Add suppport for vpc_filter, subnet_filter, and security_group_filter
2018-10-18 14:34:02 -07:00
Megan Marsh
3175dcdf81
Merge pull request #6807 from dev-rowbot/qemu-net-device-6804
Fix for #6804 - KVM/QEMU Network "has no peer"
2018-10-18 14:09:22 -07:00
Megan Marsh
c5b6eff691
Merge pull request #6871 from LKaemmerling/master
Add hcloud builder
2018-10-18 11:13:16 -07:00
Lukas Kämmerling
e4a670d2a2 Remove Debug Message 2018-10-18 10:29:06 +02:00
Adrien Delorme
29d041ea8a
Merge pull request #6858 from hashicorp/tests_race_detector
test with race detection enabled + fix race on progressbar
2018-10-18 09:48:03 +02:00
Lukas Kämmerling
bad1b95a49 Unify steps, fix some typos 2018-10-18 08:03:04 +02:00
Megan Marsh
fd89d4f020
Merge pull request #6827 from skish/qemuDiskZero
builder/qemu add drive detect-zeroes option
2018-10-17 19:12:38 -07:00
Megan Marsh
2266514408
Merge pull request #6843 from gmmephisto/pr-master-aws-security-group
aws: wait for temporary security group before authorize rules
2018-10-17 14:08:49 -07:00
Megan Marsh
e7d3a30c0e
Merge pull request #6865 from hashicorp/fix_6862
Fix 6862
2018-10-17 13:07:29 -07:00
Mikhail Ushanov
00c96fc400 aws: use IpPermissions for authorizing temporary security group
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-17 22:00:25 +03:00
Mikhail Ushanov
b316be51cd aws: wait for temporary security group before authorizing
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-17 22:00:24 +03:00
Megan Marsh
b0cfecf314 remove unnecessary valid flag 2018-10-17 11:03:31 -07:00
Matt Dainty
9e0fae9db3 Add support to explicitly disable ENA support
If `ena_support` is set to false then it previously didn't do anything
whereas now it will explicitly disable ENA support.

Fixes #6852
2018-10-17 14:58:07 +01:00
Adrien Delorme
410bee0666 make TestStepShutdown_shutdownDelay less strict on schedule 2018-10-17 12:49:38 +02:00
Lukas Kämmerling
270110767c
Add hcloud Builder 2018-10-17 12:15:47 +02:00
Adrien Delorme
af3b818de0 TestBuilderPrepare_ISOChecksumType: set config["switch_name"] = "switch" to avoid using builder.detectSwitchName which can lock down in CI mode 2018-10-17 12:09:24 +02:00
Adrien Delorme
0237956e66 builder/virtualbox/common/step_shutdown_test.go: compare durations instead of floats & ouput duration 2018-10-17 11:19:57 +02:00
Adrien Delorme
1ca21499c6 Revert "make builder/hyperv/vmcx/builder_test.go invisible to windows"
This reverts commit e692dee2d8.
2018-10-17 10:21:53 +02:00
Adrien Delorme
b80a0fed42 make builder/parallels/common/output_config_test.go invisible to windows 2018-10-17 09:59:13 +02:00
Adrien Delorme
e692dee2d8 make builder/hyperv/vmcx/builder_test.go invisible to windows 2018-10-17 09:57:42 +02:00
Megan Marsh
d4767845f0 fix tests 2018-10-16 15:01:13 -07:00
Megan Marsh
7c3f0aa3b2 make sure region validation catches authentication errors 2018-10-16 14:17:30 -07:00
Mikhail Ushanov
ee133482b4 aws: add validation for device_name parameter
cause it's required in block-device-mapping.

Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
2018-10-16 21:37:48 +03:00
Adrien Delorme
8a6c55dd69 make builder/hyperv/iso/builder_test.go invisible to windows 2018-10-16 19:09:35 +02:00
Matthew Aynalem
28eff7303e builder/googlecompute: validate startup_script_file exists 2018-10-15 16:09:33 -07:00
Megan Marsh
cdc6c57b31
Merge pull request #6822 from hashicorp/fix_6774
Fix 6774
2018-10-10 13:25:58 -07:00
Megan Marsh
f5af2afc06
Merge pull request #6818 from hashicorp/fix_6732
default wait time for amazon import to one hour.
2018-10-10 11:27:34 -07:00
Megan Marsh
f331327f24
Merge pull request #6823 from hashicorp/fix_6794
fix datastore path that contains spaces
2018-10-10 10:06:15 -07:00
Megan Marsh
53bce398bb add Managed Image test to azure artifact 2018-10-10 10:04:19 -07:00
Megan Marsh
5dc4ff95da fix azure artifact so it works with managed images as well as VHDs 2018-10-10 10:04:11 -07:00
Christopher Boumenot
520dea23fd
Merge pull request #6798 from mbearup/mb-sharedgallery
Consume images from Azure Shared Image Gallery
2018-10-10 09:53:18 -07:00
mbearup
de8d30d77c Update tests for Azure Shared Image Gallery 2018-10-10 09:20:34 -07:00
Konstantin Shloma
fe341e2bd0 fix go source formatting
add description to documentation page
2018-10-10 16:16:23 +03:00
Konstantin Shloma
1155347b55 add qemu disk detect-zeroes= option 2018-10-10 14:38:59 +03:00
mbearup
c7180413b0 Fix tests for Shared Image Gallery 2018-10-09 16:38:50 -07:00
Megan Marsh
e5e75df033 fix datastore path that contains spaces 2018-10-09 16:36:55 -07:00
mbearup
a3a2a9e970 Fix issue with composite literal in test 2018-10-09 15:35:09 -07:00
mbearup
335feaf89c Convert shared_image_gallery options to a struct
Updates tests and documentation for shared_image_gallery
2018-10-09 13:56:49 -07:00
Megan Marsh
895e7fe111
Merge pull request #6812 from hashicorp/remove_unused_processPrivateKeyFile
removed unused processPrivateKeyFile func & tests
2018-10-09 13:14:11 -07:00
Megan Marsh
02bfac118f default wait time for amazon import to one hour. 2018-10-09 13:08:42 -07:00
Megan Marsh
f494d87dc5
Merge pull request #6747 from hashicorp/fix_6743
abort if image import fails
2018-10-09 12:56:28 -07:00
Adrien Delorme
b2e2d3b008 removed unused processPrivateKeyFile func & tests 2018-10-09 11:56:43 +02:00
Rowan Potgieter
65db6be6b9 Fix for #6804
The user QEMU args may overwrite the default -device.
This results in no network
2018-10-06 14:40:43 +02:00
mbearup
5373b8586d Update tests for Azure Shared Image Gallery 2018-10-05 16:04:07 -07:00
mbearup
b6bb5d4b4d Fix format/spacing for config.go 2018-10-05 10:52:02 -07:00
mbearup
c1e0146d33 Dynamically set apiVersion for Shared Image Gallery scenario. 2018-10-03 16:33:28 -07:00
mbearup
d21b13cb85 Modify variable names for Shared Image Gallery.
Add checks for Shared Image Gallery options.
2018-10-03 16:10:46 -07:00
Adrien Delorme
f44dfcc62f
Merge pull request #6727 from hashicorp/fix_6723
reset poll delay seconds default to 2 because it can actuall be used …
2018-10-03 11:15:42 +02:00
Adrien Delorme
146db5667a fix intermitent TestProcessPrivateKeyFile_encrypted failure
Because of deficiencies in the encrypted-PEM format, it's not always possible to detect an incorrect
password. In these cases no error will be returned but the decrypted DER bytes will be random noise.

this closes #3337
2018-10-01 10:29:30 +02:00
mbearup
55be0da5da Initial changes to support Shared Image Gallery 2018-09-30 13:56:44 -07:00
Adrien Delorme
b7b1720a91
Merge pull request #6772 from fflorens/scaleway-add-boottype
scaleway: add boottype parameter in config
2018-09-27 16:51:01 +02:00
Florian Florensa
9ea5104b74 scaleway: add boottype parameter in config 2018-09-27 16:37:07 +02:00
Adrien Delorme
37c6f08abe Revert "Fix bugs"
This reverts commit 02139dcb69 that constitutes pr #6701
2018-09-27 16:27:34 +02:00
Adrien Delorme
016b0985a6 builder/openstack: use config as a pointer so values could be set
this commit will close #6712
2018-09-27 16:27:34 +02:00
Adrien Delorme
b328d3569d builer/triton: pass config as a pointer so values could be set 2018-09-27 16:27:34 +02:00
Adrien Delorme
22d3e9b5c4 builder/amazon/ebs: pass config as a pointer so values could be populated by a run 2018-09-27 16:27:34 +02:00
mvaude
7f78eef08d scaleway: fix builder problems with ssh keys
The builder is currently failing with the last packer version.

This commit is fixing:
- the ssh keys and configuration management (the config is passed through a pointer and the ssh keys through the config instead of the runner states)
- the key size for generated ssh key
- the public key added as a tag to the instance<Paste>

fix #6757
2018-09-27 15:40:18 +02:00
Matthew Hooker
9181570bc3
remove stray struct dumps in logs 2018-09-27 00:14:05 -07:00
zhuzhih2017
676b28ecc5
Merge pull request #6764 from chhaj5236/feature/support_disable_stop_instance
support disable_stop_instance option for some specific scenarios
2018-09-27 14:52:07 +08:00
zhuzhih2017
f59cde03c4
Merge pull request #6763 from chhaj5236/fix/invalid_type_convert
fix type error in step_create_tags
2018-09-27 14:49:52 +08:00
bozhi.ch
bb19cdeb55 support disable_stop_instance option for some specific scenarios 2018-09-25 22:02:05 +08:00
bozhi.ch
1f3a517a19 fix type error in step_create_tags 2018-09-25 20:20:10 +08:00
Rickard von Essen
838d5021f5 openstack: use source_image_name to find UUID 2018-09-21 10:35:15 +02:00
Daisuke Takahashi
3b8aba2d24 OpenStack: wait for volume availability when cleaning up 2018-09-21 10:13:45 +09:00
Megan Marsh
d616f0ba71 abort if image import fails 2018-09-20 13:18:59 -07:00
Daisuke Takahashi
c848f59a55 Check condition for image_disk_format option 2018-09-20 11:02:30 +09:00
Daisuke Takahashi
b7bd3d4b34 OpenStack: Change option name to image_disk_format 2018-09-20 10:44:28 +09:00
Daisuke Takahashi
904dd1df63 Add disk_format option for OpenStack builder 2018-09-20 10:44:28 +09:00
Megan Marsh
b0774d155a
Merge pull request #6512 from sharmaanshul2102/5786-use-describe-regions-for-validation-aws
Use DescribeRegions for aws region validation
2018-09-19 10:37:42 -07:00
Megan Marsh
79093da6ad skip region validation in tests that don't care; refactor Prepare func so we can test region validation logic with a mock 2018-09-19 10:30:08 -07:00
Adrien Delorme
9ba959598b
Merge pull request #6729 from hashicorp/fix_ssh_digitalocean
builder/digitalocean: pass config as a pointer so that ssh configuration is correctly set
2018-09-19 18:26:36 +02:00
zhuzhih2017
9e3e2e83ae
Merge pull request #6720 from chhaj5236/fix/attach_keypair
fix attaching keypair error due to missing keypair name
2018-09-19 14:14:55 +08:00
Megan Marsh
93f1155a14 remove test-related special casing 2018-09-18 08:08:36 -07:00
bozhi.ch
3c312eb2a0 change b.config to pointer 2018-09-18 21:40:57 +08:00
Adrien Delorme
5389ab1694 pass config as a pointer so that ssh configuration is correctly set 2018-09-18 11:36:21 +02:00
Anshul Sharma
ef3c10c403 Modify Validate Region for test cases 2018-09-17 14:45:55 -07:00
Anshul Sharma
98f13eaf29 Use DescribeRegions for aws region validation 2018-09-17 14:45:55 -07:00
Megan Marsh
f4e6d06e68 reset poll delay seconds default to 2 because it can actuall be used in one part of the conditional tree for applyEnvOverrides 2018-09-17 11:10:50 -07:00
chhaj5236
43e091de15
Merge branch 'master' into feature/support_tags 2018-09-17 16:50:44 +08:00
zhuzhih2017
31bbe2983b
Merge pull request #6688 from chhaj5236/feature/support_ssh_private_ip
support ssh with private ip address
2018-09-17 16:46:38 +08:00
bozhi.ch
b3aae89a53 fix attaching keypair error due to missing keypair name 2018-09-16 18:19:00 +08:00
bozhi.ch
b8a3e3b8f4 support adding tags to image 2018-09-16 18:16:13 +08:00
Adrien Delorme
fc75449e06
Merge pull request #6713 from hashicorp/cleanup_keys
new option allowing user to clean up the ephemeral ssh key from the a…
2018-09-14 11:12:33 -07:00
Megan Marsh
38cc525ec7 new option allowing user to clean up the ephemeral ssh key from the authorized_keys file 2018-09-14 11:06:38 -07:00
Daisuke Takahashi
02139dcb69 Fix bugs 2018-09-13 14:39:38 +09:00
Adrien Delorme
770f61e682 spot instance creation, only set blockDurationMinutes when > 0 2018-09-12 10:21:39 -07:00
Adrien Delorme
2e73ed8d46 pass Comm instance to fix Spot instance creation 2018-09-11 18:20:14 -07:00
Matt DeBoer
09797df958 use a UI wrapper to auto-decode error messages
update docs to reflect optional config
2018-09-11 16:05:43 -07:00
bozhi.ch
743be8a808 support ssh with private ip address 2018-09-11 16:56:57 +08:00
Megan Marsh
a0edaf6c46 Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice
Revert "use statebag instead of SetSharedState for winRM password"

This reverts commit b35acbd879.
2018-09-10 16:48:42 -07:00
Adrien Delorme
e02d0dacc4
Merge branch 'master' into aws-filters 2018-09-07 16:14:00 +02:00
Sargun Dhillon
63d784023f Add support to support non-gp2 volume types for building from_scratch 2018-09-06 13:22:09 -07:00
Sargun Dhillon
07ce820c70 Enable setting the volume type when building with the Amazon Chroot builder 2018-09-06 13:22:09 -07:00
Megan Marsh
b94e6e913e
Merge pull request #6670 from sargun/fix-ena-on-pv
Allow users to build hvm images from pv images to have ena_support
2018-09-06 12:50:46 -07:00
Adrien Delorme
4682b3a9d2 refactor possible random strings into common/random 2018-09-05 10:26:52 +02:00
Adrien Delorme
b80e1d51c6 aws: when building an AMI with 'encrypt_boot: true', randomize the name of the temporary AMI 2018-09-05 10:24:28 +02:00
Adrien Delorme
170b2f3383 builder/azure/common.RandomString-> common/random.String
* to share them
* also removed unused PassworString func & arm.TempPasswordAlphabet package const
2018-09-05 10:24:28 +02:00
Sargun Dhillon
902497d6ce Allow users to build hvm images from pv images to have ena_support 2018-09-04 18:16:52 -07:00
Megan Marsh
cb35829f80
Merge pull request #6411 from jmartin-r7/esxi_compact
add support for disk compaction to esx5 builder
2018-09-04 12:44:32 -07:00
Christopher Boumenot
2e294da82a
Merge pull request #6644 from riezebosch/master
[azure-arm] retry cleanup individual resources on error
2018-09-04 11:40:27 -07:00
Megan Marsh
349f9ae62b
Merge pull request #6641 from hashicorp/increase_retries
Increase retries
2018-09-04 11:39:28 -07:00
Adrien Delorme
819bda50d5
Merge pull request #6648 from hashicorp/fix_6642
Update public google cloud image projects
2018-09-03 09:29:31 +02:00
Adrien Delorme
2a2734505b
Merge pull request #6649 from hashicorp/fix_6569
Fix 6569
2018-09-03 08:44:07 +02:00
RenaudS
26aab49aaf aws spot instances: add block_duration_minutes option (#6638)
* Add block_duration_minutes option

* int64 cannot be nil

* Update doc

* Fix formating
2018-09-03 08:33:58 +02:00
Megan Marsh
4472ecccb0 fix waiters that weren't applying env defaults 2018-08-31 13:30:41 -07:00
Megan Marsh
d00b815c06 Update public google cloud image projects 2018-08-31 13:13:19 -07:00
Manuel Riezebosch
fcfa54fb1d [azure-arm] retry cleanup individual resources on error 2018-08-31 13:43:38 +02:00
Adrien Delorme
61480f41dc fix some go vet issues in tests ( composite literal uses unkeyed fields ) 2018-08-31 11:54:12 +02:00
Jeffrey Martin
1833b4edaf
validate compaction is skipped when not 'thin' 2018-08-30 16:44:00 -05:00
Jeffrey Martin
b51cd22b21
document ESXi disk compaction & use verbose option 2018-08-30 16:44:00 -05:00
Jeffrey Martin
09c71f3810
add support for disk compaction to esx5 builder 2018-08-30 16:43:53 -05:00
Megan Marsh
9926988ab7
Merge pull request #6621 from hashicorp/ssh_keys_centralised
Merge ssh fields usage
2018-08-30 14:13:21 -07:00
Megan Marsh
d606339edc
Merge pull request #6635 from hashicorp/fix_6493
fix chroot communicator to properly escape quotes
2018-08-30 09:40:03 -07:00
Megan Marsh
2b9f937c23 increase max retries from 3 to 20 2018-08-30 09:35:06 -07:00
Adrien Delorme
cbbfc6630d scaleway: stop using config from statebag 2018-08-30 17:58:09 +02:00
Adrien Delorme
d159c0900b openstack: use config only where needed 2018-08-30 17:52:11 +02:00
Adrien Delorme
df9e756865 pass the Comm instance to the amazon ebs builders steps 2018-08-30 12:50:29 +02:00
Adrien Delorme
157691c710 remove unecessary get/pug config in tests; those are being referenced 2018-08-30 12:07:37 +02:00
Adrien Delorme
94d5bb7a3b revert test changes of builder/googlecompute/step_create_ssh_key_test.go 2018-08-30 12:04:21 +02:00
Harvey Lowndes
344e7e8b92 Validation for tag configuration 2018-08-29 15:31:05 -07:00
Harvey Lowndes
cc7d4e4a95 Add support for freeform tagging of images 2018-08-29 15:31:05 -07:00
Adrien Delorme
050a98e8bb googlecompute builder: use config from statebag 2018-08-29 18:15:09 +02:00
Adrien Delorme
b0c09087a2 move SSHInterface/SSHIPVersion fields to communitator.Config struct 2018-08-29 14:51:28 +02:00
Adrien Delorme
cd851f8ac2 use public ssh key & key name from config instead of the statebag 2018-08-29 14:40:33 +02:00
Adrien Delorme
0938b640cc use key pair name from config 2018-08-29 14:40:33 +02:00
Adrien Delorme
1e71712cc9 builder.alicloud: stop using config from statebag 2018-08-29 14:40:33 +02:00
Adrien Delorme
4fdf5714a6 builder.scaleway: use c.Comm for ssh 2018-08-29 14:40:33 +02:00
Adrien Delorme
0f9eddda3a builder.oracle: use c.Comm for ssh 2018-08-29 14:40:33 +02:00
Adrien Delorme
92570a2725 builder.openstack: use c.Comm for ssh 2018-08-29 14:40:33 +02:00
Adrien Delorme
4982627dd2 builder.gcp: use c.Comm for ssh 2018-08-29 14:40:33 +02:00
Adrien Delorme
e0e6b0b8f7 builder.cloudstack: use c.Comm for ssh 2018-08-29 14:40:33 +02:00
Adrien Delorme
ef4ca9c48e builder.amazon: use c.Comm for ssh 2018-08-29 14:40:33 +02:00
Adrien Delorme
dffcbb7a35 builder.alicloud: use c.Comm for ssh 2018-08-29 14:40:33 +02:00
Adrien Delorme
9a9b82715b config.Comm.SSHKeyPair => SSHKeyPairName 2018-08-29 14:40:33 +02:00
Adrien Delorme
3a4bb26150 builder.aws: use key pair from comm struct 2018-08-29 14:40:33 +02:00
Adrien Delorme
293c485372 builder.aws: use SSHAgentAuth from Comm 2018-08-29 14:40:33 +02:00
Adrien Delorme
ef08c441c9 builder.aws: use Comm field for StepKeyPair & StepGetPassword 2018-08-29 14:40:33 +02:00
Adrien Delorme
7c358eed2f removed unused builder/azure/common/lin.StepGeneralizeOS struct 2018-08-29 14:40:33 +02:00
Adrien Delorme
3d46fbd4f2 removed unused builder/azure/common/lin.StepCreateCert struct 2018-08-29 14:40:33 +02:00
Adrien Delorme
25de7ad1f2 PrivateKey => PrivateKeyFile 2018-08-29 14:40:33 +02:00
Adrien Delorme
324c46279b up test 2018-08-29 14:40:33 +02:00
Adrien Delorme
5369c15459 helper: communicator.SSHFileSigner => ssh.FileSigner
* had to to avoid circular dependency
* this commit fixes #6631 ( esxi cannot be reached by ssh )
2018-08-29 14:40:33 +02:00
Adrien Delorme
b83c72fd54 more private keys in config 2018-08-29 14:40:32 +02:00
Adrien Delorme
336cac29d4 also use config.SSHPrivateKey for azure-arm builds 2018-08-29 14:40:32 +02:00
Adrien Delorme
d49ad12895 update gcp ssh tests 2018-08-29 14:40:32 +02:00
Adrien Delorme
663c8134ef GCP: put ssh public/private key in config 2018-08-29 14:40:32 +02:00
Adrien Delorme
51d2aac9f6 SSHPrivateKey => SSHPrivateKeyFile 2018-08-29 14:40:32 +02:00
Megan Marsh
e4f6b6f720 fix chroot communicator to properly escape quotes 2018-08-28 09:16:43 -07:00
Matthew Hooker
7519037562
Merge pull request #6629 from hashicorp/travisbuild
travis builds go 1.11. remove 1.9
2018-08-24 20:51:31 -07:00
Matthew Hooker
3f1a9766f4
formatting verb fixes for go 1.11 2018-08-24 16:18:21 -07:00
Matthew Hooker
e41e99954d
go 1.11 format rules 2018-08-24 15:56:44 -07:00
Megan Marsh
c5b346b07b
Merge pull request #6393 from DanHam/fix-hyperv-export
Various improvements to Hyper-V ISO and VMCX builders
2018-08-24 15:52:49 -07:00
Megan Marsh
bf191d1ef6
Merge pull request #6204 from arizvisa/GH-6197
Specify "bios.hddOrder" during the CreateVMX step for the vmware-iso builder.
2018-08-24 15:46:31 -07:00
Megan Marsh
b35acbd879 use statebag instead of SetSharedState for winRM password 2018-08-24 13:51:16 -07:00
Rickard von Essen
23f62f221e Only filter SG's on VPC if it's set. Only use VPC's and Subnets that are available 2018-08-24 20:24:48 +02:00
Megan Marsh
fa99f931b7
Merge pull request #6601 from hashicorp/fix_6536
Increase waiter timeout for AWS WaitUntilImageAvailable command
2018-08-24 09:35:58 -07:00
Adrien Delorme
6bbcd3e914
Remove remaining unused ssh config funcs and add missing calls (#6622)
* Remove duplicate unused SSHConfig funcs

* call to SSHConfigFunc() for azure/arm builder

* ncloud too

* remove empty ncloud file
2018-08-24 16:00:40 +02:00
Rickard von Essen
533967cb66 builder/amazon: Add suppport for security_group_filter
Allow selecting SG's using a filter. Also some cleanup of vpc_filter and
subnet_filter.
2018-08-24 12:42:38 +02:00
Megan Marsh
340363a649
Merge pull request #6613 from hashicorp/merge_ssh_config_funcs
Merge ssh config funcs from builders
2018-08-23 16:03:36 -07:00
Megan Marsh
1f79b430ee
Merge pull request #6610 from hashicorp/filter_logs
Filter logs
2018-08-23 13:30:21 -07:00
Megan Marsh
7f518cc2d0
Merge pull request #6616 from hashicorp/fix_6496
added new template variables to replace PACKER_KEY_INTERVAL with tuna…
2018-08-23 13:21:31 -07:00
Megan Marsh
31d4f8af45 use a time.Duration instead of a hardcoded ms 2018-08-23 13:16:01 -07:00
Rickard von Essen
9840862757 builder/amazon: Add suppport for vpc_filter and subnet_filter
First step of adding support for discovering VPC's and Subnets using
filters.
2018-08-23 12:52:03 +02:00
Rickard von Essen
70cfafb75c
Merge pull request #6490 from tcarrio/most-recent-image-openstack
OpenStack source image search filter
2018-08-23 12:41:06 +02:00
Tom Carrio
e2fe5cd775 Updated test cases to cover bad filters and empty() 2018-08-22 18:23:12 -04:00
Megan Marsh
bb319fb1e8
Merge pull request #6607 from hashicorp/gcp_min_cpu_platform
GCP: min cpu platform
2018-08-22 12:58:34 -07:00
Megan Marsh
918db58604 added new template variables to replace PACKER_KEY_INTERVAL with tunable key and keygroup intervals depending on driver used 2018-08-22 11:37:56 -07:00
Adrien Delorme
e5ffa9e5b3 use SSHConfigFunc on right member in builder/parallels/pvm/builder.go 2018-08-22 18:23:23 +02:00
Adrien Delorme
fa44a4546f use ssh.ParsePrivateKey where we can 2018-08-22 18:23:09 +02:00
Adrien Delorme
41f6e0334d refactor all copy pasted sshConfig with into communicator.Config.SSHConfigFunc
* still need to append the auth methods into an array for gracefullness
2018-08-22 17:02:23 +02:00
Rickard von Essen
057a635cab
Merge pull request #6532 from sermilrod/Allowing-fixed-port-in-forwarding-rules
Cloudstack builder: adding public_ssh_port flag to use a fixed port in the forwarding rules
2018-08-22 14:27:38 +02:00
Rickard von Essen
3b49caaf40 OpenStack: refactored how source_image_filter is handled to remove reflection 2018-08-22 13:37:43 +02:00
Sergio Millan Rodriguez
befdb59da6 renaming public_ssh_port to public_port 2018-08-22 10:17:46 +01:00
Rickard von Essen
bd1961b927 Correctly fail if no Image matches filter 2018-08-21 12:46:42 +02:00
Adrien Delorme
b038cd10f5 GCP: Allow to set MinCpuPlatform 2018-08-21 10:09:30 +02:00
Adrien Delorme
e37f126cf1 update gcp google.golang.org/api/compute/v1/ 2018-08-21 10:09:01 +02:00
Megan Marsh
ff6a039d5b replace scrubconfig with packer.LogSecretFilter.Set
filter winrm password from logs
Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.
2018-08-20 15:35:55 -07:00
Matthew Hooker
31fcfe4bc2 PoC for filtering logs 2018-08-20 15:20:21 -07:00
Adrien Delorme
6b3844a64f
Revert "allow to use ISO images in-place v.s. copying them" 2018-08-20 10:48:06 +02:00
Tom Carrio
c5fe1e9e34 Updated to @rickard-von-essen's code review suggestions, including:
- filter build and error checking in Prepare stage (multiErr created in the original function will be returned to Prepare and appended, so all errors show).
- source_image overrides source_image_filter.
- Doc edit
2018-08-19 18:47:07 -04:00
Tom Carrio
5ca5c037eb Updated filter parser to log all invalid values/fields provided by user 2018-08-19 18:45:22 -04:00
Tom Carrio
fc19cd8d28 Updated limit logic, removed limiter, updated test cases and sort field used 2018-08-19 18:45:22 -04:00
Tom Carrio
4147062802 Internally handling most_recent logic. 2018-08-19 18:45:22 -04:00
Tom Carrio
2d5d1890d4 Switching sort method 2018-08-19 18:45:22 -04:00
Tom Carrio
8d98237a15 I should have a git-status alias to make fmt 2018-08-19 18:45:22 -04:00
Tom Carrio
036918b81b Updated to comments in PR#6490 - Thanks @haxorof 2018-08-19 18:45:22 -04:00
Tom Carrio
db3d2682b5 Updated allowed filters to tags, visibility, owner, and name. Test cases updated and passed 2018-08-19 18:45:22 -04:00
tcarrio
e9e58e6b2b Tags field parsed from "tags" and updated test case 2018-08-19 18:45:22 -04:00
Tom Carrio
c8fd53d60b make fmt 2018-08-19 18:45:22 -04:00
Tom Carrio
de9999ecb9 Updated tag to slice, docs, comments, only active images, source_image_name supercedes filter name 2018-08-19 18:45:22 -04:00
tcarrio
e776ad51a9 Removing statement from old image erroring logic 2018-08-19 18:45:22 -04:00
tcarrio
3a6ab0fc0e Updated test logic and Error->Errof for formatted output. 2018-08-19 18:45:22 -04:00
tcarrio
6dc71590eb Updated OpenStack Builder docs and tests 2018-08-19 18:45:22 -04:00
tcarrio
94018c691c Fixed step interface, added step to builder, passing all tests for new image_query.go 2018-08-19 18:45:22 -04:00
Tom Carrio
a87c8fec38 Fixing up reflection issues on ListOpts builder 2018-08-19 18:39:42 -04:00
Tom Carrio
810a602a1b Added testing on query helper functions 2018-08-19 18:39:42 -04:00
Tom Carrio
33caed3531 Completed filters and most_recent processing using OpenStack imageservice API 2018-08-19 18:39:42 -04:00
Megan Marsh
00c6ec979f do 30 minutes not 25 2018-08-17 13:30:02 -07:00
Megan Marsh
00de0f4996 increase the timeout for waiting for an ami to become available 2018-08-17 13:27:19 -07:00
Megan Marsh
5dbd71b857
Merge pull request #6593 from hashicorp/iso_inplace
allow to use ISO images in-place v.s. copying them
2018-08-17 10:27:50 -07:00
Andrei Ozerov
6bf442f039 OpenStack builder: fix floating IP docs
Update website documentation about "floating_ip_network" parameter.
Add new inline comment about alghoritm that is used for checking
floatingIP-related configuration parameters.
2018-08-17 07:55:31 +03:00
Andrei Ozerov
103403db48 OpenStack builder: do not always use floating IPs
Only associate floating IPs if user provided "floating_ip_network" or
"floating_ip".
Remove FindExternalNetwork helper method because it won't be used.
2018-08-17 00:49:06 +03:00
Andrei Ozerov
5d6ba4301d OpenStack builder: fix floating_ip_pool validation
Only use "floating_ip_pool" if "floating_ip_network" wasn't set.
Update unit test for the OpenStack builder parameters.
2018-08-17 00:15:18 +03:00
Andrei Ozerov
1af899248b OpenStack builder: allow floating IP network name
Add support for the external network reference by it's name apart from
ID.
Include external network id in a log message of
the openstack/step_allocate_ip.
2018-08-16 23:38:41 +03:00
Andrei Ozerov
c9047cbfbe OpenStack builder: update floating IP params
Rename "floating_network" to the "floating_ip_network".
Return old "floating_ip_pool" parameter for backward compatibility with
old configuration files. It's value will be passed to the
"floating_ip_network" parameter.
2018-08-16 22:18:48 +03:00
Andrei Ozerov
0eef9b4292 OpenStack builder: floating IP refactoring
Remove usage of the deprecated OpenStack Compute service floating IP
management and add methods to work with the OpenStack Networking
service floating IPs API.

Remove usage of the deprecated OpenStack Compute service floating IP
pools and add methods to work with the OpenStack Networking service
external networks API.

Move reusable logic of working with the OpenStack Networking service API
to a separate methods in the networking.go file.

Pass error messages from the API services to the ui messages in the
allocate IP step.
2018-08-16 22:15:26 +03:00
zhuzhih2017
2eafdb33a2
Merge pull request #6588 from xiaozhu36/master
Support describing and checking source image coming from marketplace
2018-08-16 20:58:52 +08:00
Andrei Ozerov
3316d40527 OpenStack builder: make volume type optional
Volume type parameter should be optional as described in API reference:
https://developer.openstack.org/api-ref/block-storage/v3/#create-a-volume

It should be enforced by the OpenStack cluster if not specified.
2018-08-16 12:40:11 +02:00
Andrei Ozerov
572cdeecd1 OpenStack builder: create image from blockstorage
Allow to create final image from the Block Storage service volume.
2018-08-16 12:40:11 +02:00
Andrei Ozerov
c0ffe7eb89 OpenStack builder: add StepDetachVolume
Add a step of detaching Compute instance volume if it's created using
the Block Storage service.
It is needed to create a final image.

This commit also moves common volume functions to a different file and
fixes some messages in the StepCreateVolume.
2018-08-16 12:40:11 +02:00
Andrei Ozerov
005f7e56a7 OpenStack builder: cleanup blockDeviceMappingV2
There is no need to indicate type of the list elements, remove it.
2018-08-16 12:40:11 +02:00
Andrei Ozerov
d51e683bf7 OpenStack builder: add Block Storage volumes
This commit allows user to use the Block Storage v3 volume as the
Compute instance root volume.
Also it adds new volume-related parameters to the builder.
2018-08-16 12:40:11 +02:00
Megan Marsh
ac3554a37f
Merge pull request #6594 from rickard-von-essen/mode-check
Check that only certain files are executable
2018-08-15 13:07:00 -07:00
Megan Marsh
3362897c44
Merge pull request #6585 from hashicorp/do_6584
fix security hole with ami filter
2018-08-15 10:26:40 -07:00
Rickard von Essen
074b170ed4 Fixed exec bit 2018-08-15 16:13:34 +02:00
Rickard von Essen
25452945d7
Merge pull request #6546 from mzupan/do-add-tags
Add tags to DigitalOcean Droplets
2018-08-15 15:52:32 +02:00
Adrien Delorme
17f2949e36 remove stuttering; ISOConfig.InplaceISO -> Inplace 2018-08-15 15:51:25 +02:00
Rickard von Essen
889c89ec79 Validate tags 2018-08-15 15:27:00 +02:00
Adrien Delorme
82e480a285 allow to use ISO images inplace v.s. copying them 2018-08-15 14:37:38 +02:00
Rickard von Essen
9e9f0d2ab9
Merge pull request #6570 from cb-oath/openstack-builder-ports
add support for ports to the OpenStack builder
2018-08-15 13:35:48 +02:00
Rickard von Essen
c962e7b856 Simplified loop code 2018-08-15 13:12:47 +02:00
Megan Marsh
71cad4f2a9 fix tests 2018-08-14 12:30:05 -07:00
He Guimin
1a17b799f1 Support describing and checking source image coming from marketplace 2018-08-15 00:14:02 +08:00
Megan Marsh
250da0ab49 fix security hole with ami filter 2018-08-13 17:01:13 -07:00
Christopher Boumenot
39fc8593de
Merge pull request #6576 from double16/vagrant-azure
Add to vagrant post-processor support for Azure
2018-08-09 12:36:22 -07:00
Patrick Double
2868971a9b Fixes per code review 2018-08-09 07:14:14 -05:00
Patrick Double
d796edc783 Add to vagrant post-processor support for Azure 2018-08-08 10:04:28 -05:00
Megan Marsh
5585855265
Merge pull request #5165 from bennu/esxi-remote-cache
vmware-iso:esxi5 using ISO files uploaded by packer to datastore
2018-08-06 14:31:19 -07:00
Megan Marsh
99d1a1a297
Merge pull request #6541 from rsclarke/qemu-ssh-agent
add ssh agent support for qemu builder
2018-08-06 13:43:26 -07:00
Megan Marsh
57dd1c3ca2
Merge pull request #6543 from thedrow/lxc-root-path
Determine lxc root according to the running user
2018-08-06 11:34:01 -07:00
chbell43
aaa42543e6 fix formatting 2018-08-03 21:32:34 +00:00
chbell43
5f9d4b729f add support for ports to the OpenStack builder
For networks that have multiple subnets, we may want to target a single
subnet.  OpenStack doesn't let you target a single subnet in a network
and so you need to make a port.
2018-08-03 20:46:36 +00:00
Nye Liu
6d6212b75e Fix issue #6561 - Pass "--config" option correctly to "lxc launch" 2018-08-02 19:37:53 +00:00
Christopher Boumenot
a3e6153068 azure: implement clean_image_name 2018-08-01 10:54:45 -07:00
Felix Yan
f69ab4ed77
Fix a typo in config_test.go 2018-07-31 15:19:45 +08:00
Mike Zupan
11271ead59 Change name to tags 2018-07-30 07:55:06 -06:00
Mike Zupan
7081fe990b Adding in droplet tags on creation 2018-07-30 07:52:40 -06:00
Omer Katz
26dd6441e0
Locate lxc root directory when exporting as well. 2018-07-29 16:14:17 +03:00
Omer Katz
808df82eea
Remove privilege escalation with sudo when copying files. Preserve file permission mapping when copying files. 2018-07-29 16:03:01 +03:00
Omer Katz
e5b740e223
Determine lxc root according to the running user. 2018-07-29 13:16:41 +03:00
rsclarke
887e694534 add ssh agent support for qemu builder 2018-07-27 20:24:06 +08:00
Anshul Sharma
c1edcd3774
amazon-ebssurrogate clean up volumes 2018-07-26 09:38:59 +03:00
bugbuilder
2c4f703ff8 Merge 2018-07-24 20:54:08 -04:00
Sergio Millan Rodriguez
d90dfc096a adding public_ssh_port flag to use a fixed port in the forwarding rules 2018-07-24 18:39:02 +01:00
Christopher Boumenot
9c6b4287e5
Merge pull request #6480 from hashicorp/pr-azure-password-requirements
azure: satisfy Azure password requirements
2018-07-24 09:58:54 -07:00
Megan Marsh
5bbb6633cf
Merge pull request #6279 from ChrisLundquist/clundquist/lxc-perms
[WIP] Unpriviliged LXC containers
2018-07-24 09:34:21 -07:00
Megan Marsh
07b6bc0c4f
Merge pull request #6504 from sharmaansh/6309-amazon-chroot-create-volume-tags
amazon-chroot: Add tags on CreateVolume
2018-07-23 14:58:17 -07:00
Megan Marsh
d2823622e5
Merge pull request #6249 from iammattcoleman/add-use_backing_file
qemu builder: add the 'use_backing_file' setting for QCOW2 images
2018-07-23 13:40:04 -07:00
DanHam
da21c25791
Convert incorrect 'vmxc' -> 'vmcx' in codebase, docs and template opts
grep -rli --exclude-dir={vendor,bin\*,\*vmware\*,\*pkg\*} vmxc . | \
xargs sed -i 's/\(vm\)\(x\)\(c\)/\1\3\2/ig'
2018-07-20 02:12:47 +01:00
DanHam
674bad0ab4
Break very long lines for readability 2018-07-20 02:12:47 +01:00
DanHam
2bb5a92755
Fix error in comment due to copy/paste from VMware step 2018-07-20 02:12:47 +01:00
DanHam
36bd2f5691
Fix an error with an error. Add some comments. 2018-07-20 02:12:46 +01:00
DanHam
ee0a2469eb
Add ability to specify 'temp_path' for the build directory to VMCX builder 2018-07-20 02:12:46 +01:00
DanHam
8032c8151a
Tests for step to create output directory 2018-07-20 02:12:46 +01:00
DanHam
f027585a93
Tests for step to create build directory 2018-07-20 02:12:45 +01:00
DanHam
ed5bebfa8c
Change variable/statebag key name to better convey purpose 2018-07-20 02:12:45 +01:00
DanHam
00276f2f64
Change step name to better illustrate purpose of step 2018-07-20 02:12:45 +01:00
DanHam
b386e567db
Change filename to better illustrate purpose of step 2018-07-20 02:12:45 +01:00
DanHam
d2390f464d
Actually implement the function for the driver 2018-07-20 02:12:45 +01:00
DanHam
181bb0ba23
Add calling code and skeleton driver to make tests pass 2018-07-20 02:12:45 +01:00
DanHam
0a4ec13323
Tests for func to move VHDs to output dir when skip_export: true 2018-07-20 02:12:44 +01:00
DanHam
32148168bd
Introduce a new step to collate build artifact at the end of the build
The new step collects together all the required build artifacts and
places them in the output directory.

* Reintroduce/add the code removed from step export to preserve the
  legacy export directory structure when skip_export is unset/false
* Add a place holder for a future function that will move just the VHD
  files from the build directory to the output directory when
  skip_export is true
* Add tests for current functionality and placeholder tests for future
  functions
2018-07-20 02:12:44 +01:00
DanHam
ee7fa27ada
Fix up tests. Ensure export step stores the export path in state 2018-07-20 02:12:44 +01:00
DanHam
232dd8f0a6
Remove code to preserve legacy export dir structure from the export step
Store the export path in the state bag in preparation for use in a later
step
2018-07-20 02:12:44 +01:00
DanHam
c2437ba592
Remove the option to place the VHD files in a separate directory
The export process now exports the VM directly from the build directory
into the output directory. There are no intermediate steps or copying of
files involved. This means that there is no longer any benefit in having
a separate directory to house the VHD files - see #5206 for the
reasoning behind the introduction of this feature.

If a user wishes to house the build files on a separate disk from the
output directory (perhaps for performance reasons or due to disk space
limitations) they can still do so through the use of `temp_path`.
2018-07-20 02:12:43 +01:00
DanHam
d5d82c32b2
Changes to the export process have made 'inline' build of disks redundant
PR #5631 introduced code to build/create disks directly in the output
directory if `skip_export` was set in an attempt to optimise the build
process. These are no longer required.
2018-07-20 02:12:43 +01:00
DanHam
35b4e87c42
Add tests for export VM step 2018-07-20 02:12:43 +01:00
DanHam
30a71da8e7
Add tests for disk compaction step 2018-07-20 02:12:43 +01:00
DanHam
09028c14a3
Reintroduce the disk compaction process as a unique step 2018-07-20 02:12:43 +01:00
DanHam
da2df69301
Remove disk compaction from the export step 2018-07-20 02:12:42 +01:00
DanHam
c6b9d9ce90
Add checks/error reporting to compaction process
* Report compaction results
* Failure to find any disks under the supplied path is treated as a
  'soft' error and a warning message will be printed in place of the
  compaction result. Any other failure will cause the build to fail.
2018-07-20 02:12:42 +01:00
DanHam
534fc4a473
Ensure the export directory structure matches that of previous versions
Commit 3fc2defb6 altered the directory structure associated with an
exported VM. The changes mean that the export process now stores the
exported machine files and folders under a folder with name 'vm_name' in
the output directory.
This commit restores the previous behaviour whereby the exported machine
files and folders were stored directly in the output directory. This
allows us to keep the efficiency improvements introduced with 3fc2defb6
while maintaining backward compatibility.

By default the Export-VM command creates three folders in the specified
export directory - 'Virtual Hard Disks', 'Virtual Machines' and
'Snapshots'. When a machine with no associated snapshots is exported the
'Snapshots' directory is empty.
Prior to 3fc2defb6 the Snapshots folder was not copied/incorporated into
the output directory at all. This was a bug.
This commit preserves the legacy behaviour by not including an empty
Snapshots directory in the export. However, if there *are* Snapshots
associated with the VM, they are now moved into the output directory
along with the usual directories containing disks and VM metadata. This
prevents warnings/errors on import due to missing snapshots.
2018-07-20 02:09:57 +01:00
DanHam
dc46848f89
Remove now redundant function to copy exported VM files 2018-07-20 02:09:57 +01:00
DanHam
3fc2defb6d
Refactor the export step for Hyper-V ISO and VMCX builders
* Fixes a bug that caused the build to error if users did not
  explicitly set `skip_compaction:true` when setting `skip_export:
  true`. See #6392.
* Improves the efficiency of the compaction and export process by
  reordering the compaction and export steps.
* Further improves the efficiency of the compacting step through
  compacting the vmd* file directly rather than creating and then
  operating on a copy.
* The changes mean the export process now stores the exported machine
  files and folders under a folder with name 'vm_name' in the output
  directory. Previously the exported machine files and folders were
  stored directly in the output directory.
2018-07-20 02:09:54 +01:00
Matthew Hooker
814c1cf2b2
spellfix 2018-07-18 13:00:45 -07:00
Andrew Pryde
67f039509a
Merge pull request #6498 from neumayer/ocimetadata
Allow instance metadata to be specified in config
2018-07-18 18:27:27 +01:00
Anshul Sharma
885ecb0790
Issue-6309 Amazon Chroot Provider
-  Add tags on CreateVolume
2018-07-18 13:01:15 +03:00
xxx
7630268e1d Incorporate review comments 2018-07-17 17:41:19 +02:00
James Nugent
9fffe4056e
Merge pull request #5452 from smaato/tag-spot-requests
Enable tagging of spot requests
2018-07-16 13:00:07 -05:00
Sander van Harmelen
451cbd8aa9
Merge pull request #6487 from sermilrod/Honour-cloudstack-projectid
Honour cloudstack projectid
2018-07-16 13:53:06 +02:00
Sergio Millan Rodriguez
f4020835d6 flag to setup networking without firewall rules 2018-07-16 13:06:51 +02:00
Sergio Millan Rodriguez
472a7820eb Using UI keypair meaningful message 2018-07-16 11:39:15 +02:00
Sergio Millan Rodriguez
e729b21212 passing projectid to getRootVolumeID rather than the whole config struct 2018-07-16 11:38:14 +02:00
Mark Meyer
2fec76ea87 Check if spot price is empty, when spot_tags is set 2018-07-13 22:42:42 +02:00
Megan Marsh
b6b907f523 read in the environment variables that government wait time and polling time for the AWS wait in step_stop_ebs_volume 2018-07-13 09:43:28 -07:00
Sergio Millan Rodriguez
a41a4658ee make packer builder honour projectid setting if provided 2018-07-13 17:58:46 +02:00
Sergio Millan Rodriguez
eae0556dc5 Add option to enable/disable create firewall/acl rules 2018-07-13 17:58:39 +02:00
Megan Marsh
1d15f09e36
Merge pull request #6440 from DanHam/simplify-vmx-find-disks
Further simplify enumeration of attached disks for VMware VMX builder
2018-07-12 11:05:35 -07:00
Christopher Boumenot
fa7f54cb55 azure: satisfy Azure password requirements 2018-07-11 15:32:45 -07:00
Megan Marsh
8e22803099 fix loading of environment variables for managing aws waiters 2018-07-11 13:10:38 -07:00
Megan Marsh
12f1b2421d
Merge pull request #6332 from hashicorp/do_6177
Replace home-grown waiters with aws sdk's built in waiters
2018-07-11 11:17:02 -07:00
Megan Marsh
f657ca39c9 refactored env var code and tests so that I don't have to set env vars during tests to check logic 2018-07-11 10:36:21 -07:00
Megan Marsh
14166fdd99 update amazon import docs to include the env vars for setting aws waiter delays and timeouts 2018-07-11 10:36:21 -07:00
Megan Marsh
bfbe318727 fix the homegrown waiters
fix image import; issue was with wait options not being evaluated
2018-07-11 10:36:21 -07:00
Megan Marsh
f49a2d8aed move UI call to before the wait; add context to these steps 2018-07-11 10:36:21 -07:00
Megan Marsh
cf63dd10bf replace AMIStateRefreshFunc, InstanceStateRefreshFunc, our spot instance waiter, our chroot volume waiter, and our snapshot waiters with waiters form AWS's SDK. 2018-07-11 10:34:20 -07:00
M. Marsh
62d9dcb822
Merge pull request #6477 from jabbera/fixMaxResourceGroupLength
managed_image_resource_group_name max length change
2018-07-11 10:23:30 -07:00
Mike
5ea6429cd6
managed_image_resource_group_name max length change 2018-07-11 11:31:51 -04:00
M. Marsh
8e852af1eb
Merge pull request #6448 from DanHam/fix-esxi-displayName
ESXi: Fix failure to discover IP or export VM when 'displayName' differs from 'vm_name'
2018-07-10 16:57:16 -07:00
Michael Gibson
7e4fb9adb5
vnc_bind_address not getting passed through to qemu
This was mostly addressed in commit
hashicorp/packer@fa273f3

Just missing vncIP from step_type_boot_command.go
2018-07-09 14:05:39 -06:00
M. Marsh
adfee4933a
Merge pull request #6437 from hashicorp/retry_convert
make the convert retryable in case it takes a bit to release a lock
2018-07-09 11:09:57 -07:00
Mark Meyer
3dbf1cb371 Enable tagging of spot requests
This adds a new parameter to the EBS builders named `spot_tags'. This
parameter accepts a map of tags, much like `tags'. These tags will be
applied to a spot request that is created.

Improve visibility.
2018-07-07 16:06:51 +02:00
DanHam
a39c5887fb
Test we halt if a bad path is set in vmx_path 2018-07-06 10:58:25 +01:00
DanHam
21117e5d38
Test we fail if displayName is not stored in the statebag as 'display_name' 2018-07-06 10:58:25 +01:00
DanHam
88c43ec98d
Test we fail if the displayName key is not found in the VMX 2018-07-06 10:58:24 +01:00
DanHam
d68d26a6e5
Fix tests: We now need to set displayName key/val pair in the test VMX 2018-07-06 10:58:24 +01:00
DanHam
902cea0f30
ESXi: Fix failure to export VM when displayName differs from vm_name
ovftool requires we pass in `displayName` as part of the source locator
string so that it can successfully determine the VM intended for export.
2018-07-06 10:58:17 +01:00
DanHam
cd7d3812ea
ESXi: Fix failure to get VM IP when displayName differs from vm_name
The value in the Name field returned by 'esxcli network vm list'
actually returns the VMs `displayName`. As such, we need to match
against `displayName` to discover the VMs 'WorldID'.
'WorldId' is ultimately used/needed as an argument in the command that
returns the VMs IP.
2018-07-06 10:58:09 +01:00
DanHam
3eab3cc99b
ESXi builds require we store the value of displayName in the statebag
The value of displayName is needed by later steps:
* When determining the IP address of the build VM
* When exporting the VM using ovftool

By default Packer will configure the VMX so `displayName` is equal to
the value defined for `vm_name` in the build template. However, it is
possible (and sometimes desirable) to set a custom value for
`displayName`.
Users can set a custom `displayName` through use of the `vmx_data`
option in their template.
2018-07-06 01:58:09 +01:00
Edouard Bonlieu
4b1f96b527
Merge pull request #6439 from jbonachera/scaleway-config-bootscript
scaleway: add 'bootscript' configuration parameter
2018-07-04 10:10:19 +02:00
M. Marsh
8658eaf1ac
Merge pull request #6424 from DanHam/fix-esxi-export-hang
Prevent hang on export when using VMware ISO builder on remote ESXi host
2018-07-02 16:42:08 -07:00
DanHam
939aa7e289
Add test: We shouldn't error when main remote options are unset 2018-07-02 18:13:19 +01:00
DanHam
efcdf60d96
Add tests to ensure remote_password is set when exporting with ovftool 2018-07-02 18:13:19 +01:00
DanHam
0d9134bdbc
Fix existing tests as they were not doing what they should have been
* Fix test to check for remote_host when remote_type is set
* Fix tests by including remote_password where required
2018-07-02 18:12:41 +01:00
DanHam
eee16262b6
Remove duplicate/redundant test 2018-07-02 18:10:50 +01:00
DanHam
c8199458a7
Prevent hang on export for remote ESXi build due to empty remote_password 2018-07-02 18:10:50 +01:00
M. Marsh
406f4eeb93
Merge pull request #6394 from conradjones/master
Add support to vmware-vmx for linked clones
2018-07-02 09:50:24 -07:00
Robert Neumayer
22e5523faa Allow instance metadata to be specified in config 2018-07-02 10:48:08 +02:00
DanHam
fff72780e1
Further simplify enumeration of attached disks for VMware VMX builder
* Collate separate regexp's into one for greater efficiency
* Inline function and remove unnecessary struct and variables
2018-07-01 16:18:33 +01:00
Conrad Jones
d9b6924986 Add cloneType to fusion driver 2018-06-30 16:31:42 +01:00
Julien BONACHERA
eda85a4daf
scaleway: add 'bootscript' configuration parameter 2018-06-29 19:44:56 +02:00
Megan Marsh
2b2c860df8 make the convert retryable in case it takes a bit to release a lock 2018-06-28 14:21:28 -07:00
M. Marsh
c67d59515c
Merge pull request #6370 from arizvisa/patch-1
Allow StepAttachIso in the VirtualBox builder to resolve symbolic links when processing the IsoPath.
2018-06-27 10:30:30 -07:00
Owain Lewis
b600be009d Pass context into OCI client 2018-06-26 10:17:02 +01:00
M. Marsh
5a6a389e66
Merge pull request #6415 from brumfb/skip_invalid_lease_files
Fixes VMWare Builder issue regarding DHCP-less NAT networks.
2018-06-25 16:47:04 -07:00
M. Marsh
78c0b7bd9c
Merge pull request #6408 from harveylowndes/oci-support-custom-instance-display-name
Support instance display name configuration for OCI
2018-06-25 13:17:12 -07:00
Bob Brumfield
04ff0761e6 Notify that we are skipping file, but retain error message 2018-06-25 08:28:32 -07:00
Harvey Lowndes
a69e2ac78e Support instance display name configuration 2018-06-25 11:45:59 +01:00
willmao
7bab499b73 fix vpc clean up issue 2018-06-25 09:16:06 +08:00
willmao
f511c706c9 fix alicloud builder eip allocating issue 2018-06-23 16:34:45 +08:00
Bob Brumfield
591bfe3dfa Continue searching for leases even if one of the files cannot be read. 2018-06-22 18:09:27 -07:00
Alexander Georgievskiy
ec8747a042 They finally added https on download.virtualbox.org
Because downloading SHA256SUMS via http is a fun joke
2018-06-22 00:45:20 +03:00
Conrad Jones
abfb9f24d6 revert accidental debugging change 2018-06-17 01:45:26 +01:00
Conrad Jones
d05a601d00 Add support to vmware-vmx builder for linked clones. 2018-06-17 01:38:42 +01:00
M. Marsh
58e4176a73
Merge pull request #6385 from enricou/wip/add-northeast-3
Add ap-northeast-3 region
2018-06-15 10:46:36 -07:00
EC2 Default User
58f73aabbf Add ap-northeast-3 region 2018-06-15 07:15:41 +00:00
Pavel Vasilevich
4e2b1756f9 Fix misprints in steps names 2018-06-15 12:12:40 +07:00
Ali Rizvi-Santiago
47a3315fde
Added a missing reference to the "path/filepath" module.
Lol. Dammit.
2018-06-11 18:07:43 -05:00
Ali Rizvi-Santiago
963932699e
Remove a stray tab that resulted from poor usage of Github's file editor.
That's what I get for not making a proper branch...
2018-06-11 18:02:52 -05:00
Ali Rizvi-Santiago
9b30c9aed0
Allow StepAttachIso in the VirtualBox builder to resolve symbolic links when processing the IsoPath.
This just closes out a really old issue (#3437) by using `filepath.EvalSymLinks` to resolve the symbolic link that the user specifies for the IsoPath.
2018-06-11 17:53:54 -05:00
M. Marsh
2b60934420
Merge pull request #6363 from hashicorp/fix_6358
sh -c to execute command to accomodate communicator change
2018-06-11 10:25:25 -07:00
M. Marsh
5d35c71358
Merge pull request #6362 from rickard-von-essen/os-token
openstack: Add support for token authorization and cloud.yaml
2018-06-08 16:26:34 -07:00
Megan Marsh
87a93e84ac sh -c to execute command to accomodate communicator change 2018-06-08 13:14:55 -07:00
Matthew Hooker
3bdf1f1849 openstack: Add support for token authorization and cloud.yaml
via config options `cloud` and `token` and environment variables
OS_CLOUD and OS_TOKEN.
2018-06-08 21:38:26 +02:00
M. Marsh
10549d34b6
Merge pull request #6322 from sieben/remove_vc
Remove the VC product line
2018-06-08 09:55:24 -07:00
M. Marsh
c586312bf7
Merge pull request #4538 from hashicorp/defaultovf
builder/vmware: correctly default export format to ovf
2018-06-07 11:36:48 -07:00
Hariharan Jayaraman
b23d6c9589 fixing infinite loop issue deleting existing resources if we have a empty target resource 2018-06-06 15:25:19 -07:00
Rickard von Essen
c0ae1b7790
digitalocean: artifact should include build region and fixed docs
- Add the build region to the list of regions for the artefact
- Corrected docs: `snapshot_name` doesn't have to be unique.
- Updated example to use Ubuntu 16.04
2018-06-03 16:37:38 +02:00
deepuashokan85
10f118b14c
Update driver_gce.go
Added "rhel-sap-cloud" Projects_ID.
2018-05-31 11:29:57 +05:30
M. Marsh
31c7374869
Merge pull request #6303 from hashicorp/do_5871
add get windows default credentials to oci builder
2018-05-29 16:12:15 -07:00
Rémy Léone
dba9f1b015 Remove the VC product line 2018-05-28 16:19:51 +02:00
James Nugent
b97475b647
Merge pull request #6265 from DanHam/enable-t2-unlimited
Add support for T2 Unlimited for Amazon builders
2018-05-25 00:26:17 +04:00
DanHam
af7f7f2ce9
Fix redundant Sprintf 2018-05-24 21:05:03 +01:00
Megan Marsh
08218222dc add get windows default credentials to oci builder 2018-05-24 10:47:37 -07:00
M. Marsh
62e1323577
Merge pull request #5956 from hashicorp/dedupe_shell_local
Deduplicate the code for the shell-local post-processor and shell-local provisioner
2018-05-23 15:54:27 -07:00
Megan Marsh
e670eed315 Add new option, nvme_device_path, so that we can properly mount nvme block devices. 2018-05-23 09:16:40 -07:00
Paul Meyer
3dd6bf5781
Merge pull request #6285 from harijayms/devicelogin
Devicelogin Support for Windows and not requiring object ID
2018-05-22 11:26:47 -07:00
Hariharan Jayaraman
a13a2511f9 Added additional error message if we failed to parse token 2018-05-21 22:20:36 -07:00
Hariharan Jayaraman
1bd7aa534e Addressed PR feedback 2018-05-21 21:38:41 -07:00
M. Marsh
a8b6a04dda
Merge pull request #6194 from hashicorp/fix_6176
allow user to mount entire block device in chroot builder
2018-05-21 15:28:18 -07:00
Hariharan Jayaraman
8a3e599cad Added text to point out two device auth 2018-05-21 11:05:59 -07:00
Hariharan Jayaraman
da67df6d03 space fix 2018-05-18 21:17:19 -07:00
Hariharan Jayaraman
4992429e8c Minor comment fixes 2018-05-18 17:34:01 -07:00
Hariharan Jayaraman
00e809cb7e Refactored the change into a new function 2018-05-18 15:21:49 -07:00
Hariharan Jayaraman
ea9b2a8b5f review feedback 2018-05-18 12:09:42 -07:00
M. Marsh
edb5c1f50d
Merge pull request #6243 from camjjack/hyper-v-gui
Using vmconnect to display gui for hyper-v
2018-05-18 11:24:24 -07:00
M. Marsh
cbbbf551e3
Merge pull request #6274 from DanHam/fix-compaction-esx
Revert commits that enabled reporting of disk compaction results for VMware builders
2018-05-18 09:20:21 -07:00
Hariharan Jayaraman
667113338a missed formating 2018-05-18 01:41:00 -07:00
Hariharan Jayaraman
7f2277676a Ensure that Device Login tests dont block general acceptance tests 2018-05-18 01:34:12 -07:00
Hariharan Jayaraman
77fe1bffe4 Ensure that Device Login tests dont block general acceptance tests 2018-05-18 01:25:19 -07:00
Hariharan Jayaraman
de1783240f Updates to remove space changes 2018-05-18 00:53:44 -07:00
Hariharan Jayaraman
91eed4da52 trim right of the keyvault url 2018-05-18 00:44:25 -07:00
Hariharan Jayaraman
df5cc234fc updates 2018-05-18 00:39:57 -07:00
Hariharan Jayaraman
1f46271a6b Ensuring device login works for Windows build 2018-05-18 00:32:01 -07:00
Christopher Boumenot
a5530d4546
Merge pull request #6269 from harijayms/asyncrgdelete
Async delete Resource Group
2018-05-16 15:13:09 -07:00
Chris Lundquist
c925a02f82 don't chown to close the security issue 2018-05-16 21:40:22 +00:00
Matt Coleman
3192f5e0da qemu builder: add the 'use_backing_file' setting for QCOW2 images 2018-05-16 10:22:50 -04:00
DanHam
73eb9a629e
Revert "Fix test - reporting compaction results requires a tmp file"
This reverts commit f342975ff3.
2018-05-16 13:52:00 +01:00
DanHam
2939cd75ae
Revert "Report the result of the disk compaction step"
Unfortunately this broke the ability to build on remote (ESXi) hosts.

This reverts commit 08f9d619a9.
2018-05-16 12:55:59 +01:00
Hariharan Jayaraman
e1b18d594a Updates based on PR feedback 2018-05-15 11:41:26 -07:00
DanHam
ec8b70721c
Use an explicit error message when an error is expected and we don't get one
Previously, if the validation check generating the error in the main code
is removed, the 'should error' tests would just return an empty message
2018-05-15 12:25:06 +01:00
DanHam
82c8710af5
Use fmt.Errorf over errors.New as we only require basic error reporting 2018-05-15 12:25:06 +01:00
DanHam
99e3487795
Add missing validation and tests for Spot Instance requests 2018-05-15 12:25:06 +01:00
DanHam
d5304a25e9
Pass T2 Unlimited settings to run instance step for appropriate EC2 builders 2018-05-15 12:25:06 +01:00
DanHam
6fc68754d7
Allow use of T2 unlimited by adding appropriate request for the instance 2018-05-15 12:25:06 +01:00
DanHam
df7fb86984
Add tests for T2 Unlimited configuration 2018-05-15 12:25:06 +01:00
DanHam
be02b3f613
Validate template settings when T2 Unlimited has been enabled
* T2 Unlimited cannot be used with anything other than T2 instance types
* T2 Unlimited cannot be used with Spot Instances
2018-05-15 12:25:06 +01:00
DanHam
482629ae90
Add config option to enable/disable T2 Unlimited for the launched instance 2018-05-15 12:25:06 +01:00
DanHam
2c339b99d2
Sort run config options alphabetically 2018-05-15 12:25:06 +01:00
Hariharan Jayaraman
c8c9bbb22a Async delete Resource Group 2018-05-14 20:06:23 -07:00
Unknown
5710c0aca1 Making log output clearer for hyper-v gui connection 2018-05-14 20:53:51 +10:00
Unknown
29c4b4436d Changes requested in PR #6243
- Logging error if vmconnect.exe fails.
- Using StepRun struct rather than StateBag for command Cancel function
- Better handling in Disconnect when headless is true or vmconnect failed in Start
2018-05-14 20:52:10 +10:00
Unknown
fc734b6bd9 Using vmconnect to display gui for hyper-v
vmconnect.exe comes as part of Hyper-V and is the tool used by Hyper-V Manager to connect with a virtual machine. This commits sets behaviour the same as virtualbox and vmware to display the virtual machine connection unless headless is set in the template.
2018-05-14 20:52:10 +10:00
Christopher Boumenot
132dfa7c86
Merge pull request #6262 from harijayms/warningforVHDcreation
Added warning for VHD creation and updated samples
2018-05-11 11:40:42 -07:00
M. Marsh
5871b8242b
Merge pull request #6101 from adarobin/azurecompatible
Add use_fixed_vhd_format Hyper-V ISO option
2018-05-10 17:02:44 -07:00
Hariharan Jayaraman
13c0b0b370 Added warning for VHD creation and updated samples 2018-05-10 13:15:35 -07:00
Stefan Henseler
6f00596053 Adds config option to specify hyper-v secure boot template 2018-05-10 19:00:35 +02:00
M. Marsh
84a7d2436f
Merge pull request #6229 from DanHam/use-re-for-vmxadapter
Use regex based approach to detect attached disks
2018-05-08 15:12:25 -07:00
DanHam
a866232ac9
Use regex based approach to detect attached disks 2018-05-08 12:52:39 +01:00
Megan Marsh
6dc4b1cbdc move all of the run commands for shell-local provisioner and postprocessor into common library too 2018-05-07 15:10:09 -07:00
Megan Marsh
616b41e58f deduplicate the nearly identical communicators for the shell-local provisioner and post-processor, moving single communicator into a new common/shell-local module 2018-05-07 15:10:09 -07:00
Christopher Boumenot
80a096cadd azure: device login for US Gov 2018-05-06 20:59:38 -07:00
Paul Meyer
8aee53ebe9
Merge pull request #6224 from paulmey/update-azure-sdk
Update Azure SDK
2018-05-04 09:47:28 -07:00
Rickard von Essen
4be5f072c7
Merge pull request #6238 from DanHam/fix-scaleway-auto-ssh-key
Fix use of automatically generated ssh key for Scaleway
2018-05-04 13:35:03 +02:00
Paul Meyer
169f9d22e6 Update 'the other place' too 2018-05-04 00:32:15 +00:00
Paul Meyer
80f57308d7 Process review feedback 2018-05-04 00:28:34 +00:00
Christopher Boumenot
420a5842b9
Merge pull request #6231 from cantorek/f-randomize-osdiskname
Randomize osDisk name for Azure Managed Image builds.
2018-05-03 14:55:42 -07:00
Matthew Hooker
0521efa200
correctly log reason waiting for ami failed. 2018-05-03 12:27:09 -07:00
Matthew Hooker
7d5ebd5500
Merge pull request #6217 from alessiot77/5887
Feature Request: Log reason why AMI creation failed
2018-05-03 10:57:46 -07:00
DanHam
c47e5d19f0
Fix use of auto generated ssh key for scaleway builder 2018-05-03 11:33:28 +01:00
DanHam
585b93cfd6
Follow variable privateKey <-> statebag private_key convention 2018-05-03 00:33:12 +01:00
Oskar Wycislak
78d68880c0 Randomize osDisk name for Azure Managed Image builds.
This fixes #6115
2018-05-02 22:42:08 +02:00
Paul Meyer
07d8c71a2d Create and use context for Builder.Run 2018-05-01 23:40:40 +00:00
M. Marsh
e90c87f885
Merge pull request #6210 from hashicorp/add_windows_sql_cloud_to_defaults
add windows-sql-cloud to the list of projects to check for an image name
2018-05-01 12:57:10 -07:00
Paul Meyer
cf94086b5f Formatting fixes 2018-05-01 19:53:20 +00:00
Matthew Hooker
6260151034
Merge pull request #6226 from hashicorp/fix6225
builder/qemu: properly prepare boot command.
2018-05-01 12:41:11 -07:00
Matthew Hooker
4f1395e0f6
builder/qemu: properly prepare boot command. 2018-05-01 12:40:00 -07:00
Paul Meyer
c13965c0ce Add acceptance tests 2018-05-01 15:39:50 +00:00
Paul Meyer
a3fb24639a make tests pass again 2018-05-01 15:39:50 +00:00
Paul Meyer
09ce3c9803 Make it compile again 2018-05-01 15:39:50 +00:00
AlessioT
3d4c7d0df1 Feature Request: Log reason why AMI creation failed 2018-04-30 20:59:13 +01:00
DanHam
25dd27a164
Remove tmp directories created by builder/vmware/common tests 2018-04-30 20:38:03 +01:00
DanHam
13b7078cb0
Remove tmp directories created by builder/virtualbox/common tests 2018-04-30 20:38:03 +01:00
DanHam
475b3978d2
Remove tmp directories created by builder/parallels/common tests 2018-04-30 20:38:03 +01:00
DanHam
5642f8cb01
Remove tmp files created by builder/googlecompute tests 2018-04-30 20:38:03 +01:00
DanHam
9b6fc5a58d
Remove tmp files created by builder/amazon/instance tests 2018-04-30 18:16:46 +01:00
DanHam
54e9690dff
Remove tmp files created by builder/amazon/common tests 2018-04-30 18:16:46 +01:00
DanHam
96adb4a9d1
Remove tmp files created by builder/alicloud/ecs tests 2018-04-30 18:16:46 +01:00
AlessioT
373226e9c5 Extract state reason for failure 2018-04-28 12:40:48 +01:00
AlessioT
09bb21774d alessio.tomasino@yahoo.co.uk 2018-04-28 11:02:53 +01:00
AlessioT
c27f3e9445 alessio.tomasino@yahoo.co.uk 2018-04-28 11:00:33 +01:00
DanHam
c828015bc3
Follow variable varName <-> statebag var_name convention 2018-04-27 20:09:19 +01:00
M. Marsh
df5c67090e
Merge pull request #6193 from adarobin/hvf
add support for hvf accelerator to qemu builder
2018-04-27 11:41:01 -07:00
Megan Marsh
ed6d999b1f add windows-sql-cloud to the list of projects to check for an image name 2018-04-27 11:24:08 -07:00
DanHam
f342975ff3
Fix test - reporting compaction results requires a tmp file 2018-04-27 16:40:44 +01:00
DanHam
08f9d619a9
Report the result of the disk compaction step 2018-04-27 16:40:29 +01:00
DanHam
10d93dffa4
Fix tests for vmware/common 2018-04-27 16:40:23 +01:00
DanHam
a729ecda87
Fix tests for vmware/vmx builder 2018-04-27 16:40:13 +01:00
DanHam
c48a7889f9
Simplify handling of disks by collating requirements and unifying ops 2018-04-27 16:39:52 +01:00
Adam Robinson
29b89e63b8 add support for hvf accelerator to qemu builder 2018-04-27 10:11:20 -04:00
M. Marsh
879319a76c
Merge pull request #6202 from rickard-von-essen/fix-6184
builder/parallels-pvm: Add missing compaction of disks
2018-04-26 15:44:12 -07:00
Matthew Hooker
67a9c7fb92
we never expect remote cache to be a directory. 2018-04-26 12:40:40 -07:00
Matthew Hooker
de1dac1bdf
don't delete the cache directory. 2018-04-26 12:40:40 -07:00
Matthew Hooker
97cfd60b82
Remove remote cache correctly. 2018-04-26 12:40:35 -07:00
Ali Rizvi-Santiago
673d4579e4 Ack! Forgot to include the template variable in the definition for vmxTemplateData for commit 0e519d79e0. Now it's added.. 2018-04-26 14:22:37 -05:00
Ali Rizvi-Santiago
0e519d79e0 Modified iso/step_create_vmx.go in the vmware-iso builder to also specify the "bios.hddOrder" field depending on the hdd device that was specified. This might close issue #6197 2018-04-26 14:16:50 -05:00
Ali Rizvi-Santiago
5d8b476a7f Fixed the regex in common/step_clean_vmx.go for the VMware builder to also support removal of sata-based cdrom devices. Also added a comment in iso/step_create_vmx.go that links both pieces of related code. 2018-04-26 14:01:58 -05:00
Matthew Hooker
451e3d0554
builder/vmware-esxi: remove floppy files when done 2018-04-26 10:47:33 -07:00
Adam Robinson
3aebd5f462 Add use_fixed_vhd_format Hyper-V ISO option 2018-04-26 13:35:19 -04:00
Rickard von Essen
77d0ba492d
parallels-pvm: Add missing compaction of disks 2018-04-26 14:09:17 +02:00
Megan Marsh
59e3ec722d allow user to mount entire block device in chroot builder 2018-04-25 10:47:52 -07:00
Matthew Donoughe
ef03e97dc3 pass MacAddress to StepCreateVM 2018-04-24 20:39:42 -04:00
M. Marsh
148f7d39e4
Merge pull request #6142 from harveylowndes/use-official-go-sdk
builder/oracle: Use official OCI Go SDK
2018-04-24 16:34:38 -07:00
Richard Nienaber
db65c99bf4 update code based on master and update docs 2018-04-24 10:35:27 +01:00
Richard Nienaber
e2e7953fe4 Merge branch 'master' into allow_gcp_winrm_password 2018-04-24 10:25:27 +01:00
Matthew Hooker
cbdf9db832
Use contexts with amazon waiters. 2018-04-23 12:57:15 -07:00
Matthew Hooker
6bbfe7e0bd
remove useless check against format 2018-04-23 10:24:49 -07:00
Matthew Hooker
fdeadfe3f6
builder/vmware: correctly default export format to ovf 2018-04-23 10:17:53 -07:00
Matthew Hooker
0e80d98805
Merge pull request #6166 from hashicorp/parallelsfixes
forcefully stop parallels vm.
2018-04-23 10:08:35 -07:00
M. Marsh
69c7e2d51d
Merge pull request #6144 from hashicorp/winrm_password_fix
use build name to ensure that winrm password and other shared state i…
2018-04-23 09:12:52 -07:00
M. Marsh
e455e7b054
Merge pull request #6074 from DanHam/fix-vmx-compacting-error
Fix error with VMware vmx builder at compacting stage
2018-04-23 09:03:36 -07:00
Rickard von Essen
a2a593759e
Merge pull request #6041 from Xeite/f-add-instance-name
builder/openstack: Add instance_name config to OpenStack builder
2018-04-23 08:47:50 +02:00
DanHam
bd9e585cb9
Add test for enumeration of vmx network type 2018-04-21 22:49:36 +01:00
DanHam
94d5a7f2e2
Fix copy/paste error referencing Virtualbox 2018-04-21 22:49:36 +01:00
DanHam
1aee759f06
Fix tests and reconfigure for support of multi-disk vm 2018-04-21 22:49:36 +01:00
DanHam
6c9d4efd9f
Fix error on compaction step of vmx build. Support compacting multi-disk vm 2018-04-21 22:49:36 +01:00
M. Marsh
bcbee45bf9
Merge pull request #6039 from stack72/triton-insecure-skip-tls-verify
builder/triton: Add support to Skip TLS Verification of Triton Certificate
2018-04-20 13:44:28 -07:00
Matthew Hooker
024fac4b4f
Merge pull request #6129 from hashicorp/bc_replace
Replace boot command parser with PEG parser.
2018-04-20 12:21:20 -07:00
Evgeni Golov
5a10e5a038
fix invalid disc_discard setting error message 2018-04-20 13:17:40 +02:00
Matthew Hooker
11de2b9759
remove unnecessary log line. 2018-04-19 16:13:24 -07:00
Matthew Hooker
c920e0a20b
forcefully stop parallels vm.
also only output parallels version once.
2018-04-19 16:11:29 -07:00
Matthew Hooker
1d36ef038c
implement boot config struct for hyperv 2018-04-19 14:26:31 -07:00
Matthew Hooker
a0c9ddb9ae
implement boot config struct for virtualbox 2018-04-19 14:26:31 -07:00
Matthew Hooker
c8e76ce298
implement config struct for qemu 2018-04-19 14:26:31 -07:00
Matthew Hooker
c6299972b9
s/boot_command/bootcommand/ 2018-04-19 14:26:31 -07:00
Matthew Hooker
7990966a09
fix boot command config struct name 2018-04-19 14:26:31 -07:00
Matthew Hooker
e662927623
Implement boot config struct for parallels 2018-04-19 14:26:30 -07:00
Matthew Hooker
408eba88ad
flatten boot command config and implement for vmware 2018-04-19 14:26:30 -07:00
Matthew Hooker
94129b7fe3
we're using PC-XT (set1) not PC-AT 2018-04-19 14:26:30 -07:00
Matthew Hooker
a46a7afa20
Remove old tests. 2018-04-19 14:26:29 -07:00
Matthew Hooker
cba4d3235f
cleanup 2018-04-19 14:26:29 -07:00
Matthew Hooker
bf0a320125
Implement new parser for qemu boot command 2018-04-19 14:26:29 -07:00
Matthew Hooker
bdb1eee7d8
Implement new parser for HyperV boot command 2018-04-19 14:26:29 -07:00
Matthew Hooker
81d127768c
Add key press interval to virtualbox. 2018-04-19 14:26:29 -07:00
Matthew Hooker
59376294ef
Maximize scancode throughput.
Let's cache the scancodes and flush them at the end. Also make sure to
send only as many as the driver can send correctly. It's important here
to chunk the scancodes correctly, so that we don't accidentally split them
over successive calls to the driver
2018-04-19 14:26:29 -07:00
Matthew Hooker
9b7704c714
Implement new parser for Parallels boot command 2018-04-19 14:26:29 -07:00
Matthew Hooker
99d61920d0
Abstract vbox driver into PC-AT driver. 2018-04-19 14:26:29 -07:00
Matthew Hooker
e4af71858f
Implement new parser for Virtualbox boot command
Remove boot wait for virtualbox run step
2018-04-19 14:26:29 -07:00
Matthew Hooker
1c0af28662
Some cleanup and comments. 2018-04-19 14:26:29 -07:00
Matthew Hooker
4e2f14196a
Rely on context to cancel typing boot command. 2018-04-19 14:26:28 -07:00
Matthew Hooker
673245afcf
Replace boot command parser with PEG parser. 2018-04-19 14:26:28 -07:00
M. Marsh
f5c031baf9
Merge pull request #5941 from synax/hyper-v-disk-block-size
Adds Support to configure hyper-v disk block size
2018-04-19 11:27:52 -07:00
Harvey Lowndes
c442ba165e Migrate to official OCI Go SDK 2018-04-17 10:30:42 +01:00
Megan Marsh
3afb243f11 use build name to ensure that winrm password and other shared state is not overwritten if two builders need the password in the same packer run. 2018-04-16 13:41:17 -07:00
Richard Nienaber
ec6f8264bf fix winrm password access in google compute 2018-04-16 10:56:26 +01:00
Megan Marsh
ee1ff3132d remove attempt to discover whether destination is a directory from upload function in various communicators 2018-04-10 08:13:06 -07:00
M. Marsh
83162717ed
Merge pull request #4563 from marema31/vmware-iso-warn-esx
builder/vmware-iso: Fail on wrong remote_type value
2018-04-06 16:52:26 -07:00
Matthew Hooker
f094b3be85
update changelog 2018-04-05 16:32:03 -07:00
Matthew Hooker
cb90e8b375
Merge pull request #6111 from hashicorp/replace4448
Restrict deregistered AMIs to those owned by self.
2018-04-05 16:30:37 -07:00
Matthew Hooker
d70451f82e
Merge pull request #6106 from sethvargo/sethvargo/useragent
Add a common package for specifying useragent and adopt that everywhere
2018-04-05 15:38:11 -07:00
Megan Marsh
d236f26439 allow users to access winrm password in powershell and elevated powershell provisioners 2018-04-05 15:24:54 -07:00
Matthew Hooker
302b1988a5
Restrict deregistered AMIs to those owned by self. 2018-04-05 13:29:36 -07:00
Seth Vargo
5eeac07b63
Include existing azure user agent 2018-04-05 14:28:51 -04:00
Seth Vargo
b17b333e29
Add a common package for specifying useragent and adopt that everywhere
There were 5 different formats for the Packer useragent string. This
fixes that and unifies it into a helper package.

I did not touch oracle's user-agent, because it looked kinda special.
2018-04-05 14:28:50 -04:00
Megan Marsh
f2df7a45ba
Merge pull request #6096 from arizvisa/GH-5882
Fixes the DHCP lease and configuration pathfinders for VMware Player.
2018-04-02 16:57:20 -07:00
Megan Marsh
67d2de8de1
Merge pull request #6079 from hashicorp/do_5866
add user data and user data file to oracle oci builder
2018-04-02 16:48:48 -07:00
Megan Marsh
d6e5b01a23
Merge pull request #6095 from hashicorp/OPaniC
prevent panics when cleaning up resources that haven't been created.
2018-04-02 16:34:34 -07:00
Megan Marsh
22608f3efd
Merge pull request #6088 from adongy/master
Expose more source ami data in the template
2018-04-02 16:32:16 -07:00
Matthew Hooker
7e13b5c62a
prevent panics when cleaning up resources that haven't been created. 2018-04-02 11:56:11 -07:00
Matthew Hooker
52f69cd91a
Validate image name. 2018-04-02 11:22:15 -07:00
Ali Rizvi-Santiago
2c2904c095 Modified the path finders for the Player driver in the vmware-builders to search through all the possible variations for dhcp configuration and leases.. 2018-03-30 18:19:25 -05:00
Ali Rizvi-Santiago
7e9699675f Modified device matching logs to look more consistent. 2018-03-30 18:15:46 -05:00
Matthew Hooker
0533e1ad9c
Validate destination image name. 2018-03-30 13:01:52 -07:00
ADO
04790695e6 Add interpolate_build_info_test tests 2018-03-30 16:46:35 +02:00
ADO
507b3619e7 Expose more source ami data in the template 2018-03-30 10:47:11 +02:00
Ali Rizvi-Santiago
6e176f97a0 Added logs to all of the VMware drivers that emits each detected network device that gets enumerated for a network. 2018-03-29 13:12:59 -05:00
Ali Rizvi-Santiago
646523c5f4 Replaced the call to os.Open and ReadNetworkMap to just a single call to ReadNetmapConfig in both the Workstation9 and Player5 VMware drivers. 2018-03-29 13:04:25 -05:00
Matthew Hooker
f2fc064037
Merge pull request #6056 from rjosephwright/snapshots
Modify ebssurrogate builder to snapshot all launch devices
2018-03-29 10:15:19 -07:00
Matthew Hooker
541d33a80f
Merge pull request #6067 from mcandre/virtualbox-fixes
VirtualBox fixes
2018-03-29 10:13:49 -07:00
Omer Katz
56af885212
Avoid warning when using raw format.
When using the raw image format and attempting to resize it we get the following error message:
```
WARNING: Image format was not specified for 'test.raw' and probing guessed raw.
         Automatically detecting the format is dangerous for raw images, write operations on block 0 will be restricted.
         Specify the 'raw' format explicitly to remove the restrictions.
```
Specifying the format will remove this warning.
2018-03-29 14:51:02 +03:00
Megan Marsh
7623c26e4e
Merge pull request #6057 from arizvisa/GH-5925
Fixed a case-sensitivity issue when determing the network type during the cloning step in the vmware-vmx builder
2018-03-28 13:54:09 -07:00
Megan Marsh
16d044b398 add user data and user data file to oracle oci builder 2018-03-28 13:27:41 -07:00
Megan Marsh
58ecd32289 remove redundant security_protocol code from the winrm implementation of the oracle-classic provisioner 2018-03-28 10:54:06 -07:00
Andrew Pennebaker
fdc6ac631a fix vbox scancodes and support critical key combinations during boot-time operations 2018-03-26 18:35:45 -05:00
Ali Rizvi-Santiago
55702a697a Ack, forgot to :w in vim. Changed ui.Say in step_clone_vmx.go to use fmt.Sprintf as it originally was a call to log.Printf. 2018-03-25 19:03:46 -05:00
Joseph Wright
1913517d29 Fix formatting by running make fmt 2018-03-25 19:51:49 -04:00
Ali Rizvi-Santiago
72da7cbfbb Fixed a case-sensitivity issue when determing the network type during cloning in the vmware-vmx builder and added also some logs that output the different options that were determined from the .vmx. This outputs more accurate debug information and helps out with issue #5925 2018-03-25 18:51:37 -05:00
Joseph Wright
cb3699a584 Modify ebssurrogate builder to snapshot all launch devices
Documentation for ebssurrogate states that all of the devices in
`launch_block_device_mappings` are snapshotted and included in the
image. In fact, only the device that was designated as the root
device was snapshotted. This patch modifies the builder to create
snapshots of all the devices and include them in the image. This
allows creating images with separate filesystems preconfigured,
rather than having to add volumes to `ami_block_device_mappings`
and configure them after boot.
2018-03-25 19:37:44 -04:00
Megan Marsh
7253d6547b minor LXD documentation tweaks 2018-03-23 15:46:39 -07:00
Megan Marsh
088b4ab275
Merge pull request #6038 from ChrisLundquist/clundquist/more-lxd-config
[WIP] LXD fixes and feature requests
2018-03-23 15:38:28 -07:00
Megan Marsh
072cd6b745
Merge pull request #5998 from hashicorp/do_5895
allow users of AWS to use the dynamically-generated admin password wh…
2018-03-22 16:01:22 -07:00
Megan Marsh
95aa7e67bd
Merge pull request #5893 from neumayer/privateip
Allow using private ip addresses for oracle oci builder
2018-03-22 09:42:19 -07:00
Robert Neumayer
61432cd257 Update logs to talk about IP instead of public IP
When logging we don't know whether we use a private or public ip, just
the ip itself.
2018-03-22 09:08:25 +01:00
Yang Youseok
1f4212efa7 builder/openstack: Add instance_name config to OpenStack builder
RFC952 restricts hostname not to use underline(_) and period(.), so
private cloud with legacy DNS system does not allow just to use
image_name for name of server.

Add instance_name config option for servers which packer creates to
make instance_name configurable. If instance_name is not specified,
by default it works like the past using image_name for instance_name.
2018-03-22 11:20:14 +09:00
Megan Marsh
ef4f3f143b
Merge pull request #5985 from AndiDog/f-5979-vmware-fusion-guestip-lookup-multiple-devices
Handle multiple devices per VMware network type
2018-03-21 17:12:36 -07:00
Christopher Boumenot
eb201724c1 azure: unit tests for naming temp resources 2018-03-20 16:20:11 -07:00
stack72
c877312a4d builder/triton: Add support to Skip TLS Verification of Triton URL
In order to allow Packer to connect to Private Triton installations
we now expose `insecure_skip_tls_verify` which, if set to true, will
allow the user to make requests to Triton installations that use a
certificate not signed by a trusted root CA
2018-03-20 22:10:12 +02:00
Chris Lundquist
4f5e7fe060 first pass at allowing configurable sleep timeouts, profiles, and launch configs 2018-03-20 19:30:46 +00:00
Matthew Hooker
aa54f908ed
Merge pull request #6019 from hashicorp/fix-aws-credentials
Fix aws credentials
2018-03-19 10:13:09 -07:00
Matthew Hooker
49958391b3
better error when source_path doesn't exist. 2018-03-19 09:58:39 -07:00
Matthew Hooker
b16f2ec64b
builder/amazon: Use sdk default cred providers
I think we were overcomplicating things. The SDK provides the correct
credential chain by default, so let's use that. This patch does a quick
check for static credentials and uses those if found, then defaults to
the default credential provider chain.

This patch also removes the metadata timeout argument. Current versions
of the SDK have short timeouts by default, so I don't believe this is
needed.
2018-03-15 16:49:47 -07:00
Matthew Hooker
e483087574
builder/amazon: Use service default retries.
Each service has its own preconfigured number of times to retry.
Lets use that instead of setting a global number.
2018-03-14 22:26:35 -07:00
Megan Marsh
d689e6b4d3 allow users of AWS to use the dynamically-generated admin password which we use as the winRM password as an elevated password in the Powershell provisioner, as well as an environment variable in same provisoner. 2018-03-14 15:58:12 -07:00
Megan Marsh
414dd80e61
Merge pull request #6013 from jsoref/spelling
Spelling
2018-03-14 09:50:27 -07:00
Josh Soref
27dfe92f1c spelling: virtualization 2018-03-14 03:29:14 +00:00
Josh Soref
0171dfc890 spelling: validating 2018-03-14 03:28:19 +00:00
Josh Soref
b81672c906 spelling: valid 2018-03-14 03:28:00 +00:00
Josh Soref
33f90d7783 spelling: unmarshalling 2018-03-14 03:27:22 +00:00
Josh Soref
3b694feabc spelling: transfer 2018-03-14 03:25:35 +00:00
Josh Soref
5a393d4fac spelling: template 2018-03-14 03:24:51 +00:00
Josh Soref
c563ef0797 spelling: structure 2018-03-14 03:23:56 +00:00
Josh Soref
007930ec2d spelling: restricted 2018-03-14 03:20:51 +00:00
Josh Soref
aae5b50dab spelling: response 2018-03-14 02:19:26 +00:00
Josh Soref
8294c8bc66 spelling: receive 2018-03-14 02:19:01 +00:00
Josh Soref
fa36e1d961 spelling: processing 2018-03-14 02:17:22 +00:00
Josh Soref
8c72bba160 spelling: possible 2018-03-14 02:14:18 +00:00
Megan Marsh
aeb25d2c61
Merge pull request #5991 from evandbrown/google-disable-default-service-account
builder/googlecompute: Optionally disable service account
2018-03-13 13:39:08 -07:00
Evan Brown
7eda44d28c builder/googlecompute: disambiguate disable_default_service_account
This change requires 'disable_default_service_account=false' in order to
set 'service_account_email'.

This is a guard against an incorrect assumption
that disabling the default service account would mean that no service
account would be used.
2018-03-13 12:39:41 -07:00
Megan Marsh
2de0652eb4
Merge pull request #6003 from boumenot/pr-azure-support-force
azure: respect -force for managed image deletion
2018-03-13 09:47:16 -07:00
Josh Soref
18f51e7338 spelling: parameters 2018-03-13 08:29:17 +00:00
Josh Soref
61030c0d85 spelling: output 2018-03-13 08:27:26 +00:00
Josh Soref
e43b8de3b1 spelling: network 2018-03-13 08:14:30 +00:00
Josh Soref
d987fcefc3 spelling: multiples 2018-03-13 08:12:53 +00:00
Josh Soref
cab8b6ed68 spelling: maximum 2018-03-13 08:10:20 +00:00
Josh Soref
73d3d65b84 spelling: marshal 2018-03-13 08:10:01 +00:00
Josh Soref
964d5dd55e spelling: mapstructure 2018-03-13 08:09:41 +00:00
Josh Soref
ae4abedfa2 spelling: mandatory 2018-03-13 08:10:59 +00:00
Josh Soref
933ac20e68 spelling: instance 2018-03-13 08:04:50 +00:00
Josh Soref
62f59662a3 spelling: installation 2018-03-13 08:04:40 +00:00
Josh Soref
1e99dce12b spelling: inertness 2018-03-13 08:05:14 +00:00
Josh Soref
3a31baae4f spelling: incorrect 2018-03-13 08:00:05 +00:00
Josh Soref
57c0e9e4a7 spelling: illegal 2018-03-13 08:02:43 +00:00
Josh Soref
210f8e8312 spelling: hyphen 2018-03-13 07:59:00 +00:00
Josh Soref
24b4c36fc9 spelling: function 2018-03-13 07:52:02 +00:00
Josh Soref
dc942a0d8a spelling: first 2018-03-13 07:50:00 +00:00
Josh Soref
466f0d2be4 spelling: firewall 2018-03-13 07:49:46 +00:00
Josh Soref
041a115f65 spelling: existent 2018-03-13 08:15:56 +00:00
Josh Soref
33bf6de921 spelling: exceeds 2018-03-13 07:46:49 +00:00
Josh Soref
04d6bfc696 spelling: environment 2018-03-13 07:41:21 +00:00
Josh Soref
9b9ab4c492 spelling: encrypt 2018-03-13 07:41:47 +00:00
Josh Soref
83471c8399 spelling: doesn't 2018-03-13 07:39:58 +00:00
Josh Soref
60ef3c3374 spelling: directories 2018-03-13 07:37:32 +00:00
Josh Soref
939e7d5587 spelling: delete 2018-03-13 07:36:38 +00:00
Josh Soref
efb525f03d spelling: creating 2018-03-13 07:22:37 +00:00
Josh Soref
935c8e9a28 spelling: configuration 2018-03-13 08:19:16 +00:00
Josh Soref
47a4bbd9f5 spelling: compaction 2018-03-13 07:22:09 +00:00
Josh Soref
5010bfda39 spelling: comes 2018-03-13 07:20:55 +00:00
Josh Soref
f362789174 spelling: because 2018-03-13 07:15:08 +00:00
Josh Soref
7895051962 spelling: attribute 2018-03-13 07:12:16 +00:00
Josh Soref
75a7ceec48 spelling: alicloud 2018-03-13 07:09:12 +00:00
Josh Soref
fe98bcc5a1 spelling: address 2018-03-13 07:07:10 +00:00
Megan Marsh
8481663d4a
Merge pull request #6005 from boumenot/pr-azure-randomize-resource-names
azure: support concurrent deployments in the same resource group
2018-03-12 17:00:44 -07:00
Megan Marsh
5055fa66aa
Merge pull request #5987 from mcandre/multibyte-scancodes
send multibyte scancodes accurately to virtualbox
2018-03-12 16:23:41 -07:00
Megan Marsh
2a88672cd9 add test for modifyer keypress commands 2018-03-12 15:08:30 -07:00
Megan Marsh
3207ffbd9a
Merge pull request #6002 from mcandre/fix-6001
fix later commands overwriting earlier commands
2018-03-12 15:07:43 -07:00
Christopher Boumenot
2a21032964 azure: randomize NIC and Public IP names 2018-03-11 20:47:45 -07:00
Christopher Boumenot
149ce52079 azure: respect -force for managed image deletion 2018-03-10 10:43:28 -08:00
Andrew Pennebaker
1d48812b34 fix later commands overwriting earlier commands 2018-03-09 20:17:43 -06:00
Megan Marsh
b1eaaed6fb
Merge pull request #5970 from boumenot/pr-azure-plan-info
azure: support for marketplace plan information
2018-03-09 15:21:03 -08:00
Christopher Boumenot
1ef491d4c8 incorporate reviewer feedback 2018-03-08 22:43:26 -08:00
Evan Brown
4a2c124ea2 builder/googlecompute: Optionally disable service account
The ability to use a service account other than the default was
introduced in #5928. This change adds to that by introducing the
'disable_default_service_account' config option. If true - and
'service_account_email' is not set - Packer will create a GCE VM
with no service account.
2018-03-07 20:53:26 -08:00
Andrew Pennebaker
f305a2f4c2 send multibyte scancodes accurately to virtualbox 2018-03-07 10:59:02 -06:00
Andreas Sommer
ff92fb883d Handle multiple devices per VMware network type
Fixes #5979
2018-03-07 10:59:55 +01:00
Megan Marsh
ac2e02b938 remove loglines that should not have made it onto master 2018-03-06 14:12:39 -08:00
SwampDragons
97060d100c
Merge pull request #5928 from kri5/service_account_gce
Builder GoogleCompute: Allows to specify GCE service account build VM
2018-03-06 13:41:33 -08:00
SwampDragons
d3f1b501c6
Merge pull request #5975 from arizvisa/GH-5961
Disable the usage of the XHCI bus for USB on the vmware-iso builder.
2018-03-06 09:48:38 -08:00
Ali Rizvi-Santiago
df6cdcc7f7 Disable the usage of the XHCI bus for USB on the vmware-iso builder.
Some platforms with incomplete XHCI implementations (i.e. FreeBSD)
will poll the bus despite there being no usb devices available.
This disables XHCI by default and documents how to enable it using
the vmx_data option.

This closes issue #5961.
2018-03-05 20:58:43 -06:00
SwampDragons
980c777000
Merge pull request #5960 from LessMo/master
builder/amazon: Added new region cn-northwest-1
2018-03-05 17:41:12 -08:00
SwampDragons
585e31e47a
Merge pull request #5974 from boumenot/pr-azure-better-error-message
azure: better error message
2018-03-05 17:28:50 -08:00
Christopher Boumenot
d2e593de37 azure: support for marketplace plan information 2018-03-05 09:05:21 -08:00
Christopher Boumenot
8166ba2d8d azure: better error message 2018-03-04 21:21:02 -08:00
Christopher Boumenot
e0ac07f5db azure: correct function name spelling 2018-03-03 08:53:10 +00:00
Less Mo
686cacb435
builder/amazon: Added new region cn-northwest-1
Add new region China Ningxia cn-northwest-1.
2018-03-02 16:34:19 +08:00
jmajoor
675dc06967 Tests for the optional disk_additional_size configuration. 2018-02-26 17:37:46 -08:00
jmajoor
33c3d2885d Add the additional disk steps to the Linux build 2018-02-26 17:33:40 -08:00
jmajoor
47947bd0f6 Apply gofmt 2018-02-23 18:43:55 -08:00
jmajoor
efcdbfeab9 Add support for optionally building Azure VMs with additional disks. 2018-02-23 15:34:13 -08:00
Stefan Henseler
103186af86 Adds Support to configure hyper-v disk block size 2018-02-23 20:19:26 +01:00
SwampDragons
9e8e376d6c
Merge pull request #5932 from hashicorp/add_configurable_snapshot_timeout
add configurable snapshot timeout to oracle-classic builder
2018-02-22 14:27:20 -08:00
Megan Marsh
597ddc2192 add configurable snapshot timeout to oracle-classic builder 2018-02-22 14:01:53 -08:00
Christophe Courtaut
16882c1252 builder/googlecompute: Go code formatting 2018-02-22 17:19:13 +01:00
Christophe Courtaut
4befdce47e builder/googlecompute: Adds ability to specify service account
This commit allows user to specify the service account they want
to associate with the virtual machine provisionned by setting
the service_account_email field in the config.

It allows to manage permissions of the instantiated VM properly,
using a service account that can be tied up to IAM roles and
permissions.
2018-02-22 17:19:13 +01:00
Megan Marsh
33acdbf3bf move comments so indentation is more logical 2018-02-21 14:57:58 -08:00
SwampDragons
3ea7fc9876
Merge pull request #5931 from arizvisa/GH-5916
Fixes the assumption that all the VMware builder's drivers will implement a network mapper for mapping a network name to it's corresponding device.
2018-02-21 14:56:53 -08:00
SwampDragons
cfede07228
Merge pull request #5929 from hashicorp/oracle_classic_winrm
Oracle classic winrm
2018-02-21 13:31:40 -08:00
Megan Marsh
df45e0916d Add the winRM communicator to Oracle Classic builder.
update oracle classic docs with a minimal working windows example
2018-02-21 13:21:54 -08:00
Ali Rizvi-Santiago
ac2ddbcbf5 Fixes the assumption that all the VMware builder's drivers will implement a network mapper for mapping a network name to it's corresponding device.
The ESX5 driver doesn't have a way of mapping the network name to its device name because a .vmx template uses different field names for it and so packer let's ESX handle filling this in. This patch will check to see if the driver that packer determines is missing a NetworkMapper implementation (by checking for nil). If it is, then fall back to using "nat" despite ESX not using the network type at all. This is what packer did prior to exposing the network type to the user back in version 1.1.3.

This closes issue #5916.
2018-02-20 19:45:55 -06:00
SwampDragons
1b4956aef8
Merge pull request #5900 from arizvisa/GH-5882
Reinforced the VMWare Workstation builder methodology for locating the dhcp.conf and dhcpd.leases files on Linux.
2018-02-20 11:28:32 -08:00
Matthew Hooker
2806523834
Fix issue with assume role credentials 2018-02-15 14:54:01 -08:00
Ali Rizvi-Santiago
27ed479b0a Reinforced the VMWare Workstation builder methodology for locating the dhcp.conf and dhcpd.leases files on Linux.
It was reported that on WS14 on Linux, that the path may be different than stated in the documentation. This modifies `workstationDhcpConfPath` and `workstationDhcpLeasesPath` functions to walk through every permutation while attempting to find the correct file.

This reinforces the fix for issue #5882.
2018-02-14 00:11:17 -06:00
Ali Rizvi-Santiago
d6e5342ece Fixed a type-o in the VMWare builder when locating the dhcp configuration file on Linux.
Closes issue #5882.
2018-02-13 17:27:17 -06:00
Robert Neumayer
ff30b3b3f7 Remove unrelated changes 2018-02-13 14:23:19 +01:00
Robert Neumayer
30fa1494d5 Add option to use prive ip for oci builder 2018-02-13 14:20:26 +01:00
Robert Neumayer
7966e202b7 Fix typo 2018-02-13 13:25:48 +01:00
Matthew Hooker
4be86e2e18
Merge pull request #3417 from arizvisa/vmware-iso-extraconfig
Added support for sound, serial/parallel/usb ports, and mapping the correct network (via a couple parsers) for the VMware builder.
2018-02-09 13:01:01 -08:00
Matthew Hooker
19a89a101e
builder/amazon: remove ssh_private_ip
ssh_private_ip should now be set through ssh_interface.

Adds fixer to automatically fix existing json files
2018-02-08 16:47:43 -08:00
Matthew Hooker
125a9133d4
Merge pull request #5874 from hashicorp/do_5866
fail in oracle classic builder if user tries winrm since it doesn't w…
2018-02-08 14:57:35 -08:00
Matthew Hooker
5b64f71702
Merge pull request #5764 from hashicorp/fix5760
"borrow" access config code from terraform.
2018-02-08 14:55:43 -08:00
Megan Marsh
7f631fcb77 unpack attributes in oracle-classic builder earlier so that we error fast if there's an issue 2018-02-08 14:12:39 -08:00
Megan Marsh
ff717c5784 wrong place for differentiation between ssh and winrm 2018-02-08 13:21:21 -08:00
Megan Marsh
ad2e5f1f08 fail in oracle classic builder if user tries winrm since it doesn't work yet, and add attributes and attributes_file fields to oracle builder 2018-02-08 12:52:44 -08:00
Matthew Hooker
e752e3a018
use new internal multistep helper 2018-02-08 12:10:11 -08:00
Loïc Carr
22b12432db
builder/scaleway: support ssh agent authentication 2018-02-08 12:10:11 -08:00
Loïc Carr
1f7c32db98
builder/scaleway: report to ui scw api startup error 2018-02-08 12:10:11 -08:00
Loïc Carr
7f8ed28bc6
builder/scaleway: Make use of NewRunnerWithPauseFn 2018-02-08 12:10:11 -08:00
Loïc Carr
fc7d89eb79
builder/scaleway: support password auth 2018-02-08 12:10:11 -08:00
Edouard BONLIEU
eb56b1b70e
Fix terminate error 2018-02-08 12:10:10 -08:00
Edouard BONLIEU
b44798b38d
Raise error in case of create server failure 2018-02-08 12:10:10 -08:00
Edouard BONLIEU
09805911b4
Fix builder unique id
Add new ARM64 commercial types
DOC - Add default value for optional settings
DOC - Fix typo
2018-02-08 12:09:25 -08:00
Edouard BONLIEU
2de93c5ae6
Add existing SSH key support
Update documentation
2018-02-08 12:09:25 -08:00
Edouard BONLIEU
1fb13cc23e
Add image creation from snapshot
Rename organization_id / access_key
Update test / doc
2018-02-08 12:09:25 -08:00
Edouard BONLIEU
9b611af7e6
Allow token and organization id to be passed via env vars 2018-02-08 12:09:25 -08:00
Edouard BONLIEU
7e36cfcff1
Add Scaleway builder 2018-02-08 12:09:24 -08:00
Matthew Hooker
6205c71f98
Merge pull request #5791 from YuSungDuk/master
Naver Cloud Platform builder
2018-02-08 11:10:18 -08:00
Edward
c29e5de381
Remove the deprecated extensions
The Nova extension API was deprecated from OpenStack N release.
this parts of code cannot work well with the newest OpenStack version.

This patch is to remove the relative parts:
1. Remove the step_load_extensions.go
2. Remove the step of extension from builder.go
3. Remove the parameter parsing from step_stop_server.go

Resolves: #5581
2018-02-06 17:36:47 -08:00
유성덕
0ebdad2934 fix communicator type : Windows -> winrm 2018-02-07 10:29:56 +09:00
Matthew Hooker
8510f072a9
Merge pull request #5841 from hashicorp/fix5447
Add volume and run tags if in us-gov/china
2018-02-05 17:29:12 -08:00
Matthew Hooker
21812fa17f
Add volume and run tags if in us-gov/china
We can't tag on instance creation when we're in "restricted" regions,
so let's add the tags after the resources have been created.

Adds methods to AccessConfig to detect if we're in China or US Gov
regions (i.e. "restricted").

Also turns tag:tag maps into a type, and moves methods around validating
and converting them to ec2Tags to methods of the type.
2018-02-05 16:39:20 -08:00
Matthew Hooker
ff64ccda55
Merge pull request #5426 from hashicorp/fix_4915
Fix 4915
2018-02-05 14:54:27 -08:00
SwampDragons
7d5d62d748
Merge pull request #2906 from arizvisa/GH-2377
Improved support for downloading and validating a uri containing a Windows UNC path or a relative file:// scheme
2018-02-05 09:53:47 -08:00
Petr Hosek
eaef2961cb Support specifying licenses for Google Compute images
This is needed to enable features such as the nested virtualization:
https://cloud.google.com/compute/docs/instances/enable-nested-virtualization-vm-instances
2018-02-03 14:15:16 -06:00
Ali Rizvi-Santiago
fa2dddd26d Fixed some things mucked up during rebase. 2018-02-02 19:45:18 -06:00
Ali Rizvi-Santiago
aefe41a44a Fixed an issue with the previous commit so that when the user does not specify the cdrom_adapter_type to fallback to the original decision made by the disk adapter type selection. 2018-02-02 19:18:50 -06:00
Ali Rizvi-Santiago
eb0445ca96 Added support for specifying both the network adapter type and cdrom adapter type as requested by @night199uk. Also included the respective documentation for these new options. 2018-02-02 19:18:50 -06:00
Ali Rizvi-Santiago
74946071d2 Added support for specifying the disk adapter type to the vmware builders. This was squashed from the vmware-diskAdapterType branch (#2968) as submitted by Rami Abughazaleh <icnocop@users.noreply.github.com>. This closes #5671 and possibly #4885.
arizvisa: Updated icnocop's documentation to include the possible disk adapter types that one can specify.
arizvisa: Tweaked icnocop's support for the `disk_adapter_type` option to the VMWare builder that caused conflicts due to version skew.
icnocop: Updated links to the Virtual Disk Manager User's Guide PDF to open in a new window and also added the Adobe PDF icon
icnocop: Added support for vmware to specify the disk adapter type, ide or scsi (lsilogic or buslogic)
2018-02-02 19:18:49 -06:00
Ali Rizvi-Santiago
594ed950c7 Fixed a race condition in builder/vmware/common/driver_parser.go due to a misunderstanding how channels work when you close them. 2018-02-02 19:18:49 -06:00
Ali Rizvi-Santiago
737e951685 Added missing root path to path-finders for the VMware Fusion implementation in the vmware builder as mentioned by @SwampDragons. 2018-02-02 19:18:49 -06:00
Ali Rizvi-Santiago
b2fec18b1e Added parser for VMware Fusion's networking file. Replaced VmwareDriver's NetmapConfPath with a NetworkMapperInterface in order to handle the differences between VMware Fusion and the rest of the VMware suite. 2018-02-02 19:18:49 -06:00
Ali Rizvi-Santiago
069d00f70b Added the paths suggested by @phekmat and @SwampDragons for VMware Fusion... Although parser for the new mapper format is likely to be needed still. 2018-02-02 19:18:49 -06:00
Ali Rizvi-Santiago
8cc0776f3a Fixed oversight in VMware builder's mock-driver that neglected to initialize 'HostAddressResult'. 2018-02-02 19:18:49 -06:00
Ali Rizvi-Santiago
029c357d8c Modified some tests to require the PACKER_ACC environment variable to be set before executing them. This turns them into acceptance tests as per CONTRIBUTING.md. 2018-02-02 19:18:49 -06:00
Ali Rizvi-Santiago
58ebc5c9a5 When specifying NONE for serial or parallel in the VMware builder, disable the serial and parallel port devices entirely. 2018-02-02 19:18:48 -06:00
Ali Rizvi-Santiago
258804106b Added missing GetVmwareDriver() method to VMware Builder's DriverMock. 2018-02-02 19:18:48 -06:00
Ali Rizvi-Santiago
6423525a33 Updated imports of github.com/mitchellh/packer to new naming scheme github.com/hashicorp/packer 2018-02-02 19:18:48 -06:00
Ali Rizvi-Santiago
75fbfa0763 Replaced a hacky type assertion in the VMware builder with a call to Driver.GetVmwareDriver() that returns the driver-specific structure for ip and addressing information. Also implemented the addressing functions for the ESXi driver interface.
This fixes an issue where a driver might not have defined a VmwareDriver by forcing a developer to implement it via the standard Driver interface.
2018-02-02 19:18:48 -06:00
Ali Rizvi-Santiago
898b27c16d Added support for the NONE option to be specified for parallel and serial ports in the vmware iso builder. 2018-02-02 19:18:48 -06:00
Ali Rizvi-Santiago
884af69da1 go fmt on builder/vmware/* 2018-02-02 19:18:48 -06:00
Ali Rizvi-Santiago
0d6cf7fac4 Added support for auto-detection to the serial and parallel port types.
Included the yield option to all the serial port types.
Added the ability for the network type to fallback to a custom network if the
    specified network name is not found in netmap.conf.
Promoted the scope for both Read{Dhcp,Netmap}Config inside vmwcommon.driver.
Updated the documentation for the VMware builder.
2018-02-02 19:14:29 -06:00
Ali Rizvi-Santiago
b52e2d3f45 Added the ability for the vmware-builder to fallback and determine the network device-name using the .vmx configuration in case of a guest using the "custom" connection type. 2018-02-02 19:13:02 -06:00
Ali Rizvi-Santiago
e389d30a1b Implemented the unit-tests for builder/vmware/iso/step_create_vmx.go 2018-02-02 19:13:02 -06:00
Ali Rizvi-Santiago
15cb6a833a Ugh..missing argument in VMware builder's driver_esx5 unit-test due to api change for .HostIP(). Fixed. 2018-02-02 19:11:41 -06:00
Ali Rizvi-Santiago
9b95ce0bc6 Completely forgot to support the unix paths in each of the drivers for the VMware builder. Fixed. 2018-02-02 19:11:41 -06:00
Ali Rizvi-Santiago
4225b3568e Fixed bad ORs and a bad fmtstring. 2018-02-02 19:11:41 -06:00
Ali Rizvi-Santiago
75d3ea7cee Added support for sound, serial ports, parallel ports, usb, and specifying a default network to the vmware builder.
builder/vmware/{iso,vmx}:
    Added the specific configuration options that get parsed.
    Normalize paths when pulling them from the json template so that they'll work on Windows too.
    Added some improved error checking when parsing these options.
    Stash the vm's network connection type so that other steps can figure out addressing information
    Modified the esx5 driver to support the new addressing logic.
    Modified the template in step_create_vmx to include the new options.

builder/vmware/common:
    Implemented a parser for vmware's configuration files to the vmware builder.
    Modified the driver's interface to include support for resolving both guest/host hw and ip addresses
    Implemented a base structure with some methods that implement these features.
    Rewrote all ip and mac address dependent code to utilize these new methods.
    Removed host_ip and guest_ip due to their logic being moved directly into a
        base-structure used by each driver. The code was explicitly checking runtime.GOOS
        instead of portably using net.Interfaces() anyways.
    Updated driver_mock to support the new addressing methods
2018-02-02 19:11:41 -06:00
SwampDragons
8ae8f31a52
Merge pull request #5681 from mcandre/super-key
add super key (vmware builder)
2018-02-02 13:33:11 -08:00
SwampDragons
caea770af1
Merge pull request #5819 from hashicorp/oracle-oci-builder
Oracle oci builder
2018-02-02 11:56:18 -08:00
Ben Phegan
3c88e787df
Merge branch 'master' into hyperv_mac_address 2018-02-02 09:26:52 +11:00
SwampDragons
6d14eb6ea4
Merge pull request #5631 from vijayinvites/diffdisks
[Hyper-V] Use differential disks and Inline disk creation to improve build time (a lot) and to reduce disk usage(a lot)
2018-01-31 16:51:27 -08:00
Megan Marsh
383ac13e2a update default of image list after adding new entry. 2018-01-31 16:37:55 -08:00
Megan Marsh
8f7937f492 fix machine image name to include prepended / 2018-01-31 15:22:09 -08:00
Megan Marsh
3180dc327c remove copypasta comment 2018-01-31 15:02:19 -08:00
Matthew Hooker
8bdd3b45c7
use helper functions for reading vmx files 2018-01-31 13:19:31 -08:00
Megan Marsh
66cd85828e rename dest_image_list_description to image_description 2018-01-31 12:48:40 -08:00
Matthew Hooker
baf8d30ad2
Merge pull request #5738 from testworksau/intel-haxm-support
Add Intel HAXM support to QEMU builder
2018-01-31 12:41:15 -08:00
Megan Marsh
af26b312cd fix logline 2018-01-31 11:35:34 -08:00
Megan Marsh
871ead371a Clean up based on Oracle comments 2018-01-31 10:47:19 -08:00
유성덕
f39c3458f7 fix Run method arguments for testing 2018-01-30 10:20:02 +09:00
Megan Marsh
705459c260 add snapshotted machine image to image lists, then delete the snapshot. 2018-01-29 16:50:53 -08:00
유성덕
e68a742bca make fmt 2018-01-29 22:44:24 +09:00
유성덕
175dd2730f Use 'github.com/hashicorp/packer/helper/multistep' 2018-01-29 22:41:22 +09:00
유성덕
5714108ef9 Merge branch 'master' into support_ncloud 2018-01-29 22:10:18 +09:00
유성덕
6b40c726e0 Use PublicIp for communicator 2018-01-29 22:07:32 +09:00
유성덕
e57a8161e0 remove delete step of login key and public ip instance. 2018-01-29 21:47:58 +09:00
유성덕
2a3a35334a Logging root password 2018-01-29 20:42:22 +09:00
유성덕
30f8fee402 use comment with english 2018-01-29 19:08:53 +09:00
유성덕
3820f97a0b use state storage to save feeSystemTypeCode 2018-01-29 18:35:43 +09:00
유성덕
2152ad7609 Add UserDataFile 2018-01-29 18:09:14 +09:00
유성덕
da78ebbf83 - Remove plugin version
- remove `os_type`. use `communicator` instead of this.
2018-01-29 17:29:26 +09:00
Matthew Hooker
76b2ce8604
log which vmware driver we decide on 2018-01-26 16:12:43 -08:00
Matthew Hooker
07421b4433
test vmware workstation version checking 2018-01-26 15:58:17 -08:00
Megan Marsh
56c6fed42a ui.say vs ui.message 2018-01-26 15:20:12 -08:00
Megan Marsh
3ee1aa3ed6 clean up ip reservations 2018-01-26 15:18:33 -08:00
Megan Marsh
565b660b19 comments 2018-01-26 14:28:27 -08:00
Megan Marsh
98857c42cf add tests; fix a couple issues caught by said tests 2018-01-26 14:27:31 -08:00
Matthew Hooker
9edd98f7b0
Use more uuids and make messaging consistent. 2018-01-26 13:43:19 -08:00
Matthew Hooker
c6b43ce6e9
remove errouneous double prep 2018-01-26 13:13:13 -08:00
Matthew Hooker
71acccc1ed
add UI output with resource names 2018-01-26 13:12:35 -08:00
Matthew Hooker
18ffde4ecf
remove unused file 2018-01-26 12:59:46 -08:00
Matthew Hooker
fad4d5c272
update tests for mapstructure behavior changes 2018-01-26 12:40:34 -08:00
Megan Marsh
0e5be59947 wrap error message for clarity 2018-01-26 09:55:31 -08:00
Megan Marsh
ff9fef5ed2 switch to using a UUID for packer-generated keys, and clean them up at end of build 2018-01-26 09:51:16 -08:00
Megan Marsh
b6d21ecd63 validate that required fields are present 2018-01-26 08:53:24 -08:00
Megan Marsh
25bc1da8fe remove unsused access config 2018-01-26 08:48:23 -08:00
Megan Marsh
de2e5edf2e remove errant change in amazon builder 2018-01-26 08:43:51 -08:00
Matthew Hooker
4622bb4585
return no artifact if no snapshot was created 2018-01-25 16:32:37 -08:00
Matthew Hooker
77277ebc98
add logging behind "PACKER_OCI_CLASSIC_LOGGING" env var 2018-01-25 16:32:34 -08:00
Matthew Hooker
0fad49e897
simplify 2018-01-25 15:05:36 -08:00
Matthew Hooker
4dc42942f5
fix multistep path 2018-01-25 14:46:02 -08:00
Matthew Hooker
6dc0bd759a
import context 2018-01-25 14:43:55 -08:00
Matthew Hooker
dd2384483b
add context to steps 2018-01-25 14:42:39 -08:00
Megan Marsh
00db189c9c
add docs page 2018-01-25 14:34:03 -08:00
Megan Marsh
1fffbacdd3
fix ordering of deleting security rules and lists 2018-01-25 14:34:03 -08:00
Matthew Hooker
76ea73c5b2
I don't think we need to delete this artifact right now 2018-01-25 14:34:03 -08:00
Matthew Hooker
603881d990
add oci/classic artifact 2018-01-25 14:34:03 -08:00
Matthew Hooker
44befb0857
rename 2018-01-25 14:34:02 -08:00
Matthew Hooker
b9a90b9261
Check for error when creating ip reso 2018-01-25 14:34:02 -08:00
Megan Marsh
7d23cfae0a
allow user to add a security list for SSH access; add cleanup for packer-generated rules and lists 2018-01-25 14:34:02 -08:00
Megan Marsh
531cb2244d
add separated out steps 2018-01-25 14:34:02 -08:00
Megan Marsh
53ff257cf0
it LLIIIIIIIIIVES 2018-01-25 14:34:02 -08:00
Megan Marsh
89159f3a87
fix bugs in cleanup 2018-01-25 14:34:02 -08:00
Megan Marsh
f6c60aac78
clean up instance 2018-01-25 14:34:01 -08:00
Megan Marsh
256382547b
snapshot step works 2018-01-25 14:34:01 -08:00
Megan Marsh
69ba710c2a
PROGRESS! Now it only fails on the snapshot step 2018-01-25 14:34:01 -08:00
Megan Marsh
f208a071a4
fix communicator 2018-01-25 14:34:01 -08:00
Megan Marsh
6556a851dc
fix ssh key handling 2018-01-25 14:34:01 -08:00
Megan Marsh
a8a0072049
oops need to add this moved file to git 2018-01-25 14:34:01 -08:00
Megan Marsh
8b420944c5
debugs 2018-01-25 14:34:00 -08:00
Megan Marsh
46c3113613
it compiles :) 2018-01-25 14:34:00 -08:00
Megan Marsh
8aa716cd4c
stub out step_snapshot 2018-01-25 14:33:43 -08:00
Megan Marsh
007e8f7c14
finish stubbing out step_create_IP_reservation 2018-01-25 14:33:43 -08:00
Megan Marsh
7d72870179
add buffer to read template into 2018-01-25 14:33:42 -08:00
Megan Marsh
0117f53721
add error message 2018-01-25 14:33:42 -08:00
Megan Marsh
a66dfe1972
fleshing out step_create_instance 2018-01-25 14:33:42 -08:00
Megan Marsh
4fe89be32a
fleshing out steps 2018-01-25 14:33:42 -08:00
Megan Marsh
75ee66f934
add stubbed out steps 2018-01-25 14:33:42 -08:00
Matthew Hooker
3bf431a423
construct OCI client 2018-01-25 14:33:41 -08:00
Matthew Hooker
9e8d845c03
create instance reservation 2018-01-25 14:33:41 -08:00
Matthew Hooker
543caf3ec5
WIP OCI Classic builder 2018-01-25 14:33:41 -08:00
Matthew Hooker
eafda52411
use amazon steps from master 2018-01-24 17:09:18 -08:00
Matthew Hooker
8cd403425e
test fixes WIP 2018-01-24 17:09:17 -08:00
Matthew Hooker
5d48d658b4
Wire context through misc steps
Some steps actually need to pass the context around, so let's create
a ctx variable and pass it.
2018-01-24 17:09:17 -08:00
Matthew Hooker
7a189a83a1
fix imports
`find . -type f -name '*.go' -not -path "./vendor/*" -exec goimports -w {} \;`
2018-01-24 17:09:17 -08:00
Matthew Hooker
a831d522be
change run signatures
Run now takes a context as well as a statebag. We'll assign the context
to the blank identifier to prevent namespace collisions. We'll let the
step authors opt-in to using the context.

`find . -iname "step_*.go" -exec gsed -i'' 's/func \(.*\)Run(/func \1Run(_ context.Context, /' {} \;`
2018-01-24 17:09:17 -08:00
Matthew Hooker
a0c625ea44
Revert "working with opt-in"
This reverts commit 4068ffdaf541354e75507add7ca0b193993fcd52.
2018-01-24 17:09:16 -08:00
Matthew Hooker
e98f201602
working with opt-in 2018-01-24 17:09:16 -08:00
Matthew Hooker
366dc3da0a
move multistep imports to helper.
gomvpkg -from "github.com/mitchellh/multistep" -to "github.com/hashicorp/packer/helper/multistep"
2018-01-24 17:09:15 -08:00
Matthew Hooker
807e88245b
trying to add context to state bag 2018-01-24 17:09:15 -08:00
James Nugent
5967732442
Merge pull request #5795 from stack72/bump-triton-go-deps
builder/triton: bump triton-go dependencies
2018-01-23 14:40:03 +00:00
Matthew Hooker
ebe995c0ff
run goimports 2018-01-22 17:21:10 -08:00
stack72
20f9ef3445 builder/triton: bump triton-go dependencies
This introduces a new triton-go errors package so we can error handle our code in a better way
2018-01-17 16:55:00 +02:00
Ali Rizvi-Santiago
c17f827e1d Split up DownloadableURL() into it's individual components: SupportedURL(), DownloadableURL(), and ValidatedURL(). Updated all instances of DownloadableURL() to point to ValidatedURL(). Reverted the tests that are based on un-supported protocols. 2018-01-16 13:37:32 -06:00
Ali Rizvi-Santiago
3cf448f6ec Reverted previously removed additions of tests that check for ftp:// or nonexistent-protocol:// using DownloadableURL. DownloadableURL's responsibility is not to have inherent knowledge of protocols that are available, but to format an invalid url/path to a valid url/path. 2018-01-16 13:37:32 -06:00
Ali Rizvi-Santiago
46a5ca30e5 Removed call to filepath.Rel(...) in builder/vmware/iso/step_create_vmx.go 2018-01-16 13:37:32 -06:00
Ali Rizvi-Santiago
5d97b105a8 Removed implementation of the ftp protocol and the usage of cheggaaa's progress-bar as suggested by @SwampDragons. Replaced some of the old smoke-tests that were based on the ftp-protocol non-existing with a "non-existent://" protocol that's guaranteed to not exist. 2018-01-16 13:37:31 -06:00
Ali Rizvi-Santiago
d275bacb0f go fmt builder/vmware/iso/step_create_vmx.go to calm down Travis CI. 2018-01-16 13:37:31 -06:00
Ali Rizvi-Santiago
e940dc7e42 Fixed a config_test that should've failed but didn't because ftp:// uris work now. HeH! 2018-01-16 13:37:31 -06:00
Ali Rizvi-Santiago
281dd1258a Added proper support for downloading via a Windows UNC path or a relative uri.
Added proper support for validating a downloadableURL containing a UNC or relative uri.
Removed the workaround for an earlier Go issue that had remained dormant in common/download.go (issue #5927).
When building a .vmx file via the vmware-iso builder, transform the path to the correct os-formatted one (using filepath.FromSlash).
2018-01-16 13:36:17 -06:00
Matthew Hooker
cea2ab8c6d
move kms/encrypted validation to block devices 2018-01-12 15:10:51 -08:00
Matthew Hooker
e968f9d6cc
spelling/style fixes 2018-01-12 14:26:56 -08:00
Jason Wieringa
f6772f06be builder/amazon: Raise error when ebsvolume kms_key_id is without encrypted = true 2018-01-11 20:27:38 -08:00
Jason Wieringa
2ac59b3c27 builder/amazon: Added KmsKeyID to BlockDevice
+ Adds kms_key_id to list of options
+ Tests that configuraiton is set along with encrypted
+ Updates documentation on ebsvolume builder
2018-01-11 20:27:38 -08:00
유성덕
b909e9d4e6 remove not used variables 2018-01-12 10:15:40 +09:00
유성덕
26030d750c update err format 2018-01-12 10:12:47 +09:00
Matthew Hooker
2ce3ca1538
Merge pull request #5773 from hashicorp/fix5705
Use SDK's InstanceReady waiter
2018-01-11 12:12:03 -08:00
SwampDragons
fb730cf521
Merge pull request #5761 from hashicorp/fix_5713
fix nasty edge case where we can't find guest additions on windows if they are on a different drive
2018-01-11 11:48:26 -08:00
유성덕
5189d65467 Support Naver Cloud Platform 2018-01-11 18:57:53 +09:00
Megan Marsh
3ace5bb91b simplify FileExistsLocally 2018-01-10 16:11:17 -08:00
Matthew Hooker
f5ea1e8312
Use WaitUntilInstanceReady waiter 2018-01-10 15:57:31 -08:00
Megan Marsh
216c44b153 fix FileExistsLocally 2018-01-09 15:47:07 -08:00
Matthew Hooker
dfd5f07145
fix ebs acc test 2018-01-08 12:27:10 -08:00
Megan Marsh
e164621bfe log line to help prevent confusion when guest_additions_url is set from env variable that is empty 2018-01-05 09:19:38 -08:00
SwampDragons
ff3cbbf28c
Merge pull request #5757 from arizvisa/virtualbox-guest_additions_url-interpolation
Fixed an issue where the VirtualBox builder was checking for whether guest_additions_url was empty or not before it actually interpolated any variables.
2018-01-04 15:39:29 -08:00
Matthew Hooker
c5bcb97d06
"borrow" access config code from terraform.
This gives us a few benefits:

* timeout early if metadata service can't be reached
* report which auth provider we're using
* give much better errors if something goes wrong
2018-01-04 15:04:07 -08:00
Matthew Hooker
98c2a2d1f7
builder/aws: catch static credential errors early.
If we're using static credentials, either both the access key and secret key must be set, or neither of them should be.
2018-01-04 11:50:27 -08:00
Megan Marsh
4f3b470804 add helper function to manage validation of filepaths created using DownloadableURL 2018-01-03 16:53:47 -08:00
Ali Rizvi-Santiago
4fcd542d0c Fixed an issue where the VirtualBox builder was checking for whether guest_additions_url was empty or not before it actually interpolated any variables. 2018-01-02 21:09:41 -06:00
stack72
c3467b686c builder/triton: Add support for Triton RBAC
Fixes: #5737

Triton allows for subusers to be granted access to your account. This PR allows a user to be specified
2017-12-29 21:20:40 +02:00
QuantumGhost
a90376f12a Attach keypair before starting instance in alicloud builder
[Documentation of `AttachKeyPair`](https://goo.gl/gC3srG) states that
attaching keypair to running instance takes effect after reboot.
So we need to attach keypair before starting instance to avoid an
additional restart.
2017-12-29 10:13:26 +08:00
Glenn McDonald
7250c4f7f0 Add Intel HAXM support to QEMU builder 2017-12-29 11:51:57 +11:00
Rickard von Essen
05fcecb1e7
Merge pull request #5666 from kwilczynski/remove-ecr-credentials-from-logging
docker: Remove credentials from being shown in the log.
2017-12-26 08:07:37 +01:00
Matthew Hooker
f3dea272d9
Set session in state bag
We can construct connections to arbitrary regions from it
2017-12-19 11:32:33 -08:00
Matthew Hooker
f6c401a143
don't pass in accessconfig 2017-12-19 11:32:32 -08:00
Matthew Hooker
1c352726d7
Merge pull request #5719 from rchenv/issue5606
Ensure all AWS connections are configured alike
2017-12-19 11:32:24 -08:00
Rong Chen
3e92b1374e issue5606: follow the convention to use AccessConfig to create new aws session for step_create_tags etc. 2017-12-19 10:34:12 -08:00
Olivier Bazoud
8bcb469b8b builder/amazon: Added new region Paris - eu-west-3 2017-12-19 10:00:03 +01:00
Ben Phegan
c338cb79d0 Initial commit of feature to allow MAC address specification for HyperV builders 2017-12-15 13:24:15 +11:00
Arjen Schwarz
c2ecdd98c6
5691: Invalid image URLs make Azure builder crash 2017-12-12 20:12:53 +11:00
Vijaya Bhaskar Reddy Kondreddi
54f059d3d4 Add support for skip export 2017-12-11 11:24:59 +05:30
Krzysztof Wilczynski
567b566c23
docker: Remove AWS credentials and Session Token from being shown in the log.
Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
2017-12-10 20:55:03 +01:00
Rickard von Essen
63f791570a
Merge pull request #5665 from kwilczynski/remove-sts-token-from-logging
amazon: Remove Session Token (STS) from being shown in the log.
2017-12-10 06:50:42 +01:00
Andrew Pennebaker
d069dc5b7c handle holding a-z keys, such as for boot options (vmware builder) 2017-12-09 20:51:49 -06:00
Matthew Hooker
f216330ba3
spot instance ena/sriov checking for all other builders 2017-12-08 14:56:19 -08:00
Matthew Hooker
4b1d8e3fe8
don't allow enhanced networking flags for spot instances. 2017-12-08 13:38:49 -08:00
Matthew Hooker
73b98b2a04
use waiter to wait for ebs instances to stop 2017-12-08 13:38:48 -08:00
Matthew Hooker
dada63801b
also use waiter code for spot instances 2017-12-08 13:38:48 -08:00
Matthew Hooker
9e61005f7c
Merge pull request #5660 from hashicorp/fix_5625
modify validation to allow user to have the original region in the am…
2017-12-08 13:36:10 -08:00
Ben Gnoinski
5df2e040d0 Update amazon run_config.go absent ssh_private_key_file error 2017-12-08 08:51:27 -08:00
Andrew Pennebaker
4acc98a729 add super key (vmware builder) 2017-12-07 23:15:56 -06:00
Matthew Hooker
2c1c7b9659
Merge pull request #5630 from johndaviesco/winrm_no_proxy
Winrm no proxy
2017-12-07 15:41:16 -08:00
Matthew Hooker
a90c45d9bb
Wait until source instance OK before continuing 2017-12-07 12:31:50 -08:00
Matthew Hooker
7b5c0900ef
Correctly set aws region if given in template along with a profile. 2017-12-07 11:12:57 -08:00
Christopher Boumenot
1202bdd080
Merge pull request #5661 from jamielennox/no-location-for-existing-rg
Azure: Don't provide location for build_resource_group_name
2017-12-05 09:52:45 -08:00
Krzysztof Wilczynski
05327b7524
amazon: Remove Session Token (STS) from being shown in the log.
This commit adds a change which ensures that the Session Token
config struct item is removed from log output.

Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
2017-12-04 22:14:38 +01:00
Jamie Lennox
d043c37ad4 Azure: Don't provide location for build_resource_group_name
Location is required by default because you must specify where to create
the resource group containing the packer resources.

When using build_resource_group_name you are specifying that packer
should use an existing resource group and so the location that resources
are in can be determined by fetching the information from the existing
group.

It is forbidden to pass both variables as it is easier and more
intuitive that the location comes from the group rather than ignore a
parameter.

Closes: #5655
2017-12-04 11:22:54 +11:00
SwampDragons
8a30b3db80
Merge pull request #5456 from GoSecure/vmware-iso-improved-network-logging
vmware-iso builder: Logging on network errors on connection refused
2017-11-30 16:31:30 -08:00
Megan Marsh
1c681fc096 tests 2017-11-30 14:08:48 -08:00
Megan Marsh
556da47d35 modify validation to allow user to have the original region in the ami_regions list 2017-11-30 13:51:33 -08:00
Christopher Boumenot
da0c13f622 azure: delete keyvault deployment 2017-11-30 01:19:08 -08:00
zhuzhih2017
bdc1fa0527
Merge pull request #5641 from zhuzhih2017/master
Add security token supported and TLS handshake timeout support
2017-11-28 11:15:56 +08:00
zhuzhih2017
de0017c37a Add security token supported and TLS handshake timeout support 2017-11-28 10:32:17 +08:00
John Davies-Colley
10aaa49beb fixing tests and funky logic 💦 2017-11-28 14:42:14 +13:00
John Davies-Colley
0c787ec9df Valadating early 2017-11-28 11:46:32 +13:00
Vijaya Bhaskar Reddy Kondreddi
3d5303c60d Fix tests 2017-11-24 13:24:44 +05:30
Vijaya Bhaskar Reddy Kondreddi
b7e3f37b44 Add support for differential disk 2017-11-24 12:44:53 +05:30
John Davies-Colley
75320440ec adding missing quote 🙏 2017-11-22 15:59:15 +13:00
John Davies-Colley
707ec675b2 ssh interface for amazon builders 🔨 2017-11-22 15:49:38 +13:00
Christopher Boumenot
a3c9485062 azure: sanity check resource group names 2017-11-20 15:19:12 -08:00
Christopher Boumenot
247da61ad1
Merge pull request #5593 from boumenot/pr-azure-keep-resource-group
Azure: Keep temporary resource group.
2017-11-16 17:39:33 -08:00
Christopher Boumenot
8985bd45ba azure: go fmt 2017-11-16 17:32:35 -08:00
Christopher Boumenot
ee767e55d1 azure: change literal to constant 2017-11-16 16:36:42 -08:00
Christopher Boumenot
2684153cb2 azure: reject bad configuration faster 2017-11-16 16:34:18 -08:00
Christopher Boumenot
787f08f39b azure: add user message to indicate what is being deleted 2017-11-16 16:31:05 -08:00
Megan Marsh
20390ff1ec fix vetting for test fail print statements 2017-11-15 17:01:53 -08:00
SwampDragons
ab542c07ff
Merge pull request #5547 from egraff/hyperv-patch
builder/hyperv/vmcx: missing InterpolateContext
2017-11-15 17:00:55 -08:00
Ammar Ansari
b8bd66d10d Align virtual disk size for qemu builder
When booting from a disk image, the Qemu builder resizes the disk to 40000
which is not a multiple of 1kB. This causes problems while booting from the image.
Updating the default disk size to 40960 fixes this issue
2017-11-15 15:00:13 -05:00
Matthew Hooker
b07a0cd6f0
fix tests
always sort telemetry options
2017-11-14 16:39:03 -08:00
Megan Marsh
6756df9510 use url library instead of parsing string naiively 2017-11-13 12:57:53 -08:00
Megan Marsh
771349e58c fix error message 2017-11-13 12:52:47 -08:00
Megan Marsh
764be03876 didn't mean for this error message to get changed 2017-11-13 12:42:57 -08:00
Megan Marsh
0d18de2942 do validation in vmx config stage 2017-11-13 12:42:57 -08:00
Daniel Hess
f0299ba713 Adding GCE container optimized os image project 2017-11-12 00:45:22 -08:00
bugbuilder
f7b45312f1 Removing skip attribute 2017-11-10 23:58:24 -03:00
bugbuilder
be2afccb85 Revamped the process to verify remote cache. 2017-11-10 23:55:26 -03:00
bugbuilder
463d87adcd Merge branch 'master' of https://github.com/hashicorp/packer into esxi-remote-cache 2017-11-10 23:08:09 -03:00
Arjen Schwarz
f43f3155d4
Remove breaking debug statement 2017-11-10 11:04:31 +11:00
Matthew Hooker
f146e5903f
Merge pull request #5567 from bennu/vm-template-with-export-vm
enable vsphere-template post processor to work with export behavior
2017-11-09 15:24:41 -08:00
SwampDragons
e5c59468df
Merge pull request #5343 from evandbrown/pr-googlecompute-subnetworks
Interpolate network and subnetwork values
2017-11-09 12:10:41 -08:00
SwampDragons
aae324e4e7
Merge pull request #5562 from hashicorp/fix5558
don't set region from metadata if profile is set.
2017-11-09 10:22:15 -08:00
Arjen Schwarz
0e706320ad
Issue #5045 - Add build_resource_group_name
* Created a new parameter for using existing resource groups
* Implemented logic to ensure temp_ and build_ can't both be used
* Implemented logic to ensure they can only be used in correct context
* Implemented tests for this logic
* Updated where required to ensure the process works
2017-11-09 22:20:09 +11:00
bugbuilder
23f4d187e2 validating keep_registered and fixing skip_export issues 2017-11-08 15:57:34 -03:00
stack72
450a233303 builder/triton: Wait for ImageCreation State
A bug was reported to Joyent, that sometimes packer UI reports that an image was created but it wasn't actually available in Triton for use. We believe that there was a bug uploading that image to Manta but that the metadata of the image was already populated and thus packer was reporting success as it was just checking for the metadata presence

This PR changes Packer to wait for the state of the image to be `active` to make sure that it has fully uploaded and is ready for use

```
==> triton: Stopping source machine (61647c3c-f2bf-4e30-b4bc-f076d3b01522)...
==> triton: Waiting for source machine to stop (61647c3c-f2bf-4e30-b4bc-f076d3b01522)...
==> triton: Creating image from source machine...
==> triton: Waiting for image to become available...
==> triton: Deleting source machine...
==> triton: Waiting for source machine to be deleted...
Build 'triton' finished.

==> Builds finished. The artifacts of successful builds are:
--> triton: Image was created: c2537582-34c7-42ea-bd11-b6ed499d5831
```
2017-11-08 16:38:04 +02:00
Chris Lundquist
d00f884e71
Merge pull request #5530 from BaxterStockman/lxc-builder-cli-options
Add options to LXC builder for influencing for how containers are built and started
2017-11-07 22:32:17 -08:00
Matthew Hooker
0a24f4eb2e
don't shadow package name 2017-11-07 16:05:43 -08:00
Matthew Hooker
f681faa296
fix tests 2017-11-07 14:57:10 -08:00
Matthew Hooker
545ee45567
debug region we found 2017-11-07 14:51:20 -08:00
Matthew Hooker
c106e7c26c
Don't set region from metadata if profile is set. 2017-11-07 14:33:26 -08:00
Matthew Hooker
52fc0100eb
this is a critical error 2017-11-07 12:52:03 -08:00
Evan Brown
13e0c232d4 builder/googlecompute: Test networking interpolation
This change pulls the logic that interpolates network and subnetwork
into its own func and adds tests.
2017-11-06 21:22:53 -08:00
Evan Brown
f2fed94a71 builder/googlecompute: Derive network and subnetwork IDs locally
This change constructs partial URLs for networks and subnetworks if they
are not already partial or full URLs (i.e., they do not contain a '/' in
their name). Network and subnetwork self-links are no longer retrieved
from the API.

Previously, if a user did not provide the network or subnetwork as a
fully-qualified URL (i.e., self-link), the builder would make
compute.(sub)networks.get API calls with the provided identifier to
discover the self-link. This requires the user or service account Packer
is using to have permission to describe those network resources, which
is becoming less common as IAM is used more. Specifically, a user may
have permission to launch a VM into a network/subnetwork, but will not
have permission to call APIs to describe network resources.
2017-11-06 16:41:42 -08:00
Evan Brown
bada7b73c1 builder/googlecompute: Selectively set default network
If a network is not specified, it should only be set to "default" if a
subnetwork is also not specified.
2017-11-06 16:41:42 -08:00
Evan Brown
1b3eb1c34d builder/googlecompute: Set default network_project_id
If network_project_id is not specified in the GCE builder config, it
should default to the project_id.
2017-11-06 16:41:42 -08:00
Matthew Hooker
68fa09c308
Merge pull request #5512 from hashicorp/fix5501
builder/virtualbox-ovf retry removing VM.
2017-11-06 15:56:08 -08:00
Matthew Hooker
bdb2509735
Merge pull request #5475 from ChrisLundquist/lxd-publish-properties
[Lxd] publish properties
2017-11-06 15:45:56 -08:00
Matthew Hooker
0172a5c82b
Merge pull request #5511 from hashicorp/fix5507
remove login_email from docker
2017-11-06 15:34:04 -08:00
Arjen Schwarz
f4600a208f
Azure: Keep temporary resource group. Fixes #5045
This changeset will detect if the defined temporary resource group
already exists. If it does, it will not destroy it, but clean up
every resource required for building that is created by Packer
individually, both on success and failure.

Unit tests have been fixed, but more tests should be added for the new
functionalities.
2017-11-06 16:16:58 +11:00
Erlend Graff
27fc72c137 fix formatting errors 2017-11-05 15:16:47 +01:00
Erlend Graff
ae6987c74b hyper-v: add test for hashicorp/packer#5184 2017-11-05 14:58:08 +01:00
Erlend Graff
eeeee3ec35 hyper-v/vmcx: add missing InterpolateContext 2017-11-05 14:55:56 +01:00
Erlend Graff
d890051940 hyper-v: implement driver mock 2017-11-05 14:51:18 +01:00
James Nugent
fdd9b952d1
Merge pull request #5538 from stack72/triton-image-data-source
builder/triton: Add a data source for source_machine_image
2017-11-02 15:33:22 -05:00
Matthew Hooker
4d117bf117
Make vm log output less confusing 2017-11-02 10:45:54 -07:00
Matthew Hooker
ac8bc522e0
Merge pull request #5534 from lisimia/digital_ocean_ipv6_option
Added option for ipv6 within the digitalocean builder
2017-11-02 09:55:45 -07:00
Matthew Hooker
95e4ae251e
WIP 2017-11-02 09:03:44 -07:00
Matthew Hooker
e87b468c6e
Merge pull request #5536 from hashicorp/fix5535
add delay option to security group waiter
2017-11-02 08:54:34 -07:00
Matthew Hooker
8ab390a048
Merge pull request #5495 from smaato/master
Fix regressions relating to spot instances and EBS volumes
2017-11-02 08:53:27 -07:00
stack72
7776bf596b builder/triton: Add a data source for source_machine_image
fixes: #5476

Based on this new template addition:

```
{
    "variables": {
        "image_version": "",
        "triton_account": "",
        "triton_key_id": "",
        "triton_key_material": ""
    },
    "builders": [{
        "type": "triton",
        "triton_account": "{{user `triton_account`}}",
        "triton_key_id": "{{user `triton_key_id`}}",
        "triton_key_material": "{{user `triton_key_material`}}",
        "source_machine_package": "g4-highcpu-128M",
        "source_machine_image_filter": {
          "name": "ubuntu-16.04",
          "most_recent": "true"
        },
        "ssh_username": "root",
        "image_version": "{{user `image_version`}}",
        "image_name": "teamcity-server"
    }],
    "provisioners": [
        {
            "type": "shell",
            "start_retry_timeout": "10m",
            "inline": [
                "sudo apt-get update -y",
                "sudo apt-get install -y nginx"
            ]
        }
    ]
}

```

I got the following output from packer:

```
packer-testing % make image
packer build \
		-var "triton_account=stack72_joyent" \
		-var "triton_key_id=40:9d:d3:f9:0b:86:62:48:f4:2e:a5:8e:43:00:2a:9b" \
		-var "triton_key_material=""" \
		-var "image_version=1.0.0" \
		new-template.json
triton output will be in this color.

==> triton: Selecting an image based on search criteria
==> triton: Based, on given search criteria, Machine ID is: "7b5981c4-1889-11e7-b4c5-3f3bdfc9b88b"
==> triton: Waiting for source machine to become available...
==> triton: Waiting for SSH to become available...
==> triton: Connected to SSH!
==> triton: Provisioning with shell script: /var/folders/_p/2_zj9lqn4n11fx20qy787p7c0000gn/T/packer-shell797317310
    triton: Get:1 http://security.ubuntu.com/ubuntu xenial-security InRelease [102 kB]
    triton: Hit:2 http://archive.ubuntu.com/ubuntu xenial InRelease
```

I can verify from the triton cli tools that the id `7b5981c4` (from the packer output) is indeed the correct ID

```
terraform [master●] % triton images name=~ubuntu-16.04
SHORTID   NAME          VERSION   FLAGS  OS     TYPE        PUBDATE
49b22aec  ubuntu-16.04  20160427  P      linux  lx-dataset  2016-04-27
675834a0  ubuntu-16.04  20160505  P      linux  lx-dataset  2016-05-05
4edaa46a  ubuntu-16.04  20160516  P      linux  lx-dataset  2016-05-16
05140a7e  ubuntu-16.04  20160601  P      linux  lx-dataset  2016-06-01
e331b22a  ubuntu-16.04  20161004  P      linux  lx-dataset  2016-10-04
8879c758  ubuntu-16.04  20161213  P      linux  lx-dataset  2016-12-13
7b5981c4  ubuntu-16.04  20170403  P      linux  lx-dataset  2017-04-03 <------- THIS IS THE LATEST UBUNTU IMAGE
```
2017-11-02 16:10:16 +02:00
Matthew Hooker
f2413ff138
add delay option to security group waiter 2017-11-02 00:25:54 -07:00
Matthew Hooker
a14e9f4d48
Merge pull request #5525 from hashicorp/fix5524
use correct default region when deregistering AMIs.
2017-11-01 16:17:59 -07:00
Lawrence
5509d0734b Added ipv6 option for digitalocean builder
the ipv6 option is already part of the godo package

Updated documentation to reflect new feature

Closes: https://github.com/hashicorp/packer/issues/5533
2017-11-01 15:41:25 -04:00
James Nugent
a495948dc5
Merge pull request #5531 from stack72/bump-triton-dependencies
Bump Joyent/triton-go to modern version of the SDK
2017-10-31 11:21:08 -05:00
stack72
b04796c2cc Bump Joyent/triton-go to modern version of the SDK
This brings packer into the same version of triton-go as that in Terraform, where we rewrote the package from a library with everything in 1 place to individual packages

I was able to successfully provision a machine on triton using this new change, you can find the output in the attached gist

https://gist.github.com/stack72/a64d745459107c5a16bcb156965597ce
2017-10-31 18:08:53 +02:00
Matthew Hooker
19e6049f17
style fixes 2017-10-31 08:48:17 -07:00
Matthew Hooker
f64fa7b5ba
Merge pull request #5491 from BenPhegan/hyperv-disk_additional_size
Hyper-V disk_additional_size capability
2017-10-31 08:42:07 -07:00
Matt Schreiber
1f2135f65e
Add options to LXC builder for influencing for how containers are built and started
via

- create_options: a list of options passed to lxc-create
- start_options: a list of options passed to lxc-start
- attach_options: a list of options passed to lxc-attach

Also extended existing LXC builder BATS tests to exercise the new builder
options, and added website docs.
2017-10-30 21:48:43 -04:00
Matthew Hooker
d322fc6c19
Shorten metadata timeout
When running in travis, metadata requests will timeout after 5 seconds.
After 24 such timeouts, we'll hit travis' build timeout of two minutes,
and the build will fail. Lowering it to 100 gets us in a safe time
limit. We _may_ need to expose a timeout env var with this logic,
however.
2017-10-30 15:22:15 -07:00
Matthew Hooker
314fc94bd8
clean up 2017-10-30 15:02:39 -07:00
Matthew Hooker
0e4ea7420b
fix tests 2017-10-30 14:34:16 -07:00
Matthew Hooker
c65fa8490d
fix various bugs deregistering AMIs
always deregister ami in session region
validate that session region does not appear in ami_regions
2017-10-30 14:17:19 -07:00
Matthew Hooker
6c4fbe8d87
use correct default region when deregistering AMIs. 2017-10-30 13:07:58 -07:00
Matthew Hooker
faf96b369f Merge pull request #5510 from hashicorp/fix5216
fix hyper-v admin check
2017-10-27 08:49:16 -07:00
Joe Ferguson
5c2f758053 🎨 Fix typo in "copyed" -> "copied" usages. 2017-10-26 07:42:49 -05:00
Matthew Hooker
794e518eb7
use hyper-v admin group, not admin 2017-10-25 13:29:03 -07:00
Matthew Hooker
812fd12a0b
move trimspace to powershell exit check 2017-10-25 13:28:59 -07:00
Matthew Hooker
1901c0385f
remove login_email from docker
adds fixer
removes documentation
removes from docker builder and docker-push pp
2017-10-25 10:53:06 -07:00
Matthew Hooker
fb098d045d
builder/virtualbox-ovf retry removing VM.
moves behavior from builder/virtualbox-iso into the driver
so it is automatically available to callers.
2017-10-25 10:27:33 -07:00
Matthew Hooker
0be02ab217
hyper-v: Don't error while checking for admin permissions. 2017-10-25 09:18:40 -07:00
Mark Meyer
4c5df79222 Fix regressions introduced in the instance builder
Related to #5504
2017-10-24 23:23:18 +02:00
Mark Meyer
309bf61257 Add missing blockdevices to ebsvolume builder 2017-10-23 22:33:16 +02:00
Mark Meyer
1cc9b3f1e3 Bring back volume tagging to ebsvolume
Related to #5486
2017-10-23 22:09:04 +02:00
Mark Meyer
7e1646826d Check if VolumeTags is empty before tagging volumes
Related to #5486
2017-10-23 21:10:40 +02:00
Andrew Pryde
f31c2c59c1 Merge pull request #5407 from prydie/fix-5401
Fix Oracle OCI builder ignores region value provided in OCI config file
2017-10-23 09:56:49 +01:00
Ben Phegan
12fc928e1d Initial commit of Hyper-V disk_additional_size capability. Support a
maximum of 64 disks added to the SCSI controller.  Implement #4823.
2017-10-23 08:26:35 +11:00
SwampDragons
1563fb97c7 Merge pull request #5463 from atsushi-ishibashi/issue5323
Add clean_image_name for gcp
2017-10-20 14:16:11 -07:00
Megan Marsh
4721b48c70 add a couple of extra tests and reword documentation 2017-10-20 14:06:02 -07:00
Atsushi Ishibashi
c3a00993d0 Don't truncate and replace with 'a', update docs 2017-10-19 10:45:48 +09:00
Andrew Pryde
bb497c2453 Fixed incorrect test failure message in oci client 2017-10-18 11:11:14 +01:00
Chris Lundquist
c1a7b3845a [lxd] allow passing of publish properties 2017-10-18 04:57:13 +00:00
Atsushi Ishibashi
3e68f1c505 Change first and last character when it doesn't match 2017-10-18 11:10:19 +09:00
Aaron Browne
ffc63a8724 Use amazon common AccessConfig for ecr_login
Signed-off-by: Aaron Browne <aaron0browne@gmail.com>
2017-10-17 15:00:19 -04:00
Atsushi Ishibashi
210dd08326 Change args of NewConfig 2017-10-17 13:48:15 +09:00
Atsushi Ishibashi
5310d5629b Modify clean_image_name not defined error 2017-10-17 12:31:50 +09:00
Aaron Browne
8df643c343 Add aws_profile option to docker-push ecr_login
An aws_profile option is added to the AWS ECR login credentials
configuration to allow using shared AWS credentials stored in
a non-default profile.

Signed-off-by: Aaron Browne <aaron0browne@gmail.com>
2017-10-16 16:55:34 -04:00
Atsushi Ishibashi
3600924e59 Rename files 2017-10-17 04:55:50 +09:00
Atsushi Ishibashi
2da4e4c31d Change func name 2017-10-16 11:45:18 +09:00
Atsushi Ishibashi
caa6c9bf22 Add clean_ami_name for gcp 2017-10-16 00:53:18 +09:00
Matthew Hooker
454cb08896 Merge pull request #5336 from SLAZ666/keepregistered-ovf
Add option keep_registered to virtualbox-ovf builder
2017-10-13 17:45:07 -07:00
Olivier Bilodeau
820811675d vmware-iso builder: Logging on network errors on connection refused 2017-10-13 19:00:48 -04:00
Matthew Hooker
f617a678b1 Merge pull request #5422 from localghost/upload_owner_fix
Fix owner of files uploaded to docker container run as non-root.
2017-10-13 14:56:16 -07:00
SwampDragons
f3c33240fa Merge pull request #5444 from vijayinvites/packer-vhdx
Hyperv vmcx builder and allow vhd/vhdx instead of ISO
2017-10-13 11:53:27 -07:00
Matthew Hooker
f7e269945e
add cidr validation and rename option 2017-10-12 17:05:56 -07:00
Matthew Hooker
c74be87187 Merge pull request #5384 from dave2/sg-source-cidr
[WIP] Allow temporary security group to have source CIDR block explicit
2017-10-12 17:05:45 -07:00
Matthew Hooker
07b013945f
more consistent flag name 2017-10-12 16:38:18 -07:00
Matthew Hooker
106408f6be
add new disable_vnc option 2017-10-12 16:34:40 -07:00
nictrix
6a238a3ef3
add option to skip vnc phase and update docs 2017-10-12 16:28:27 -07:00
SwampDragons
512ac214b4 Merge pull request #5417 from smaato/master
Add ability to tag volumes on creation
2017-10-12 12:56:25 -07:00
Mark Meyer
dbb3c76032 Remove redundant step and its usage
StepTagEBSVolumes is no longer needed, since this functionality is now
taken over by StepRunSourceInstance and StepRunSpotInstance. So remove
this functionality from the codebase.
2017-10-12 21:40:21 +02:00
Vijaya Bhaskar Reddy Kondreddi
4f6a207441 go fmt 2017-10-11 22:10:39 +05:30
Matthew Hooker
2655cf7493 fix tests 2017-10-11 22:05:53 +05:30
Matthew Hooker
91d66fb67c use new method of building runner 2017-10-11 22:05:52 +05:30
Matthew Hooker
d8c6e6d4a4 remove duplicate line 2017-10-11 22:05:52 +05:30
Matthew Hooker
7978fd8ec0 make fmt 2017-10-11 22:05:52 +05:30
Taliesin Sisson
5f2c71f7d7 Floppy directories are provided by default with common.floppydrives 2017-10-11 22:05:52 +05:30
Taliesin Sisson
2fbe0b4a7f Don't try to mount vhd and vhdx files as dvd drive. Hard drives are mounted in the create vm step 2017-10-11 22:05:52 +05:30
Taliesin Sisson
628116f4c4 Test settings for clone from vm and import vmxc from path 2017-10-11 22:05:52 +05:30
Taliesin Sisson
8232759397 If vhd or vhdx extension is specified for ISOUrls, we want to use an existing hard drive which means that we don't need to specify hard drive size
Filepath.ext includes the dot
2017-10-11 22:05:51 +05:30
Taliesin Sisson
3d0ac529e0 use common floppy_config instead of builder specific one
Add tests for floppy files and comm
2017-10-11 22:05:51 +05:30
Taliesin Sisson
efa62e1550 Can specify an iso, vhd or vhdx for download. If it is a vhd or vhdx it is used as the hard drive for spinning up a new machine, importing an exported virtual machine or cloning a virtual machine.
Can import a virtual machine from a folder
Can clone an existing virtual machine
2017-10-11 22:05:45 +05:30
Taliesin Sisson
452fcbd9a1 Only attach dvd drive if there is one
Fix debug messages for cloning

Add hyperv-vmcx as a builder from command line
2017-10-11 21:42:32 +05:30
Taliesin Sisson
429e1bc3ad Adding an ISO is now optional for hyperv vmcx
Add documentation for hyperv vmcx
2017-10-11 21:42:32 +05:30
Taliesin Sisson
6fd7f0877d Initial check in to add a builder that can clone existing hyper v machines 2017-10-11 21:42:32 +05:30
localghost
5866d4ea24 Move container user inspect to StepConnectDocker. 2017-10-10 22:45:47 +02:00
Matthew Hooker
eb64920e80 Merge pull request #5206 from sandersaares/hyperv-second-temp-dir
(Hyper-V) Enable a separate directory to be used for temporary VHDs
2017-10-09 10:08:00 -07:00
Matthew Hooker
ae455bff99
add debugging help if ec2-upload-bundle fails 2017-10-05 17:33:07 -07:00
Matthew Hooker
2a326b5172
fix nil ptr exception 2017-10-05 16:34:13 -07:00
Megan Marsh
e8cabc1e83 implemented for LXD 2017-10-04 15:23:36 -07:00
Megan Marsh
93bddb3e65 implement directory fix for lxc file uploads 2017-10-04 13:35:15 -07:00
Mark Meyer
2661fd7869 Move building of spot instances into its own step 2017-10-04 12:38:21 +02:00
Megan Marsh
8452ca898c implemented for docker communicator 2017-10-03 17:06:33 -07:00
localghost
ba72021274 Fix owner of files uploaded to docker container run as non-root. 2017-10-03 21:49:26 +02:00
Mark Meyer
939b44b4fd Add logic to handle volumes of spot instances 2017-10-03 01:03:21 +02:00
Mark Meyer
cfd6b6fed5 Change EBS builder to do tag-on-creation
The EBS builder will now use the tag-on-creation pattern, so
that it's possible to restrict packer to only create volumes that are
properly tagged by using an AWS policy.
2017-10-03 00:13:02 +02:00
Andrew Pryde
f426ba4660 Do not override region in OCI builder
Only default the OCI builder region to us-phoenix-1 when no value is
present in the packer template and the OCI config file.

Fixes: #5401
2017-09-29 10:51:31 +01:00
Matthew Hooker
b3661c1f63
builder/docker: set user during exec.
Add `exec_user` option to control what user `docker exec` is run as.
2017-09-28 16:39:23 -07:00
Matthew Hooker
74bf75b71a Merge pull request #5388 from hashicorp/fix5386
cloudstack: check that template was created
2017-09-27 15:34:57 -07:00
Megan Marsh
201e8c05a0 add ami name to output 2017-09-26 16:04:40 -07:00
Matthew Hooker
b42c916f9a
cloudstack: check that template was created 2017-09-26 13:36:53 -07:00
Zanetti, David
8a8b51be97 Allow temporary security group to have source CIDR block explicitly provided 2017-09-26 00:57:56 +00:00
Matthew Hooker
02cd6bc7f0 Merge pull request #5288 from hashicorp/fix3114
add token variable to upload bundle command template
2017-09-25 18:36:28 -05:00
Matthew Hooker
4bc8e7de3d
add token variable to upload bundle command template 2017-09-25 16:35:53 -07:00
Matthew Hooker
eabcec6809 Merge pull request #5363 from batzen/patch-1
Fixes #4880 by always using EnableDynamicMemory
2017-09-25 18:14:30 -05:00
Zanetti, David
42dc1e4795 In Amazon builders, allow tag names to be interpolated like values 2017-09-25 02:24:23 +00:00
Bastian Schmidt
c1aba87b39 Fixes #4880 by always using EnableDynamicMemory
This was needed because the default in Hyper-V on Windows 10 changed from "false" to "true".
2017-09-20 14:53:37 +02:00
Peter Mounce
7cbd57faa6 Filling it back 2017-09-19 11:40:01 +01:00
Peter Mounce
15a456750b CI as compiler! 2017-09-19 11:34:08 +01:00
Peter Mounce
2239d55fdb Add test coverage 2017-09-19 11:31:05 +01:00
Peter Mounce
5bcb0644c3 Using CI for compilation errors because am on Windows 2017-09-18 18:13:21 +01:00
Peter Mounce
ac8eedf171 Introduce a new configuration parameter instead
... so that one can have a different list compared to instances.
2017-09-18 17:53:40 +01:00
Peter Mounce
e579b947b1 Fix signature that I missed 2017-09-18 17:34:06 +01:00
Peter Mounce
8789ae72e8 Make the googlecompute builder label the resulting image.
... so that it's possible to find images matching particular characteristics more easily.
2017-09-18 15:44:01 +01:00
SLAZ666
f6bb79784f Add option keep_registered to virtualbox-ovf builder 2017-09-13 15:37:26 +02:00
Matthew Hooker
392af507e0
builder/docker: respect rsync semantics when uploading directories. 2017-09-12 14:45:25 -07:00
Matthew Hooker
ab216ec61b
Add license with copyright notice 2017-09-12 12:22:50 -07:00
Andrew Pryde
6fd2f6701d
Rename Oracle BMCS builder to OCI
Oracle Bare Metal Cloud Services (BMCS) has been rebranded as Oracle
Cloud Infrastructure (OCI).
2017-09-12 10:40:56 -07:00
Matthew Hooker
624b1e5110 Merge pull request #4554 from prydie/f-oracle-bmcs
Oracle Bare Metal Cloud Services (BMCS) builder
2017-09-11 09:42:14 -07:00
Matthew Hooker
322422f235
remove copyright notice header and add COPYRIGHT file 2017-09-08 09:49:06 -07:00
Matthew Hooker
d4895156e5
remove copyright notice 2017-09-07 11:44:38 -07:00
Matthew Hooker
f7c85e36bc
add pkcs12 license 2017-09-07 11:40:14 -07:00
Matthew Hooker
57237c55e6 Merge pull request #5308 from pdecat/f-gce-instance-labels
Add support for setting labels on GCE instance
2017-09-06 14:59:40 -07:00
Matthew Hooker
3eeb722897 Merge pull request #5301 from hashicorp/pkcs12redux
Replace pkcs12 code with upstream
2017-09-06 10:52:11 -07:00
Megan Marsh
4d89ab3943 Merge pull request #5309 from hashicorp/pr/3523
Pr/3523
2017-09-06 09:27:58 -07:00
Patrick Decat
a7283f2281 Add support for setting labels on GCE instance 2017-09-06 10:58:08 +02:00
zhuzhih2017
1861a22c77 Merge pull request #5219 from zhuzhih2017/master
update alicloud go sdk and enable multi sites support for alicloud
2017-09-06 09:41:38 +08:00
Megan Marsh
8d24b3930a cleanup imports and rebase artifacts 2017-09-05 15:23:22 -07:00
Chris Lundquist
cd2a783382 [lxc] update to new conventions, improve docs 2017-09-05 15:19:25 -07:00
Chris Lundquist
5eb1bc9338 [lxc] go fmt our files 2017-09-05 15:18:07 -07:00
Chris Lundquist
9b4a7e935f [lxc] add basic tests 2017-09-05 15:18:07 -07:00
Chris Lundquist
2d19b4f2d2 Revert "[lxc] only build for linux. Ignore vim swp files."
This reverts commit 60409dc678.
2017-09-05 15:17:15 -07:00
Chris Lundquist
8b4e94d9c6 [lxc] remove commented code 2017-09-05 15:17:15 -07:00