upstream/packer
1
0
Fork 0
mirror of https://github.com/hashicorp/packer.git synced 2026-02-25 10:59:43 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 4
15357 commits 313 branches 141 tags 156 MiB
Commit graph

5388 commits

Author SHA1 Message Date
Lars Lehtonen
c6212731ff builder/vagrant: fix dropped errors in code and tests 2019-09-17 05:39:23 -07:00
Miles Crabill
2bff60bac8
address review feedback 2019-09-16 13:50:43 -07:00
Miles Crabill
328baced05
add some test cases for image names 2019-09-16 10:18:22 -07:00
Miles Crabill
c11a444f77
googlecompute: fail fast when image name is invalid, replace unusable characters w/ -'s 2019-09-16 10:10:41 -07:00
Lars Lehtonen
6c1ce2bd9a builder/openstack: Fix dropped error 2019-09-16 06:26:56 -07:00
Adrien Delorme
4d4bd38afa
Merge pull request #8087 from hashicorp/fix_8048 
add retry wrapper to query so it handles rate limiting
 2019-09-16 10:25:12 +02:00
William Bianchini
d022c2194a [cloudstack builder] Detach iso step 
Detach iso file after loading image to cache, allowing OS to boot from
volume ater the installation

Add eject iso check and wait timeout

Closes #7235
 2019-09-13 21:33:49 -03:00
Megan Marsh
a6e263adb6 don't fall for nil pointer dereference in account file 2019-09-13 16:37:19 -07:00
Megan Marsh
fc6a4fd5d8
Merge pull request #8021 from hashicorp/fix_7959 
[WIP] implement custom data type "trilean" (tri-state-boolean) to track boo…
 2019-09-13 14:42:27 -07:00
Megan Marsh
9503802814 adding ctx makes the cancel channel redundant 2019-09-13 14:32:13 -07:00
Megan Marsh
4b497006b3 add retry wrapper to query so it handles rate limiting 2019-09-13 14:32:13 -07:00
allinwait
171c2a9a07 add the floppy label option 2019-09-12 12:25:22 +00:00
Adrien Delorme
2e58b807de
Merge pull request #8096 from onematchfox/virtualbox-snapshot 
fix(virtualbox-vm) LoadSnapshots should succeed even if machine has no snapshots
 2019-09-12 13:18:46 +02:00
Adrien Delorme
1d0cf1db98
Merge pull request #8092 from milescrabill/fix-vagrant-builder-stepup 
vagrant builder: use GlobalID where provided, add test for `vagrant up` args generation
 2019-09-12 13:13:04 +02:00
Brian Fox
5b6dcb0c94 fix(virtualbox) LoadSnapshots should succeed even if VM has no snapshots 2019-09-12 10:51:12 +02:00
lonegunman
0de807cce0 make ucloud builder's base url configurable 2019-09-12 11:33:57 +08:00
Miles Crabill
e6d2a97e12
s/destory/destroy 2019-09-10 14:31:00 -07:00
Miles Crabill
7850bf8bc5
use GlobalID where provided, add test for vagrant up args generation 2019-09-10 10:46:16 -07:00
Gennady Lipenkov
524b822e11 Support GPU instances, allow set source image by name 
Signed-off-by: Gennady Lipenkov <xgen@yandex-team.ru>
 2019-09-10 17:52:42 +03:00
Adrien Delorme
597a3e323b Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config 2019-09-10 13:20:07 +02:00
Adrien Delorme
350aa54274 Update step_shutdown_test.go 
bump test duration
 2019-09-10 13:07:30 +02:00
Adrien Delorme
146b88ba1e Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config 2019-09-10 12:44:46 +02:00
Adrien Delorme
de9bb26f62
Merge branch 'master' into fix_7959 2019-09-10 12:21:33 +02:00
Adrien Delorme
e730e9f3ce
Merge pull request #8051 from DanHam/aws-vol-tags 
Add ability to set `run_volume_tags` for Amazon EBS Volume builder
 2019-09-10 12:04:58 +02:00
Calle Pettersson
b467bb22a3 Shorten default boot_key_interval to 5ms from 100ms 2019-09-09 22:33:48 +02:00
Adrien Delorme
dad3ae1535
Merge pull request #8084 from carlpett/check-disk-format-set 
builder/proxmox: Check that disk format is set when pool type requires it
 2019-09-09 10:33:50 +02:00
Adrien Delorme
78bfda582f
Merge pull request #8083 from carlpett/bump-proxmox-api-dep 
Bump proxmox api dep
 2019-09-09 10:33:18 +02:00
Calle Pettersson
10ad38fcbd Check that disk format is set when pool type requires it 2019-09-08 18:40:29 +02:00
Calle Pettersson
df41b56d9a Change MonitorCmd/sendkeys to Sendkey 2019-09-07 23:09:16 +02:00
Calle Pettersson
8c2c1a82cb Bump proxmox-api-go dependency 2019-09-07 23:07:45 +02:00
Adrien Delorme
a5b899770e
Merge pull request #8077 from marinsalinas/master 
Outscale Builder: Get SSH Host from VM.Nics insead VM's Root
 2019-09-05 15:40:23 +02:00
Marin Salinas
640612da92 refactor: get ssh hot from nics instead of root of the vm 2019-09-05 08:21:07 -05:00
Marin Salinas
793b3f1990 chore: remove unused code in omi config 2019-09-05 08:20:27 -05:00
Marin Salinas
7d024b9725 change ui message to private ip in run source vm 2019-09-05 08:19:58 -05:00
Calle Pettersson
0813c5bdb4 Check for StateCancelled 2019-09-04 23:03:25 +02:00
Adrien Delorme
c4c88d3768 debug template id 2019-09-04 14:29:45 +02:00
Adrien Delorme
d113dd12c1 fix panic in proxmox builder 2019-09-04 14:21:52 +02:00
Adrien Delorme
ba9ffcbf73 re-indent HWConfig struct comments 2019-09-03 17:35:29 +02:00
DanHam
bbeb1a3528
Delete any run_volume_tags applied to EBS volumes at instance creation 
* Allows `run_volume_tags` to be set without requiring a major rewrite
  of the (common) amazon builder code used to start an instance.
  The common start up code tags the instance and *all attached volumes
  at creation*. If `run_volume_tags` are set this means that any volumes
  specified in `ebs_volumes` will *initially* be tagged with the
  `run_volume_tags` rather than the tags set in the `ebs_volumes`
  section
* Once the instance is reported to be 'ready' the step to tag the EBS
  volumes is run. Once complete all volumes should have the tags
  requested by the user:

    * Volumes associated with the source instance should be tagged with
      the tags set in `run_volume_tags` (if any)
    * Each EBS volumes specified in the `ebs_volumes` section of the
      template should only be tagged with its associated tags (if any)
 2019-08-30 14:30:25 +01:00
DanHam
61b1605a85
More accurate error description; Add comments; Add output 2019-08-30 14:26:06 +01:00
DanHam
430d41fbf9
Add option to enable tagging of the running instances volumes 
* Currently this results in *all* volumes attached to the instance
  being tagged with the `run_volume_tags`. This includes any `ebs_volumes`
  for which the user may have configured other tags.
* This issue will be addressed in a later commit
 2019-08-30 14:16:29 +01:00
DanHam
30070ffb30
Sort fields and options alphabetically 2019-08-30 14:16:29 +01:00
Adrien Delorme
a841da960d Merge branch 'master' of ssh://github.com/hashicorp/packer into scrape_doc_to_builder_struct_config 2019-08-30 15:10:29 +02:00
Adrien Delorme
c475eb57ef
Merge pull request #8047 from hashicorp/avoid_panic_when_token_in_azure_builder 
azure builder: avoid a panic in getObjectIdFromToken
 2019-08-30 11:26:48 +02:00
Adrien Delorme
7d9798f5ee update AlicloudAccessConfig docs for SECURITY_TOKEN 
SecurityToken=>SECURITY_TOKEN
 2019-08-29 14:39:25 +02:00
Adrien Delorme
9f8e9893b3 Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config 2019-08-29 14:22:16 +02:00
Lars Lehtonen
b6eadb419a builder/qemu: Fix dropped error 2019-08-29 05:13:46 -07:00
Adrien Delorme
86cee5cbef
Merge pull request #8034 from cove/retry-describe-instances 
add AWS API call reties on AMI prevalidation
 2019-08-29 10:48:54 +02:00
Adrien Delorme
f11341c0b4 azure builder: avoid a panic in getObjectIdFromToken 2019-08-29 10:34:59 +02:00
cove
87e0a3b5e7 add prevalidating AMI name retries so the build doesn't fail when throttled 2019-08-27 18:00:08 -07:00
Adrien Delorme
9d0bc476d9 add ommited struct interpolation 
after dcc22df609
 2019-08-27 15:17:57 +02:00
Adrien Delorme
b3cdf2ac8f remove docs typo 2019-08-27 15:16:33 +02:00
Adrien Delorme
94bb33db57 fix triple backtick indentation 2019-08-27 13:37:28 +02:00
Adrien Delorme
d135106171 fix more docs 2019-08-27 09:50:43 +02:00
Adrien Delorme
f66ca58a46 Update azure docs for config.go 
add missing docs fields

Co-Authored-By: Megan Marsh <swampdragons@users.noreply.github.com>
 2019-08-27 09:32:03 +02:00
Adrien Delorme
783b02bd15 Update config.go 
add missing doc  fields

Co-Authored-By: Megan Marsh <swampdragons@users.noreply.github.com>
 2019-08-27 09:28:36 +02:00
Adrien Delorme
239f97471c fix ebs volume tags doc field 
Co-Authored-By: Megan Marsh <swampdragons@users.noreply.github.com>
 2019-08-27 09:21:29 +02:00
Adrien Delorme
5517d41468 make sure all documentation fields are there 
* add missing `temporary_key_pair_name` field for alicloud
* add missing description to `vpc_filter` for aws
* add missing ssh communicator fields for aws
* add links for aws
* update vmware-vmx docs
* manually describe AMI Configuration section for ebsvolume
* display missing required ami_name field for aws
* add missing fields for docker
* add missing fields for openstack
 2019-08-26 17:16:54 +02:00
Adrien Delorme
2db109d55b Merge branch 'master' into scrape_doc_to_builder_struct_config 2019-08-23 17:37:53 +02:00
Adrien Delorme
2efc94521b use trilean initializers in test where missing 2019-08-23 11:17:45 +02:00
Megan Marsh
6a895db9be converte block device encryption to trilean 2019-08-22 14:24:22 -07:00
Megan Marsh
1d9bba6fe3 change AMIEncryptBootVolume to trilean 2019-08-22 14:04:26 -07:00
Megan Marsh
f7c8321a7e convert alicloud s.IOOptimized into trilean in code 2019-08-22 13:59:38 -07:00
Megan Marsh
ecaec1ac58 swap out alicloud encryption *bools for trileans 2019-08-22 13:52:29 -07:00
Megan Marsh
1a6adadb89 convert EnableAMIENASupport to trilean in code 2019-08-22 13:18:22 -07:00
Megan Marsh
3c3f7f26ce implement custom data type "trilean" (tri-state-boolean) to track booleans which have a "null" or "unset" state. Previously we used *bool for these template options, but it turns out that those won't work because "unset" will evaluate to "false" if a user is using template variables to set the option that maps to a *bool. 2019-08-22 13:18:15 -07:00
Megan Marsh
04d9888657
Merge pull request #8016 from psinghal20/issue-8009 
fix: move adding metadata step after waiting for uploading step
 2019-08-22 11:24:37 -07:00
Pratyush Singhal
dbb50337bc
fix: out of scope blockStorageClient nil value issue 
Co-Authored-By: Adrien Delorme <azr@users.noreply.github.com>
 2019-08-22 20:50:46 +05:30
Megan Marsh
fcef7e2d85 this timeout regularly flakes on Travis, I suspect because the instances running the tests are brutally underpowered. Increase the fudge factor. 2019-08-21 16:36:42 -07:00
Adrien Delorme
4cb7c30987 Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config 2019-08-21 16:44:23 +02:00
psinghal20
bbd71136dc
fix: move adding metadata step after waiting for uploading step 
Signed-off-by: psinghal20 <psinghal20@gmail.com>
 2019-08-21 15:45:46 +05:30
Megan Marsh
17d9a85895
Merge pull request #7945 from ahilsend/hcloud-image-filter 
feat(builder/hcloud): allow selecting image based on filters
 2019-08-19 14:37:43 -07:00
Megan Marsh
b6fdccc2af
Merge pull request #7970 from williamb1024/master 
Decrease the delay between Hyper-V VM startup and hyper-v builder's ability to send keystrokes to the target VM.
 2019-08-19 14:37:10 -07:00
Megan Marsh
4aa33306cb make sure that fleetId exists before trying to stick it into error message 2019-08-19 13:44:39 -07:00
Megan Marsh
8dbd078738
Merge pull request #8011 from tmeckel/vbox-vm-target-snapshot-optional 
Fix: VirtualBox VM builder, target snapshot optional
 2019-08-19 13:29:06 -07:00
Megan Marsh
dd97435d42
Merge pull request #7957 from milescrabill/fix-vagrant-builder-basebox-sourcebox 
vagrant builder: fix provisioning boxes, define source and output boxes
 2019-08-19 13:25:54 -07:00
Thomas Meckel
01edafb49f Cleaned up golint warnings 2019-08-19 21:36:43 +02:00
Thomas Meckel
92501cd344 target_snapshot is not optional as described in the documentation 2019-08-19 21:36:43 +02:00
William L. Brooks
be4ca4b666 Move hyper-v host ip determination earlier in steps, connect to Hyper-V vm prior to issuing the start operation. 2019-08-19 11:45:41 -07:00
Megan Marsh
06bef2844b
Merge pull request #7996 from hashicorp/fix_7925 
dont bother with a targetpath for the vbox additions; use a hash like…
 2019-08-19 09:45:38 -07:00
Brian Fox
47c027e5c8 Remove check/requirement for target_snapshot 2019-08-19 11:25:17 +02:00
Megan Marsh
316a30b31d fix spot_tags 2019-08-15 16:06:16 -07:00
Megan Marsh
02399f32f6 dont bother with a targetpath for the vbox additions; use a hash like everything else 2019-08-15 15:10:25 -07:00
Megan Marsh
94d8da60f0
Merge pull request #7940 from jgeorgeson/openstack-winrmpassword-provisioners 
OpenStack builder store WinRM password for provisioners to use
 2019-08-15 12:02:26 -07:00
Megan Marsh
9f6d14c75a work around spot_tags related regression and bad fleet cleanup in spot instances 2019-08-14 11:08:59 -07:00
Andre Hilsendeger
cb1e30ef69 feat(builder/hcloud): allow selecting image based on filters 2019-08-13 08:40:47 +02:00
Megan Marsh
0eebebaedb
Merge pull request #7939 from hashicorp/fix_7938 
check container os, not host os, when creating container dir default
 2019-08-12 16:45:00 -07:00
xiaohan.liang
f4fc9dd09a Rewrite all files, remove sensitive information 2019-08-09 15:00:23 +08:00
Miles Crabill
ff157c8a6d
vagrant builder: define source box and output box in Vagrantfile 2019-08-07 10:11:34 -07:00
Justin Georgeson
c0ee859559 OpenStack builder store WinRM password for provisioners to use 2019-08-01 19:02:36 -05:00
Megan Marsh
c0e37e6045
Merge pull request #7780 from tmeckel/own-vbox-snapshot 
VirtualBox Snapshot Builder
 2019-08-01 15:31:15 -07:00
Megan Marsh
1952130030
Merge pull request #7920 from hashicorp/fix_7865 
[wip] fix polling issues in azure
 2019-08-01 12:40:11 -07:00
Megan Marsh
773e76c1ce remove unused import 2019-08-01 11:35:53 -07:00
Megan Marsh
b6f3742425 check container os, not host os, when creating container dir default 2019-08-01 11:31:21 -07:00
Megan Marsh
6a201211a9 fix polling issues in azure 
adds a configurable timeout to the shared image gallery publisher
 2019-08-01 11:18:03 -07:00
Mason, Elliot
ee484f2dd9 Updated public gcp cloud images 2019-07-31 11:38:35 -05:00
Megan Marsh
f97df6721e
Merge pull request #7927 from hashicorp/fix_googlecompute_crash_7921 
code changed recently so that sometimes the conf is nil.
 2019-07-30 09:55:09 -07:00
Megan Marsh
7c93a5c51e code changed recently so that sometimes the conf is nil. 2019-07-29 13:19:43 -07:00
Megan Marsh
b42701380c add test for nil case 2019-07-29 12:11:59 -07:00
DanHam
088151e51d
Type assertion safety - fix panic when key cannot be retrieved from statebag 2019-07-28 10:44:24 +01:00
Thomas Meckel
822b72bd14 Added force_delete_snapshot configuration item and the corresponding checks 2019-07-26 12:34:28 +02:00
Thomas Meckel
e7583de847 StepCreateSnapshot.Run() will stop and create an error if the virtual machine is still running 
Removed left over code from StepCreateSnapshot.Cleanup()
 2019-07-26 12:34:27 +02:00
Thomas Meckel
d9b8623f64 StepShutdown now always waits for the shutdown of the virtual machine to complete, not only if a shutdown command is specified 2019-07-26 12:34:27 +02:00
Thomas Meckel
b873876670 Added test TestSnapshot_EnsureParents 
No using asserts NotNil and Nil
 2019-07-26 12:34:27 +02:00
Thomas Meckel
6fd0b3e83e Fixed a bug in ParseSnapshotData 
Added fuction GetSnapshots
 2019-07-26 12:34:26 +02:00
Thomas Meckel
225a140055 Applied correct source format (got fmt) to builder\virtualbox\common\driver_mock.go 2019-07-26 12:34:26 +02:00
Thomas Meckel
51e5ae69db Corrected method signatures in builder\virtualbox\common\driver_mock.go 2019-07-26 12:34:26 +02:00
Thomas Meckel
ab6a163ff2 Added missing newline at end of builder\virtualbox\common\driver_mock.go 2019-07-26 12:34:25 +02:00
Thomas Meckel
e9b5332e99 Added missing functions to builder\virtualbox\common\driver_mock.go 2019-07-26 12:34:25 +02:00
Thomas Meckel
fd5a2db58f Removed commented (obsolete) code from builder\virtualbox\common\driver_4_2.go 2019-07-26 12:34:25 +02:00
Thomas Meckel
7d3c84e5f9 Changed VirtualBox VM builder according to current builder interface 2019-07-26 12:29:48 +02:00
Thomas Meckel
2ef911f6f0 Fixed bugs in snapshot and builder code 2019-07-26 12:29:47 +02:00
Thomas Meckel
ebd2780e5d implemented first unit tests for snapshot.go 2019-07-26 12:29:46 +02:00
Thomas Meckel
f1f7c4e10c * added function ParseSnapshotData to parse a string representation of a VBox snapshot tree 
* fixed bugs
 2019-07-26 12:29:46 +02:00
Thomas Meckel
45e2095ae3 Moved parsing of tree string representation to new function in snapshot.go 2019-07-26 12:29:45 +02:00
Thomas Meckel
092e32fe9e First version of reworked snapshot implementation 2019-07-26 12:29:45 +02:00
Thomas Meckel
a6074894f1 Defined struct and first function for enhanced snapshot handling 2019-07-26 12:29:45 +02:00
Thomas Meckel
d3202497ae First working version of virtualbox/vm builder 2019-07-26 12:29:44 +02:00
Thomas Meckel
2a531f8ad6 Merged changes from local branch 2019-07-26 12:29:44 +02:00
mingsheng.su
66f142adf1 update docs 2019-07-26 17:27:58 +08:00
mingsheng.su
59c8911cd5 update api about stop instance 2019-07-26 17:03:57 +08:00
Megan Marsh
d21f4eb888
Merge pull request #7908 from muesli/typo-fixes 
Fixed various typos
 2019-07-25 12:21:20 -07:00
Megan Marsh
3d22535742
Merge pull request #7884 from jprorama/fix-7171 
[WIP] Fix #7171: select instance network on which to assign floating ip
 2019-07-25 11:57:24 -07:00
Megan Marsh
166f1de5fd
Merge pull request #7887 from xunleii/f-scaleway-autoremove-volume 
Allow removing volume after image creation for Scaleway builder
 2019-07-25 11:56:23 -07:00
Christian Muehlhaeuser
216afbaa8b
Fixed various typos 
Just a bunch of nit-picky typo fixes.
 2019-07-25 06:49:51 +02:00
Megan Marsh
140785f088 make sure we create the temp dir explicitly when we are setting up the config dir in docker. Otherwise, we create it with root later on and it causes permissions failures. 2019-07-24 16:51:38 -07:00
Alexandre NICOLAIE
6835a12cb3
fix: fix typo in comment 
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
 2019-07-24 21:19:53 +02:00
Megan Marsh
54a7b4f377 update comments and docs 2019-07-22 11:54:42 -07:00
y-kuno
6305c555df Add openstack image min_disk option 2019-07-22 11:44:34 -07:00
Alexandre NICOLAIE
b010442e07 fix: delete volume only after snapshot step 
Signed-off-by: Alexandre NICOLAIE <alexandre.nicolaie@gmail.com>
 2019-07-21 10:42:34 +02:00
Alexandre NICOLAIE
39b8c0ecca feat: add 'remove volume' step to scaleway 
Signed-off-by: Alexandre NICOLAIE <alexandre.nicolaie@gmail.com>
 2019-07-18 23:19:48 +02:00
Megan Marsh
975ee377b2
Merge pull request #7792 from psinghal20/issue-7721 
set openstack image metadata with use_blockstorage_volume
 2019-07-18 11:58:01 -07:00
Marin Salinas
e634caee0a remove chroot acc test 2019-07-18 12:07:08 -05:00
Megan Marsh
e10b9fb708 fix ssh interface conflict 2019-07-18 09:47:15 -07:00
Marin Salinas
1424f1b564 fix: remove AWS references and unnecessary code 2019-07-18 09:39:08 -07:00
Marin Salinas
73cd148e80 refactor: change ebs_volume to bsu_volumeattribute in bsuvolume builder 2019-07-18 09:39:08 -07:00
Marin Salinas
7e23f14d4e fix: chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas
1b7c56f73d fix: change bad artifact validation in bsu builder 2019-07-18 09:39:08 -07:00
Marin Salinas
03f8b2ceb5 fix: change GlobalPermission to false in order to prevent public image creation 2019-07-18 09:39:08 -07:00
Marin Salinas
dc0db4b322 fix: change osc builder to be passed a context for cancellation and remove conflicts 2019-07-18 09:39:08 -07:00
Marin Salinas
2337703be6 fix: add missing secret key in http client configuration 2019-07-18 09:39:08 -07:00
Marin Salinas
ed2d2b9058 refactor: clean duplicate files with aws chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas
488535118d refactor: change validation when bsu is set 2019-07-18 09:39:08 -07:00
Marin Salinas
6820806436 refactor: add err check in create tags 2019-07-18 09:39:08 -07:00
Marin Salinas
17ee7b8163 fix: add missing secret key in http client configuration 2019-07-18 09:39:08 -07:00
Marin Salinas
f28c3877e3 refactor: remove unused attributes 2019-07-18 09:39:08 -07:00
Marin Salinas
590bef0969 chore: fix bad comments 2019-07-18 09:39:08 -07:00
Marin Salinas
04534d87ac chore: change templateCleanOMIName to templateCleanResourceName function 
:
 2019-07-18 09:39:08 -07:00
Marin Salinas
1811b3af52 chore: remove unused buildBlockDevice function 2019-07-18 09:39:08 -07:00
Marin Salinas
4b52816935 fix: go modules conflicts 2019-07-18 09:39:08 -07:00
Marin Salinas
35c7c6163c refactor: remove unnecessary fields and add default values 2019-07-18 09:39:08 -07:00
Marin Salinas
810e30e8e1 refactor: fix symlink issue on ubuntu 2019-07-18 09:39:08 -07:00
Marin Salinas
27528aeb68 test: fix test error in block_device 2019-07-18 09:39:08 -07:00
Marin Salinas
80dadaf3f1 feature: add bsuvolume builder and acceptance test 2019-07-18 09:39:08 -07:00
Marin Salinas
c9b8bc6b54 fix: typo in bsusurrogate acc test 2019-07-18 09:39:08 -07:00
Marin Salinas
8b8eb70e19 feature: add create tags to volume 2019-07-18 09:39:08 -07:00
Marin Salinas
db2832d80c fix: change name of dirs 2019-07-18 09:39:08 -07:00
Marin Salinas
683431afa2 fix acceptance test configuration 2019-07-18 09:39:08 -07:00
Marin Salinas
571ef828e6 fix: remove pointer when vm is getting 2019-07-18 09:39:08 -07:00
Marin Salinas
cf1fdfef00 fix: add missing keys when artifact is destroying 2019-07-18 09:39:08 -07:00
Marin Salinas
8a6faf1ad3 feature: add create tags for vm and volume 2019-07-18 09:39:08 -07:00
Marin Salinas
ff0336965b feature: add create tags function 2019-07-18 09:39:08 -07:00
Marin Salinas
987b4148e1 fix: remove pointer when gets vm from the state 2019-07-18 09:39:08 -07:00
Marin Salinas
9d6c4a8e5b feature: add remaining steps and and create artifact in chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas
70d2ff3d8a feature: add create omi step in chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas
6843b64331 feature: add eartly cleanup and snapshot steps in chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas
352972a33d feature: add chroot provision step in chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas
31367ff768 feature: add copy files step in chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas
07b1580003 feature: add mount extra step in chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas
b3d165e864 feature: add post mount commands step in chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas
6e6bdc4f42 feature: add mount device step in chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas
00ab0097de feature: add pre mount commands step for chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas
0f51ab5c08 feature: add early unflock step for chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas
b3310f65a6 feature: add link volume step for chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas
f1e5dafc71 fix: convert volume size to Gib before volume creation 2019-07-18 09:39:07 -07:00
Marin Salinas
b246bf7329 wip: add create_volume step in chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas
b7f8c6ad9d feature: add prepare device for chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas
bf2d66c4e6 feature: add file lock step for chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas
66cf27fe31 feature: add step check root device step in chrrot builder 2019-07-18 09:39:07 -07:00
Marin Salinas
bc907f0fd0 feature: add vm info step 2019-07-18 09:39:07 -07:00
Marin Salinas
a3b0c28bb6 test: add acceptance basic test for outscale chroot builder 2019-07-18 09:39:07 -07:00
Marin Salinas
e8ef12e41c test: fix unit test in block device security group and build info 2019-07-18 09:39:07 -07:00
Marin Salinas
2f87427fd4 feature: add chroot build prepare function implementation 2019-07-18 09:39:07 -07:00
Marin Salinas
0d5ce8b9b9 feature: add chroot build cancel function implementation 2019-07-18 09:39:07 -07:00
Marin Salinas
30d5b1f7c2 feature: add chroot builder configuration 2019-07-18 09:39:07 -07:00
Marin Salinas
0c47ee55e6 feature: add chroot builder structure 2019-07-18 09:39:07 -07:00
Marin Salinas
6e6e518095 fix: change image id on bsu acceptance test 2019-07-18 09:39:07 -07:00
Marin Salinas
52621a3dd2 chore: remove unencrypted work in log when image is creating 2019-07-18 09:39:07 -07:00
Marin Salinas
a4966d9823 add ExpectedRunDevice constant 2019-07-18 09:39:07 -07:00
Marin Salinas
c4e69d3169 wip: add bsu plugin acc testing 2019-07-18 09:39:07 -07:00
Marin Salinas
4779b028f1 feature: bsu, run implementation add artifact 2019-07-18 09:39:07 -07:00
Marin Salinas
972dcc2b25 feature: bsu, run implementation add steps after createOMI step 2019-07-18 09:39:07 -07:00
Marin Salinas
83c9a3d4c8 feature: bsu, run implementation add createOMI step 2019-07-18 09:39:07 -07:00
Marin Salinas
4847e79b8d feature: bsu, run implementation add steps before createOMI step 2019-07-18 09:39:07 -07:00
Marin Salinas
1c8e9a7dd8 feature: bsu, run implementation add step prevalidate 2019-07-18 09:39:07 -07:00
Marin Salinas
4c04df26fd feature: bsu, cancel function implementation 2019-07-18 09:39:07 -07:00
Marin Salinas
85d601dd81 feature: bsu, prepare function and test 2019-07-18 09:39:07 -07:00
Marin Salinas
91bdf5c212 feature: bsu, builder structure and test 2019-07-18 09:39:07 -07:00
Marin Salinas
d2d794f6dc fix: undefined variable correction 2019-07-18 09:39:07 -07:00
Marin Salinas
996ee89397 change amis to omis in artifact 2019-07-18 09:39:07 -07:00
Marin Salinas
ae444a3250 fix: change the debugKeyPath name in osc bsusurrogate builder 2019-07-18 09:39:07 -07:00
Marin Salinas
1c69d55a1f feature: bsusurrogate, run implementation add artifact 2019-07-18 09:39:07 -07:00
Marin Salinas
3bcebc1af6 feature: bsusurrogate, add CreateTags step 2019-07-18 09:39:07 -07:00
Marin Salinas
2c4b2b8657 feature: bsusurrogate, add StepUpdateOMIAttributes step 2019-07-18 09:39:07 -07:00
Marin Salinas
b46636a39b feature: bsusurrogate, add RegisterOMI step 2019-07-18 09:39:07 -07:00
Marin Salinas
9c63f4cd92 feature: bsusurrogate, add DeregisterOMI step 2019-07-18 09:39:07 -07:00
Marin Salinas
871df8be85 feature: bsusurrogate, add StepUpdateBSUBackedVm and StepSnapshotVolumes step 2019-07-18 09:39:07 -07:00
Marin Salinas
09b899bb84 fix: change name to keypair key path file 2019-07-18 09:39:07 -07:00
Marin Salinas
52962f2355 feature: bsusurrogate, add stop bsu backed vm step 2019-07-18 09:39:07 -07:00
Marin Salinas
3ed7c7ff33 feature: bsusurrogate, add provision and cleanup temp keys step 2019-07-18 09:39:07 -07:00
Marin Salinas
957bdae441 feature: bsusurrogate, add clean connect step 2019-07-18 09:39:07 -07:00
Marin Salinas
b0c4784b96 feature: bsusurrogate, add clean get password step 2019-07-18 09:39:07 -07:00
Marin Salinas
1df7f15f53 fix: namming in step keypair 2019-07-18 09:39:07 -07:00
Marin Salinas
7ef09bba13 feature: bsusurrogate, add clean volumes and run source vm step 2019-07-18 09:39:07 -07:00
Marin Salinas
5ef3e81234 feature: bsusurrogate, add security group step 2019-07-18 09:39:07 -07:00
Marin Salinas
cef9a4b9fd feature: bsusurrogate, add network info step 2019-07-18 09:39:07 -07:00
Marin Salinas
c24ee2c9ca feature: bsusurrogate, add keypair step 2019-07-18 09:39:07 -07:00
Marin Salinas
e4405a0c02 feature: bsusurrogate, add Source network Info step 2019-07-18 09:39:07 -07:00
Marin Salinas
fdd3b594b9 fix: add function to validate if image name exists 2019-07-18 09:39:07 -07:00
Marin Salinas
33d1671e4c feature: bsusurrogate, add Source OMI Info step 2019-07-18 09:39:07 -07:00
Marin Salinas
3d8b0e5228 fix: change logs in omi config 2019-07-18 09:39:07 -07:00
Marin Salinas
1281f28f6d add prevalidate step 2019-07-18 09:39:07 -07:00
Marin Salinas
de973fba0e chore: add Bsusurrogate Run function skeleton 2019-07-18 09:39:07 -07:00
Marin Salinas
ca8ab3b5b0 feature: implement Prepare function in bsusurrogate builder 2019-07-18 09:39:07 -07:00
Marin Salinas
24d1d886f8 feature: add root volume run tags config to bsusurrogate config struct 2019-07-18 09:39:07 -07:00
Marin Salinas
837aada415 feature: add root block device config to bsusurrogate config struct 2019-07-18 09:39:07 -07:00
Marin Salinas
f6372e8ac6 feature: add omi config to bsusurrogate config struct 2019-07-18 09:39:07 -07:00
Marin Salinas
bb848366b6 feature: add block devices config to bsusurrogate config struct 2019-07-18 09:39:07 -07:00
Marin Salinas
be36a2159e feature: add run config to bsusurrogate config struct 2019-07-18 09:39:07 -07:00
Marin Salinas
1c3939fcd3 add access config to bsusurrogate config struct 2019-07-18 09:39:07 -07:00
Marin Salinas
c1fc2801ef add access_config struct and test 2019-07-18 09:39:07 -07:00
Marin Salinas
c29816f496 chore: add bsusurrogate builder structure 2019-07-18 09:39:07 -07:00
Megan Marsh
e658a50880 refactored step_ami_region_copy to fix bugs and clarify assumptions; added more tests for that step. 
fix race condition caused by variable declaration outside of loop
 2019-07-18 09:39:06 -07:00
Megan Marsh
42f7cbc30b add code to deduplicate the region list, and to make sure that the original region's kms key id is in the map. 2019-07-18 09:39:06 -07:00
John-Paul Robinson
038e9f316c Clean patch formatting with make fmt 2019-07-17 17:10:52 -05:00
John-Paul Robinson
5fe9f3980d Fix #7171: select instance network on which to assign floating ip 
Add config parameter instance_floating_ip_net to control
floating ip assignment for a multi-homed instances.  This ensures
the floating ip can be correctly assigned to the instance port
that is connected to the preferred network for floating ip assignment.

This avoids the default first-returned selection method which may
choose a network to which floating ip's can't be assigned,
e.g. because that network is not reachable from the floating ip
network.
 2019-07-17 17:00:28 -05:00
Megan Marsh
6b1a407e2a
Merge pull request #7870 from hashicorp/fix_7673 
Fix bugs in region encryption, copy, skipping logic
 2019-07-17 14:07:37 -07:00
Megan Marsh
54d2ad5028 refactored step_ami_region_copy to fix bugs and clarify assumptions; added more tests for that step. 
fix race condition caused by variable declaration outside of loop
 2019-07-17 11:30:20 -07:00
Megan Marsh
2d02ea209d
Merge pull request #7836 from 70k10/vncpassword 
QEMU builder - implement VNC password functionality
 2019-07-16 16:37:49 -07:00
Jayson Cofell
7f5fd4851e QEMU: Remove QMPEnable and depend upon VNC password usage for QMP enablement. 2019-07-16 08:56:22 -06:00
Vladislav Rassokhin
991cf22504 Prevent endless reading of closed file in vmware plugin 2019-07-16 16:02:57 +03:00
Megan Marsh
39a4da4d07 add code to deduplicate the region list, and to make sure that the original region's kms key id is in the map. 2019-07-11 16:56:40 -07:00
Jayson Cofell
4b0a7b0af7 Fix QEMU fmt miss 2019-07-10 13:12:31 -06:00
Jayson Cofell
f1ad385669 Change QMP socket test to join with filepath 2019-07-10 12:55:44 -06:00
Megan Marsh
327cd67557 fix tests 2019-07-09 15:42:48 -07:00
Megan Marsh
4a9d42b78f use box_name instead of source_path when generating vagrant file 2019-07-09 15:26:04 -07:00
Megan Marsh
a87ce366b3
Merge pull request #7835 from hashicorp/google_oauth 
replace some bespoke google auth code with code from golang's oauth2 …
 2019-07-08 09:48:27 -07:00
Megan Marsh
8315da6a12
Merge pull request #7837 from amydutta/master 
Fix bug while publishing SIG destination id for every managed image
 2019-07-08 09:41:14 -07:00
Megan Marsh
7d48eab11e
Merge pull request #7841 from hbdgr/digitalocean_timeout 
builder/digitalocean: increase timeout for Digital Ocean snapshot creation.
 2019-07-08 09:40:14 -07:00
hbdgr
6a8f45123a test for snapshotTimeout option 2019-07-04 16:28:09 +02:00
hbdgr
7d723b7c7b builder/digitalocean: add snapshotTimeout option 2019-07-04 16:25:42 +02:00
hbdgr
750e4b0f31 builder/digitalocean: increase timeout for waitForActionState 2019-07-04 09:55:13 +02:00
Li Kexian
b4e70cc0ec fixed tencentcloud builder error strings 2019-07-04 12:15:31 +08:00
Amrita Dutta
4c09dfde87 Fix bug while publishing SIG destination id for every managed image 2019-07-04 00:44:05 +00:00
Jayson Cofell
5c5943b8ba Add VNC Password support to QEMU builder 2019-07-03 18:38:56 -06:00
Jayson Cofell
afe9ba2869 QEMU: Initial QMP support 2019-07-03 18:33:59 -06:00
Megan Marsh
ba66d5d857
Merge pull request #7831 from hashicorp/fix_ssh_interface 
Revert "move SSHInterface/SSHIPVersion fields to communitator.Config …
 2019-07-03 16:23:00 -07:00
Megan Marsh
617fd18255 supply complete dummy data for googlecompute tests 2019-07-03 15:58:08 -07:00
Megan Marsh
0dfb3cc56f replace some bespoke google auth code with code from golang's oauth2 library 2019-07-03 14:27:33 -07:00
Megan Marsh
242f5b1c9f typos 2019-07-03 13:34:23 -07:00
Megan Marsh
c03c3f4410 replace duplicate commHost functions with a single communicator helper that checks for ssh_host and does a statebag lookup for a given key 2019-07-03 13:30:29 -07:00
Megan Marsh
0cfe8e7070 allow ssh_host override for OpenStack 2019-07-02 14:00:51 -07:00
Megan Marsh
eb8c74bf85 allow ssh_host config option to override host logic for all builders 2019-07-02 13:56:28 -07:00
Megan Marsh
ad8a88e366 allow ssh_host to override the host ip gathered from the instance for GCP builder 2019-07-02 13:01:41 -07:00
Megan Marsh
6ad975f296 Revert "move SSHInterface/SSHIPVersion fields to communitator.Config struct" 
This reverts commit b0c09087a2.
 2019-07-02 10:46:10 -07:00
Megan Marsh
62120c5c0b
Merge pull request #7813 from hashicorp/stop_calculating_spot_bids 
stop calculating spot bids
 2019-07-02 10:35:45 -07:00
Megan Marsh
d4b6a61445 don't store names of volumes we will be deleting when the instance terminates 2019-07-01 14:44:17 -07:00
Megan Marsh
486bdcce9d
Merge pull request #7815 from zqfan/tencent-data-disks 
feature: support data disks for tencentcloud builder
 2019-07-01 13:39:11 -07:00
Megan Marsh
42611e6004 fix build 2019-07-01 13:03:33 -07:00
Megan Marsh
a60f7e395e add a test to make sure we don't error becaue of spot price auto product, yet 2019-07-01 13:01:41 -07:00
Megan Marsh
c722afe707 stop calculating spot bids; amazon changed the way spot instances are priced to be stable rather than bid-based, so when user sets auto, we can just default to the ondemand price and know that they'll get the same price as everyone else bidding at that time. 2019-07-01 13:01:41 -07:00
Megan Marsh
1678d66e31
Merge pull request #7818 from StileEducation/master 
Allow EC2 Spot Fleet packer instances to run in parallel
 2019-07-01 09:47:40 -07:00
Pratyush singhal
6c8421e802 fix: fix volumes.Delete method call 
Signed-off-by: Pratyush singhal <psinghal20@gmail.com>
 2019-07-01 12:56:00 +05:30
Pratyush singhal
cf8bfa56f0 fix: set openstack image metadata with use_blockstorage_volume 
Signed-off-by: Pratyush singhal <psinghal20@gmail.com>
 2019-07-01 12:56:00 +05:30
Daniel Rodgers-Pryor
8a9753032c Allow EC2 fleet packer instances to run in parallel 
Without conflicting over the name of the launch template that they create/delete.

Previously, the launch template name was just hard coded to `packer-fleet-launch-template`, but since AWS enforces unique template names within an account, this caused simultaneously running packer instances to hit template-already-exists errors when creating their templates and race-conditions around deleting the template. Now, the template name is randomly generated on each run, so there should be no conflicts.
 2019-06-30 16:19:35 +10:00
ZhiQiang Fan
7235a4a775 feature: support data disks for tencentcloud builder 
Data disk is an important feature for instances and images, this
patch implements the basic functionality of it. More work needs
to be done to make it friendly to users. Docs has pointed out
current limitation.

Also update dependencies because this feature requires new code in
tencentcloud go sdk.
 2019-06-30 00:05:38 +08:00
Megan Marsh
8d5ecb9514 fix bug where ReadAll on the stderr pipe was causing an infinite hang because there was no stderr to report 2019-06-28 16:23:28 -07:00
Megan Marsh
9dd871120a
Merge pull request #7810 from zqfan/tencent-add-run-tags 
feature: add run_tags to instance in tencentcloud builder
 2019-06-28 14:39:52 -07:00
Megan Marsh
1d1ff4ebc9
Merge pull request #7775 from shawnmssu/feature/ucloud_builder 
Packer plugin support UCloud
 2019-06-28 10:28:37 -07:00
ZhiQiang Fan
310a40f8fe feature: add run_tags to instance in tencentcloud builder 
Instance tags are useful, our customer asks us to support it in packer as
well, to enable them to identify the purpose of the instance, even the
instance runs in a very short time.
 2019-06-28 23:18:41 +08:00
mingsheng.su
d3414e31e4
Update builder/ucloud/uhost/step_create_instance.go 
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
 2019-06-28 12:05:23 +08:00
mingsheng.su
591f2833b8
Update builder/ucloud/uhost/step_create_instance.go 
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
 2019-06-28 12:04:55 +08:00
mingsheng.su
0679f64689
Update builder/ucloud/uhost/step_copy_image.go 
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
 2019-06-28 12:04:36 +08:00
mingsheng.su
33d9e1ca49
Update builder/ucloud/uhost/step_copy_image.go 
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
 2019-06-28 12:03:11 +08:00
mingsheng.su
c8a9447aa4
Update builder/ucloud/uhost/step_create_image.go 
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
 2019-06-28 12:02:56 +08:00
mingsheng.su
4dfb338915
Update builder/ucloud/uhost/step_config_vpc.go 
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
 2019-06-28 12:02:45 +08:00
mingsheng.su
71fcc9fce3
Update builder/ucloud/uhost/step_config_subnet.go 
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
 2019-06-28 12:02:24 +08:00
mingsheng.su
7fdd72d418
Update builder/ucloud/uhost/step_config_security_group.go 
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
 2019-06-28 12:02:03 +08:00
mingsheng.su
a44df3d899
Update builder/ucloud/uhost/step_config_security_group.go 
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
 2019-06-28 12:01:47 +08:00
mingsheng.su
e9e5493fd1
Update builder/ucloud/uhost/step_check_source_image.go 
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
 2019-06-28 12:01:26 +08:00
Megan Marsh
350894200e
Merge pull request #7786 from zqfan/tencent-rm-img-name-limit 
remove image name check in tencentcloud builder
 2019-06-26 14:22:50 -07:00
Megan Marsh
b565075813
Merge pull request #7791 from 70k10/qemuadddisks 
Add additional disk support for QEMU builder.
 2019-06-26 12:47:05 -07:00
mingsheng.su
6109ad79a3
Merge branch 'master' into feature/ucloud_builder 2019-06-26 10:09:28 +08:00
Megan Marsh
bed0938b6c
Merge pull request #7782 from hashicorp/fix_7758 
Allow user to override vagrant ssh-config details
 2019-06-25 09:18:24 -07:00
Megan Marsh
8bca6b7cba
Merge pull request #7785 from dhirschfeld/patch-1 
Set MaxRamSize to 64GB
 2019-06-25 09:17:40 -07:00
Jayson Cofell
e690cb90ce Go fmt AdditionalDiskSizes code 2019-06-24 18:36:01 -06:00
Jayson Cofell
37e15ec854 Add AdditionalDiskSizes test 2019-06-24 18:11:14 -06:00
Dave Hirschfeld
2a284dffa0
Bump MaxRamSize to 1TB 2019-06-25 09:39:27 +10:00
Jayson Cofell
c9b693080a Add additional disk support for QEMU builder. 2019-06-24 17:35:06 -06:00
Megan Marsh
3a55437f4e
Merge pull request #7790 from hashicorp/fix_7748 
clarify pathing requirements for hyperv-vmcx
 2019-06-24 11:36:49 -07:00
Megan Marsh
6ead0493d9
Merge pull request #7787 from zqfan/tencent-fix-tmp-keypair 
fix: correctly remove tencentcloud temporary keypair
 2019-06-24 11:21:30 -07:00
Megan Marsh
29bff0975f clarify pathing requirements for hyperv-vmcx 2019-06-24 10:56:32 -07:00
Megan Marsh
1eef03c36b
Merge pull request #7778 from amydutta/master 
Publish Managed Images to Azure Shared Image Gallery (same Subscription)
 2019-06-24 10:43:00 -07:00
Amrita Dutta
78be7ab4e4 fix typo 2019-06-24 16:57:07 +00:00
ZhiQiang Fan
1c7b23357d fix: correctly remove tencentcloud temporary keypair 
Tencent Cloud key pair cannot be removed if it is in a image, so
when user doesn't specify any log in method, such as ssh_password,
temporary key pair will be created and used, which eventually will
always fail.

This patch detach temporary key pair before creating image, so in
cleanup step, it can be deleted correctly.

Note that if user specifies a private key pair, we do not detach it,
because user might want to use it when creating new instances from this
image.
 2019-06-23 23:23:48 +08:00
ZhiQiang Fan
20315155a9 remove image name check in tencentcloud builder 
Spinnaker uses packer to create images, but tencentcloud builder
has name check to forbidden special characters such as dot(.) while
it is absolutely valid in API side.

This patch simply removes this limitation.
 2019-06-23 20:32:13 +08:00
Dave Hirschfeld
96a3ef1465
Set MaxRamSize to 64GB 
Fixes #7784
 2019-06-22 19:47:16 +10:00
Megan Marsh
06a0db9350 allow user to override vagrant authentication by setting ssh_username and ssh_password. 2019-06-21 16:27:34 -07:00
Amrita Dutta
ba76d86cab remove comment 2019-06-21 03:51:44 +00:00
Amrita Dutta
e96458e8bd Merge branch 'master' of https://github.com/amydutta/packer 2019-06-21 03:43:31 +00:00
Amrita Dutta
85036231c4 Final commit 2019-06-21 02:47:39 +00:00
Adrien Delorme
67d96d5103 openstack: document using partials from struct conf 2019-06-20 15:28:27 +02:00
Adrien Delorme
4a61dc3670 vmware: document using partials 2019-06-20 15:28:27 +02:00
mingsheng.su
95611695b1 update builder_test && make generate 2019-06-20 18:07:56 +08:00
Adrien Delorme
74f0d56cfc virtualbox merge vbpx manage configs 2019-06-19 17:07:23 +02:00
Adrien Delorme
01eff9472a virtualbox: merge ExportOpts and ExportConfig structs 2019-06-19 16:35:15 +02:00
mingsheng.su
7804a52dd2 ucloud packer review 2019-06-19 21:32:33 +08:00
Adrien Delorme
02421bad33 simplify BlockDevice prepares 2019-06-19 12:15:18 +02:00
Adrien Delorme
433c40d72d make block device example less specific 2019-06-19 12:10:08 +02:00
Adrien Delorme
8cea5d409a doc ebsvolume builder using partials 2019-06-19 12:02:12 +02:00
Adrien Delorme
4c1abf828c
Merge branch 'master' into scrape_doc_to_builder_struct_config 2019-06-19 11:21:06 +02:00
Adrien Delorme
aeb898d598 document amazon-instance builder with partials 2019-06-19 11:09:00 +02:00
Amrita Dutta
78f001431e add example config file 2019-06-19 07:18:08 +00:00
Amrita Dutta
994dca5f78 fix bug in step_publish w.r.t managed image RG 2019-06-19 06:53:20 +00:00
Amrita Dutta
963336d421 Remove un-intended import 2019-06-19 06:42:55 +00:00
Amrita Dutta
76dbf4fb3b Remove subscription id from SIG destination input 2019-06-19 06:10:18 +00:00
Amrita Dutta
1d6de7167f Another update to replication logic 2019-06-18 23:51:10 +00:00
Amrita Dutta
de591cff77 Fix append in builder.go 2019-06-18 23:48:38 +00:00
Amrita Dutta
f7e08a097a Replication region changes 2019-06-18 23:41:14 +00:00
Adrien Delorme
c54879717b document ebssurrogate with partials 2019-06-18 18:00:49 +02:00
Adrien Delorme
9f4c8fb321 document ebs builder using partials 2019-06-18 17:41:50 +02:00
Adrien Delorme
a476ab79d7 document chroot builder using partials 2019-06-18 17:26:36 +02:00
Adrien Delorme
dcc22df609 aws: move the OmitFromArtifact field in ebssurrogat where it's being used 
also, simplified a bit the usage of block device
 2019-06-18 16:04:12 +02:00
Adrien Delorme
a86aae1c7e mode KmsKeyId to chroot block device, as it's only used there 2019-06-18 15:25:17 +02:00
Adrien Delorme
9989845ada add BuildEC2BlockDeviceMapping func to the BlockDevice type 2019-06-18 15:07:03 +02:00
Adrien Delorme
c696878d2e aws block devices mapping: BlockDevices.Build -> BuildEC2BlockDeviceMappings() 2019-06-18 12:44:24 +02:00
Adrien Delorme
ff2e0298ba simplify block devices utilisation by removing intermediary types 2019-06-18 12:37:47 +02:00
mingsheng.su
d1b9ad90c8 Merge remote-tracking branch 'origin' into feature/ucloud_builder 2019-06-18 18:17:19 +08:00
Adrien Delorme
78b29d1a74 up AMIBlockDevices docs 2019-06-18 11:55:12 +02:00
Amrita Dutta
c9cdb34589 Update validation logic for missing replication region 2019-06-18 06:39:43 +00:00
Amrita Dutta
f1f93f0665 normalize replication regions 2019-06-18 06:01:22 +00:00
Amrita Dutta
59a0f7f6e6 add validation checks for replication regions + formatting 2019-06-18 05:34:26 +00:00
Amrita Dutta
d13b9574d6 Use user - provided version number instead of generating timestamp on our own 2019-06-17 22:54:37 +00:00
Megan Marsh
305592d8ed fix copy logic and tests 2019-06-17 15:38:28 -07:00
Amrita Dutta
34dac69112 pass subscription id via state bag 2019-06-17 22:08:10 +00:00
Megan Marsh
8cc82ca8d2 add broken test 2019-06-17 15:04:19 -07:00
Megan Marsh
0d55bc46ee add skip_save_build_region flag to fix naming conflicts when building for multiple regions 2019-06-17 14:39:11 -07:00
Amrita Dutta
540c904fd4 add missing check to not publish to SIG if config.SharedGalleryDestination.SigDestinationGalleryName is null 2019-06-17 19:13:03 +00:00
Adrien Delorme
9b75c0af3d WIP VB 2019-06-17 16:42:49 +02:00
Ubuntu
6504d3ae5c Changes to ARM builder for publishing to SIG 2019-06-14 21:54:27 +00:00
Julien Brochet
ab52c4f87e fix(promox): update proxmox-api-go dependency 2019-06-14 20:42:09 +02:00
Megan Marsh
8d25cc578f
Merge pull request #7746 from hashicorp/fix_7671 
Abort hyperv build if there's a name collision
 2019-06-14 10:58:22 -07:00
Adrien Delorme
7a60990825 alicloud: use partials 2019-06-14 15:56:05 +02:00
Adrien Delorme
daa9f9d34e Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config 2019-06-14 15:17:56 +02:00
Adrien Delorme
c11ef90cb6 use interpolate.NewContext() instead of testConfigTemplate(t) 
because it's what's happenning there
 2019-06-14 12:17:28 +02:00
Adrien Delorme
2dc300c02e hyperv-iso: use partial docs 2019-06-14 12:17:28 +02:00
Adrien Delorme
926c8bbaa6 refactor ShutdownConfig into a single struct 2019-06-14 12:17:28 +02:00
Adrien Delorme
cfda61b81f
Merge pull request #7747 from chhaj5236/bugfix/refine_io_optimize 
let product API determine the default value of io_optimized
 2019-06-14 11:58:03 +02:00
Adrien Delorme
76f50619b1 builder/qemu/builder.go: Document from Config file 2019-06-14 11:52:38 +02:00
mingsheng.su
787485f66f add validate project_id 2019-06-14 14:50:46 +08:00
bozhi.ch
b3277698f6 let product API determine the default value of io_optimized 2019-06-14 11:49:42 +08:00
Megan Marsh
daddb65da8 add tests 2019-06-13 14:29:22 -07:00
Megan Marsh
2e821da84b check to make sure a vm-name isn't already in use before trying to launch a vm with said name. 2019-06-13 14:09:45 -07:00
Megan Marsh
1c3b234b55
Merge pull request #7737 from hashicorp/document_retry 
retry.Backoff: document
 2019-06-13 10:54:08 -07:00
mingsheng.su
9798c86a0d update string to const 2019-06-13 20:17:08 +08:00
mingsheng.su
156d31f933 update acc test 2019-06-13 18:38:07 +08:00
mingsheng.su
c8bab9b382 add ucloud packer 2019-06-13 15:16:49 +08:00
bozhi.ch
6a5db1e948 cleanup image and snapshot if target image is still not available after timeout 2019-06-13 11:17:39 +08:00
Adrien Delorme
a3e3c313a9 docs: use partials in googlecompute after master merge 2019-06-12 15:18:39 +02:00
Adrien Delorme
6e3dc1aa9a Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config 2019-06-12 14:28:11 +02:00
Adrien Delorme
632e42eb88
Merge pull request #7720 from psinghal20/issue-6617 
Add feature to import user-data from a file
 2019-06-12 11:06:33 +02:00
Pratyush singhal
92af5847a7 refactor: replace *packer.MultiError from type signature of createInstanceMetadata with generic error interface 
Signed-off-by: Pratyush singhal <psinghal20@gmail.com>
 2019-06-11 21:01:26 +05:30
Adrien Delorme
0a74a6ae10
Merge pull request #7734 from yandex-cloud/yandex-cloud-builder-2 
graceful shutdown instance, metadata from file and preemptible instance type
 2019-06-11 17:23:42 +02:00
Pratyush singhal
6ce6bd8ad3 refactor: add multiError in createInstanceMetadata method to capture multiple errors 
Signed-off-by: Pratyush singhal <psinghal20@gmail.com>
 2019-06-11 20:09:14 +05:30
Gennady Lipenkov
9c7e6a0aec fix test 2019-06-11 17:04:51 +03:00
Pratyush singhal
4a369b4ef1 chore: add test for MetadataFiles option 
Signed-off-by: Pratyush singhal <psinghal20@gmail.com>
 2019-06-11 17:45:30 +05:30
Pratyush singhal
99a3e9cf0a chore: update tests for createInstaceMetadata 
Signed-off-by: Pratyush singhal <psinghal20@gmail.com>
 2019-06-11 16:47:16 +05:30
Pratyush singhal
529dff0abb refactor: add error handling in createInstanceMetadata method 
Signed-off-by: Pratyush singhal <psinghal20@gmail.com>
 2019-06-11 16:36:16 +05:30
Adrien Delorme
98206d59d7 aws: step_create_tags make the max waiting time 30s and not 30ns 2019-06-11 12:37:52 +02:00
Adrien Delorme
ac03fddfe5
Merge pull request #7731 from psinghal20/issue-7636 
add retry for temp key-pair generation in amazon-ebs
 2019-06-11 12:35:32 +02:00
Pratyush Singhal
d92e82c43f refactor: replace the maxBackoff from 30 nanosecond to 30 seconds 
Co-Authored-By: Adrien Delorme <azr@users.noreply.github.com>
 2019-06-11 16:01:03 +05:30
Gennady Lipenkov
87b44a5879 Bulk fixes and enhancements 
1) graceful shutdown instance
2) support metadata from file
3) support preemptible instance
 2019-06-11 12:28:37 +03:00
bozhi.ch
45249fc764 fix describing snapshots issue when image_ignore_data_disks is provided 2019-06-11 15:22:06 +08:00
Pratyush singhal
d4b0cb68e3 feat: add retry for temp key-pair generation in amazon-ebs 
Signed-off-by: Pratyush singhal <psinghal20@gmail.com>
 2019-06-10 22:45:02 +05:30
Ubuntu
fb9fd58dfb Imports for publishing to SIG 2019-06-07 20:47:37 +00:00
Ubuntu
bf075d20c3 Merge branch 'master' of https://github.com/amydutta/packer 2019-06-06 23:37:55 +00:00
Adrien Delorme
696fce9739 docker: rewrap struct comments for documentation generation 2019-06-06 17:34:17 +02:00
Adrien Delorme
d81ca5728d azure-arm: rewrap struct comments for documentation generation 2019-06-06 17:34:17 +02:00
Adrien Delorme
8e857d64f1 aws: rewrap struct comments for documentation generation 2019-06-06 17:34:17 +02:00
Adrien Delorme
4bf6a56d71 split communitacor.SSH & communitacor.WinRM to facilitate documentation 
put doc for communicator into the struct
 2019-06-06 16:55:24 +02:00
Adrien Delorme
4399684372 make fmt autogenerated docs 2019-06-06 16:29:25 +02:00
Adrien Delorme
8488176dae vagrant/builder.Config rewrap docs 2019-06-06 16:21:21 +02:00
Pratyush singhal
1e1af35341 refactor: replace userdata_files with generic metadata_files map 
Signed-off-by: Pratyush singhal <psinghal20@gmail.com>
 2019-06-06 16:14:57 +05:30
Pratyush singhal
3845186c4c feat: add feature to import user-data from a file 
Signed-off-by: Pratyush singhal <psinghal20@gmail.com>
 2019-06-06 11:28:59 +05:30
Adrien Delorme
e09f3fbd02 amazon: update docs & links 2019-06-05 16:42:18 +02:00
Adrien Delorme
e6cbb013ba add // go:generate struct-markdown to all previously edited files 2019-06-05 16:42:18 +02:00
Adrien Delorme
f1917edd34 generate the comments for config struct of builders scraping doc website 2019-06-05 16:42:17 +02:00
Adrien Delorme
2d12af0b48
Merge pull request #7712 from hashicorp/fix_7699 
test for length of ami tags before tagging
 2019-06-04 10:17:43 +02:00
Adrien Delorme
936ca6545a
Merge pull request #7526 from aleksey-hariton/master 
Add tags to instance in CloudStack builder
 2019-06-04 10:13:42 +02:00
Megan Marsh
3f036b33c5 test for length of ami tags before tagging 2019-06-03 19:14:06 -07:00
Amrita Dutta
1438e2e449 SIG as destination validation changes 2019-06-04 00:47:29 +00:00
Megan Marsh
d9960fdaeb use length instead of a nil test. 2019-06-03 15:13:49 -07:00
Megan Marsh
078d888dba
Merge pull request #7707 from CARFAX/master 
Enable encrypted AMI sharing across accounts
 2019-06-03 13:08:06 -07:00
Brian Fox
d6776dc5f2 Remove unused variable 2019-06-03 11:10:01 +02:00
Megan Marsh
ad668dcc86
Merge pull request #7706 from amydutta/master 
Update Azure SDK for Go to v30.0.0
 2019-05-31 11:57:08 -05:00
Adrien Delorme
a145804795
Merge pull request #7597 from oseiberts11/add-openstack-image-properties 
Add image filtering on properties.
 2019-05-31 11:03:56 +02:00
Jason McIntosh
abef9820c7 Fixed spacing on comment 2019-05-30 17:25:36 -05:00
Jason McIntosh
24a4e2f23e Updated comments 2019-05-30 17:18:33 -05:00
Jason McIntosh
24bc50ce1b Enable encrypted AMIs with custom KMS Keys 2019-05-30 17:16:36 -05:00
Amrita Dutta
700c95c613 Update Azure SDK for Go to v30.0.0 2019-05-30 21:25:43 +00:00
Megan Marsh
6786c0d641 update tests to reflect new behavior 2019-05-30 16:17:23 -05:00
Megan Marsh
bda09bf7d5 the build ami is made with an intermediary name, which means that we can't skip copying even from the original build region when unencrypted 2019-05-24 15:08:20 -07:00
Megan Marsh
1204213516
Merge pull request #7678 from hashicorp/docker_windows_defaults 
builder/docker: better windows defaults
 2019-05-24 11:19:32 -07:00
Megan Marsh
708165eaa8 refactoring step_run_spot_instance and swapping out the calls to create a spot instance with a call to create a spot fleet of one, so that we can be more flexible with the instance type when desired 2019-05-24 09:32:54 -07:00
Adrien Delorme
2da36b7374 builder/docker: default container dir to "c:/packer-files" on windows 2019-05-22 16:55:26 +02:00
Megan Marsh
3e73abc93a refresh line endings 2019-05-17 14:58:20 -07:00
Megan Marsh
5504709e1d
Merge pull request #7612 from hashicorp/fix_6897 
add omit_from_artifact option for ebssurragote launch_block_devices
 2019-05-13 10:57:07 -07:00
Adrien Delorme
8d4b9116b5
Merge pull request #7633 from hashicorp/fix_vagrant_libvirt_package 
Work around bug in libvirt-vagrant plugin
 2019-05-13 15:02:27 +02:00
Adrien Delorme
783f6938cf
Update builder/vagrant/driver_2_2.go 2019-05-13 10:43:09 +02:00
Megan Marsh
ff59cfdaae Work around bug in libvirt-vagrant plugin by changing directories instead of supplying absolute path to output box 2019-05-10 16:11:41 -07:00
aaronk1
4ffa1779f1
Correct typo in var name 2019-05-10 18:49:42 -04:00
Megan Marsh
1062295ecd add omit_from_artifact option for ebssurragote launch_block_devices 2019-05-10 11:12:11 -07:00
Megan Marsh
2cfba56265 fix typos 2019-05-07 16:44:29 -07:00
Megan Marsh
02c9f24531 allow user to set architecture 2019-05-07 16:38:55 -07:00
Megan Marsh
fdae14bc18
Merge pull request #7551 from krzyszko/gcp_encryption_key 
Googlecompute builder image encryption support
 2019-05-07 15:59:59 -07:00
Adrien Delorme
a6bb06c04e
Merge pull request #7615 from hashicorp/fix_7607 
fix copypasta mistake switching ssh port mix/max for vnc port min/max
 2019-05-07 12:17:45 +02:00
Radek Simko
b4d35eceff
builder/qemu: Fix typo in version comparison 2019-05-07 08:37:57 +01:00
Megan Marsh
bf59f01ba2 fix copypasta mistake switching ssh port mix/max for vnc port min/max 2019-05-06 15:01:09 -07:00
Radek Simko
c7cf39808d
builder/qemu: Replace dot-based parsing with hashicorp/go-version 2019-05-06 22:28:27 +01:00
krisko
e96bda6466
Remove config interface. Make CreateImage function to accept config as list of config fields 2019-05-05 17:17:08 +02:00
Megan Marsh
2c352cc681 add tests for step_ami_region_copy 2019-05-03 14:47:09 -07:00
Megan Marsh
ae3cf48f71 in ebs, don't clean up temporary amis from encryption step. that's handled in step_copy_ami now 2019-05-02 14:38:56 -07:00
Megan Marsh
8c1d0f9686 clean up temporary unencrypted AMI and associated snapshots 2019-05-02 14:20:26 -07:00
Megan Marsh
c0e69a9da0 if encrypt_boot is explicitly set to false, don't copy. Also, make sure we don't cause a wait group block when we aren't performing a copy. 2019-05-02 13:28:43 -07:00
krisko
f1e9664012
Googlebuilder: Add image key encryption 2019-05-02 17:37:43 +02:00
krisko
9b39e3f928
GCP builder add image encryption support 2019-05-02 17:37:36 +02:00
Olaf Seibert
377867969b Remove some debugging messages. 2019-05-02 10:56:09 +02:00
Olaf Seibert
43bb372f84 Fix edge case with results spread over several pages 
When most_recent=false, and one page contains just a single potential
result, but a following page may contain more (which needs to be
reported as an error).
 2019-05-02 10:47:04 +02:00
Megan Marsh
c1d69b1f20
Merge pull request #7553 from hashicorp/fix_7404 
[WIP] add 30 minute timeout for destroying a VM
 2019-05-01 12:13:00 -07:00
Adrien Delorme
b7be4f9c74
Merge pull request #7564 from zaenk/proxmox-builder-static-ssh-host 
ProxMox builder: Use ssh_host config as host for the communicator
 2019-05-01 11:04:04 +02:00
Peter Pribula
14f96e8951 Fixes a typo in a comment 2019-05-01 08:39:48 +02:00
Peter Pribula
778dda9fe0 Takes static WinRM config into consideration 2019-04-30 22:26:40 +02:00
Peter Pribula
02b6e7f3de Changes qemu_agent config frm string to bool 
Defaults to true
 2019-04-30 20:23:34 +02:00
Olaf Seibert
58f8f088e2 Add image filtering on properties. 
Initial commit with debugging info.
 2019-04-30 16:34:40 +02:00
wb-ywq399345
0da7b918ce support encryption with default service key 2019-04-26 15:12:07 +08:00
chhaj5236
6b081cc41c
update alicloud builder to use official SDK (#7477) 2019-04-26 10:37:49 +08:00
Peter Pribula
cb7b77cd90 Adds qemu_agent optional config parameter 2019-04-25 19:25:00 +02:00
Peter Pribula
c261428c4f ProxMox builder ssh communicator uses ssh_host from builder config when present 2019-04-25 11:43:12 +02:00
Megan Marsh
f7c1b5e940 add 30 minute timeout for destroying a VM 2019-04-23 12:55:59 -07:00
Calle Pettersson
65545073f8 Fix port number type 2019-04-21 08:33:34 +02:00
Aleksey Hariton
1bf3428263 Add tags to instance 2019-04-18 17:52:16 +03:00
Megan Marsh
105d3f8853 delete unencrypted temporary snapshot when encrypt_boot is true. Also, fix nil map error in region copy 2019-04-17 12:55:30 -07:00
Adrien Delorme
ad6d142e16
Merge pull request #7508 from displague/feature/add-linode 
Add Linode Images builder
 2019-04-17 10:59:42 +02:00
Megan Marsh
71f2017209 read stderr before we try to read the artchive. 2019-04-16 13:05:25 -07:00
Megan Marsh
8315be7e19
Merge pull request #7509 from hashicorp/investigate_7505 
fix panic in StepConfigureVNC ( fix 7505 )
 2019-04-16 11:24:55 -07:00
Adrien Delorme
56c7593725 fix panic in StepConfigureVNC 
When the driver is the esx5 driver s.l won't be set at all. Meaning this will crash.
In the esx5 driver we try to dial possible ports to see if it works so it doesn't make sense to use packer's `net.ListenRangeConfig`. It could make sense to have a net.DialRangeConfig but this sounds a bit too specific and not broad enough to do.

fix #7505
 2019-04-16 15:32:05 +02:00
Marques Johansson
99987c2d56 Add Linode Images builder 
Packer Builder for [Linode Images](https://www.linode.com/docs/platform/disk-images/linode-images/)

Adds the following builder:

  * `linode`

Based on https://github.com/linode/packer-builder-linode (MPL/2)
(formerly maintained by @dradtke).  Includes website docs and tests.

Relates to #174, #3131
 2019-04-15 20:40:59 -04:00
Megan Marsh
201c8c1332 make sure that you encrypt using the provided kms key id and not the default 2019-04-15 16:44:56 -07:00
Megan Marsh
45af9f0cbc
Merge pull request #7498 from hashicorp/do_7465 
add keep_registered option to hyperv
 2019-04-15 11:12:43 -07:00
Adrien Delorme
97f2914c6a
Merge pull request #7484 from yandex-cloud/yandex-cloud-builder 
Builder for Yandex.Cloud
 2019-04-15 14:02:43 +02:00
Megan Marsh
73205f3a91 add keep_registered option to hyperv 2019-04-12 15:59:09 -07:00
Adrien Delorme
d2f036ec44 Revert "Revert "Merge pull request #7391 from carlpett/proxmox-builder"" 
This reverts commit 032527ecfe.
 2019-04-12 12:26:34 +02:00
Gennady Lipenkov
ddd2106973 Remove LICENSE and THIRD-PARTY 2019-04-12 01:13:27 +03:00
Gennady Lipenkov
f9c7606452 Adopt new Builder interface signature 2019-04-12 01:10:52 +03:00
Gennady Lipenkov
8e4e314553 Bulk update 'yandex' builder 
Squashed commit of the following:

commit ccc020231780179d241d46eef7c0ba103366aed0
Author: Yandex.Cloud Bot <ycloud-bot@yandex.ru>
Date:   Tue Apr 9 14:38:30 2019 +0000

    sync upstream
 2019-04-12 01:00:54 +03:00
Gennady Lipenkov
a12c5d57ec Bulk update builder (doc, acc test) 
Squashed commit of the following:

commit 372db94a5c4bc81bd4149de5ea9c21946362f3f9
Author: Yandex.Cloud Bot <ycloud-bot@yandex.ru>
Date:   Thu Apr 4 13:16:03 2019 +0000

    sync upstream
 2019-04-12 01:00:54 +03:00
Gennady Lipenkov
af333a5de0 Initial version 2019-04-12 01:00:51 +03:00
Adrien Delorme
63f5bbbc73 use our own copy of iochan.LineReader 2019-04-11 14:25:24 +02:00
Adrien Delorme
032527ecfe Revert "Merge pull request #7391 from carlpett/proxmox-builder" 
This reverts commit b7d62b2ae0, reversing
changes made to c36eaf16f7.
 2019-04-11 14:19:25 +02:00
Adrien Delorme
aee73d745d update code after go mod update 2019-04-11 14:19:24 +02:00
Adrien Delorme
6ff392d713 Update windows_container_communicator.go 
after merge
 2019-04-09 17:46:38 +02:00
Adrien Delorme
d72040f4fa move retry code into the common/retry pkg and make retry context aware 2019-04-09 17:46:38 +02:00
Adrien Delorme
06941a86a3 make the file builder run provisioners for testing purposes 2019-04-08 20:09:21 +02:00
Adrien Delorme
f555e7a9f2 allow a provisioner to timeout 
* I had to contextualise Communicator.Start and RemoteCmd.StartWithUi
NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer.
Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock
* cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions
* also had to simplify StartWithUi
 2019-04-08 20:09:21 +02:00
Adrien Delorme
a81abd297b Merge remote-tracking branch 'origin/master' into context_provisioner 2019-04-08 20:09:01 +02:00
Megan Marsh
b7d62b2ae0
Merge pull request #7391 from carlpett/proxmox-builder 
Implement Proxmox builder
 2019-04-08 09:54:11 -07:00
Calle Pettersson
65cd5bbd29 Change disk size config parameter name 2019-04-06 08:10:28 +02:00
Megan Marsh
3e72e65a6c
Merge pull request #7456 from hashicorp/do_5770 
introduce the clean_resource_name to clean image/var names
 2019-04-05 09:12:20 -07:00
Megan Marsh
04b57b3e32 fix tests; clean up ip file after build 2019-04-04 22:33:24 -07:00
Calle Pettersson
e9d5a1d272 Update to builder interface change 2019-04-04 15:20:46 -07:00
Calle Pettersson
2f754c38f8 Add validation of interface implementation for both proxmox.Client and mocks 2019-04-04 15:20:46 -07:00
Calle Pettersson
c4ce295f67 Add tests for step_start_vm cleanup 2019-04-04 15:20:46 -07:00
Calle Pettersson
4c1fbfdd61 Shifted special runes are already handled, simplify SendKey 2019-04-04 15:20:46 -07:00
Calle Pettersson
0765bc2283 Add tests for step_type_boot_command, fix found bug (shifted chars were not lower cased) 2019-04-04 15:20:46 -07:00
Calle Pettersson
28ca0f71b5 Add tests for step_convert_to_template 2019-04-04 15:20:46 -07:00
Calle Pettersson
3d5f433b22 Add more finalizetemplate tests, fix found bug 2019-04-04 15:20:46 -07:00
Calle Pettersson
5eb600bf88 Add draft of step test 2019-04-04 15:20:46 -07:00
Calle Pettersson
2e3086be5a Initial tests 2019-04-04 15:20:46 -07:00
Calle Pettersson
9f8fc37fde Implement Proxmox builder 2019-04-04 15:20:46 -07:00
Megan Marsh
196028a7ed
Merge pull request #7444 from hashicorp/docker_windows 
Docker windows
 2019-04-04 09:30:43 -07:00
Paul Meyer
7fc8901d8f
Merge pull request #7464 from paulmey/fix-snapshots 
[azure] Fix: Power off before taking snapshot (windows)
 2019-04-03 16:38:04 -07:00
Adrien Delorme
c4f3dccc14 rename interpolation context from ctx to ictx and contexts to ctx to avoid conflicts 2019-04-03 15:56:15 +02:00
Adrien Delorme
a4bf94dd3c change Builder to be passed a context for cancellation 
we have to to give it to our hook
 2019-04-03 15:55:55 +02:00
Adrien Delorme
9836dad0c9 introduce the clean_resource_name to clean image names and deprecate the old ones 2019-04-03 11:25:51 +02:00
Megan Marsh
17c14770a7
Merge pull request #7450 from AkshatM/rename_security_group_cidr_to_security_group_cidrs 
Rename and change `temporary_security_group_source_cidr`  to accept a list of strings (for Amazon builders).
 2019-04-02 10:54:31 -07:00
Paul Meyer
eb274c4e87 Power off before shapshotting 2019-04-01 18:40:50 +00:00
Megan Marsh
874a4ff8c7
Merge pull request #7451 from bh9/master 
Allow both ports and networks in openstack builder
 2019-04-01 09:30:39 -07:00
Adrien Delorme
225f4bab1f
Merge pull request #7446 from hashicorp/do_6928 
remove default ssh_username from oracle classic builder, but add note…
 2019-04-01 17:24:36 +02:00
bh9
cbbbc451b5
Allow both ports and networks in openstack builder 
Current code would throw an index out of range exception when trying to access `s.Networks[len(s.Networks)]` when `len(s.Ports)>0` and would ignore the first `len(s.Ports)` entries of `s.Networks`, fix by shifting access to `s.Networks` back by `len(s.Ports)` so that the final read is `networks[len(s.Networks)+len(s.Ports)-1].UUID=s.Networks[len(s.Networks)+len(s.Ports)-1-len(s.Ports)]` which is necessarily the last member of `s.Networks`
 2019-04-01 11:43:21 +01:00
Akshat Mahajan
f07e4214cc Addresses issues #5384, #5494: Rename and change temporary_security_group_source_cidr 
to accept a list of strings (for Amazon builders).

Per this change, `temporary_security_group_source_cidr` in the configuration:

1. Will be renamed to `temporary_security_group_source_cidrs`.
2. Will accept a list of CIDRs.
3. Will have its documentation updated to reflect this change.
4. Will have a fixer attached for newer templates to avail of.
 2019-03-30 15:47:03 -07:00
Megan Marsh
b3c6dd0baa fix tests 2019-03-29 15:52:41 -07:00
Megan Marsh
bcacd331c3 change cpu to cpus and ram_size to memory in order to bring hyper v into line with other builder defaults 2019-03-29 15:12:51 -07:00
Megan Marsh
b764b1d7e1 fix tests 2019-03-29 15:05:51 -07:00
Megan Marsh
a84fc6bde9 remove default ssh_username from oracle classic builder, but add note in docs. 2019-03-29 14:24:12 -07:00
Megan Marsh
af06334114 fix tests 2019-03-29 11:37:23 -07:00
Megan Marsh
6407a579f0 Document why we need windows communicator in code 2019-03-29 11:21:07 -07:00
Megan Marsh
12b9004c76 reduce duplicated code 2019-03-29 11:14:01 -07:00
Megan Marsh
0860edeed8 fix mocks 2019-03-28 16:55:35 -07:00
Megan Marsh
70150ffa0f set powershell entrypoint for windows containers 2019-03-28 16:46:07 -07:00
Megan Marsh
36f2634352 can't use docker cp so call powershell to do this natively. Fix implementation for upload, uploadDir, and download in windows container communicator 2019-03-28 16:20:05 -07:00
Megan Marsh
af01860fa9 remove old docker-toolbox limitation. 2019-03-27 15:29:22 -07:00
Megan Marsh
3b87f2a519 stop container before committing if windows 2019-03-27 15:25:51 -07:00
Megan Marsh
8f3313d81e Create new docker communicator for windows containers 2019-03-27 15:25:32 -07:00
Megan Marsh
9f1a4e0fed
Merge pull request #7423 from hashicorp/lock_ports 
Lock packer ports using a lock file
 2019-03-26 10:35:18 -06:00
Adrien Delorme
ac92916b01 StepConfigureVNC: close listener only once 2019-03-26 10:58:51 +01:00
Megan Marsh
e97f864016
Merge pull request #7395 from josepand/openstack_force_delete 
Expose force_delete for openstack builder
 2019-03-25 17:34:00 -06:00
Megan Marsh
e5ddf3e56b
Merge pull request #7419 from vhaidamaka/vbox_check_none_communicator 
Validate 'none' communicator in the virtualbox builder
 2019-03-25 17:09:17 -06:00
Paul Meyer
e4bea87a20
Merge pull request #7211 from riezebosch/master 
arm-builder: specify zone resilient image from config
 2019-03-19 08:59:29 -07:00
Adrien Delorme
a3838ecfad error on negative ports 2019-03-19 15:21:09 +01:00
Adrien Delorme
5a6dffde9a use port as ints 2019-03-19 15:01:12 +01:00
Adrien Delorme
f828b72c10 step configure vnc: allow to use ESX5Driver again 2019-03-19 12:54:15 +01:00
Adrien Delorme
c214f6735b make everything a uint 2019-03-19 12:54:15 +01:00
Adrien Delorme
ae182a7c20 qemu stepForwardSSH: use common/net pkg to find open port 2019-03-19 12:54:15 +01:00
Adrien Delorme
446105e384 quemu stepConfigureVNC: use common/net pkg to find open port 2019-03-19 12:54:15 +01:00
Adrien Delorme
f67b5ff59d virtualbox StepConfigureVRDP: use common/net pkg to find open port 2019-03-19 12:54:15 +01:00
Adrien Delorme
59370986fb virtualbox StepForwardSSH: use common/net pkg to find open port 2019-03-19 12:54:15 +01:00
Adrien Delorme
b5d78d47f5 vmware StepConfigureVNC: use common/net pkg to find open port 2019-03-19 12:54:15 +01:00
Vadym Haidamaka
414d0750f0 Add tests to validate 'none' communicator in the virtualbox builder 2019-03-16 18:18:29 +02:00
Vadym Haidamaka
0263503c45 Validate virtualbox_version_file and guest_additions_mode when communicator is none 2019-03-16 18:15:27 +02:00
Esten Rye
ba5385b224 Fix invalid character issue on Windows. 
Output from driver includes a `\r` character.  This change adds logic to
trim `\r` and `\n` values from parsed output.

#7414
 2019-03-15 20:00:27 -05:00
Megan Marsh
d505bc59a0
Merge pull request #7415 from programmer04/improve-name-conflict-msg 
fix 7403: Improve error message for conflicting images name
 2019-03-15 16:01:41 -07:00
Megan Marsh
24c42e4a1f
Merge pull request #7397 from vhaidamaka/fix-7321 
Add vagrant-cloud post-processor support for the vagrant builder
 2019-03-15 16:00:05 -07:00
programmer04
596a9cc7ff Improve error message for AWS and Alibaba 2019-03-15 23:38:05 +01:00
Adrien Delorme
9f82b75e57 Use the hashicorp/go-getter to download files 
* removed packer.Cache and references since packer.Cache is never used except in the download step. The download step now uses the new func packer.CachePath(targetPath) for this, the behavior is the same.
* removed download code from packer that was reimplemented into the go-getter library: progress bar, http download restart, checksuming from file, skip already downloaded files, symlinking, make a download cancellable by context.
* on windows if packer is running without symlinking rights and we are getting a local file, the file will be copied instead to avoid errors.
* added unit tests for step_download that are now CI tested on windows, mac & linux.
* files are now downloaded under cache dir `sha1(filename + "?checksum=" + checksum) + file_extension`
* since the output dir is based on the source url and the checksum, when the checksum fails, the file is auto deleted.
* a download file is protected and locked by a file lock,
* updated docs
* updated go modules and vendors
 2019-03-13 12:11:58 +01:00
Megan Marsh
0196d7f835
Merge pull request #7370 from sargun/allow-users-to-specify-custom-block-device-mapping 
amazon-chroot: Allow users to specify custom block device mapping
 2019-03-12 14:21:23 -07:00
Vadym Haidamaka
4855bc79c9 Add vagrant-cloud post-processor support for the vagrant builder 2019-03-12 05:33:46 +02:00
josepand
f2b42f2b4b Expose force_delete for openstack builder 
Very similar to how its exposed in terraform adds an optional force_delete config entry on the openstack builder.
 2019-03-11 18:39:47 +00:00
Megan Marsh
67fe820465
Merge pull request #7361 from hashicorp/fix_insecure_skip_tls_verify 
fix proxy and tls
 2019-03-07 09:21:06 -08:00
Lukas Kämmerling
633934369c
Use Context of run method and allow users to cancel the build 2019-03-07 11:41:39 +01:00
Lukas Kämmerling
cc2267fd2a
Fix usage of rescue system 2019-03-07 07:24:22 +01:00
Lukas Kämmerling
b6ee0ea736
Fix Format 2019-03-06 08:05:08 +01:00
Lukas Kämmerling
7730cdcb56
Fix usage of freebsd64 rescue image 2019-03-06 07:57:51 +01:00
Megan Marsh
5aeab4ec06
Merge pull request #7300 from kmbulebu/openstack_app_creds 
OpenStack: Support Application Credential Authentication
 2019-03-05 13:11:51 -08:00
Megan Marsh
8b2fb15f4d
Merge pull request #7375 from lrxcy/fix_190220 
fix 'Acceptance Tests can't find image problem'
 2019-03-05 09:41:49 -08:00
wb-ywq399345
035b9e5cda fix 'Acceptance Tests can't find image problem' 2019-03-05 16:14:59 +08:00
Megan Marsh
3ed9fe6dee remove unused imports 
remove HttpClientWithEnvironmentProxy from amazon builders; let access config handle it
 2019-03-04 16:42:33 -08:00
Megan Marsh
0ed57a37a3 dont overwrite session config in ebs builder 2019-03-04 16:41:31 -08:00
Megan Marsh
ca9a5daf29 fix proxy and tls 2019-03-04 16:41:31 -08:00
Megan Marsh
3dc1dafe58
Merge pull request #7287 from stephen-fox/ephemeral-ssh-key-pair-issue-7225 
virtualbox: create ephemeral SSH key pair for build process
 2019-03-04 14:25:04 -08:00
Sargun Dhillon
601e754438 amazon/chroot: Allow creating new block device mappings !not fromScratch 
Previously, when you built from an existing image, you were unable
to reconfigure block device mappings, as it just took them and
copied them over. This allows users to specify new, custom
block device mappings, even when building from an existing
image.
 2019-03-04 13:11:14 -08:00
Megan Marsh
eb98840f18
Merge pull request #7357 from e-mow/issue-7140 
Issue 7140
 2019-03-01 15:51:39 -08:00
Eric Mowry
cef3d0eb24 Ran make fmt per Megan's request. 2019-03-01 14:16:00 -05:00
Megan Marsh
ec3b0a5138 fix conflict from mergeing too many things to master at once 2019-03-01 11:13:32 -08:00
Megan Marsh
9d2b06bd61
Merge pull request #7342 from hashicorp/fix_7316 
swap region copy and encryption steps
 2019-03-01 10:26:43 -08:00
Megan Marsh
0abd16527e
Merge pull request #7337 from sargun/fix-chroot-builder 
Amazon-chroot: Fix building PV images and where mount_partition is set
 2019-03-01 10:25:04 -08:00
Stephen Fox
7e1cbc6d89 Rename references to key pair name to comment. 
Per the OpenSSH manual, the field is for a comment.
 2019-03-01 10:00:29 -05:00
Eric Mowry
109ba2c54c After testing a ISO and VMX clone along with setting the display_name option it was determined that having no name for the .vmxf file did not work either. Updating to check if displayName is not empty before using and falling back to VMName if displayName is empty. 2019-02-28 21:36:25 -05:00
Megan Marsh
3b6ff0fe3e
Merge pull request #7106 from hashicorp/revert_docker_changes 
docker: user /bin/sh by default
 2019-02-28 15:31:53 -08:00
Megan Marsh
0371e2a1b4
Merge pull request #7074 from hashicorp/fix_3329 
vmware-iso (esxi) Add check that "format" is not being set when remote_type is empty.
 2019-02-28 15:30:54 -08:00
Megan Marsh
424a6a3a7e
Merge pull request #6983 from hashicorp/revert-6979-revert-6925-organization_renaming 
DONT MERGE YET: Revert "Revert "Rename attribute api_access_key to organization_id""
 2019-02-28 15:30:25 -08:00
Stephen Fox
61a8968b22 Use 'os.OpenFile' to atomically create debug key file. 
Per code review feedback.
 2019-02-28 17:23:33 -05:00
Stephen Fox
094c87e395 Remove 'SSHPublicKeyUrlEncoded', use 'urlquery' instead. 
Per code review feedback, the Go template library supports
encoding variables in URL query format. Instead of exposing
two different public key formats (unmodified string and a
URL encoded string), just have the user apply the 'urlquery'
modifier to their template.
 2019-02-28 17:06:51 -05:00
Eric Mowry
e74a81e27b Deny the copying of .vmxf from the source VM to the target VM. If this file gets copied over to the new VM once the VM gets deleted the .vmxf and the folder for the VM stay on the datastore. This causes Packer to hang because the folder on the datastore does not go away during the cleanup process. 2019-02-28 16:47:46 -05:00
Eric Mowry
1127096beb Setting extendedconfigfile to the name of the VM so that when ESXi makes the vmxf it is named after the VM and ESXi will properly delete the file when the VM gets deleted. 2019-02-28 16:43:47 -05:00
Adrien Delorme
f535464097 up a test 2019-02-27 11:17:56 +01:00
Adrien Delorme
f03cbd8a10 aws: allow to pass nil bool as encryption parameter 
to retain current encryption settings

this changes the fields :
* ami_config.encrypt_boot
* block_device.encrypted

This also removes StepCreateEncryptedAMICopy as this step is now done in StepAMIRegionCopy
 2019-02-27 11:17:56 +01:00
Adrien Delorme
ce8532e94b aws: document ValidateRegion better 2019-02-27 11:17:08 +01:00
Adrien Delorme
6af621c37a aws: StepAMIRegionCopy call waitgroup.add only once 2019-02-27 11:17:08 +01:00
Michael F
01a0b0c766 kmsArnStartPattern - fix support for aws-us-gov 
While the `kmsArnStartPattern` regexp supports `us-gov` as a region, it does not take the AWS partition into consideration.
For more info see https://docs.aws.amazon.com/govcloud-us/latest/ug-east/using-govcloud-arns.html

Added test case for AWS partition us-gov as well as a negative test case for a non-existing AWS partition.
 2019-02-26 16:54:54 -08:00
Megan Marsh
026e543b24 move snapshot deletion to cleanup; this allows people with tag-specific permissions to perform snapshot deletion operation 2019-02-25 17:01:19 -08:00
Stephen Fox
2ef6b9247d Initial take on code review feedback from @azr. 
Do not use builder pattern or interfaces; stick to structs and
some basic functions.
 2019-02-25 17:16:24 -05:00
Megan Marsh
3b726e66c1 swap region copy and encryption steps 2019-02-25 11:03:03 -08:00
Sargun Dhillon
142a84ef43 amazon/chroot: Refactor step_register_ami for testing EBS-related behaviour 
There is some logic around how EBS mappings are handled / generated depending
on whether an image if from scratch or not. There was no testing around
this behaviour before. This strips that logic out into a separate function,
to enable testing it independentlhy.
 2019-02-25 10:45:23 -08:00
Megan Marsh
3f7c4f7406
Merge pull request #7341 from hashicorp/fix_7325 
openstack WaitForImage: pass context for cancellation
 2019-02-25 09:30:36 -08:00
Megan Marsh
05897c8653
Merge pull request #7294 from hyperonecom/hyperone 
Add HyperOne builder
 2019-02-25 08:30:04 -08:00
Adrien Delorme
b9411712eb builder/openstack/step_create_image.go: pass context for cancellation 
fix #7325
 2019-02-25 15:03:11 +01:00
Miłosz Smółka
94a7a07c87 Merge branch 'master' into hyperone 2019-02-24 15:16:21 +01:00
Miłosz Smółka
0673bb2c57 Add cleanup for stepCreateImage 2019-02-23 14:57:19 +01:00
Sargun Dhillon
d3c65ee77d builder/amazon/chroot: Fix building PV images with mount_partition 
Right now, if we have a source image that's PV, and try to build an
image with mount_partition set to not 0, it does not get picked up.
This is because under PV we only had a filesystem, not partitions,
but you can convert a PV image to an HVM image during build time.
 2019-02-22 18:21:01 -08:00
Joel Lopes
c8a60c77d1 Add comments 2019-02-21 18:12:57 -08:00
Joel Lopes
1c030cb54b Use IMDS to get subscription for Azure MSI 2019-02-21 09:35:14 -08:00
Megan Marsh
5cc442872e
Merge pull request #7314 from hashicorp/fix_7234 
add noSSLVerify to ovftool args
 2019-02-19 16:54:48 -08:00
Manuel Riezebosch
d79b54e46a feat(arm-builder): print warning on zone resiliency for currently not supported locations 2019-02-15 19:27:53 +01:00
Manuel Riezebosch
f31031f6b1 feat(arm-builder): zone resilient from config 2019-02-15 19:27:32 +01:00
Megan Marsh
75f574bd4b
Merge pull request #7221 from hashicorp/vagrant_builder 
Vagrant builder
 2019-02-15 10:05:44 -08:00
Megan Marsh
cb5c896c01
Merge pull request #7310 from hashicorp/fix_7286 
also strip \r to work around windows file ending strangeness
 2019-02-15 09:19:33 -08:00
Megan Marsh
9f702af6d9 we lost the skip_add step somewhere 2019-02-14 14:46:14 -08:00
Megan Marsh
bbc52f9a7d add noSSLVerify to ovftool args 2019-02-14 12:10:58 -08:00
Megan Marsh
be21850e32
Merge pull request #7060 from andrewsomething/do-post-processor 
Add digitalocean-import post-processor.
 2019-02-14 11:58:00 -08:00
Megan Marsh
bd3339f1f9 also strip \r to work around windows file ending strangeness 2019-02-13 15:41:37 -08:00
Megan Marsh
c7278e871c
Merge pull request #7038 from kmbulebu/openstack_deprecated_api 
Replaced compute/v2/images with imageservice/v2/images.
 2019-02-11 15:05:45 -08:00
Megan Marsh
f2439625bf
Merge pull request #7298 from hashicorp/fix_7256 
Fix 7256
 2019-02-11 14:24:01 -08:00
Megan Marsh
22e3f09db3
Merge pull request #7282 from hashicorp/do_6994 
Allow amazon builders to read credentials from Vault.
 2019-02-11 12:49:23 -08:00
Megan Marsh
2a613dd6e9 fix up the github suggestion 2019-02-11 11:49:17 -08:00
Adrien Delorme
3ae5a912d4
Update builder/amazon/common/step_pre_validate.go 
Co-Authored-By: SwampDragons <megan@hashicorp.com>
 2019-02-11 11:41:58 -08:00
Kevin Bulebush
cd1f1165ed Support reading app creds from packer config 2019-02-09 22:52:02 -05:00
Kevin Bulebush
2edf3d8b8e Openstack: Added application credential config 2019-02-09 22:52:02 -05:00
Megan Marsh
3fd589fa72 typos 2019-02-08 09:31:30 -08:00
Megan Marsh
e2d8c0bfd7 docs 2019-02-08 09:28:10 -08:00
Megan Marsh
07c0c599e0 attach guest additions via SATA when necessasry 2019-02-08 09:15:15 -08:00
Megan Marsh
5057220ad2 use VAGRANT_CWD rather than changing packer run directories 2019-02-07 14:35:01 -08:00
Megan Marsh
dc848ea5d7 just make vagrantfile instead of calling init 2019-02-07 12:39:56 -08:00
Miłosz Smółka
228829139b Merge branch 'master' into hyperone 2019-02-07 14:12:13 +01:00
Miłosz Smółka
1ee4517370 Update source_image names in tests 2019-02-07 09:22:30 +01:00
stephen-fox
b7719650ae
Merge pull request #1 from stephen-fox/parse-user-supplied-keypair 
Parse user supplied keypair
 2019-02-06 15:07:04 -05:00
chris marget
53c0376dfd don't print keypair to the user's screen 2019-02-06 13:54:05 -05:00
chris marget
13cc73d600 keypair parsing and testing 2019-02-06 13:46:55 -05:00
Miłosz Smółka
fdf028c463 Search SCSI device in /sys/bus due to issues with by-path 2019-02-06 12:30:14 +01:00
Megan Marsh
e56d7f7234 fix tests 2019-02-05 15:34:59 -08:00
Megan Marsh
608b7cb7a3 review comments 2019-02-05 15:16:47 -08:00
Megan Marsh
3704a053d0 move region validation and credential wait into step pre validate 2019-02-05 14:07:04 -08:00
Stephen Fox
354fcc5cc6 Merge branch 'master' into 'ephemeral-ssh-key-pair-issue-7225'. 2019-02-05 16:16:51 -05:00
Stephen Fox
f9d24ccda0 Allow user to get public key straight up, or URL encoded. 2019-02-05 11:59:13 -05:00
Miłosz Smółka
0d8e9f50bf Add proper SCSI search 2019-02-05 16:20:42 +01:00
Paul Meyer
68516fc05c Fix Azure interactive authentication 
Builder looks up tenant ID before asking for token. Client config did
not allow that. Also found that token provider was not properly
initialized.

Fixes 7267
 2019-02-05 02:35:12 +00:00
Megan Marsh
a7d9d62996 fix tests on windows 2019-02-04 16:11:25 -08:00
Megan Marsh
8add176ab7 finish first pass at vault code; needs testing and cleanup of error messages 2019-02-04 15:54:14 -08:00
Megan Marsh
7a78b47e83 make vault engine stuff into a little struct for easier management 2019-02-04 15:29:45 -08:00
Megan Marsh
af7131b169 tests, logic cleanup, docs for vagrant builder 2019-02-04 14:08:43 -08:00
Megan Marsh
52892699ca make it work with a local vagrant box 2019-02-04 14:08:43 -08:00
Megan Marsh
ad21367b21 vagrant builder 2019-02-04 14:08:43 -08:00
Stephen Fox
f2c11b55be Renamed authorized_keys public key function. 2019-02-04 14:27:14 -05:00
Stephen Fox
ea2a7c3fe9 Merge branch 'master' into 'ephemeral-ssh-key-pair-issue-7225'. 2019-02-04 12:47:42 -05:00
Stephen Fox
01c98f3d82 Tweaked debug SSH private key file name for vbox. 2019-02-04 12:47:18 -05:00
Stephen Fox
c6ae8654d9 Moved SSH key pair code into 'helper/ssh'. 2019-02-04 12:21:58 -05:00
Stephen Fox
25775886a8 Properly set SSH key pair name. 2019-02-04 12:12:18 -05:00
Stephen Fox
be081944b1 Moved new key pair funcs closer to builder funcs. 2019-02-04 12:09:23 -05:00
Stephen Fox
b1b67ecffa Added support for setting a name in SSH key pair. 
Also refactored how new SSH key pairs are created, and how the
tests are structured.
 2019-02-04 12:07:32 -05:00
Stephen Fox
5893134c61 Updated comment for 'PrivateKeyPemBlock()'. 2019-02-04 10:02:07 -05:00
Stephen Fox
cd4ae03324 Create / use SSH key pairs in vbox builders. 
This follows the business logic for creating / using SSH key pairs
in the cloud-type builders (e.g., Amazon EC2).
 2019-02-03 12:20:52 -05:00
Stephen Fox
72d1501551 Made SSH public key available in vbox boot command. 
The SSH public key (in authorized_keys format) can be retreived in
the build template by specifying '{{ .SSHPublicKey }}'. The key is
URL encoded to escape spaces.
 2019-02-03 12:20:42 -05:00
Stephen Fox
459bd1ea7a Added vbox step for SSH key pair business logic. 2019-02-03 12:07:57 -05:00
Stephen Fox
6824806e6f Allow caller to specify new line for SSH public key. 
The default behavior of the various builders that create SSH key
pairs appears to be to add a trailing new line. This will be the
default behavior, but at least it can be customized if desired.
 2019-02-03 10:37:32 -05:00
Stephen Fox
ad075ffac3 Added 'Description()' to 'sshKeyPair'. 
Also cleaned up tests.
 2019-02-03 09:17:18 -05:00
Miłosz Smółka
f7de056f23 Add proper cleanup of chroot disk 
Closes #3
 2019-02-03 00:30:56 +01:00
Miłosz Smółka
5e8eade205 Add support for custom API url of compatible service 
Closes #4
 2019-02-02 14:05:06 +01:00
Miłosz Smółka
6921cc93a9 Add acceptance tests for chroot 2019-02-01 18:58:16 +01:00
Miłosz Smółka
4704565869 Rename vm_flavour to vm_type 2019-02-01 18:57:43 +01:00
Miłosz Smółka
e7e84f04e7 Fix timestamp interpolation in mount path 
Closes #1
 2019-02-01 17:46:35 +01:00
Murcurio
60c7d22ffb
Change metadata url to FQDN 
If instance has a different DNS/search domain then "metadata" alone won't work. The FQDN of "metadata.google.internal" is included in hosts file, and will work regardless of DNS configuration. Alternatively the IP 169.254.169.254 can be used.
 2019-02-01 15:36:40 +11:00
Megan Marsh
eef4fc7a01
Merge pull request #7222 from Adezandee/gce-post-processors 
googlecompute-postprocessors: service account and export configs
 2019-01-31 16:58:42 -08:00
Megan Marsh
6ea64bc378
Merge pull request #7191 from arizvisa/GH-7190 
Adds support to the vmware builders for specifying the number of cores per socket via the `cores` option.
 2019-01-31 15:27:52 -08:00
Stephen Fox
f233e54992 Initial SSH key pair helper implementation. 2019-01-30 22:10:27 -05:00
Yaakov
0a08920816 Hyper-V: Fix integer overflows in 32-bit builds 2019-01-31 13:53:01 +11:00
Miłosz Smółka
3d3e933f48 Add host key hash verify 2019-01-29 10:44:23 +01:00
Miłosz Smółka
bd4ce90728 Add chroot disk build 2019-01-28 12:33:25 +01:00
Megan Marsh
035c3506ba manually set proxyfromenvironment in default http client for ec2 sessions 2019-01-25 12:33:25 -08:00
Megan Marsh
c63b54a1e7 move http with proxy call into a helper function 2019-01-25 12:32:52 -08:00
Megan Marsh
904c4b9adb
Merge pull request #7230 from hashicorp/up-aws-sdk-go 
Don't try to guess region from metadata if not set + update aws-sdk-go
 2019-01-25 10:06:11 -08:00
Adrien Delorme
4a2773f8fa remove default max retries config of 8, it will now be used from env 
removing the code that wants to guess region from metadata allows us to change that setting, which can now be taken from environment.
 2019-01-25 13:51:02 +01:00
Adrien Delorme
964b149df2 aws: remove now unused AccessConfig.metadataRegion 2019-01-25 13:03:14 +01:00
Adrien Delorme
335f442b51 aws: unwrap AccessConfig.region func 
* it was used only in the Session() call.
* default region guessing from metadata should happen in the SDK, not 'manually'
 2019-01-25 13:02:42 +01:00
Adrien Delorme
54af9951a8 make guard clauses to clearly see success pass 2019-01-25 13:00:21 +01:00
Adrien Delorme
0864b4d07b name unclear import 2019-01-25 12:59:43 +01:00
Arnaud Dezandee
91d2cb8c83
googlecompute-import: add service accounts 2019-01-25 11:36:18 +01:00
Megan Marsh
a0c238940e
Merge pull request #7223 from hashicorp/fix_7200 
escape query as suggested in issue #7200
 2019-01-24 09:48:38 -08:00
Megan Marsh
e4dca0016c
Merge pull request #7156 from vtolstov/qemu 
qemu: Add configuration options to specify cpu count and memory size
 2019-01-23 15:19:08 -08:00
Megan Marsh
d0e5c67dc3
Merge pull request #7205 from hashicorp/fix_7196 
fix region stuff
 2019-01-23 15:15:27 -08:00
Megan Marsh
ce8f5c31df escape query as suggested in issue #7200 2019-01-23 11:04:14 -08:00
Miłosz Smółka
3ce05c7c26 Add acceptance tests 2019-01-23 14:59:28 +01:00
Miłosz Smółka
be30415395 Add HyperOne builder 2019-01-23 14:04:05 +01:00
Vasiliy Tolstov
b6ebe00249 provide memory and cpus like other builders does 
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
 2019-01-23 13:21:52 +03:00
Adrien Delorme
f57953d4ff Docker needs a temporary dir that is inside the $HOME dir 2019-01-18 16:42:04 +01:00
Adrien Delorme
f19b7c0300 Revert "aws: test timeout when no credenrtials are set" Revert "aws: set max retries back to 20" 
This reverts commits b8b3e64cff and 993af36f2e.
 2019-01-18 12:40:02 +01:00
Adrien Delorme
b8b3e64cff aws: test timeout when no credenrtials are set 2019-01-18 11:43:52 +01:00
Adrien Delorme
993af36f2e aws: set max retries back to 20 2019-01-18 11:43:26 +01:00
Ali Rizvi-Santiago
9d2f98394e Revert "Renamed the terse option, cores, to to the less-terse version cores_per_socket." 
This reverts commit 0c37a3c68f and avoids bikeshedding from other committers.
 2019-01-17 14:49:07 -06:00
Ali Rizvi-Santiago
0c37a3c68f Renamed the terse option, cores, to to the less-terse version cores_per_socket. 2019-01-17 10:39:19 -06:00
Ali Rizvi-Santiago
4894873971 Added logic to the vmware-iso builder that appends the number of cores per socket to the vmx in stepCreateVmx. 2019-01-17 10:39:19 -06:00
Ali Rizvi-Santiago
062c62eed8 Added support for specifying the number of cores as cores to vmware-common. 2019-01-17 10:39:19 -06:00
Megan Marsh
e0543246fa remove commented code 2019-01-16 11:05:11 -08:00
Megan Marsh
783ed32e7e fix region stuff 2019-01-16 11:02:58 -08:00
Paul Meyer
e189db97d4 [azure] deallocate instead of just power-off 
1. allegedly prevents error where  fails because VM still appears running
2. prevents left-behind VM's after failures from accumulating charges
 2019-01-16 00:31:23 +00:00
Paul Meyer
aa29facdae Allow certificate bearer JWT client authentication 
This allows certificate based authentication, both by just referencing
the certificate file as well as by providing a bearer JWT. This last
option allows authentication without exposing the private key to packer
using an expiring JWT containting the thumbprint (and sometimes the
whole certificate for subject/issuer based auth), signed using the
certificate private key.
 2019-01-15 17:29:28 +00:00
Paul Meyer
7e34579b7e Factor out Azure client credential config 2019-01-15 17:23:57 +00:00
Adrien Delorme
9ddec470a0
Merge pull request #7188 from hashicorp/dedupe_step_output_dir 
deduplicate step_output_dir and move to common folder
 2019-01-15 17:28:21 +01:00
Megan Marsh
126ca2a877
Merge pull request #7158 from rickard-von-essen/fix-7155 
WIP: parallels: Fix attaching prl tools
 2019-01-11 15:30:37 -08:00
Megan Marsh
97a791389a deduplicate step_output_dir and move to common folder 2019-01-11 15:06:36 -08:00
Adrien Delorme
c8a39e939a
Merge pull request #7178 from edwardmlyte/simplify-version-check 
Simplify version check for port count argument
 2019-01-10 16:07:00 +01:00
Ed Maxwell-Lyte
e8e92fe6c6 rename clashing import 2019-01-09 16:30:54 +00:00
Ed Maxwell-Lyte
4437f8d8ba Use go-version for comparison 2019-01-09 16:22:33 +00:00
Ed Maxwell-Lyte
346f5d9bba Simplify version check for port count argument 
Might be personal preference, but I think this reads more clearly
 2019-01-09 09:46:24 +00:00
Adrien Delorme
9f7b4ffc17
Merge branch 'master' into pr/6950 2019-01-09 10:11:18 +01:00
Adrien Delorme
19cbb9cb24
Merge pull request #7136 from hashicorp/fix_5984 
Add "version" option to hyperv calls
 2019-01-09 10:06:49 +01:00
Adrien Delorme
1b84019a45
Merge pull request #7174 from edwardmlyte/reverse-default-vbox-portcount-arg 
Make portcount default argument for storagectl
 2019-01-08 17:35:43 +01:00
Ed Maxwell-Lyte
4fc02ea406 Assign to existing var 2019-01-08 16:19:11 +00:00
Adrien Delorme
f91b668617
Create portCountArg in the if statement 
You can't assign to something that doesn't exist

Co-Authored-By: edwardmlyte <edwardmlyte@gmail.com>
 2019-01-08 16:15:24 +00:00
Ed Maxwell-Lyte
a9eed311a6 Run gofmt on driver_4_2.go 2019-01-08 15:58:12 +00:00
Rickard von Essen
c8fab8c7a3
Merge pull request #7037 from kmbulebu/openstack_tags 
openstack: `image_tags` - Adds support for tagging new images.
 2019-01-08 16:53:21 +01:00
Ed Maxwell-Lyte
e5b1e0f4d9 Add version 0.x to the rule 2019-01-08 15:35:45 +00:00
Ed Maxwell-Lyte
e40c90423f Reverse default port count virtualbox argument 
As we know the exact versions that used the old `sataportcount` option, it's safe to assume we want to use the newer `portcount` option for everything else.

Reversed the option check and use the `portcount` option by default. Prevents needing to update this for future major versions of VirtualBox.
 2019-01-08 14:14:26 +00:00
Rickard von Essen
e3f82d3725
Merge pull request #6933 from cb-oath/openstack-v2-network-optional 
openstack: Make the config.networkV2Client conditional in StepAllocateIp
 2019-01-07 08:48:38 +01:00
Megan Marsh
16149844a7
Merge pull request #7151 from nelsonjchen/qemu-whpx-option 
Add support for whpx accelerator to qemu builder
 2019-01-04 12:37:03 -08:00
Megan Marsh
c789a68d89
Merge pull request #7154 from ladar/fix-hyperv-ssh-host-bug 
Fix ssh_host bug in hyper-v builders.
 2019-01-04 12:14:13 -08:00
Nelson Chen
b39f398fda Add support for whpx accelerator to qemu builder 
Windows Hypervisor Platform (WHPX) is the Windows counterpart to HVF and
KVM. It's an operating system provided component that provides
virtualization acceleration support.

This is kind of the missing counterpart to https://github.com/hashicorp/packer/pull/6193.
QEMU 2.12 also added support for WHPX.

There's no support for libvirt on Windows so nothing was added in those
areas.

The popular QEMU for Windows distribution does not have WHPX support
built-in for legal reasons as the maintainer does not wish to use or
obtain any part of Microsoft's SDK to compile the distribution.
 2019-01-03 15:20:37 -08:00
Adrien Delorme
7132037faa
Merge pull request #7137 from YuSungDuk/fix_to_get_ssh_password 
Fix to get ssh password
 2019-01-03 11:22:14 +01:00
Rickard von Essen
21a7a0a614
parallels: Fix attaching prl tools 
Closes #7155
 2019-01-02 21:33:58 +01:00
Ladar Levison
217028b902 Added comment regarding use of host param. 2018-12-27 03:34:08 -06:00
Ladar Levison
8a9962882c Use Printf not Println. D'oh. 2018-12-27 03:15:44 -06:00
Ladar Levison
35aaf44fa5 A properly formatted hyperv ssh.go file. 2018-12-27 02:55:14 -06:00
Ladar Levison
cb0011d665 Fix ssh_host bug in hyper-v builders. 2018-12-27 02:33:58 -06:00
유성덕
38c4e21563 Fix to get ssh password 2018-12-21 17:53:52 +09:00
Megan Marsh
141f3b29f3
Merge pull request #7127 from ladar/master 
Added change support to docker-import post processor.
 2018-12-20 14:44:05 -08:00
Adrien Delorme
7655d2efb2
Add tencent cloud builder (#7135 & #6839) 2018-12-20 17:09:44 +01:00
Megan Marsh
006682a09c add version option and also refactor powershell script to use golang templates for ease of testing and variable passing. 2018-12-19 16:30:57 -08:00
Adrien Delorme
e666b60d16
Merge pull request #7126 from hashicorp/fix_7125 
fix packer crash that occurs when image is nil
 2018-12-19 09:25:28 +01:00
Megan Marsh
56d722f779
Merge pull request #7130 from jo/openstack-add-volume-size-option 
Openstack add volume size option
 2018-12-18 16:35:25 -08:00
Megan Marsh
d288f94073
Merge pull request #7128 from ladar/hyperv-legacy-network-adapter 
Updated support for legacy network adapters on Hyper-V.
 2018-12-18 15:32:35 -08:00
Johannes J. Schmidt
a545caa24a use openstack volume_size option on creation 
if present. Otherwise fallback to to source image min disk value (if
set) or calculated from the source image bytes size.

Note that in some cases this needs to be specified, if
`use_blockstorage_volume` is true. See #6957 for the discussion.
 2018-12-18 23:59:54 +01:00
Johannes J. Schmidt
336c11c54a add openstack volume_size option 
Adds an option to OpenStack, `volume_size` (int), which is the size of
the Block Storage service volume in GB.
 2018-12-18 23:58:27 +01:00
Christopher Boumenot
acacf6e59c
Merge pull request #7111 from hashicorp/pr-7077-azure-regression 
azure: fix snapshot regression
 2018-12-18 09:53:52 -08:00
Ladar Levison
bdcbf61ade Fixed replace variable name. 2018-12-18 06:18:51 -06:00
Ladar Levison
fa154f5298 Fixed driver mock up formatting. 2018-12-18 06:14:38 -06:00
Ladar Levison
31d03fb48e Added legacy network adapter driver mock up. 2018-12-18 06:12:05 -06:00
Ladar Levison
da8b140bca Fix Hyper-V builder formatting. 2018-12-18 05:50:16 -06:00
Ladar Levison
348c267054 Updated support for legacy network adapters on Hyper-V. 2018-12-18 04:59:00 -06:00
Ladar Levison
6ac5971288 Fixed cmd order for docker driver. Added config to post proc. 2018-12-17 22:59:41 -06:00
Ladar Levison
10095678c8 Adding driver changes. 2018-12-17 22:37:32 -06:00
Ladar Levison
21fdbadf04 Adding changes to import prototype. 2018-12-17 22:35:59 -06:00
Ladar Levison
050f809a1c Add changes var to docker driver import func. 2018-12-17 22:04:43 -06:00
Megan Marsh
19144111dd fix packer crash that occurs when image is nil 2018-12-17 14:54:27 -08:00
wizurijyq
8184fcb99a
Make sure sshkey is not nil 2018-12-14 22:30:26 +01:00
DanHam
0821653256
Fix 'nil' dir in VMware artifact when building locally 2018-12-14 13:21:41 +00:00
Megan Marsh
2045390e74
Merge pull request #7108 from hashicorp/revert_hddorder_setting 
Revert hddorder setting
 2018-12-13 16:27:31 -08:00
Christopher Boumenot
f9230aeb95 azure: fix snapshot regression 2018-12-13 13:58:18 -08:00
Megan Marsh
7d5ea43f41 revert the hddorder being added to the vmx template, since it's breaking things for some of our users. 2018-12-13 09:58:24 -08:00
Megan Marsh
b95123f457 add new copy_in_compare flag so users can set the copy var to whatever they need in order to get the compatibility report to work. 2018-12-13 09:12:23 -08:00
Adrien Delorme
2718a5ed62 Revert "revert changes to docker entrypoint; since this is a backwards-breaking change it needs to wait for a minor release" 
This reverts commit 2a79d64ae0.
 2018-12-13 10:23:46 +01:00
Adrien Delorme
47257c0d07
Merge pull request #7104 from hashicorp/revert_docker_changes 
revert changes to docker entrypoint; since this is a backwards-breaki…
 2018-12-13 10:23:18 +01:00
Megan Marsh
ee2e5cc874
Merge pull request #7080 from hashicorp/do_6508 
Move logging about aws waiters to the access config prepare() so that…
 2018-12-12 15:42:37 -08:00
Megan Marsh
2a79d64ae0 revert changes to docker entrypoint; since this is a backwards-breaking change it needs to wait for a minor release 2018-12-12 15:30:24 -08:00
Megan Marsh
279949ddcc
Merge pull request #7090 from tomelliff/validate-kms-key-id 
Check that the KMS key ID is valid
 2018-12-12 10:04:22 -08:00
Adrien Delorme
b7222d1f56 Add tmp package that offers Dir & File funcs 
this regroups the calls of tmp func calls into one package.
the tmp pkg allows to store tmp files under a common directory for easier managment

Squashed commit of the following:
commit 74b674c015
Merge: fc94b5714 66001525d
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Fri Nov 2 02:02:38 2018 -0400

    Merge branch 'remove_TMPDIR_docs' of github.com:tb3088/packer into remove_TMPDIR_docs

commit fc94b57142
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Fri Nov 2 01:42:38 2018 -0400

    update tests to honor configured temporary directory

commit 5a562359f4
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 18:52:38 2018 -0400

    sync straggler to refactor. implement tests at packer/configfile instead of buried in docker.

commit 9d5a4a0935
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 15:39:46 2018 -0400

    insert URL to GoLang API for os.TempDir()

commit fbae4c2e05
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 07:41:29 2018 -0400

    revise documentation to match code

commit 3590fae8bd
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 07:21:59 2018 -0400

    refacter config_file. replace all hard-coded os.TempDir with wrapper

commit d5c5306a97
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 20:11:36 2018 -0400

    close massive file overwrite hole with TempDir

commit 0a72297da8
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 01:06:00 2018 -0400

    adjust var declaration scope

commit 20f68228b6
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 00:54:35 2018 -0400

    use mktemp() equivalent to create temporary directory

commit c73ebe3d83
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 20:40:58 2018 -0400

    remove extraneous variable declaration, fix FOR loop

commit 63549b8bd7
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 19:30:44 2018 -0400

    match styistic convension with rest of docs

commit 9761010749
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 19:08:39 2018 -0400

    revert dangling config file change

commit 95159afbc0
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Fri Dec 29 23:53:43 2017 -0500

    replace invalid TMPDIR variable wth PACKER_TMP_DIR.
    update ConfigTmpDir() to try common temporary paths first and
    only write to configDir() as a last resort.

commit 66001525d7
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Fri Nov 2 01:42:38 2018 -0400

    update tests to honor configured temporary directory

commit e9b6adefea
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 18:52:38 2018 -0400

    sync straggler to refactor. implement tests at packer/configfile instead of buried in docker.

commit 852113ed07
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 15:39:46 2018 -0400

    insert URL to GoLang API for os.TempDir()

commit 54add38d1d
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 07:41:29 2018 -0400

    revise documentation to match code

commit 6b5b8f6d4e
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Thu Nov 1 07:21:59 2018 -0400

    refacter config_file. replace all hard-coded os.TempDir with wrapper

commit c22092c601
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 20:11:36 2018 -0400

    close massive file overwrite hole with TempDir

commit 7a73045091
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 01:06:00 2018 -0400

    adjust var declaration scope

commit 0f2933adb6
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Wed Oct 31 00:54:35 2018 -0400

    use mktemp() equivalent to create temporary directory

commit d74839ede0
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 20:40:58 2018 -0400

    remove extraneous variable declaration, fix FOR loop

commit eb65416619
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 19:30:44 2018 -0400

    match styistic convension with rest of docs

commit acaa2b31ed
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 19:08:39 2018 -0400

    revert dangling config file change

commit e573fde668
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Fri Dec 29 23:53:43 2017 -0500

    replace invalid TMPDIR variable wth PACKER_TMP_DIR.
    update ConfigTmpDir() to try common temporary paths first and
    only write to configDir() as a last resort.

commit 39a9874afc
Merge: 8a413cfe8 3315812c2
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Oct 30 18:19:26 2018 -0400

    Merge branch 'master' of https://github.com/hashicorp/packer into prestine

commit 8a413cfe83
Merge: e07491de5 4e14710a6
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Mon Oct 1 20:18:10 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit e07491de59
Merge: 42610a35d a1fa35dff
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Tue Aug 21 13:26:19 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit 42610a35d5
Merge: 5298142da 0d63cf7bc
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Tue Jun 19 22:45:05 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit 5298142da6
Merge: 7bb110bc7 9d9736552
Author: Matthew Patton <mpatton@enquizit.com>
Date:   Mon Jun 11 15:10:09 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit 7bb110bc74
Merge: a61c869ca 6189d66e7
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Wed May 9 23:41:22 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit a61c869ca7
Merge: 098101dd9 4be5f072c
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Fri May 4 10:13:04 2018 -0400

    Merge remote-tracking branch 'upstream/master' into prestine

commit 098101dd99
Merge: fefaf0fa6 554b2b4a5
Author: Matthew Patton <matthew.patton@itgfirm.com>
Date:   Tue May 1 20:52:30 2018 -0400

    Merge branch 'EOL-handling' into prestine

Co-Authored-By: Matthew Patton <pattonme@yahoo.com>
 2018-12-12 16:35:57 +01:00
Tom Elliff
12bf7fc4d6 Check that the KMS key ID is valid 
KMS key IDs can be given as either a raw key ID, an alias (always prefixed with 'alias/'), the full ARN to the KMS key ID or the full ARN to the KMS key alias.

Should help with https://github.com/hashicorp/packer/issues/6599 but probably isn't enough to fully close it.
 2018-12-12 11:41:58 +00:00
Adrien Delorme
dfa284c02b
Merge pull request #7094 from hashicorp/fix_7087 
fix virtualbox 6.0 beta command options
 2018-12-11 11:54:56 +01:00
Adrien Delorme
5e5ed9793f
Merge pull request #7092 from arizvisa/vmware-builders.halt-duplicate-code 
Tiny fix to replace some duplicate code with usage of the already defined `halt` closure in the StepCloneVMX step for the vmware-vmx builder.
 2018-12-11 11:53:26 +01:00
Megan Marsh
a819217c93 fix virtualbox 6.0 beta command options 2018-12-10 15:18:21 -08:00
Ali Rizvi-Santiago
1a36458e9e Tiny fix to replace some duplicate code with usage of the halt closure in the StepCloneVMX step for the vmware-vmx builder. 2018-12-10 16:24:27 -06:00
Megan Marsh
d367c1ba8b
Merge pull request #7091 from arizvisa/GH-6920 
Proper fix to #6920 which ensures that entrypoint and arguments get passed to docker, not the image.
 2018-12-10 13:25:34 -08:00
Ali Rizvi-Santiago
a6af04417e Moved the entrypoint argument for the docker builder in front of the image so it's passed correctly as an argument. 2018-12-10 15:09:56 -06:00
Megan Marsh
32f226eda0
Merge pull request #7069 from arizvisa/GH-6920 
Updated docker's default config to use regular bourne shell instead of bourne again.
 2018-12-10 11:29:27 -08:00
chhaj5236
c4782807de
Merge pull request #7050 from chhaj5236/feature/force_delete_copied 
alicloud: delete copied image and snapshots if corresponding options are specified
 2018-12-09 19:39:14 +08:00
Adrien Delorme
c42b3a41a9
Merge pull request #7059 from hashicorp/fix_6965 
Fix 6965
 2018-12-07 13:35:00 +01:00
Megan Marsh
ce71932f95
Merge pull request #7061 from boumenot/pr-6773-caching-type 
azure: configuration for disk caching
 2018-12-06 15:06:21 -08:00
Megan Marsh
042e9ad14b Move logging about aws waiters to the access config prepare() so that it's only spit out once per builder. 2018-12-06 14:37:31 -08:00
Megan Marsh
dbfc1b5aff fix tests 2018-12-06 09:36:16 -08:00
Megan Marsh
0058422a5c also for vmx 2018-12-05 15:58:44 -08:00
Megan Marsh
0fe4d79bbf add validation to prevent users from being confused about format functionality 2018-12-05 15:57:45 -08:00
Ali Rizvi-Santiago
2e977019e4 Modified the docker builder's default run_command to specify the shell via the entrypoint command line argument as suggested by @vrubiolo in #6920. 2018-12-04 23:52:17 -06:00
bozhi.ch
0174a502eb support -force option and update docs 2018-12-05 11:50:35 +08:00
Ali Rizvi-Santiago
310ea6c006 Updated docker's default config to use regular bourne shell instead of bourne again. Closes #6920. 2018-12-04 18:28:48 -06:00
Ali Rizvi-Santiago
040a33567e Trying again one more time to prevent import cycles.. Moved common.ExpandUser into packer.ExpandUser.. 2018-12-04 16:54:47 -06:00
Ali Rizvi-Santiago
79b68fb89c Replaced the previous incorrect logic with an re-implementation of common.ExpandUser. 2018-12-04 16:53:33 -06:00
Ali Rizvi-Santiago
e04986659a Changed the logic for when to actually prefix a path with a u.HomeDir so that it's only done when a non-absolute path is specified. 2018-12-04 16:53:33 -06:00
Ali Rizvi-Santiago
1a3c3f2ffc Replaced all instances of mitchellh/go-homedir with an implementation based on os/user. 2018-12-04 16:53:33 -06:00
Megan Marsh
152f6fed8f
Merge pull request #7066 from arizvisa/vmware-temporary-devices 
Add a "temporaryDevices" key to the statebag for the VMware builder
 2018-12-04 10:34:37 -08:00
Ali Rizvi-Santiago
96bdf17d2e Added knowledge of the "temporaryDevices" statebag to the StepCleanVMX tests for the VMware builders. 2018-12-03 18:03:02 -06:00
Megan Marsh
65124985d1 don't set DetectZeroes if it's off, because some versions of QEMU don't support this option 2018-12-03 15:52:13 -08:00
Ali Rizvi-Santiago
fa4998e1ec Modified StepCleanVMX to walk through the "temporaryDevices" statebag so that we can disable or remove its devices cleanly. This gets rid of the regex hack that was previously used to identify a cdrom-image. 2018-12-03 17:50:40 -06:00
Ali Rizvi-Santiago
e0d3861e81 Updated StepCreateVMX to add the CDROM device that packer uses to the "temporaryDevices" statebag so that StepCleanVMX can unmount its ISO later. 2018-12-03 17:48:05 -06:00
Ali Rizvi-Santiago
3512c3c5ea Updated StepConfigureVMX to add the floppy disk device to the "temporaryDevices" statebag so that StepCleanVMX can remove it later. 2018-12-03 17:48:05 -06:00
Ali Rizvi-Santiago
27b16cee0a Added a new "temporaryDevices" key to the VMware builders' statebag in order to keep track of devices that were temporarily added during build and need to be removed later by StepCleanVMX. 2018-12-03 17:47:45 -06:00
Christopher Boumenot
c7d8f4e150 azure: configuration for disk caching 
Export a configuration knob to change the disk caching setting. The
default value remains ReadWrite.  This seems the most appropriate value
given Packer.  Certain disk sizes require that disk caching be disable,
and this knob allows the user to do just that.
 2018-11-30 14:14:43 -08:00
Andrew Starr-Bochicchio
c0c5c6afac Add DigitalOcean post-processor. 2018-11-29 21:00:57 -05:00
Megan Marsh
c03894c05d fix bad interpolation exemption for volume_size 2018-11-29 16:39:43 -08:00
Adrien Delorme
c29268a5d2
Merge pull request #7046 from nferch/hcloud_snapshot_labels 
add snapshot_labels to hcloud builder
 2018-11-29 13:48:57 +01:00
Megan Marsh
a2c3b35bff
Merge pull request #7032 from hashicorp/fix_region_validation 
move region validation to run so that we don't break validation when no creds are set
 2018-11-28 15:02:18 -08:00
Megan Marsh
11ef407b4d
Merge pull request #7016 from rickard-von-essen/vmware-tech-prev 
vmware: Correctly parse version for VMware Fusion Tech Preview
 2018-11-28 14:59:53 -08:00
PORTE Loïc
bf97557abf Backport VNC log from vmware to qemu 2018-11-28 19:13:29 +01:00
bozhi.ch
a485bcfdf3 delete copied image and snapshots if corresponding options are specified 2018-11-28 21:34:21 +08:00
Megan Marsh
ec75913412 fix crash that occurs when dir is nil 2018-11-27 16:34:26 -08:00
Megan Marsh
89fb8f0d3e fix defaulting/lack thereof for cpu count and memory in vmware template 2018-11-27 15:43:48 -08:00
Nathan A. Ferch
fccd7d0692 add snapshot_labels to hcloud builder 2018-11-27 14:41:32 -05:00
Megan Marsh
6728244480 simplify for loop logic 2018-11-27 09:33:29 -08:00
Andrew Pennebaker
c05ac784d3 fix tests 2018-11-27 09:31:01 -08:00
Andrew Pennebaker
5ada3376b8 fix test 2018-11-27 09:31:01 -08:00
Andrew Pennebaker
2c989157e4 gofmt 2018-11-27 09:31:01 -08:00
Andrew Pennebaker
5b6cbeed1d expose --iso option down in VBoxManage export --iso up to virtualbox-iso configuration as "bundle_iso"; ensure ISOs are not removed when this is enabled. 2018-11-27 09:31:01 -08:00
Megan Marsh
8cc3320977
Merge pull request #7034 from zenjoy/hcloud/rescue_mode 
[Hetzner Cloud] Support for builds using rescue mode
 2018-11-26 11:39:34 -08:00
bozhi.ch
7704ff2f24 apply tags to relevant snapshots 2018-11-26 16:58:32 +08:00
dedene
1aaa998b02 Revert back to reset server 2018-11-26 09:49:45 +01:00
dedene
6589bfaaab Small code improvements and fixes 2018-11-26 09:10:17 +01:00
zhuzhih2017
53bfe7179f
Merge pull request #7022 from chhaj5236/feature/image_without_datadisks 
alicloud: support creating image without data disks
 2018-11-26 13:13:51 +08:00
Kevin Bulebush
76d1bf567e Replaced compute/v2/images with imageservice/v2/images. 
Removed usage of a deprecated API.
Standardized clientService naming.
 2018-11-25 14:30:31 -05:00
bozhi.ch
3c1395eb04 support wait_snapshot_ready_timeout for much bigger disk 2018-11-25 16:05:26 +08:00
dedene
0f3bfbf8e6 Fix timing issues by updating to hcloud-go v1.11.0 2018-11-24 17:56:09 +01:00
Kevin Bulebush
802e7d467d openstack: Add support for tagging new images. 2018-11-23 20:22:10 -05:00
dedene
064e6c7e08 Add support for builds using rescue mode 2018-11-23 20:35:32 +01:00
Adrien Delorme
e539133d8c
Merge pull request #7019 from arizvisa/vmware.cpu-memory 
Add configuration options to vmware builder to specify cpu count and memory size
 2018-11-23 10:53:46 +01:00
Adrien Delorme
24510907be
Merge pull request #7018 from arizvisa/parallels.cpu-memory 
Add configuration options to parallels builder to specify cpu count and memory size
 2018-11-23 10:50:01 +01:00
Adrien Delorme
174c811c1e
Merge pull request #7017 from arizvisa/virtualbox.cpu-memory 
Add configuration options to virtualbox builder to specify cpu count and memory size
 2018-11-23 10:27:14 +01:00
Ali Rizvi-Santiago
f8c23c1808 Updated things related to the vmware-iso builder to include @azr's suggestions. 2018-11-22 21:03:06 -06:00
Ali Rizvi-Santiago
0f019407d6 Updated things related to the general hw config in the virtualbox builders to correspond to @azr's suggestions. 2018-11-22 20:48:00 -06:00
Ali Rizvi-Santiago
784535a4e3 Updated things related to the parallels-iso builder to correspond to @azr's suggestions. 2018-11-22 20:19:00 -06:00
Ali Rizvi-Santiago
61ee3a44f5 Modified the cpus and memory options for the vmware builders to only apply them if they were specified. 2018-11-21 00:43:14 -06:00
Megan Marsh
da6e350949 fix tests 2018-11-20 15:20:01 -08:00
Megan Marsh
fbb3d526e3 move region validation to run so that we don't break validation when we don't have aws creds set 2018-11-20 15:01:28 -08:00
Nathan A. Ferch
849a6ed353 add ssh_keys config to hcloud builder 2018-11-20 13:58:17 -05:00
bozhi.ch
3c2c13a021 support creating image without data disks 2018-11-19 15:25:12 +08:00
Ali Rizvi-Santiago
fb7ce9f2b5 Renamed both cpu_count and memory_size to cpus and memory (respective). 2018-11-17 06:36:02 -06:00
Ali Rizvi-Santiago
eca26f43f2 Renamed both cpu_count and memory_size to cpus and memory (respective). 2018-11-17 06:34:22 -06:00
Ali Rizvi-Santiago
24140131c7 Renamed both cpu_count and memory_size to cpus and memory (respective). 2018-11-17 06:32:11 -06:00
Ali Rizvi-Santiago
51948daf92 Added options for the cpu count, memory, audio, and usb to the virtualbox builder. 2018-11-17 06:19:54 -06:00
Ali Rizvi-Santiago
71d15d05c0 Added support for the cpu_count, memory_size, sound, and usb options to the parallels builder. 2018-11-17 06:13:59 -06:00
Ali Rizvi-Santiago
cd45248eaa Moved common hardware config options used by the vmware-iso builder into common/hw_config and added options for the CpuCount and MemorySize. 2018-11-17 06:08:08 -06:00
Rickard von Essen
4ea3d1567a
vmware: Correctly parse version for VMware Fusion Tech Preview 
Closes #5317
 2018-11-17 09:32:15 +01:00
Ali Rizvi-Santiago
4e73c85e22 Re-sorted, grouped, and commented the options in the template VMX for the VMWare builder to keep things organized. 2018-11-16 22:20:00 -06:00
Christopher Boumenot
06c2c35e4c
Merge pull request #6980 from amydutta/amdut/snapshot 
Adding options for Managed Image OS Disk and Data Disk(s) snapshot(s)
 2018-11-16 15:51:52 -08:00
Amrita Dutta
b8def0b3fb Added test to check for missing OS disk snapshot name and data disk snapshot prefix 2018-11-15 22:01:16 +00:00
Amrita Dutta
67342750a3 Addressed PR comments 2018-11-14 01:47:48 +00:00
Megan Marsh
dca02c7b07
Merge pull request #6962 from hashicorp/fix_6940 
escape vSphere username when putting it into the query
 2018-11-13 10:15:25 -08:00
Megan Marsh
3b413d2e5e fix rebase conflicts 2018-11-12 13:24:03 -08:00
Megan Marsh
89184ae384 rework if/else to simplify main code body. 2018-11-12 13:21:25 -08:00
Megan Marsh
536e0501ac Validate username/password for ovftool during prepare. 
Add template option skip_validate_credentials allowing users to skip this validation if they don't want it.
Refactor vmware-iso builder to separate out config so that it matches the vmware-vmx builder and simplifies the builder.go file
 2018-11-12 13:21:25 -08:00
Megan Marsh
7643ccc67d
Merge pull request #6982 from hashicorp/fix_6161 
azure builder: allow to auth with managed identities ( MSI )
 2018-11-12 09:03:41 -08:00
Megan Marsh
49b40e0789
Merge pull request #6984 from hashicorp/add_display_name_vmware 
add new display_name template option
 2018-11-12 08:49:38 -08:00
Adrien Delorme
f1fa28847f
remove debug line. 
Co-Authored-By: SwampDragons <megan@hashicorp.com>
 2018-11-12 08:07:08 -08:00
Adrien Delorme
78ac943679
Merge pull request #6987 from hashicorp/6624 
6624
 2018-11-12 15:31:36 +01:00
Adrien Delorme
175b6a7971 add test for MSI configuration 2018-11-12 12:04:57 +01:00
Adrien Delorme
1958ef6e81 remove unecessary check 2018-11-12 11:32:49 +01:00
Adrien Delorme
08e8b1850e
remove unnecessary parenthesis 2018-11-12 10:49:39 +01:00
Amrita Dutta
2d6b18e63e Fix tests after bug fix 2018-11-10 00:05:25 +00:00
Megan Marsh
2e2b2cea82 add a warning that checks for collisions between packer-generated values in the default vmx file and the vmx_data 2018-11-09 15:46:52 -08:00
Amrita Dutta
213fbbae00 Updated go version and reformatted 2018-11-09 22:41:48 +00:00
Megan Marsh
3cf4c63a87 Change antiquated Master/Slave terminology for disk drives to more appropriate Primary/Secondary. 2018-11-09 14:00:07 -08:00
Megan Marsh
e5c4a4a6fb create export directories for vmx and ovf file types, too. 2018-11-09 11:45:36 -08:00
Amrita Dutta
a297d73b98 correcting wrong log message 2018-11-09 19:29:57 +00:00
Amrita Dutta
06525dd885 adding logs in the steps 2018-11-09 19:28:37 +00:00
Megan Marsh
68c9e34bfe add new display_name template option 2018-11-09 10:54:31 -08:00
Megan Marsh
be0959004a
Revert "Revert "Rename attribute api_access_key to organization_id"" 2018-11-09 08:47:22 -08:00
Adrien Delorme
1ab0173e69 azure builder: allow to auth with managed identities ( MSI ) 2018-11-09 17:39:03 +01:00
Amrita Dutta
8881bc2d64 Fix bug in snapshot client creation 2018-11-09 03:30:57 +00:00
Megan Marsh
c1c929164f
Revert "Rename attribute api_access_key to organization_id" 2018-11-08 16:34:23 -08:00
Megan Marsh
210d62de2c
Merge pull request #6925 from sieben/organization_renaming 
Rename attribute api_access_key to organization_id
 2018-11-08 16:33:15 -08:00
Rémy Léone
e54d2e3591 Rename attribute api_access_key to organization 2018-11-08 13:45:32 +01:00
Mikhail Ushanov
536252683e builders: reuse private key file reading function 
Signed-off-by: Mikhail Ushanov <gm.mephisto@gmail.com>
 2018-11-08 14:25:50 +03:00
Amrita Dutta
8d8c86366b Config tests + typo fix 2018-11-07 22:23:22 +00:00
Amrita Dutta
1fa9f1ef11 formatting changes in stateBag.go 2018-11-07 18:11:48 +00:00
Amrita Dutta
8c326dbab7 Formatting changes 2018-11-07 18:08:15 +00:00
Amrita Dutta
b2d1675d39 Added tests 2018-11-07 03:23:17 +00:00
Amrita Dutta
369b2dae5e Inlining suggested functions 2018-11-06 21:50:53 +00:00
Megan Marsh
790d5661c5 escape username 2018-11-06 11:30:45 -08:00
Amrita Dutta
593363c5be fix typo in last commit 2018-11-06 19:23:15 +00:00
Amrita Dutta
1266d5146d addressed PR comments + add file for data disk snapshots 2018-11-06 19:17:03 +00:00
Megan Marsh
8567be43d9
Merge pull request #6927 from hashicorp/rebased_4591 
Extend vmware-vmx builder to allow esxi builds. (Rebase of PR #4591)
 2018-11-06 09:59:26 -08:00
Megan Marsh
96d628eef1 fix silliness with pointers 2018-11-06 09:50:28 -08:00
Amrita Dutta
d12d23d34b OS disk snapshot 2018-11-05 23:48:22 +00:00
Megan Marsh
79862f1bbb
Merge pull request #6931 from hashicorp/fix_6919 
aws: better error handling of region/credential guessing from metadata
 2018-11-05 11:24:09 -08:00
Megan Marsh
5c2ca450bd fix tests 2018-11-02 15:44:27 -07:00
Megan Marsh
5815b376b4 remove unnecessary checks; we always default format to ovf if it is unset. 
fix exportoutputdir
 2018-11-02 14:22:01 -07:00