upstream/packer
1
0
Fork 0
mirror of https://github.com/hashicorp/packer.git synced 2026-02-24 10:21:20 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 4
15357 commits 313 branches 141 tags 156 MiB
Commit graph

5388 commits

Author SHA1 Message Date
Megan Marsh
6315f69019 break out of loop once channel is read from. 2020-01-15 11:00:41 -08:00
Megan Marsh
b8edaa9850
Merge pull request #8605 from hashicorp/fix_8599 
remove unhelpful quotes to fix bug with reading key from a path with …
 2020-01-15 10:56:23 -08:00
Megan Marsh
bbd64896a0 use strconv.unquote instead of DIY 2020-01-15 10:23:25 -08:00
Sylvia Moss
0e177915f8
Add retry mechanism to DeregisterImage from awsec2 (#8598) 2020-01-15 10:28:14 +01:00
Megan Marsh
5980d32efb remove unhelpful quotes to fix bug with reading key from a path with spaces in it. 2020-01-14 13:57:11 -08:00
Megan Marsh
82f03fca7c fix to work with hcl2; update tests 2020-01-13 15:52:05 -08:00
Megan Marsh
dfb45e86cc remove unused file, set up prepare() properly to work with HCL2 in vsphere-clone builder 2020-01-13 12:33:56 -08:00
Megan Marsh
9459e2233b fix config loading to work with HCL2 2020-01-13 11:51:36 -08:00
Megan Marsh
f84634aff3 small log line improvements 2020-01-13 11:43:53 -08:00
Sylvia Moss
d6a351b173
Rename communicator config variables and remove deprecated code (#8584) 2020-01-09 08:37:30 -08:00
Sylvia Moss
baa203bb53
Adds acpi_shutdown to virtualbox builder (#8587) 2020-01-09 08:36:19 -08:00
Moss
6a2d73a0e9 Add missing doc variable description 2020-01-08 15:28:53 -08:00
Megan Marsh
e87aa237dd Get plugin up to parity with v1.5.0. Remove custom jetbrains-internal testing logic; disable acceptance tests (for now) until we can set up a test rig inside of HashiCorp. Regenerate code based on vendoring changes. 2020-01-08 14:41:51 -08:00
Shengyu Liu
c3c2622204 builder/tencentcloud: Correct the image name length validation, the max length of image name is 60 (#8536) 2020-01-08 12:05:37 +01:00
Megan Marsh
073eda76aa remove extraneous files from when vsphere builder was a plugin, and move README into packer website as separated docs for vsphere-clone and vsphere-iso. Move option descriptions into struct code, and generate documentation directly from those structs as we do inside of the other builders 2020-01-07 16:59:31 -08:00
Megan Marsh
8cb1f7b1c1 Merge branch 'master' into merge-vsphere-builder 2020-01-07 14:23:38 -08:00
Megan Marsh
eeac289fa5
Merge pull request #8535 from alexyueer/master 
fix issue #8534
 2020-01-07 12:47:23 -08:00
Megan Marsh
21edd085c7
Merge pull request #8560 from alexyueer/feature/support_aliyun_profile_20200103 
support aliyun profile
 2020-01-07 12:45:54 -08:00
Megan Marsh
e9bb81a440
Merge pull request #8578 from hashicorp/unstick_vmware_shutdown_tests 
bump the timeout to a very high level to protect against laggy CI mac…
 2020-01-07 12:44:48 -08:00
Megan Marsh
7d789a1483
Merge pull request #8579 from hashicorp/do_8562 
step_download: return without error if Urls is empty
 2020-01-07 12:01:24 -08:00
Megan Marsh
c446bf07c5
Merge pull request #8574 from hashicorp/fix_8541 
Fix 8541
 2020-01-07 12:00:27 -08:00
Megan Marsh
90bdcf58bd update step_download to return an ActionContinue if the URls field is empty. this allows us to simplify the hyperv builder, and is still safe because all other builders and uses of step_download already validate that the iso url is not empty if that's what they need, most of them inside of the IsoConfig prepare function. 2020-01-07 10:45:24 -08:00
Megan Marsh
be3c1ef106 bump the timeout to a very high level to protect against laggy CI machines 2020-01-07 09:59:25 -08:00
Megan Marsh
af2c4346f8
Merge pull request #8561 from ata18/ata18-end-of-life 
Set expiry for image versions in SIG
 2020-01-07 09:53:14 -08:00
Adrien Delorme
7b5a868de2 virtualbox/vm.Builder: use config as a non pointer to avoid a panic 
this is a continuation to #8513
 2020-01-07 16:55:50 +01:00
Adrien Delorme
13ea97a1df mapstructure-to-hcl2: make basic named types pointers ( optional ) 2020-01-07 12:46:27 +01:00
Adrien Delorme
731904d3d2 mapstructure-to-hcl2: use accessor for named types and not named type + go genrate + tests 2020-01-07 11:44:22 +01:00
Megan Marsh
be97507088 delete qmp socket path. Also, clean up unnecessary use of statebag to recieve step values. (#8572) 2020-01-07 11:18:01 +01:00
Aishwarya Thangappa
9f24869e36 Update the error handling for end-of-life-date parsing 2020-01-06 22:58:26 -08:00
Aishwarya Thangappa
9569d35d14 Set expiry for image versions in SIG 
Updates azure builder to support setting end-of-life-date for
image versions in shared image gallery. In addition, this change adds
the ability to set the global replica count for the image version
and allows the vms deployed from the latest version of the Image
Definition to exclude this Image Version.
 2020-01-06 22:58:26 -08:00
Megan Marsh
b7ee807cf1
Merge pull request #8571 from hashicorp/fix_8565 
fix ssh interface docs for amazon builders
 2020-01-06 14:34:40 -08:00
Megan Marsh
6655f93b59 fix typo and regenerate code 2020-01-06 14:12:29 -08:00
Megan Marsh
7411a8a6ef
Merge pull request #8550 from tpounds/add-ami-owner-to-template 
Add source AMI owner ID/name to build template
 2020-01-06 13:38:49 -08:00
Megan Marsh
76251e5fd2 fix ssh interface docs for amazon builders 2020-01-06 12:01:30 -08:00
Lars Lehtonen
8098ba9cdf builder/virtualbox/common: remove unused url variable (#8559) 2020-01-06 16:45:05 +01:00
alexyueer
ec4a7b6af0 support aliyun profile 2020-01-03 12:17:34 +08:00
Trevor Pounds
47e48ebc24 Add source AMI owner ID/name to build template. 2019-12-30 14:04:49 -05:00
wujin
2e2f197bc3 add SecurityGroupId when DescribeSecurityGroups if user specify SecurityGroupId 2019-12-24 09:47:52 +08:00
Megan Marsh
348e00422e
Merge pull request #8509 from hashicorp/fix_step_import_panic 
Remove config dependency from inside StepImport
 2019-12-20 09:19:30 -08:00
Moss
7912e496aa Remove config dependency inside StepImport 2019-12-20 11:58:28 +01:00
Megan Marsh
127905e855 remove time flaky time limited tests (#8522) 
* remove flaky test. It isn't very useful anyway given that we're slowly adding retries to the checks for lockfiles

* remove time-component from retry test; in underpowered CI builds, this can flake fairly often.
 2019-12-20 08:16:18 +01:00
zhuzhih2017
66445ecd2d
Merge pull request #8425 from haoshuwei/master 
add show expired arg when describe image
 2019-12-20 13:33:55 +08:00
haoshuwei
37dc411f30 add skip_image_validation arg to use an expired image as the soure image 
Signed-off-by: haoshuwei <haoshuwei24@gmail.com>
 2019-12-20 11:28:31 +08:00
Wilken Rivera
f45d315be4
Merge pull request #8518 from hashicorp/update_jdcloud_config_pointer 
update jdcloud statebag to use pointers for config, to bring in line …
 2019-12-19 15:45:40 -05:00
Megan Marsh
f47d9f1b1f
Merge pull request #8514 from hashicorp/fix_5821 
Configure NAT interface before forwarded port mapping
 2019-12-19 11:30:33 -08:00
Megan Marsh
09489da149 update jdcloud statebag to use pointers for config, to bring in line with other implementations 2019-12-19 11:17:04 -08:00
Adrien Delorme
f1e6f8eac1 removed unused config puts 2019-12-19 18:06:39 +01:00
Adrien Delorme
a67948f155 fix config pointers 2019-12-19 17:51:57 +01:00
Moss
9216f43463 Configure NAT interface before forwarded port mapping 2019-12-19 17:03:31 +01:00
Moss
42cf9ef064 Remove pointer fixing panic on interface conversion 2019-12-19 13:30:54 +01:00
Wilken Rivera
a72242cd70
Merge pull request #8498 from hashicorp/f-builder_docker-typeassertion-check 
builder/docker: Fix interface conversion issue when getting config from state bag
 2019-12-17 18:08:00 -05:00
Megan Marsh
dca2c03cdb
Merge pull request #7866 from hashicorp/sharing_info 
Add new struct to Provision() method signature, allowing us to share connection and credential info generated at build time with provisioners.
 2019-12-17 14:55:20 -08:00
nywilken
9403d55549 builder/docker: Add type assertion check when reading config from state bag 2019-12-17 17:48:35 -05:00
nywilken
0ba6b22fee builder/docker: Update type of config stored in state bag 2019-12-17 17:48:35 -05:00
Ryan Hartje
bfc3b72050 attempting to resolve deployment quota issue due to non-cleanup 2019-12-17 09:57:57 -06:00
nywilken
1eb55c2ae3 builder/azure: Remove double override of GalleryImageVersionsClient.PollDuration 
This change fixes an issues where custom timeouts set for the
GalleryImagesVersionClient was being over written by the default client
poll duration.
 2019-12-17 10:47:32 -05:00
Adrien Delorme
4b7132c87c Merge remote-tracking branch 'origin/master' into sharing_info 2019-12-17 11:57:09 +01:00
Adrien Delorme
0785c2f6fc
build using HCL2 (#8423) 
This follows #8232 which added the code to generate the code required to parse
HCL files for each packer component.

All old config files of packer will keep on working the same. Packer takes one
argument. When a directory is passed, all files in the folder with a name
ending with  “.pkr.hcl” or “.pkr.json” will be parsed using the HCL2 format.
When a file ending with “.pkr.hcl” or “.pkr.json” is passed it will be parsed
using the HCL2 format. For every other case; the old packer style will be used.

## 1. the hcl2template pkg can create a packer.Build from a set of HCL (v2) files

I had to make the packer.coreBuild (which is our one and only packer.Build ) a public struct with public fields

## 2. Components interfaces get a new ConfigSpec Method to read a file from an HCL file.

  This is a breaking change for packer plugins.

a packer component can be a: builder/provisioner/post-processor

each component interface now gets a `ConfigSpec() hcldec.ObjectSpec`
which allows packer to tell what is the layout of the hcl2 config meant
to configure that specific component.

This ObjectSpec is sent through the wire (RPC) and a cty.Value is now
sent through the already existing configuration entrypoints:

 Provisioner.Prepare(raws ...interface{}) error
 Builder.Prepare(raws ...interface{}) ([]string, error)
 PostProcessor.Configure(raws ...interface{}) error

close #1768


Example hcl files:

```hcl
// file amazon-ebs-kms-key/run.pkr.hcl
build {
    sources = [
        "source.amazon-ebs.first",
    ]

    provisioner "shell" {
        inline = [
            "sleep 5"
        ]
    }

    post-processor "shell-local" {
        inline = [
            "sleep 5"
        ]
    }
}

// amazon-ebs-kms-key/source.pkr.hcl

source "amazon-ebs" "first" {

    ami_name = "hcl2-test"
    region = "us-east-1"
    instance_type = "t2.micro"

    kms_key_id = "c729958f-c6ba-44cd-ab39-35ab68ce0a6c"
    encrypt_boot = true
    source_ami_filter {
        filters {
          virtualization-type = "hvm"
          name =  "amzn-ami-hvm-????.??.?.????????-x86_64-gp2"
          root-device-type = "ebs"
        }
        most_recent = true
        owners = ["amazon"]
    }
    launch_block_device_mappings {
        device_name = "/dev/xvda"
        volume_size = 20
        volume_type = "gp2"
        delete_on_termination = "true"
    }
    launch_block_device_mappings {
        device_name = "/dev/xvdf"
        volume_size = 500
        volume_type = "gp2"
        delete_on_termination = true
        encrypted = true
    }

    ami_regions = ["eu-central-1"]
    run_tags {
        Name = "packer-solr-something"
        stack-name = "DevOps Tools"
    }
    
    communicator = "ssh"
    ssh_pty = true
    ssh_username = "ec2-user"
    associate_public_ip_address = true
}
```
 2019-12-17 11:25:56 +01:00
Megan Marsh
0f6d1beccf add an extra string array to the Prepare() return values in the builder interfaces; this sets up the ability for builders to give the provisioners custom user-accessible build-time variables. 2019-12-16 21:23:05 -08:00
Sylvia Moss
c57f093efe
Remove unnecessary source_path validation for virtualbox-ovf (#8489) 2019-12-16 16:50:21 +01:00
Sylvia Moss
0a8b172bf9 Remove duplicated retry mechanism when deleting VM ffrom virtual box (#8485) 
This retry was also added to fix a locked by session error reported in #5501 and fixed in #5512.
 2019-12-16 14:31:15 +01:00
Megan Marsh
84063d2132 implement ID and Type values in the provisioner template info sharing 2019-12-13 11:57:01 -08:00
Kris Hicks
40357e2534 docs/builder/azure-arm: Remove errant html comment (#8484) 
* Remove errant html comment from source

* make generate
 2019-12-13 10:35:24 -05:00
Sylvia Moss
2ee3311082
Retry command execution when VM session is locked (#8483) 2019-12-13 10:47:19 +01:00
Megan Marsh
3389d843f0 update all provisioners that used the winrmpassword tooling to use the new generateddata option 2019-12-12 16:42:53 -08:00
Sylvia Moss
c6b9efb522 Fix virtualbox-iso TestBuilderAcc_basic (#8481) 
make sure the test works for later usage
 2019-12-12 10:43:51 +01:00
Megan Marsh
6f418d0e54 get data sharing to a working state with the powershell provisioner 2019-12-11 15:43:38 -08:00
Megan Marsh
601007e3e2 pas data into provisioners well 2019-12-11 15:43:38 -08:00
Oded Priva
5e81c6f44e added the option to skip IAM instance profile validation (#8457) 2019-12-10 09:17:38 +01:00
Chris Doherty
1140504935 Merge remote-tracking branch 'packer-builder-vsphere/master' into cd/merge 2019-12-09 17:15:08 -08:00
Chris Doherty
ffcae91e8e Re-arrange directory structure for merge. 2019-12-09 17:14:55 -08:00
Sylvia Moss
2f63c581a0
Remove unnecessary 1 sec sleep (#8453) 2019-12-06 11:43:28 +01:00
Sylvia Moss
5ff5623433
Add disable_shutdown option to VirtualBox builder (#8449) 2019-12-05 14:34:56 +01:00
deisenzimmer
2b3935778e amazon-ebssurrogate plugin: StepSnapshotVolumes: Added mutex to synchronise map access across threads. (#8432) 2019-12-04 15:13:07 +01:00
Megan Marsh
de9f391a1c
Merge pull request #8430 from hashicorp/fix_8359 
Fix request retry mechanism  to launch aws instance
 2019-12-03 16:03:03 -08:00
Megan Marsh
05b972e550
Merge pull request #8444 from ad-m/hyperone-builder 
Fix tags & modernize config for HyperOne builder
 2019-12-03 10:30:26 -08:00
Megan Marsh
9fc37f9456
Merge pull request #8438 from hashicorp/fix_qemu_sizes 
make sure we continue to default to Megabytes for qemu disk size to p…
 2019-12-03 09:58:21 -08:00
Adam Dobrawy
a97ff7ce8b builder/hyperone: Update schema for cli config 2019-12-03 14:57:41 +01:00
Adam Dobrawy
3b091e6046 builder/hyperone: fix & add tests for tags 2019-12-03 14:57:40 +01:00
Megan Marsh
7d8f1c01c4 Revert "fix: persist default drive/device" (#8440) 
This reverts commit 30ccab4 which introduced the issue 8436.
 2019-12-03 13:42:11 +01:00
Megan Marsh
fcda07ee6a clarify docs by removing unclear string (#8439) 
the docs generator from code PR #7724  mis scrapped it
 2019-12-03 10:07:46 +01:00
Megan Marsh
f5806afda8 update docs 2019-12-02 16:04:29 -08:00
Megan Marsh
effd330945 make sure we continue to default to Megabytes for qemu disk size to prevent backwards incompatabilities. 2019-12-02 15:13:17 -08:00
Lars Lehtonen
df031db9da builder/azure/common/template: remove unused TemplateBuilder.getResourceByType2() (#8419) 
builder/azure/common/template: remove unused TemplateBuilder.toKeyVaultID()
 2019-12-02 18:09:42 +01:00
Ilhaan Rasheed
2c22b9f721 Update LXD directory upload command (#8416) 2019-12-02 12:01:18 +01:00
Moss
28c720bd3a Organize imports 2019-12-02 10:17:36 +01:00
Moss
250643d54b Remove 5 sec sleep after adding iam instance profile 2019-12-02 10:13:26 +01:00
Moss
4516978555 Fix request retry mechanism to run aws instance 2019-11-29 18:11:10 +01:00
Jon Allie
c31bbcf4cf builder/amazon: AmiFilterOptions.GetOwners: avoid taking the address of a loop iterator var (#8417) 
GetOwners() always returned a slice of pointers to the last value. Because slice ranging reuses the same local variable.
 2019-11-27 12:28:07 +01:00
Aurélien Guillaume
1a397b9fcd builder/osc: fix ssh host detection in Public Cloud and Nets 2019-11-26 17:50:30 +01:00
Mike Dziedziela
7c3e032fb7 amazon docs: update block-device-configuration docs (#8395) 
So that it works for all builders as some use it with the following field names: launch_block_device_mappings, ami_block_device_mappings or ebs_volumes. the refactored docs weird being to specific.
 2019-11-25 11:58:30 +01:00
henry-aj-jones
d317d7f3d1 post-processor/docker-tag: Allow to tag an artifact with multiple tags (#8392) 2019-11-22 11:48:36 +01:00
Megan Marsh
59e6e1d4d5
Merge pull request #8393 from hashicorp/fix_8362 
Add no_ephemeral template option to nuke ephemeral drives from launch mappings
 2019-11-21 16:08:50 -08:00
Megan Marsh
818d9bb087 send to step run spot instance 2019-11-21 13:21:56 -08:00
Megan Marsh
67c3373107 enable no_ephemeral for spot devices, clean up ranging behavior, update docs 2019-11-21 12:46:31 -08:00
Anthony Dong
2e989088e5 amazon-ebssurrogate: allow enabling ena/sr-iov on spot instances 2019-11-21 11:13:32 +01:00
Megan Marsh
08e97ba4d8 generate code for no_ephemeral option 2019-11-20 13:49:04 -08:00
Megan Marsh
0e2bdc8be6 forcibly prevent ephemeral drives from being created in the amazon-ebs builder, when no_ephemeral is set 2019-11-20 13:42:14 -08:00
DanHam
b40e5d90b6
builder/amazon/common/step_pre_validate: Return DescribeVpcs errors 2019-11-19 20:18:53 +00:00
nywilken
afb880c134 test/builder/amazon/common/step_pre_validate: Update DescribeVpcs mock 
* Update condition to check for a empty VpcId
 2019-11-19 14:48:07 -05:00
DanHam
074be9942d
Only validate the user has provided a subnet_id when vpc_id has been set 2019-11-19 14:09:58 +00:00
Lars Lehtonen
3571c585bb builder/googlecompute: fix dropped error (#8385) 2019-11-19 11:41:39 +01:00
Wilken Rivera
ad74a87b5c
Merge pull request #8360 from hashicorp/fix-7167 
builder/amazon: Add validation for `subnet_id` when specifying `vpc_id`
 2019-11-18 16:50:11 -05:00
nywilken
f9f4726eff builder/amazon/step_pre_validate: Add check for non-default VPCs 
Subnet information is only really needed when the specified `vpc_id` is
not the default VPC for the region where the builder is being executed.
This change uses the AWS API to determine if the VPC provided is a
non-default VPC and only validates the existence of a `subnet_id` if a
user has provided a non-default `vpc_id`.

Tests after change
```
> make test TEST=./builder/amazon/... TESTARGS='-count=1 -v -run=TestStepPreValidate_checkVpc'
...

=== RUN   TestStepPreValidate_checkVpc
=== RUN   TestStepPreValidate_checkVpc/DefaultVpc
=== RUN   TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet
=== RUN   TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet
=== RUN   TestStepPreValidate_checkVpc/SubnetWithNoVpc
=== RUN   TestStepPreValidate_checkVpc/NoVpcInformation
--- PASS: TestStepPreValidate_checkVpc (0.00s)
    --- PASS: TestStepPreValidate_checkVpc/DefaultVpc (0.00s)
    --- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcNoSubnet (0.00s)
    --- PASS: TestStepPreValidate_checkVpc/NonDefaultVpcWithSubnet (0.00s)
    --- PASS: TestStepPreValidate_checkVpc/SubnetWithNoVpc (0.00s)
    --- PASS: TestStepPreValidate_checkVpc/NoVpcInformation (0.00s)
PASS

...
```
 2019-11-18 16:44:09 -05:00
Megan Marsh
ef137a8f08
Merge pull request #8380 from bennu/qemu-args 
fix: persist default drive/device
 2019-11-18 11:05:45 -08:00
Megan Marsh
dfa134cd98 ditch else statement for improved clarity 2019-11-18 10:11:59 +01:00
Megan Marsh
ce8bca349f Update builder/amazon/ebs/step_create_ami.go 
Co-Authored-By: Adrien Delorme <azr@users.noreply.github.com>
 2019-11-18 10:11:59 +01:00
Megan Marsh
a35ac0127e fix bug in step_region_copy 2019-11-18 10:11:59 +01:00
bugbuilder
30ccab472f fix: persist default drive/device 2019-11-17 04:38:30 -03:00
Megan Marsh
437983343a
Merge pull request #8371 from stephentawn/master 
Fix error message when ovftool is missing
 2019-11-14 16:07:12 -08:00
Stephen Tawn
c66219084e Fix error message when ovftool is missing 2019-11-14 23:11:16 +00:00
Lars Lehtonen
59472c6aad
builder/lxc: fix dropped error 2019-11-14 13:40:40 -08:00
nywilken
488e539f63 builder/amazon: Add helper function for checking against AWSError 
Replace all straight forward occurrences of `if err, ok := err.(awserr.Error)` with the `isAWSErr` helper function
 2019-11-12 15:27:47 -05:00
Lars Lehtonen
4c9cfed743
builder/ncloud: fix dropped error 2019-11-11 20:56:55 -08:00
Lars Lehtonen
418152f23a
builder/digitalocean: fix dropped error on RSA key generation 2019-11-08 10:35:48 -08:00
Lars Lehtonen
643fce7b8a builder/hcloud: handle dropped ssh errors 2019-11-08 11:35:58 +01:00
Adrien Delorme
db4f242a24 go generate ./builder/qemu after #7676 2019-11-08 11:27:00 +01:00
Megan Marsh
6e2456d028 make error messaging around ResourceNotReady better, update docs with other possible issues (#8349) 2019-11-08 11:15:24 +01:00
Megan Marsh
98c94ab8cb
Merge pull request #7676 from ltrager/master 
Add display template option for qemu.
 2019-11-07 15:41:17 -08:00
Megan Marsh
e70e82d892
Merge pull request #8342 from cove/retry-runinstances2 
retry runinstances aws api that wasn't retried
 2019-11-07 15:39:02 -08:00
Li Kexian
f2f544c434 fixed get copy region value (#8345) 2019-11-07 11:12:19 +01:00
Megan Marsh
d5ba530b26 make it clear we expect pem format not some other formate (#8344) 2019-11-07 10:30:51 +01:00
Lars Lehtonen
5f02150e05
builder/vmware/common: defer close after testing for errors 2019-11-06 14:28:17 -08:00
cove
2898d66812
retry runinstances aws api that wasn't retried and could fail 2019-11-06 14:06:35 -08:00
Adrien Delorme
a36b94320a virtualbox: simplify ParseSnapshotData 2019-11-06 10:24:20 +01:00
Lars Lehtonen
5a0dc48f0f
builder/file: defer close after testing for errors 2019-11-05 11:40:42 -08:00
Adrien Delorme
116a038de9 Update snapshot.go 
avoid a panic on a too short slice.
 2019-11-05 15:48:32 +01:00
Adrien Delorme
44a7c49334
Merge pull request #8320 from hashicorp/do_8228 
re-add backwards incompatible changes to 1.5.0
 2019-11-05 14:40:48 +01:00
Adrien Delorme
ee6b72570b Update builder.hcl2spec.go 2019-11-05 14:21:07 +01:00
Megan Marsh
5692294a96 use absolute path for vagrantfile to avoid confusion with build directory later 2019-11-04 15:15:37 -08:00
Megan Marsh
6c704f7046 Revert "fix template imports" 
This reverts commit 0e70e0e5a4.
 2019-11-04 14:29:00 -08:00
Megan Marsh
d010762dbf Revert "Revert "Qemu builder disk size as a string"" 
This reverts commit 9c782f4d04.
 2019-11-04 14:28:48 -08:00
Megan Marsh
517834d528 Revert "Revert "remove clean_ami_name and clean_image_name; complete the deprecation for these functions in favor of clean_resource_name"" 
This reverts commit 44f91c9afc.
 2019-11-04 14:28:40 -08:00
Adrien Delorme
14243ce56a
Merge pull request #8305 from hashicorp/fix_8301 
allow nvme, since virtualbox 6.0 allows it
 2019-11-04 17:58:18 +01:00
Adrien Delorme
c935eb1435
Merge pull request #8308 from alrs/prune-dead-linode-func 
builder/linode: remove unused sshConfig() and associated import
 2019-11-04 15:57:29 +01:00
Adrien Delorme
a23801d4a9 builder.virtualbox.iso: document that EFI mode needs to be enabled for pcie/nvme to work too 2019-11-04 14:30:59 +01:00
Lars Lehtonen
9924d16fc3
builder/vmware/common: remove unused testHWConfig() 2019-11-01 19:13:26 -07:00
Lars Lehtonen
6eefe55e23
builder/vmware/iso: remove unused testState() 2019-11-01 19:11:42 -07:00
Lars Lehtonen
af1e41793d
builder/linode: move commHost() out of orphaned ssh.go 2019-11-01 19:02:52 -07:00
Lars Lehtonen
9dad09b9d3
builder/linode: remove unused sshConfig() function and associated import 2019-11-01 18:58:14 -07:00
Megan Marsh
fcb65ee422
Merge pull request #8307 from hashicorp/fix_8116 
delete amazon import post-processor intermediary snapshots
 2019-11-01 14:55:22 -07:00
Megan Marsh
e9e4c102e5 delete amazon import post-processor intermediary snapshots 2019-11-01 14:17:44 -07:00
Megan Marsh
974eba443a update docs to include warning about extension pack 2019-11-01 09:48:35 -07:00
Adrien Delorme
b790776096 vbox iso: use NVMe Controller when the hard drive interface if pcie 2019-11-01 14:43:59 +01:00
Adrien Delorme
86e24df947
Merge pull request #8304 from alrs/remove-dead-openstack-test-function 
builder/openstack: remove dead testConfig() function
 2019-11-01 11:06:50 +01:00
Adrien Delorme
1b7ef252d2
Merge pull request #8303 from alrs/amazon-builder-cleanup 
Cleanup builder/amazon/common
 2019-11-01 11:06:06 +01:00
Megan Marsh
6f54468dd5 fix mocks 2019-10-31 15:36:22 -07:00
Megan Marsh
65ad3105b3 udpdate generated code 2019-10-31 15:28:36 -07:00
Megan Marsh
9343a23021 add driver calls to enable nvme controller 2019-10-31 15:21:52 -07:00
Megan Marsh
d2867c47f0 allow nvme, since virtualbox 6.0 allows it 2019-10-31 14:43:46 -07:00
Lars Lehtonen
b68c75ea3e
builder/openstack: remove dead testConfig() function 2019-10-31 13:36:00 -07:00
Lars Lehtonen
d072079899
builder/amazon/common: remove dead test type and function mockEC2Conn_Modify_EBS.ModifyInstanceAttribute() 2019-10-31 12:38:32 -07:00
Lars Lehtonen
953be1603b
builder/amazon/common: remove dead test type and function mockEC2ConnSpot.DescribeSpotPriceHistory() 2019-10-31 12:34:11 -07:00
Lars Lehtonen
7a09f9c678
builder/amazon/common: remove dead test function fakeModifyEBSBackedInstanceState() 2019-10-31 12:22:10 -07:00
Lars Lehtonen
0a13b620d6
builder/amazon/common: remove dead test function StepModifyEBSBackedInstance_EnableAMIENASupport() 2019-10-31 12:19:28 -07:00
Lars Lehtonen
c74df8b652
builder/amazon/common: remove dead test function getMockConnSpot() 2019-10-31 12:15:53 -07:00
Lars Lehtonen
e5e2bfa83f
builder/amazon/common: remove nil check on slice, len() on nil slices is zero 2019-10-31 12:09:32 -07:00
Adrien Delorme
1efd86e809 Linode: remove unused StateTimeout field 2019-10-31 16:13:06 +01:00
Adrien Delorme
819329228a Change back to make sure all durations are a time.Duration 
It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because:

* we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.)
* we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config.
* the hcl2 generated code asks for a string, so this will be enforced by default.
 2019-10-31 16:12:07 +01:00
Adrien Delorme
bf3d9841c6 Force durations to be passed a strings 
Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".
 2019-10-31 11:47:19 +01:00
Adrien Delorme
ada9821897
Merge pull request #8294 from hashicorp/do_7974 
add insert_key option for toggling whether to add Vagrant's insecure key
 2019-10-31 10:27:27 +01:00
Megan Marsh
2fa79c6086 fix tests 2019-10-30 13:48:12 -07:00
Megan Marsh
8f996cd4de update docs 2019-10-30 13:36:56 -07:00
Megan Marsh
3b3aa562ed add insert_key option for toggling whether to add Vagrant's insecure key 2019-10-30 13:27:34 -07:00
Megan Marsh
553ca2e15d
Merge pull request #8293 from alrs/fix-azure-chroot-dropped-err 
builder/azure/chroot: fix dropped error
 2019-10-30 13:13:25 -07:00
Megan Marsh
ca64cc1237
Merge pull request #8261 from shawnmssu/feature/ucloud_import 
Packer Post-Processor support UCloud import
 2019-10-30 13:11:55 -07:00
Lars Lehtonen
6862e3534f
builder/azure/chroot: fix dropped error 2019-10-30 11:14:32 -07:00
Megan Marsh
6191b9c8c6
Merge pull request #8288 from hashicorp/fix_8271 
add some extra layers of validation to make sure that people don't tr…
 2019-10-30 10:41:52 -07:00
Megan Marsh
d084cd1895 Update builder/amazon/common/ami_config.go 2019-10-30 09:41:23 -07:00
Adrien Delorme
d915618819
Merge pull request #8289 from hashicorp/test_filter_builder 
add test to catch this case
 2019-10-30 10:34:58 +01:00
mingsheng.su
545575b879 optimize code about ufile config 2019-10-29 16:11:44 -07:00
mingsheng.su
37e898e115 optimize code style 2019-10-29 16:11:44 -07:00
mingsheng.su
9de1c42ad4 fix ucloud builder acctest 2019-10-29 16:11:44 -07:00
Megan Marsh
a4f95c8e7d fux gebeaj 2019-10-29 16:11:44 -07:00
mingsheng.su
2c513fce64 update ucloud packer 2019-10-29 16:11:43 -07:00
mingsheng.su
61f9d3a9fe add ucloud import 2019-10-29 16:11:43 -07:00
Megan Marsh
e9f02e44cb add test to catch this case 2019-10-29 11:28:56 -07:00
Megan Marsh
7cf47fc463 add some extra layers of validation to make sure that people don't trip over magical encrypt_boot settings later in the build 2019-10-29 11:26:22 -07:00
Andrey Kaipov
5da5b00e1c [builder/openstack] adds option to discover provisioning network 2019-10-29 13:02:27 -04:00
Adrien Delorme
8b6f1358fb
Merge pull request #8281 from alrs/fix-builder-oneandone-errors 
builder/oneandone: fix dropped errors
 2019-10-29 12:25:27 +01:00
Adrien Delorme
b2b12d6b04
Merge pull request #8280 from blinohod/cloudstack-display-name 
[WIP] Add instance_display_name for cloudstack builder
 2019-10-29 12:19:50 +01:00
Megan Marsh
e2283445f2 need to initialize variables scoped to the individual loop, because the address of k,v stay the same and that means we overwrite previous variables when assigning them to the struct directly. 2019-10-28 14:31:13 -07:00
Lars Lehtonen
6f7693577d
builder/oneandone: fix dropped errors 2019-10-28 08:25:48 -07:00
Michael Bochkaryov
da7e72246c Add instance_display_name parameter for Cloudstack builder 
This change introduce instance_display_name optional parameter
for Cloudstack builder to set custom VM display name.
By default it is set to "Created by Packer".
 2019-10-26 21:13:45 -07:00
Megan Marsh
0cb098b713 regenerate code because of hyperv refactor 2019-10-25 09:52:37 -07:00
Megan Marsh
2d01b3b7ab
Merge pull request #8274 from hashicorp/fix_8264 
Make Vagrant driver code pass through logs as it receives them rather…
 2019-10-24 14:38:53 -07:00
Megan Marsh
a783a09ea3
Merge pull request #8269 from paulmey/paulmey/generalize-chroot 
[amazon/chroot] Move common/generic chroot builder steps to common directory
 2019-10-24 14:32:01 -07:00
Megan Marsh
a7be0bed30 Make Vagrant driver code pass through logs as it receives them rather than buffering and returning them all at the end of the call. 2019-10-24 13:12:35 -07:00
Megan Marsh
eccdb44e3b
Merge pull request #8246 from hashicorp/fix_8089 
Add the additional_disk_size option tho the hyperv vmcx builder.
 2019-10-24 11:50:58 -07:00
Megan Marsh
7928b5b045 fix transcription error from when we moved to generated docs 2019-10-24 10:19:03 -07:00
Paul Meyer
3be7d81ce2 Move common steps together 2019-10-24 04:21:46 +00:00
Paul Meyer
e6dfe301ac Move CommandWrapper & ShellCommand to common 2019-10-24 04:06:29 +00:00
Megan Marsh
1731f87ad0
Merge pull request #8186 from puetzk/issue8178 
fix: set openstack metadata for use_blockstorage_volume
 2019-10-23 12:53:30 -07:00
Megan Marsh
436e21ae15 Merge branch 'master' into pr/8186 2019-10-23 12:08:02 -07:00
Paul Meyer
b54a2ee09d Set correct user agent for Azure clientset 2019-10-23 11:31:29 -07:00
Megan Marsh
b9245a402d add structure to its own struct to make generated code stop complaining 2019-10-23 10:46:42 -07:00
Megan Marsh
5614f307fb regerate code 
generate flat FlatPolicyDocument
add PolicyDocument to generate command
 2019-10-23 10:46:07 -07:00
Kevin Puetz
00d0297d26 Merge branch 'master' into issue8178 2019-10-23 00:34:38 -05:00
Megan Marsh
d15f43e4eb
Merge pull request #8232 from hashicorp/artifact-tree 
HCL2 configs - part one
 2019-10-22 11:54:34 -07:00
Megan Marsh
cdc3fdf926
Merge pull request #8247 from b-b3rn4rd/master 
New Feature: allow to specify  IAM policy for a temporary instance profile
 2019-10-22 09:33:23 -07:00
Bernard Baltrusaitis
ec1d70dc44 adding required changes 2019-10-22 21:40:18 +11:00
Megan Marsh
0c2fba089d
Merge pull request #8250 from tencentyun/master 
tencentcloud-cvm builder: we added retry on remote api call to improve the user experience
 2019-10-21 14:45:37 -07:00
Megan Marsh
34f5bfa498 regenerated things 2019-10-21 14:21:15 -07:00
Megan Marsh
e439dd039b fix tests 2019-10-21 14:08:49 -07:00
Megan Marsh
fe5ea886a2 refactir hyperv builders to remove duplicated config and prepare code 2019-10-21 13:29:56 -07:00
Megan Marsh
eb7bce0728 add additional disk size option to hyperv-vmcx 2019-10-21 13:29:55 -07:00
Megan Marsh
836aaafaa3
Merge pull request #8203 from sumit-kalra/master 
Azure-ARM builder: Deploy NSG if list of IP addresses is provided in config
 2019-10-21 11:10:58 -07:00
Li Kexian
6fb8988d08
we added retry on remote api call to improve the user experience 2019-10-21 13:21:56 +08:00
Bernard Baltrusaitis
65d1447b64 adding formatting 2019-10-19 21:33:58 +11:00
Bernard Baltrusaitis
6e2146324f Merge branch 'master' of github.com:b-b3rn4rd/packer 2019-10-19 20:56:49 +11:00
Bernard Baltrusaitis
8b83cca064 adding temporary instance profile document policy 2019-10-19 20:56:18 +11:00
Adrien Delorme
8b76453e7f make generate 2019-10-16 10:50:45 +02:00
Adrien Delorme
4542666e25 fix func calls after master merge 2019-10-16 10:40:25 +02:00
Adrien Delorme
cf1555bf17 Merge remote-tracking branch 'origin/master' into artifact-tree 2019-10-16 10:22:56 +02:00
Paul Meyer
575de8659e
Merge pull request #8226 from larohra/IncreasePollingDuration 
[azure] Increase polling duration
 2019-10-15 16:25:36 -07:00
Paul Meyer
b716299d8e PR comment 2019-10-15 21:14:20 +00:00
Paul Meyer
d3dc1be71c Doc updates 2019-10-15 21:14:20 +00:00
Paul Meyer
9b724d4ca0 Add artifact 2019-10-15 21:14:20 +00:00
Paul Meyer
0866cb3714 Reorganize client/common packages 2019-10-15 21:14:20 +00:00
Paul Meyer
fe584f4448 Format updates 2019-10-15 21:14:20 +00:00
Paul Meyer
19a3502b36 Add 'vm' template function 2019-10-15 21:14:20 +00:00
Paul Meyer
f72c4ec7a3 Update example and docs 2019-10-15 21:14:20 +00:00
Paul Meyer
b5c0742951 Add test that verifies disksize bug (2/2) 2019-10-15 21:14:20 +00:00
Paul Meyer
98175c06d5 Add test that verifies disksize bug (1/2) 2019-10-15 21:14:20 +00:00
Paul Meyer
eb5dc9326d Adding more tests 2019-10-15 21:14:20 +00:00
Paul Meyer
5943881051 Default for Gen 1 VMs 2019-10-15 21:14:20 +00:00
Paul Meyer
716f19a457 make fmt 2019-10-15 21:14:20 +00:00
Paul Meyer
8c73450f3d fixup! Add documentation to config struct 2019-10-15 21:14:20 +00:00
Paul Meyer
11ef06b94d Add StepVerifySourceDisk 2019-10-15 21:13:37 +00:00
Paul Meyer
cb729e5a38 Add documentation to config struct 2019-10-15 21:13:37 +00:00
Paul Meyer
27a5bfe11c Add implementation for disk as source 2019-10-15 21:13:37 +00:00
Paul Meyer
eff3f2bdcf Add test for disk input validation 2019-10-15 21:13:37 +00:00
Paul Meyer
57cff8961a Allow skipping OSDisk cleanup 2019-10-15 21:13:37 +00:00
Paul Meyer
6dee4d2d32 Wait for detach optimization 2019-10-15 21:13:37 +00:00
Paul Meyer
bbac79f0a4 Make PIR images work 2019-10-15 21:13:37 +00:00
Paul Meyer
b5401d552a Make from_scratch work 2019-10-15 21:13:37 +00:00
Paul Meyer
b9b5bb2951 Use DiskStorageAccountTypes 2019-10-15 21:13:37 +00:00
Paul Meyer
b4d0865548 Update azure-chroot builder 2019-10-15 21:13:37 +00:00
Paul Meyer
e11a5bdb40 Put os disk id in state 2019-10-15 21:13:37 +00:00
Paul Meyer
77b782c5b5 Add StepEarlyCleanup 2019-10-15 21:13:37 +00:00
Paul Meyer
977ca5be1c Add StepCopyFiles and StepChrootProvision 2019-10-15 21:13:37 +00:00
Paul Meyer
9a3e6661b1 Add StepMountExtra 2019-10-15 21:13:37 +00:00
Paul Meyer
addbdedea9 Add StepPostMountCommands 2019-10-15 21:13:37 +00:00
Paul Meyer
d1f8b8545d Add StepAttachDisk 2019-10-15 21:13:37 +00:00
Paul Meyer
4d750ddefa Reuse amazon/chroot/step_pre_mount_commands.go 2019-10-15 21:13:37 +00:00
Paul Meyer
45d3f28c67 Add StepCreateNewDisk 2019-10-15 21:13:37 +00:00
Paul Meyer
3d329cf87d Add chroot builder framework 2019-10-15 21:13:37 +00:00
Paul Meyer
369ec9a84c Create disk attacher component 2019-10-15 21:13:37 +00:00
Paul Meyer
3c33aa4fc5 Add metadata client 2019-10-15 21:13:37 +00:00
Paul Meyer
113dc12346 Add function to detect whether Packer is running on Azure 2019-10-15 21:13:37 +00:00
Paul Meyer
f106adbd12 Add Azure client set for chroot builder 2019-10-15 21:13:37 +00:00
Paul Meyer
2ded8f25ec Add metadata client 2019-10-15 21:13:37 +00:00
Paul Meyer
72fdce09ba Allow GetServicePrincipalToken to be called independently 2019-10-15 21:13:37 +00:00
Adrien Delorme
21a0cbffba fmt 2019-10-15 12:56:43 +02:00
Adrien Delorme
078ba7c8c3 commit old code generation tool 
for history
 2019-10-15 12:56:42 +02:00
Adrien Delorme
438f704333 fmt 2019-10-15 12:56:42 +02:00
Adrien Delorme
766e5c77ef builder.vmware.vmx: remove duplicate RemoteType field. 2019-10-15 12:56:42 +02:00
Adrien Delorme
00e3f97f5b builder.vmware.iso: remove duplicate Format field 2019-10-15 12:56:42 +02:00
Adrien Delorme
6fbd664b66 builder.vagrant: simplify communicator.Config field 2019-10-15 12:56:42 +02:00
Adrien Delorme
3fe1c96491 builder.proxmox: make ProxmoxURL *url.URL field unexported 
the only exported field we/users care about is ProxmoxURLRaw
 2019-10-15 12:56:42 +02:00
Adrien Delorme
40692a4e38 builder.profitbricks: remove duplicate communicator.Config field 2019-10-15 12:56:41 +02:00
Adrien Delorme
3fa614b5e1 builder.oracle.oci: make ConfigProvider unexported 
so that it doesn't temper with hcl2 code generation & parsing.

The field is set only later on after further processing.
 2019-10-15 12:56:41 +02:00
Adrien Delorme
17c069baa5 builder.google: 
* make CustomerEncryptionKey our own type so that it can be hcl2 generated
* make Account setting unexported so that it doesn't temper with HCL2 generation ( the field is set a bit later after processing )
 2019-10-15 12:56:41 +02:00
Adrien Delorme
f8402f1b91 builder.azure.common: make CloudEnvironment private so it doesn't temper with hcl2 code generation 
the struct is not read from file but later set after some computations
 2019-10-15 12:56:41 +02:00
Adrien Delorme
221e72e9c3 builder.amazon.common: remove pointer (*) from []*string and map[*string]*string types 
because they make hcl2/cty decoding panic
 2019-10-15 12:56:41 +02:00
Adrien Delorme
8b8c2fc138 builder.amazon.chroot: remove specific BlockDevice definition 
because the common one already has a KmsKeyId field
 2019-10-15 12:56:41 +02:00
Adrien Delorme
d2f5daf98f
Merge pull request #8209 from dvrkps/patch-3 
Ignore retry.Config var
 2019-10-15 10:29:51 +02:00
Megan Marsh
f05fd3969f
Merge pull request #8212 from hashicorp/fix_8204 
Fix 8204
 2019-10-14 14:40:17 -07:00
Megan Marsh
2e20facc8b fix tests 2019-10-14 14:13:21 -07:00
Megan Marsh
0e70e0e5a4 fix template imports 2019-10-14 13:22:06 -07:00
Megan Marsh
9c782f4d04 Revert "Qemu builder disk size as a string" 
This reverts commit 1ecfa032ba.
 2019-10-14 13:09:22 -07:00
Megan Marsh
44f91c9afc Revert "remove clean_ami_name and clean_image_name; complete the deprecation for these functions in favor of clean_resource_name" 
This reverts commit 0026792d2f.
 2019-10-14 13:08:15 -07:00
larohra
936ae42b00 Added a new parameter in config to override the default Azure Go SDK PollingDuration timeout 2019-10-11 15:29:02 -07:00
Davor Kapsa
29a6938de6
clean and return nil for retry.Config 2019-10-10 20:48:26 +02:00
Sumit Kalra
4bd09f381e
Fixing documentation (#6) 2019-10-10 11:30:28 -07:00
Davor Kapsa
4c615341ef
Ignore retry.Config var 
retry.Config is struct.
Call it err is wrong.
 2019-10-10 17:33:24 +02:00
Megan Marsh
4bc381183d make aws instsance builder work with recent changes for volume copy 2019-10-09 16:59:51 -07:00
Megan Marsh
e283023d9b make sure step_register_ami in chroot builder respects encryption and ami skip build retion values once the copy happens 2019-10-09 16:52:41 -07:00
Megan Marsh
469af8e592 ebssurrogate builds didn't keep up with recent optimizations to region encryption in the ebs builder, and that was causing bugs with the common ami region copy step 2019-10-09 16:02:37 -07:00
Davor Kapsa
3eb075b9fc
Consolidate receiver name 2019-10-09 21:18:46 +02:00
Davor Kapsa
fb267dd1dc
Add error check 2019-10-09 21:08:40 +02:00
Davor Kapsa
50262ba0b8
Remove explicit err var declaration 2019-10-09 13:17:43 +02:00
Sumit Kalra
595b103bbe
Adding NSG to the ARM deployment template when needed (#3) 
* Adding NSG to the ARM eployment template when needed

* Adding tests and fixing bugs

* Removing denyall rule

* Fixing logic to determine which port to open

* Fixing config description
 2019-10-08 14:56:43 -07:00
Lee Trager
c7f38b232f Add display template option for QEMU. Fixes #7675 2019-10-08 12:04:49 -07:00
Samuel Noordhuis
eecac683b8
Update builder/proxmox/config.go 
Co-Authored-By: Adrien Delorme <azr@users.noreply.github.com>
 2019-10-08 19:45:15 +11:00
Adrien Delorme
ef4db8b158
Merge branch 'master' into f-proxmox-cpu-type-support 2019-10-08 10:34:53 +02:00
Samuel Noordhuis
5add6cc6c8
Add ability to select CPU type 2019-10-06 21:39:53 +11:00
Samuel Noordhuis
d3f369494a
Add support for SCSI controller selection 2019-10-06 20:14:04 +11:00
Megan Marsh
e3257ba088
Merge pull request #8192 from hashicorp/fix_7904 
use a unique temp dir for each build to prevent concurrent builds fro…
 2019-10-04 09:39:03 -07:00
Adrien Delorme
3a4079f97a yandex: use clean_resource_name too 2019-10-04 11:31:33 +02:00
Adrien Delorme
d4600a7716 fix go imports 2019-10-04 11:19:45 +02:00
Megan Marsh
0026792d2f remove clean_ami_name and clean_image_name; complete the deprecation for these functions in favor of clean_resource_name 2019-10-03 15:49:01 -07:00
Megan Marsh
de8e8557ae make config dir if it doens't exist. 2019-10-03 15:16:27 -07:00
Megan Marsh
7f040dfed8 update tests 2019-10-03 15:06:01 -07:00
Megan Marsh
7c41244e15 use a unique temp dir for each build to prevent concurrent builds from stomping on each other 2019-10-03 14:50:53 -07:00
Megan Marsh
f685931cde
Merge pull request #8176 from winklerm/issue5575 
Fix Issue 5575 - OpenStack builder should warn instead of fail on terminate if instance is already shut down
 2019-10-03 09:41:47 -07:00
Kevin Puetz
6e069c94e8 fix: set openstack metadata for use_blockstorage_volume 
Also set os-set_image_metadata on the tempoary volume before uploading
(volume metadata does not automatically become image metadata)
so the uploaded image will be created with the desired metadata
 2019-10-02 17:59:13 -05:00
Megan Marsh
e16fb19bfc don't abort on a single error if another availability zone was able to create the instance 2019-10-02 14:17:00 -07:00
Marek Winkler
0bd256326f builder/openstack: Fix interface conversion panic when attempting to find a volume when not using volumes 2019-10-02 22:16:18 +02:00
Megan Marsh
c138edcbe1
Merge pull request #8177 from alrs/virtualbox-builder-dropped-error 
builder/virtualbox/vm: fix dropped error
 2019-10-02 13:00:39 -07:00
Marek Winkler
7e6f58f699 builder/openstack: fix issue 5575 - support shutdown by Sysprep 2019-10-02 21:07:41 +02:00
Lars Lehtonen
4a3a011310
builder/virtualbox/vm: fix dropped error 2019-10-01 15:54:28 -07:00
Megan Marsh
19a9d7149f fix structs and regenerate partials 2019-10-01 13:36:55 -07:00
Kevin Faulkner
1ecfa032ba Qemu builder disk size as a string 2019-10-01 13:27:02 -07:00
Megan Marsh
dfaded3f80
Merge pull request #8172 from neumayer/definedtags 
Support defined tags for oci builder
 2019-10-01 12:26:16 -07:00
larohra
23c320d59e Increased the default polling duration to 60mins 2019-09-30 16:17:22 -07:00
Lars Lehtonen
ad860bf1a8
builder: remove deprecated context usage 2019-09-30 11:33:53 -07:00
Robert Neumayer
7dd579f630 Remove commented code 2019-09-30 12:17:47 +02:00
Adrien Delorme
a6c8440150
Merge pull request #7862 from carlpett/proxmox-pool-support 
Allow running the template VM in a Proxmox resource pool
 2019-09-30 12:09:52 +02:00
Calle Pettersson
8a443a7e21 Allow running the template VM in a Proxmox resource pool 2019-09-29 19:28:21 +02:00
Lars Lehtonen
2b795053b4
builder/vmware: fix dropped test errors 2019-09-27 16:05:12 -07:00
Megan Marsh
f4dca172e3
Merge pull request #8155 from hashicorp/on_error_script 
error cleanup provisioner
 2019-09-27 14:08:45 -07:00
Megan Marsh
eccf0fb51d update docs 2019-09-27 09:51:18 -07:00
Megan Marsh
e047b97bf7
Merge pull request #8162 from hashicorp/fix_8154 
make sure amazon builders respect ssh_host option
 2019-09-27 09:34:49 -07:00
Megan Marsh
ac6e7a4800 updates tests to validate that ssh_host value supplied in the template overrides all else 2019-09-27 09:19:23 -07:00
Robert Neumayer
70b2d300e6 Support defined tags for oci builder 2019-09-27 15:10:04 +02:00
Adrien Delorme
941dc394f0 Update step_run_spot_instance.go 2019-09-27 13:04:52 +02:00
Adrien Delorme
d049284120
Update builder/amazon/common/step_run_spot_instance.go 
remove unused code that might induce errors
 2019-09-27 13:00:53 +02:00
Adrien Delorme
07e97e26de
step_run_source_instance.go: make sure we use the right ShouldRetry error 2019-09-27 12:57:55 +02:00
Sumit Kalra
91d19adcd7 Ensuring that specifying allowed inbound IP and VNet are mutually exclusive (#2) 2019-09-26 23:33:18 +00:00
Sumit Kalra
132779c343 Adding config to specify allowed inbound IP addresses and CIDR blocks (#1) 
* Adding config to specify allowed inbound IP addresses

* Also allowing CIDR blocks in addition to IP addresses
 2019-09-26 23:31:28 +00:00
Megan Marsh
c722009159 we only need one describeInstances call, not 3, and it should be wrapped in a retry 2019-09-26 15:47:01 -07:00
Megan Marsh
e47059aaca put retry around describeinstances call in amazon 2019-09-26 14:49:28 -07:00
Megan Marsh
31bb1e818f fix tests 2019-09-26 13:02:11 -07:00
Megan Marsh
0cbd3ff0f3 make sure amazon builders respect ssh_host option 2019-09-26 12:30:04 -07:00
Paul Meyer
698c9c44d4
Merge pull request #8121 from paulmey/clientconfig 
[azure] Refactor client config
 2019-09-26 10:49:13 -07:00
Megan Marsh
72d393c95a update docs to show a use case for block device mappings 2019-09-25 16:48:04 -07:00
Megan Marsh
0683bc409b add test for error-cleanup provisioner, and fix tests by fixing null builder to use an actual none communicator instead of skipping communicator generation altogether 2019-09-25 13:39:09 -07:00
Paul Meyer
c72a612b44 Re-added tests for FillParamters 2019-09-25 20:33:38 +00:00
Paul Meyer
094a8840d8 Improve comments for FillParameters 2019-09-25 20:33:38 +00:00
Paul Meyer
feeae1514e Refactor client config 2019-09-25 20:33:38 +00:00
Megan Marsh
e5e864c624
Merge pull request #8143 from hashicorp/google_vault_oauth 
Google vault oauth
 2019-09-25 10:12:29 -07:00
Gennady Lipenkov
d070b4868a Wrap values with backticks 
Signed-off-by: Gennady Lipenkov <xgen@yandex-team.ru>
 2019-09-25 16:04:45 +03:00
Gennady Lipenkov
00e4e0c7a7 Add description of field in config struct 
Signed-off-by: Gennady Lipenkov <xgen@yandex-team.ru>
 2019-09-25 14:31:27 +03:00
Megan Marsh
3c14c50aba Allow user to real oauth token from properly configured Vault instance 2019-09-23 13:26:03 -07:00
Megan Marsh
2a662b451c
Merge pull request #8142 from yandex-cloud/yandex-add-retries 
Add retries to Yandex builder
 2019-09-23 12:23:47 -07:00
Megan Marsh
c24693372d
Merge pull request #8132 from scienty/support_floppy_vmx_esxi 
Support floppy_files for vmx on esxi
 2019-09-23 12:20:49 -07:00
Gennady Lipenkov
fceaa9ccf9 Add retries to Yandex builder 
Signed-off-by: Gennady Lipenkov <xgen@yandex-team.ru>
 2019-09-23 21:03:17 +03:00
Megan Marsh
f0461da1a1
Merge pull request #7724 from hashicorp/scrape_doc_to_builder_struct_config 
Generate builder documentation markdown from structs.
 2019-09-20 16:50:39 -07:00
Adrien Delorme
4fb05e5bc4 fix test 2019-09-20 15:28:43 +02:00
Adrien Delorme
792f61a4ad fmt 2019-09-20 15:18:48 +02:00
Adrien Delorme
55f1c734d0 fix alicloud docs a little 2019-09-20 15:10:02 +02:00
Adrien Delorme
849de792da re-apply doc changes of master 2019-09-20 15:04:01 +02:00
Adrien Delorme
299544a4c7 Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config 2019-09-20 14:47:02 +02:00
Adrien Delorme
3fe9d52e3f Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config 2019-09-20 11:15:44 +02:00
Prakash Sidaraddi
67be007f45 Support floppy_files for vmx on esxi 2019-09-20 00:23:28 +05:30
Megan Marsh
30f86bb778 fix ssh and package steps to use source syntax. 2019-09-18 13:15:49 -07:00
Megan Marsh
577a34b1c3
Merge pull request #8106 from shapeblue-br/master 
[cloudstack builder] Detach iso option step
 2019-09-17 10:15:09 -07:00
Megan Marsh
35357616e0
Merge pull request #8112 from milescrabill/packer-googlecompute-validate-imagename 
googlecompute: fail fast when image name is invalid, replace unusable characters w/ -'s
 2019-09-17 10:00:33 -07:00
Adrien Delorme
f779530715
Merge pull request #8102 from hashicorp/fix_8085 
don't fall for nil pointer dereference in account file
 2019-09-17 17:00:52 +02:00
Lars Lehtonen
c6212731ff builder/vagrant: fix dropped errors in code and tests 2019-09-17 05:39:23 -07:00
Miles Crabill
2bff60bac8
address review feedback 2019-09-16 13:50:43 -07:00
Miles Crabill
328baced05
add some test cases for image names 2019-09-16 10:18:22 -07:00
Miles Crabill
c11a444f77
googlecompute: fail fast when image name is invalid, replace unusable characters w/ -'s 2019-09-16 10:10:41 -07:00
Lars Lehtonen
6c1ce2bd9a builder/openstack: Fix dropped error 2019-09-16 06:26:56 -07:00
Adrien Delorme
4d4bd38afa
Merge pull request #8087 from hashicorp/fix_8048 
add retry wrapper to query so it handles rate limiting
 2019-09-16 10:25:12 +02:00
William Bianchini
d022c2194a [cloudstack builder] Detach iso step 
Detach iso file after loading image to cache, allowing OS to boot from
volume ater the installation

Add eject iso check and wait timeout

Closes #7235
 2019-09-13 21:33:49 -03:00
Megan Marsh
a6e263adb6 don't fall for nil pointer dereference in account file 2019-09-13 16:37:19 -07:00
Megan Marsh
fc6a4fd5d8
Merge pull request #8021 from hashicorp/fix_7959 
[WIP] implement custom data type "trilean" (tri-state-boolean) to track boo…
 2019-09-13 14:42:27 -07:00
Megan Marsh
9503802814 adding ctx makes the cancel channel redundant 2019-09-13 14:32:13 -07:00
Megan Marsh
4b497006b3 add retry wrapper to query so it handles rate limiting 2019-09-13 14:32:13 -07:00
allinwait
171c2a9a07 add the floppy label option 2019-09-12 12:25:22 +00:00
Adrien Delorme
2e58b807de
Merge pull request #8096 from onematchfox/virtualbox-snapshot 
fix(virtualbox-vm) LoadSnapshots should succeed even if machine has no snapshots
 2019-09-12 13:18:46 +02:00
Adrien Delorme
1d0cf1db98
Merge pull request #8092 from milescrabill/fix-vagrant-builder-stepup 
vagrant builder: use GlobalID where provided, add test for `vagrant up` args generation
 2019-09-12 13:13:04 +02:00
Brian Fox
5b6dcb0c94 fix(virtualbox) LoadSnapshots should succeed even if VM has no snapshots 2019-09-12 10:51:12 +02:00
lonegunman
0de807cce0 make ucloud builder's base url configurable 2019-09-12 11:33:57 +08:00
Miles Crabill
e6d2a97e12
s/destory/destroy 2019-09-10 14:31:00 -07:00
Miles Crabill
7850bf8bc5
use GlobalID where provided, add test for vagrant up args generation 2019-09-10 10:46:16 -07:00
Gennady Lipenkov
524b822e11 Support GPU instances, allow set source image by name 
Signed-off-by: Gennady Lipenkov <xgen@yandex-team.ru>
 2019-09-10 17:52:42 +03:00
Adrien Delorme
597a3e323b Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config 2019-09-10 13:20:07 +02:00
Adrien Delorme
350aa54274 Update step_shutdown_test.go 
bump test duration
 2019-09-10 13:07:30 +02:00
Adrien Delorme
146b88ba1e Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config 2019-09-10 12:44:46 +02:00
Adrien Delorme
de9bb26f62
Merge branch 'master' into fix_7959 2019-09-10 12:21:33 +02:00
Adrien Delorme
e730e9f3ce
Merge pull request #8051 from DanHam/aws-vol-tags 
Add ability to set `run_volume_tags` for Amazon EBS Volume builder
 2019-09-10 12:04:58 +02:00
Calle Pettersson
b467bb22a3 Shorten default boot_key_interval to 5ms from 100ms 2019-09-09 22:33:48 +02:00
Adrien Delorme
dad3ae1535
Merge pull request #8084 from carlpett/check-disk-format-set 
builder/proxmox: Check that disk format is set when pool type requires it
 2019-09-09 10:33:50 +02:00
Adrien Delorme
78bfda582f
Merge pull request #8083 from carlpett/bump-proxmox-api-dep 
Bump proxmox api dep
 2019-09-09 10:33:18 +02:00
Calle Pettersson
10ad38fcbd Check that disk format is set when pool type requires it 2019-09-08 18:40:29 +02:00
Calle Pettersson
df41b56d9a Change MonitorCmd/sendkeys to Sendkey 2019-09-07 23:09:16 +02:00
Calle Pettersson
8c2c1a82cb Bump proxmox-api-go dependency 2019-09-07 23:07:45 +02:00
Adrien Delorme
a5b899770e
Merge pull request #8077 from marinsalinas/master 
Outscale Builder: Get SSH Host from VM.Nics insead VM's Root
 2019-09-05 15:40:23 +02:00
Marin Salinas
640612da92 refactor: get ssh hot from nics instead of root of the vm 2019-09-05 08:21:07 -05:00
Marin Salinas
793b3f1990 chore: remove unused code in omi config 2019-09-05 08:20:27 -05:00
Marin Salinas
7d024b9725 change ui message to private ip in run source vm 2019-09-05 08:19:58 -05:00
Calle Pettersson
0813c5bdb4 Check for StateCancelled 2019-09-04 23:03:25 +02:00
Adrien Delorme
c4c88d3768 debug template id 2019-09-04 14:29:45 +02:00
Adrien Delorme
d113dd12c1 fix panic in proxmox builder 2019-09-04 14:21:52 +02:00
Adrien Delorme
ba9ffcbf73 re-indent HWConfig struct comments 2019-09-03 17:35:29 +02:00
DanHam
bbeb1a3528
Delete any run_volume_tags applied to EBS volumes at instance creation 
* Allows `run_volume_tags` to be set without requiring a major rewrite
  of the (common) amazon builder code used to start an instance.
  The common start up code tags the instance and *all attached volumes
  at creation*. If `run_volume_tags` are set this means that any volumes
  specified in `ebs_volumes` will *initially* be tagged with the
  `run_volume_tags` rather than the tags set in the `ebs_volumes`
  section
* Once the instance is reported to be 'ready' the step to tag the EBS
  volumes is run. Once complete all volumes should have the tags
  requested by the user:

    * Volumes associated with the source instance should be tagged with
      the tags set in `run_volume_tags` (if any)
    * Each EBS volumes specified in the `ebs_volumes` section of the
      template should only be tagged with its associated tags (if any)
 2019-08-30 14:30:25 +01:00
DanHam
61b1605a85
More accurate error description; Add comments; Add output 2019-08-30 14:26:06 +01:00
DanHam
430d41fbf9
Add option to enable tagging of the running instances volumes 
* Currently this results in *all* volumes attached to the instance
  being tagged with the `run_volume_tags`. This includes any `ebs_volumes`
  for which the user may have configured other tags.
* This issue will be addressed in a later commit
 2019-08-30 14:16:29 +01:00
DanHam
30070ffb30
Sort fields and options alphabetically 2019-08-30 14:16:29 +01:00
Adrien Delorme
a841da960d Merge branch 'master' of ssh://github.com/hashicorp/packer into scrape_doc_to_builder_struct_config 2019-08-30 15:10:29 +02:00
Adrien Delorme
c475eb57ef
Merge pull request #8047 from hashicorp/avoid_panic_when_token_in_azure_builder 
azure builder: avoid a panic in getObjectIdFromToken
 2019-08-30 11:26:48 +02:00
Adrien Delorme
7d9798f5ee update AlicloudAccessConfig docs for SECURITY_TOKEN 
SecurityToken=>SECURITY_TOKEN
 2019-08-29 14:39:25 +02:00
Adrien Delorme
9f8e9893b3 Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config 2019-08-29 14:22:16 +02:00
Lars Lehtonen
b6eadb419a builder/qemu: Fix dropped error 2019-08-29 05:13:46 -07:00
Adrien Delorme
86cee5cbef
Merge pull request #8034 from cove/retry-describe-instances 
add AWS API call reties on AMI prevalidation
 2019-08-29 10:48:54 +02:00
Adrien Delorme
f11341c0b4 azure builder: avoid a panic in getObjectIdFromToken 2019-08-29 10:34:59 +02:00
cove
87e0a3b5e7 add prevalidating AMI name retries so the build doesn't fail when throttled 2019-08-27 18:00:08 -07:00
Adrien Delorme
9d0bc476d9 add ommited struct interpolation 
after dcc22df609
 2019-08-27 15:17:57 +02:00
Adrien Delorme
b3cdf2ac8f remove docs typo 2019-08-27 15:16:33 +02:00
Adrien Delorme
94bb33db57 fix triple backtick indentation 2019-08-27 13:37:28 +02:00
Adrien Delorme
d135106171 fix more docs 2019-08-27 09:50:43 +02:00
Adrien Delorme
f66ca58a46 Update azure docs for config.go 
add missing docs fields

Co-Authored-By: Megan Marsh <swampdragons@users.noreply.github.com>
 2019-08-27 09:32:03 +02:00
Adrien Delorme
783b02bd15 Update config.go 
add missing doc  fields

Co-Authored-By: Megan Marsh <swampdragons@users.noreply.github.com>
 2019-08-27 09:28:36 +02:00
Adrien Delorme
239f97471c fix ebs volume tags doc field 
Co-Authored-By: Megan Marsh <swampdragons@users.noreply.github.com>
 2019-08-27 09:21:29 +02:00
Adrien Delorme
5517d41468 make sure all documentation fields are there 
* add missing `temporary_key_pair_name` field for alicloud
* add missing description to `vpc_filter` for aws
* add missing ssh communicator fields for aws
* add links for aws
* update vmware-vmx docs
* manually describe AMI Configuration section for ebsvolume
* display missing required ami_name field for aws
* add missing fields for docker
* add missing fields for openstack
 2019-08-26 17:16:54 +02:00
Adrien Delorme
2db109d55b Merge branch 'master' into scrape_doc_to_builder_struct_config 2019-08-23 17:37:53 +02:00
Adrien Delorme
2efc94521b use trilean initializers in test where missing 2019-08-23 11:17:45 +02:00
Megan Marsh
6a895db9be converte block device encryption to trilean 2019-08-22 14:24:22 -07:00
Megan Marsh
1d9bba6fe3 change AMIEncryptBootVolume to trilean 2019-08-22 14:04:26 -07:00
Megan Marsh
f7c8321a7e convert alicloud s.IOOptimized into trilean in code 2019-08-22 13:59:38 -07:00
Megan Marsh
ecaec1ac58 swap out alicloud encryption *bools for trileans 2019-08-22 13:52:29 -07:00
Megan Marsh
1a6adadb89 convert EnableAMIENASupport to trilean in code 2019-08-22 13:18:22 -07:00
Megan Marsh
3c3f7f26ce implement custom data type "trilean" (tri-state-boolean) to track booleans which have a "null" or "unset" state. Previously we used *bool for these template options, but it turns out that those won't work because "unset" will evaluate to "false" if a user is using template variables to set the option that maps to a *bool. 2019-08-22 13:18:15 -07:00
Megan Marsh
04d9888657
Merge pull request #8016 from psinghal20/issue-8009 
fix: move adding metadata step after waiting for uploading step
 2019-08-22 11:24:37 -07:00
Pratyush Singhal
dbb50337bc
fix: out of scope blockStorageClient nil value issue 
Co-Authored-By: Adrien Delorme <azr@users.noreply.github.com>
 2019-08-22 20:50:46 +05:30
Megan Marsh
fcef7e2d85 this timeout regularly flakes on Travis, I suspect because the instances running the tests are brutally underpowered. Increase the fudge factor. 2019-08-21 16:36:42 -07:00
Adrien Delorme
4cb7c30987 Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config 2019-08-21 16:44:23 +02:00
psinghal20
bbd71136dc
fix: move adding metadata step after waiting for uploading step 
Signed-off-by: psinghal20 <psinghal20@gmail.com>
 2019-08-21 15:45:46 +05:30
Megan Marsh
17d9a85895
Merge pull request #7945 from ahilsend/hcloud-image-filter 
feat(builder/hcloud): allow selecting image based on filters
 2019-08-19 14:37:43 -07:00
Megan Marsh
b6fdccc2af
Merge pull request #7970 from williamb1024/master 
Decrease the delay between Hyper-V VM startup and hyper-v builder's ability to send keystrokes to the target VM.
 2019-08-19 14:37:10 -07:00
Megan Marsh
4aa33306cb make sure that fleetId exists before trying to stick it into error message 2019-08-19 13:44:39 -07:00
Megan Marsh
8dbd078738
Merge pull request #8011 from tmeckel/vbox-vm-target-snapshot-optional 
Fix: VirtualBox VM builder, target snapshot optional
 2019-08-19 13:29:06 -07:00
Megan Marsh
dd97435d42
Merge pull request #7957 from milescrabill/fix-vagrant-builder-basebox-sourcebox 
vagrant builder: fix provisioning boxes, define source and output boxes
 2019-08-19 13:25:54 -07:00
Thomas Meckel
01edafb49f Cleaned up golint warnings 2019-08-19 21:36:43 +02:00
Thomas Meckel
92501cd344 target_snapshot is not optional as described in the documentation 2019-08-19 21:36:43 +02:00
William L. Brooks
be4ca4b666 Move hyper-v host ip determination earlier in steps, connect to Hyper-V vm prior to issuing the start operation. 2019-08-19 11:45:41 -07:00
Megan Marsh
06bef2844b
Merge pull request #7996 from hashicorp/fix_7925 
dont bother with a targetpath for the vbox additions; use a hash like…
 2019-08-19 09:45:38 -07:00
Brian Fox
47c027e5c8 Remove check/requirement for target_snapshot 2019-08-19 11:25:17 +02:00
Megan Marsh
316a30b31d fix spot_tags 2019-08-15 16:06:16 -07:00
Megan Marsh
02399f32f6 dont bother with a targetpath for the vbox additions; use a hash like everything else 2019-08-15 15:10:25 -07:00
Megan Marsh
94d8da60f0
Merge pull request #7940 from jgeorgeson/openstack-winrmpassword-provisioners 
OpenStack builder store WinRM password for provisioners to use
 2019-08-15 12:02:26 -07:00
Megan Marsh
9f6d14c75a work around spot_tags related regression and bad fleet cleanup in spot instances 2019-08-14 11:08:59 -07:00
Andre Hilsendeger
cb1e30ef69 feat(builder/hcloud): allow selecting image based on filters 2019-08-13 08:40:47 +02:00
Megan Marsh
0eebebaedb
Merge pull request #7939 from hashicorp/fix_7938 
check container os, not host os, when creating container dir default
 2019-08-12 16:45:00 -07:00
xiaohan.liang
f4fc9dd09a Rewrite all files, remove sensitive information 2019-08-09 15:00:23 +08:00
Miles Crabill
ff157c8a6d
vagrant builder: define source box and output box in Vagrantfile 2019-08-07 10:11:34 -07:00
Justin Georgeson
c0ee859559 OpenStack builder store WinRM password for provisioners to use 2019-08-01 19:02:36 -05:00
Megan Marsh
c0e37e6045
Merge pull request #7780 from tmeckel/own-vbox-snapshot 
VirtualBox Snapshot Builder
 2019-08-01 15:31:15 -07:00
Megan Marsh
1952130030
Merge pull request #7920 from hashicorp/fix_7865 
[wip] fix polling issues in azure
 2019-08-01 12:40:11 -07:00
Megan Marsh
773e76c1ce remove unused import 2019-08-01 11:35:53 -07:00
Megan Marsh
b6f3742425 check container os, not host os, when creating container dir default 2019-08-01 11:31:21 -07:00
Megan Marsh
6a201211a9 fix polling issues in azure 
adds a configurable timeout to the shared image gallery publisher
 2019-08-01 11:18:03 -07:00
Mason, Elliot
ee484f2dd9 Updated public gcp cloud images 2019-07-31 11:38:35 -05:00
Megan Marsh
f97df6721e
Merge pull request #7927 from hashicorp/fix_googlecompute_crash_7921 
code changed recently so that sometimes the conf is nil.
 2019-07-30 09:55:09 -07:00
Megan Marsh
7c93a5c51e code changed recently so that sometimes the conf is nil. 2019-07-29 13:19:43 -07:00
Megan Marsh
b42701380c add test for nil case 2019-07-29 12:11:59 -07:00
DanHam
088151e51d
Type assertion safety - fix panic when key cannot be retrieved from statebag 2019-07-28 10:44:24 +01:00
Thomas Meckel
822b72bd14 Added force_delete_snapshot configuration item and the corresponding checks 2019-07-26 12:34:28 +02:00
Thomas Meckel
e7583de847 StepCreateSnapshot.Run() will stop and create an error if the virtual machine is still running 
Removed left over code from StepCreateSnapshot.Cleanup()
 2019-07-26 12:34:27 +02:00
Thomas Meckel
d9b8623f64 StepShutdown now always waits for the shutdown of the virtual machine to complete, not only if a shutdown command is specified 2019-07-26 12:34:27 +02:00
Thomas Meckel
b873876670 Added test TestSnapshot_EnsureParents 
No using asserts NotNil and Nil
 2019-07-26 12:34:27 +02:00
Thomas Meckel
6fd0b3e83e Fixed a bug in ParseSnapshotData 
Added fuction GetSnapshots
 2019-07-26 12:34:26 +02:00
Thomas Meckel
225a140055 Applied correct source format (got fmt) to builder\virtualbox\common\driver_mock.go 2019-07-26 12:34:26 +02:00
Thomas Meckel
51e5ae69db Corrected method signatures in builder\virtualbox\common\driver_mock.go 2019-07-26 12:34:26 +02:00
Thomas Meckel
ab6a163ff2 Added missing newline at end of builder\virtualbox\common\driver_mock.go 2019-07-26 12:34:25 +02:00
Thomas Meckel
e9b5332e99 Added missing functions to builder\virtualbox\common\driver_mock.go 2019-07-26 12:34:25 +02:00
Thomas Meckel
fd5a2db58f Removed commented (obsolete) code from builder\virtualbox\common\driver_4_2.go 2019-07-26 12:34:25 +02:00
Thomas Meckel
7d3c84e5f9 Changed VirtualBox VM builder according to current builder interface 2019-07-26 12:29:48 +02:00
Thomas Meckel
2ef911f6f0 Fixed bugs in snapshot and builder code 2019-07-26 12:29:47 +02:00
Thomas Meckel
ebd2780e5d implemented first unit tests for snapshot.go 2019-07-26 12:29:46 +02:00
Thomas Meckel
f1f7c4e10c * added function ParseSnapshotData to parse a string representation of a VBox snapshot tree 
* fixed bugs
 2019-07-26 12:29:46 +02:00
Thomas Meckel
45e2095ae3 Moved parsing of tree string representation to new function in snapshot.go 2019-07-26 12:29:45 +02:00
Thomas Meckel
092e32fe9e First version of reworked snapshot implementation 2019-07-26 12:29:45 +02:00
Thomas Meckel
a6074894f1 Defined struct and first function for enhanced snapshot handling 2019-07-26 12:29:45 +02:00
Thomas Meckel
d3202497ae First working version of virtualbox/vm builder 2019-07-26 12:29:44 +02:00
Thomas Meckel
2a531f8ad6 Merged changes from local branch 2019-07-26 12:29:44 +02:00
mingsheng.su
66f142adf1 update docs 2019-07-26 17:27:58 +08:00
mingsheng.su
59c8911cd5 update api about stop instance 2019-07-26 17:03:57 +08:00
Megan Marsh
d21f4eb888
Merge pull request #7908 from muesli/typo-fixes 
Fixed various typos
 2019-07-25 12:21:20 -07:00
Megan Marsh
3d22535742
Merge pull request #7884 from jprorama/fix-7171 
[WIP] Fix #7171: select instance network on which to assign floating ip
 2019-07-25 11:57:24 -07:00
Megan Marsh
166f1de5fd
Merge pull request #7887 from xunleii/f-scaleway-autoremove-volume 
Allow removing volume after image creation for Scaleway builder
 2019-07-25 11:56:23 -07:00
Christian Muehlhaeuser
216afbaa8b
Fixed various typos 
Just a bunch of nit-picky typo fixes.
 2019-07-25 06:49:51 +02:00
Megan Marsh
140785f088 make sure we create the temp dir explicitly when we are setting up the config dir in docker. Otherwise, we create it with root later on and it causes permissions failures. 2019-07-24 16:51:38 -07:00
Alexandre NICOLAIE
6835a12cb3
fix: fix typo in comment 
Co-Authored-By: Megan Marsh <megan@hashicorp.com>
 2019-07-24 21:19:53 +02:00
Megan Marsh
54a7b4f377 update comments and docs 2019-07-22 11:54:42 -07:00
y-kuno
6305c555df Add openstack image min_disk option 2019-07-22 11:44:34 -07:00
Alexandre NICOLAIE
b010442e07 fix: delete volume only after snapshot step 
Signed-off-by: Alexandre NICOLAIE <alexandre.nicolaie@gmail.com>
 2019-07-21 10:42:34 +02:00
Alexandre NICOLAIE
39b8c0ecca feat: add 'remove volume' step to scaleway 
Signed-off-by: Alexandre NICOLAIE <alexandre.nicolaie@gmail.com>
 2019-07-18 23:19:48 +02:00
Megan Marsh
975ee377b2
Merge pull request #7792 from psinghal20/issue-7721 
set openstack image metadata with use_blockstorage_volume
 2019-07-18 11:58:01 -07:00
Marin Salinas
e634caee0a remove chroot acc test 2019-07-18 12:07:08 -05:00
Megan Marsh
e10b9fb708 fix ssh interface conflict 2019-07-18 09:47:15 -07:00
Marin Salinas
1424f1b564 fix: remove AWS references and unnecessary code 2019-07-18 09:39:08 -07:00
Marin Salinas
73cd148e80 refactor: change ebs_volume to bsu_volumeattribute in bsuvolume builder 2019-07-18 09:39:08 -07:00
Marin Salinas
7e23f14d4e fix: chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas
1b7c56f73d fix: change bad artifact validation in bsu builder 2019-07-18 09:39:08 -07:00
Marin Salinas
03f8b2ceb5 fix: change GlobalPermission to false in order to prevent public image creation 2019-07-18 09:39:08 -07:00
Marin Salinas
dc0db4b322 fix: change osc builder to be passed a context for cancellation and remove conflicts 2019-07-18 09:39:08 -07:00
Marin Salinas
2337703be6 fix: add missing secret key in http client configuration 2019-07-18 09:39:08 -07:00
Marin Salinas
ed2d2b9058 refactor: clean duplicate files with aws chroot builder 2019-07-18 09:39:08 -07:00
Marin Salinas
488535118d refactor: change validation when bsu is set 2019-07-18 09:39:08 -07:00
Marin Salinas
6820806436 refactor: add err check in create tags 2019-07-18 09:39:08 -07:00
Marin Salinas
17ee7b8163 fix: add missing secret key in http client configuration 2019-07-18 09:39:08 -07:00
Marin Salinas
f28c3877e3 refactor: remove unused attributes 2019-07-18 09:39:08 -07:00
Marin Salinas
590bef0969 chore: fix bad comments 2019-07-18 09:39:08 -07:00
Marin Salinas
04534d87ac chore: change templateCleanOMIName to templateCleanResourceName function 
:
 2019-07-18 09:39:08 -07:00
Marin Salinas
1811b3af52 chore: remove unused buildBlockDevice function 2019-07-18 09:39:08 -07:00
Marin Salinas
4b52816935 fix: go modules conflicts 2019-07-18 09:39:08 -07:00