upstream/packer
1
0
Fork 0
mirror of https://github.com/hashicorp/packer.git synced 2026-05-28 04:35:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Add environment variable precheck for datasource acceptance tests (#11254)

Browse source 
Before change
```
=== Failed
=== FAIL: datasource/hcp-packer-iteration TestAccDatasource_HCPPackerIteration (1.97s)
    pluginacc.go:143: Error running plugin acceptance tests: Bad exit code. Logfile: packer_log_hcp_packer_iteration_datasource_basic_test.txt
        Logs can be found at /Users/wilkenrivera/Development/packer/datasource/hcp-packer-iteration/packer_log_hcp_packer_iteration_datasource_basic_test.txt
        and the acceptance test template can be found at /Users/wilkenrivera/Development/packer/datasource/hcp-packer-iteration/hcp_packer_iteration_datasource_basic_test.pkr.hcl

DONE 690 tests, 5 skipped, 1 failure in 387.912s
```

After change
```
=== SKIP: datasource/hcp-packer-iteration TestAccDatasource_HCPPackerIteration (0.00s)
    data_acc_test.go:35: Acceptance tests skipped unless envs "HCP_CLIENT_ID" and "HCP_CLIENT_SECRET" are set
```
This commit is contained in:
Wilken Rivera 2021-09-08 06:16:33 -04:00 committed by GitHub
parent 6d0d5c89f3
commit 7aa6b699ab
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
datasource/hcp-packer-iteration/data_acc_test.go
View file

@ -3,12 +3,18 @@ package hcp_packer_iteration
import (
_ "embed"
"fmt"
"os"
"os/exec"
"testing"
"github.com/hashicorp/packer-plugin-sdk/acctest"
)
const (
HCPClientID string = "HCP_CLIENT_ID"
HCPClientSecret string = "HCP_CLIENT_SECRET"
)
//go:embed test-fixtures/template.pkr.hcl
var testDatasourceBasic string
@ -25,6 +31,11 @@ var testDatasourceBasic string
// as defined above.
func TestAccDatasource_HCPPackerIteration(t *testing.T) {
if os.Getenv(HCPClientID) == "" && os.Getenv(HCPClientSecret) == "" {
t.Skip(fmt.Sprintf("Acceptance tests skipped unless envs %q and %q are set", HCPClientID, HCPClientSecret))
return
}
testCase := &acctest.PluginTestCase{
Name: "hcp_packer_iteration_datasource_basic_test",
Template: testDatasourceBasic,