From 5c0191828f6f3ba26cf666ef5c1ba5eb01f8586c Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:05:56 +0000 Subject: [PATCH 01/89] spelling: account --- post-processor/alicloud-import/post-processor.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/post-processor/alicloud-import/post-processor.go b/post-processor/alicloud-import/post-processor.go index 2606e5fdf..4421b170d 100644 --- a/post-processor/alicloud-import/post-processor.go +++ b/post-processor/alicloud-import/post-processor.go @@ -214,7 +214,7 @@ func (p *PostProcessor) PostProcess(ui packer.Ui, artifact packer.Artifact) (pac if err != nil { e, _ := err.(*packercommon.Error) - if e.Code == "NoSetRoletoECSServiceAcount" { + if e.Code == "NoSetRoletoECSServiceAccount" { ramClient := ram.NewClient(p.config.AlicloudAccessKey, p.config.AlicloudSecretKey) roleResponse, err := ramClient.GetRole(ram.RoleQueryRequest{ RoleName: "AliyunECSImageImportDefaultRole", @@ -282,7 +282,7 @@ func (p *PostProcessor) PostProcess(ui packer.Ui, artifact packer.Artifact) (pac imageId, err = ecsClient.ImportImage(imageImageArgs) if err != nil { e, _ = err.(*packercommon.Error) - if e.Code == "NoSetRoletoECSServiceAcount" { + if e.Code == "NoSetRoletoECSServiceAccount" { time.Sleep(5 * time.Second) continue } else if e.Code == "ImageIsImporting" || From 5e167e3b6d55c0b198bd49fe6af3097827eaa235 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:03:51 +0000 Subject: [PATCH 02/89] spelling: accumulates --- helper/multistep/multistep_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helper/multistep/multistep_test.go b/helper/multistep/multistep_test.go index 25bbeef9b..3ced60d83 100644 --- a/helper/multistep/multistep_test.go +++ b/helper/multistep/multistep_test.go @@ -2,7 +2,7 @@ package multistep import "context" -// A step for testing that accumuluates data into a string slice in the +// A step for testing that accumulates data into a string slice in the // the state bag. It always uses the "data" key in the state bag, and will // initialize it. type TestStepAcc struct { From fe98bcc5a109cf2629c209ca51c2264e7d2fc0b9 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:07:10 +0000 Subject: [PATCH 03/89] spelling: address --- builder/alicloud/ecs/step_config_public_ip.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/builder/alicloud/ecs/step_config_public_ip.go b/builder/alicloud/ecs/step_config_public_ip.go index 7e0a246e0..594f85603 100644 --- a/builder/alicloud/ecs/step_config_public_ip.go +++ b/builder/alicloud/ecs/step_config_public_ip.go @@ -10,8 +10,8 @@ import ( ) type stepConfigAlicloudPublicIP struct { - publicIPAdress string - RegionId string + publicIPAddress string + RegionId string } func (s *stepConfigAlicloudPublicIP) Run(_ context.Context, state multistep.StateBag) multistep.StepAction { @@ -25,7 +25,7 @@ func (s *stepConfigAlicloudPublicIP) Run(_ context.Context, state multistep.Stat ui.Say(fmt.Sprintf("Error allocating public ip: %s", err)) return multistep.ActionHalt } - s.publicIPAdress = ipaddress + s.publicIPAddress = ipaddress ui.Say(fmt.Sprintf("Allocated public ip address %s.", ipaddress)) state.Put("ipaddress", ipaddress) return multistep.ActionContinue From c38cdd043982f409074aa6bfd3f9becbde1e9e8c Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:06:52 +0000 Subject: [PATCH 04/89] spelling: administrator --- website/source/docs/provisioners/converge.html.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/source/docs/provisioners/converge.html.md b/website/source/docs/provisioners/converge.html.md index b76652abe..1c06678ed 100644 --- a/website/source/docs/provisioners/converge.html.md +++ b/website/source/docs/provisioners/converge.html.md @@ -59,7 +59,7 @@ Optional parameters: various [configuration template variables](/docs/templates/engine.html) available. -- `prevent_sudo` (boolean) - stop Converge from running with adminstrator +- `prevent_sudo` (boolean) - stop Converge from running with administrator privileges via sudo - `bootstrap_command` (string) - the command used to bootstrap Converge. This From 75a7ceec48062171e5b282cd2a7942638210e072 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:09:12 +0000 Subject: [PATCH 05/89] spelling: alicloud --- builder/alicloud/ecs/run_config.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/alicloud/ecs/run_config.go b/builder/alicloud/ecs/run_config.go index b6098ce5c..2c52bb37b 100644 --- a/builder/alicloud/ecs/run_config.go +++ b/builder/alicloud/ecs/run_config.go @@ -57,7 +57,7 @@ func (c *RunConfig) Prepare(ctx *interpolate.Context) []error { } if c.InstanceType == "" { - errs = append(errs, errors.New("An aliclod_instance_type must be specified")) + errs = append(errs, errors.New("An alicloud_instance_type must be specified")) } if c.UserData != "" && c.UserDataFile != "" { From e7a30b4ba2f88cfa40086cb333996adec32878c7 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:11:42 +0000 Subject: [PATCH 06/89] spelling: attempt --- command/fix.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/command/fix.go b/command/fix.go index 1a94f5786..e7cfac9ea 100644 --- a/command/fix.go +++ b/command/fix.go @@ -85,7 +85,7 @@ func (c *FixCommand) Run(args []string) int { c.Ui.Say(result) if flagValidate { - // Attemot to parse and validate the template + // Attempt to parse and validate the template tpl, err := template.Parse(strings.NewReader(result)) if err != nil { c.Ui.Error(fmt.Sprintf( From 7895051962b62e40fb01b15b4b701e4a6fd9e935 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:12:16 +0000 Subject: [PATCH 07/89] spelling: attribute --- builder/alicloud/ecs/step_run_instance.go | 4 ++-- builder/oracle/classic/config.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/builder/alicloud/ecs/step_run_instance.go b/builder/alicloud/ecs/step_run_instance.go index 72491dd1d..57a799183 100644 --- a/builder/alicloud/ecs/step_run_instance.go +++ b/builder/alicloud/ecs/step_run_instance.go @@ -43,8 +43,8 @@ func (s *stepRunAlicloudInstance) Cleanup(state multistep.StateBag) { ui := state.Get("ui").(packer.Ui) client := state.Get("client").(*ecs.Client) instance := state.Get("instance").(*ecs.InstanceAttributesType) - instanceAttrubite, _ := client.DescribeInstanceAttribute(instance.InstanceId) - if instanceAttrubite.Status == ecs.Starting || instanceAttrubite.Status == ecs.Running { + instanceAttribute, _ := client.DescribeInstanceAttribute(instance.InstanceId) + if instanceAttribute.Status == ecs.Starting || instanceAttribute.Status == ecs.Running { if err := client.StopInstance(instance.InstanceId, true); err != nil { ui.Say(fmt.Sprintf("Error stopping instance %s, it may still be around %s", instance.InstanceId, err)) return diff --git a/builder/oracle/classic/config.go b/builder/oracle/classic/config.go index b9f5d808f..a483c8e50 100644 --- a/builder/oracle/classic/config.go +++ b/builder/oracle/classic/config.go @@ -33,7 +33,7 @@ type Config struct { SourceImageList string `mapstructure:"source_image_list"` SnapshotTimeout time.Duration `mapstructure:"snapshot_timeout"` DestImageList string `mapstructure:"dest_image_list"` - // Attributes and Atributes file are both optional and mutually exclusive. + // Attributes and Attributes file are both optional and mutually exclusive. Attributes string `mapstructure:"attributes"` AttributesFile string `mapstructure:"attributes_file"` // Optional; if you don't enter anything, the image list description @@ -129,7 +129,7 @@ func NewConfig(raws ...interface{}) (*Config, error) { err = json.Unmarshal(fidata, &data) c.attribs = data if err != nil { - err = fmt.Errorf("Problem parsing json from attrinutes_file: %s", err) + err = fmt.Errorf("Problem parsing json from attributes_file: %s", err) packer.MultiErrorAppend(errs, err) } c.attribs = data From c312493c387fe7522f631ee8322fc625d8fb569a Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:13:24 +0000 Subject: [PATCH 08/89] spelling: available --- examples/alicloud/chef/chef.sh | 2 +- post-processor/vagrant/post-processor.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/alicloud/chef/chef.sh b/examples/alicloud/chef/chef.sh index 6d678b7cc..3e3144561 100644 --- a/examples/alicloud/chef/chef.sh +++ b/examples/alicloud/chef/chef.sh @@ -1,5 +1,5 @@ #!/bin/sh -#if the related deb pkg not found, please replace with it other avaiable repository url +#if the related deb pkg not found, please replace with it other available repository url HOSTNAME=`ifconfig eth1|grep 'inet addr'|cut -d ":" -f2|cut -d " " -f1` if [ not $HOSTNAME ] ; then HOSTNAME=`ifconfig eth0|grep 'inet addr'|cut -d ":" -f2|cut -d " " -f1` diff --git a/post-processor/vagrant/post-processor.go b/post-processor/vagrant/post-processor.go index de93628c0..d4b587316 100644 --- a/post-processor/vagrant/post-processor.go +++ b/post-processor/vagrant/post-processor.go @@ -246,7 +246,7 @@ func providerForName(name string) Provider { } } -// OutputPathTemplate is the structure that is availalable within the +// OutputPathTemplate is the structure that is available within the // OutputPath variables. type outputPathTemplate struct { ArtifactId string From f362789174140601fc5d07fd5ed788eabb51308f Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:15:08 +0000 Subject: [PATCH 09/89] spelling: because --- builder/oracle/classic/step_security.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/oracle/classic/step_security.go b/builder/oracle/classic/step_security.go index 892695f83..a4b547d27 100644 --- a/builder/oracle/classic/step_security.go +++ b/builder/oracle/classic/step_security.go @@ -53,7 +53,7 @@ func (s *stepSecurity) Run(_ context.Context, state multistep.StateBag) multiste application = "/oracle/public/ssh" } else if commType == "WINRM" { // Check to see whether a winRM security protocol is already defined; - // don't need to do this for SSH becasue it is built into the Oracle API. + // don't need to do this for SSH because it is built into the Oracle API. protocolClient := client.SecurityProtocols() winrmProtocol := fmt.Sprintf("WINRM_%s", runUUID) input := compute.CreateSecurityProtocolInput{ From 9434b0fed852323907b4bf3dc4fc249aba12e77f Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:19:04 +0000 Subject: [PATCH 10/89] spelling: builder --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2cc52892f..f7bc2926d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1321,7 +1321,7 @@ * builder/parallels: Support Parallels Desktop 11. [GH-2199] * builder/openstack: Add `rackconnect_wait` for Rackspace customers to wait for RackConnect data to appear -* buidler/openstack: Add `ssh_interface` option for rackconnect for users that +* builder/openstack: Add `ssh_interface` option for rackconnect for users that have prohibitive firewalls * builder/openstack: Flavor names can be used as well as refs * builder/openstack: Add `availability_zone` [GH-2016] From 5010bfda39811c46e27c09fe9e03b230a66942e9 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:20:55 +0000 Subject: [PATCH 11/89] spelling: comes --- builder/openstack/step_key_pair_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/openstack/step_key_pair_test.go b/builder/openstack/step_key_pair_test.go index 0ce45d6a7..891ad3cdc 100644 --- a/builder/openstack/step_key_pair_test.go +++ b/builder/openstack/step_key_pair_test.go @@ -81,7 +81,7 @@ func TestBerToDer(t *testing.T) { Writer: msg, } - // Test - a DER encoded key commes back unchanged. + // Test - a DER encoded key comes back unchanged. newKey := berToDer(der_encoded_key, ui) if newKey != der_encoded_key { t.Errorf("Trying to convert a DER encoded key should return the same key.") From 47a4bbd9f592222db03f10a16c33398758522c6c Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:22:09 +0000 Subject: [PATCH 12/89] spelling: compaction --- builder/parallels/common/driver_9.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/parallels/common/driver_9.go b/builder/parallels/common/driver_9.go index b6757d891..cfdee4a5d 100644 --- a/builder/parallels/common/driver_9.go +++ b/builder/parallels/common/driver_9.go @@ -119,7 +119,7 @@ func getAppPath(bundleID string) (string, error) { return pathOutput, nil } -// CompactDisk performs the compation of the specified virtual disk image. +// CompactDisk performs the compaction of the specified virtual disk image. func (d *Parallels9Driver) CompactDisk(diskPath string) error { prlDiskToolPath, err := exec.LookPath("prl_disk_tool") if err != nil { From f6745897c5100fc536e2a36e2b75d76ad66b9e4c Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:21:31 +0000 Subject: [PATCH 13/89] spelling: compute --- post-processor/checksum/post-processor_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/post-processor/checksum/post-processor_test.go b/post-processor/checksum/post-processor_test.go index fb4d0faf1..6b4420d39 100644 --- a/post-processor/checksum/post-processor_test.go +++ b/post-processor/checksum/post-processor_test.go @@ -35,7 +35,7 @@ func TestChecksumSHA1(t *testing.T) { t.Errorf("Unable to read checksum file: %s", err) } if buf, _ := ioutil.ReadAll(f); !bytes.Equal(buf, []byte("d3486ae9136e7856bc42212385ea797094475802\tpackage.txt\n")) { - t.Errorf("Failed to compate checksum: %s\n%s", buf, "d3486ae9136e7856bc42212385ea797094475802 package.txt") + t.Errorf("Failed to compute checksum: %s\n%s", buf, "d3486ae9136e7856bc42212385ea797094475802 package.txt") } defer f.Close() From 935c8e9a2827b429a4c38ff729f35293f81a55b2 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:19:16 +0000 Subject: [PATCH 14/89] spelling: configuration --- builder/parallels/common/driver.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/parallels/common/driver.go b/builder/parallels/common/driver.go index b485d5b67..ac23a7880 100644 --- a/builder/parallels/common/driver.go +++ b/builder/parallels/common/driver.go @@ -51,7 +51,7 @@ type Driver interface { // Send scancodes to the vm using the prltype python script. SendKeyScanCodes(string, ...string) error - // Apply default сonfiguration settings to the virtual machine + // Apply default configuration settings to the virtual machine SetDefaultConfiguration(string) error // Finds the MAC address of the NIC nic0 From faf7928a4105676d1127859201c59aaca1d5ad77 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:22:23 +0000 Subject: [PATCH 15/89] spelling: conservative --- contrib/azure-setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/azure-setup.sh b/contrib/azure-setup.sh index ef855b353..8ccd0cbc0 100755 --- a/contrib/azure-setup.sh +++ b/contrib/azure-setup.sh @@ -182,7 +182,7 @@ createServicePrincipal() { createPermissions() { echo "==> Creating permissions" az role assignment create --assignee $azure_object_id --role "Owner" --scope /subscriptions/$azure_subscription_id - # If the user wants to use a more conserative scope, she can. She must + # If the user wants to use a more conservative scope, she can. She must # configure the Azure builder to use build_resource_group_name. The # easiest solution is subscription wide permission. # az role assignment create --spn http://$meta_name -g $azure_group_name -o "API Management Service Contributor" From efb525f03ddd92f768d7946280b7097367ef1a42 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:22:37 +0000 Subject: [PATCH 16/89] spelling: creating --- builder/hyperv/common/step_create_external_switch.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/hyperv/common/step_create_external_switch.go b/builder/hyperv/common/step_create_external_switch.go index 56e6fa6e8..52626afce 100644 --- a/builder/hyperv/common/step_create_external_switch.go +++ b/builder/hyperv/common/step_create_external_switch.go @@ -23,7 +23,7 @@ func (s *StepCreateExternalSwitch) Run(_ context.Context, state multistep.StateB ui := state.Get("ui").(packer.Ui) vmName := state.Get("vmName").(string) - errorMsg := "Error createing external switch: %s" + errorMsg := "Error creating external switch: %s" var err error ui.Say("Creating external switch...") From 684a3f5d8a80e2c8da6a55d39e3076771571e1dc Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:26:33 +0000 Subject: [PATCH 17/89] spelling: custom --- provisioner/salt-masterless/provisioner_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/provisioner/salt-masterless/provisioner_test.go b/provisioner/salt-masterless/provisioner_test.go index bad83b3f6..166e17f96 100644 --- a/provisioner/salt-masterless/provisioner_test.go +++ b/provisioner/salt-masterless/provisioner_test.go @@ -49,7 +49,7 @@ func TestProvisionerPrepare_InvalidKey(t *testing.T) { } } -func TestProvisionerPrepare_CustomeState(t *testing.T) { +func TestProvisionerPrepare_CustomState(t *testing.T) { var p Provisioner config := testConfig() From 0cff0f2f848c981c77e613d30c9ec68ac46c34ae Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:35:21 +0000 Subject: [PATCH 18/89] spelling: default --- website/source/docs/builders/hyperv-iso.html.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/source/docs/builders/hyperv-iso.html.md b/website/source/docs/builders/hyperv-iso.html.md index e1454fea7..094e46bcb 100644 --- a/website/source/docs/builders/hyperv-iso.html.md +++ b/website/source/docs/builders/hyperv-iso.html.md @@ -101,7 +101,7 @@ can be configured for this builder. source is a vhd/vhdx. This defaults to false. - `skip_export` (boolean) - If true skips VM export. If you are interested only in the vhd/vhdx files, you can enable this option. This will create - inline disks which improves the build performance. There will not be any copying of source vhds to temp directory. This defauls to false. + inline disks which improves the build performance. There will not be any copying of source vhds to temp directory. This defaults to false. - `enable_dynamic_memory` (boolean) - If true enable dynamic memory for virtual machine. This defaults to false. From dfcd5742ccfc308e3451bfaa2d6480a1aec6eac9 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:35:31 +0000 Subject: [PATCH 19/89] spelling: defined --- website/source/docs/builders/profitbricks.html.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/website/source/docs/builders/profitbricks.html.md b/website/source/docs/builders/profitbricks.html.md index bbb691bab..2b4bc4bc5 100644 --- a/website/source/docs/builders/profitbricks.html.md +++ b/website/source/docs/builders/profitbricks.html.md @@ -25,9 +25,9 @@ builder. - `image` (string) - ProfitBricks volume image. Only Linux public images are supported. To obtain full list of available images you can use [ProfitBricks CLI](https://github.com/profitbricks/profitbricks-cli#image). -- `password` (string) - ProfitBricks password. This can be specified via environment variable \`PROFITBRICKS\_PASSWORD', if provided. The value definded in the config has precedence over environemnt variable. +- `password` (string) - ProfitBricks password. This can be specified via environment variable \`PROFITBRICKS\_PASSWORD', if provided. The value defined in the config has precedence over environemnt variable. -- `username` (string) - ProfitBricks username. This can be specified via environment variable \`PROFITBRICKS\_USERNAME', if provided. The value definded in the config has precedence over environemnt variable. +- `username` (string) - ProfitBricks username. This can be specified via environment variable \`PROFITBRICKS\_USERNAME', if provided. The value defined in the config has precedence over environemnt variable. ### Optional From 939e7d5587fc28b4f0f2b7a9f50c97e21fb147e9 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:36:38 +0000 Subject: [PATCH 20/89] spelling: delete --- builder/alicloud/ecs/builder.go | 6 +++--- builder/alicloud/ecs/image_config.go | 4 ++-- builder/alicloud/ecs/step_delete_images_snapshots.go | 8 ++++---- post-processor/alicloud-import/post-processor.go | 6 +++--- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/builder/alicloud/ecs/builder.go b/builder/alicloud/ecs/builder.go index 08a7dad08..7269bd3f0 100644 --- a/builder/alicloud/ecs/builder.go +++ b/builder/alicloud/ecs/builder.go @@ -89,7 +89,7 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe steps = []multistep.Step{ &stepPreValidate{ AlicloudDestImageName: b.config.AlicloudImageName, - ForceDelete: b.config.AlicloudImageForceDetele, + ForceDelete: b.config.AlicloudImageForceDelete, }, &stepCheckAlicloudSourceImage{ SourceECSImageId: b.config.AlicloudSourceImage, @@ -165,8 +165,8 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe ForceStop: b.config.ForceStopInstance, }, &stepDeleteAlicloudImageSnapshots{ - AlicloudImageForceDeteleSnapshots: b.config.AlicloudImageForceDeteleSnapshots, - AlicloudImageForceDetele: b.config.AlicloudImageForceDetele, + AlicloudImageForceDeleteSnapshots: b.config.AlicloudImageForceDeleteSnapshots, + AlicloudImageForceDelete: b.config.AlicloudImageForceDelete, AlicloudImageName: b.config.AlicloudImageName, }, &stepCreateAlicloudImage{}, diff --git a/builder/alicloud/ecs/image_config.go b/builder/alicloud/ecs/image_config.go index b987558f9..d747009ef 100644 --- a/builder/alicloud/ecs/image_config.go +++ b/builder/alicloud/ecs/image_config.go @@ -32,8 +32,8 @@ type AlicloudImageConfig struct { AlicloudImageUNShareAccounts []string `mapstructure:"image_unshare_account"` AlicloudImageDestinationRegions []string `mapstructure:"image_copy_regions"` AlicloudImageDestinationNames []string `mapstructure:"image_copy_names"` - AlicloudImageForceDetele bool `mapstructure:"image_force_delete"` - AlicloudImageForceDeteleSnapshots bool `mapstructure:"image_force_delete_snapshots"` + AlicloudImageForceDelete bool `mapstructure:"image_force_delete"` + AlicloudImageForceDeleteSnapshots bool `mapstructure:"image_force_delete_snapshots"` AlicloudImageForceDeleteInstances bool `mapstructure:"image_force_delete_instances"` AlicloudImageSkipRegionValidation bool `mapstructure:"skip_region_validation"` AlicloudDiskDevices `mapstructure:",squash"` diff --git a/builder/alicloud/ecs/step_delete_images_snapshots.go b/builder/alicloud/ecs/step_delete_images_snapshots.go index d3f6139f0..9e294c45f 100644 --- a/builder/alicloud/ecs/step_delete_images_snapshots.go +++ b/builder/alicloud/ecs/step_delete_images_snapshots.go @@ -12,8 +12,8 @@ import ( ) type stepDeleteAlicloudImageSnapshots struct { - AlicloudImageForceDetele bool - AlicloudImageForceDeteleSnapshots bool + AlicloudImageForceDelete bool + AlicloudImageForceDeleteSnapshots bool AlicloudImageName string } @@ -23,7 +23,7 @@ func (s *stepDeleteAlicloudImageSnapshots) Run(_ context.Context, state multiste config := state.Get("config").(Config) ui.Say("Deleting image snapshots.") // Check for force delete - if s.AlicloudImageForceDetele { + if s.AlicloudImageForceDelete { images, _, err := client.DescribeImages(&ecs.DescribeImagesArgs{ RegionId: common.Region(config.AlicloudRegion), ImageName: s.AlicloudImageName, @@ -43,7 +43,7 @@ func (s *stepDeleteAlicloudImageSnapshots) Run(_ context.Context, state multiste ui.Error(err.Error()) return multistep.ActionHalt } - if s.AlicloudImageForceDeteleSnapshots { + if s.AlicloudImageForceDeleteSnapshots { for _, diskDevice := range image.DiskDeviceMappings.DiskDeviceMapping { if err := client.DeleteSnapshot(diskDevice.SnapshotId); err != nil { err := fmt.Errorf("Deleting ECS snapshot failed: %s", err) diff --git a/post-processor/alicloud-import/post-processor.go b/post-processor/alicloud-import/post-processor.go index 4421b170d..853e97ef1 100644 --- a/post-processor/alicloud-import/post-processor.go +++ b/post-processor/alicloud-import/post-processor.go @@ -60,7 +60,7 @@ type Config struct { Architecture string `mapstructure:"image_architecture"` Size string `mapstructure:"image_system_size"` Format string `mapstructure:"format"` - AlicloudImageForceDetele bool `mapstructure:"image_force_delete"` + AlicloudImageForceDelete bool `mapstructure:"image_force_delete"` ctx interpolate.Context } @@ -160,7 +160,7 @@ func (p *PostProcessor) PostProcess(ui packer.Ui, artifact packer.Artifact) (pac getEndPonit(p.config.OSSBucket), p.config.OSSKey, err) } - if len(images) > 0 && !p.config.AlicloudImageForceDetele { + if len(images) > 0 && !p.config.AlicloudImageForceDelete { return nil, false, fmt.Errorf("Duplicated image exists, please delete the existing images " + "or set the 'image_force_delete' value as true") } @@ -185,7 +185,7 @@ func (p *PostProcessor) PostProcess(ui packer.Ui, artifact packer.Artifact) (pac if err != nil { return nil, false, fmt.Errorf("Failed to upload image %s: %s", source, err) } - if len(images) > 0 && p.config.AlicloudImageForceDetele { + if len(images) > 0 && p.config.AlicloudImageForceDelete { if err = ecsClient.DeleteImage(packercommon.Region(p.config.AlicloudRegion), images[0].ImageId); err != nil { return nil, false, fmt.Errorf("Delete duplicated image %s failed", images[0].ImageName) From e4c56e3cbd0568bd4bb6824fad3208d30c4bdf5a Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:35:45 +0000 Subject: [PATCH 21/89] spelling: delimiters --- website/source/docs/builders/hyperv-iso.html.md | 2 +- website/source/docs/builders/hyperv-vmcx.html.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/website/source/docs/builders/hyperv-iso.html.md b/website/source/docs/builders/hyperv-iso.html.md index 094e46bcb..8e481bcad 100644 --- a/website/source/docs/builders/hyperv-iso.html.md +++ b/website/source/docs/builders/hyperv-iso.html.md @@ -221,7 +221,7 @@ can be configured for this builder. - `mac_address` (string) - This allows a specific MAC address to be used on the default virtual network card. The MAC address must be a string with no - delimeters, for example "0000deadbeef". + delimiters, for example "0000deadbeef". - `vm_name` (string) - This is the name of the virtual machine for the new virtual machine, without the file extension. By default this is "packer-BUILDNAME", diff --git a/website/source/docs/builders/hyperv-vmcx.html.md b/website/source/docs/builders/hyperv-vmcx.html.md index a7afe93ce..f43372c65 100644 --- a/website/source/docs/builders/hyperv-vmcx.html.md +++ b/website/source/docs/builders/hyperv-vmcx.html.md @@ -227,7 +227,7 @@ can be configured for this builder. - `mac_address` (string) - This allows a specific MAC address to be used on the default virtual network card. The MAC address must be a string with no - delimeters, for example "0000deadbeef". + delimiters, for example "0000deadbeef". - `vm_name` (string) - This is the name of the virtual machine for the new virtual machine, without the file extension. By default this is From 9d26e6dd8670ebede82129ee3f59e55213de06a4 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:36:15 +0000 Subject: [PATCH 22/89] spelling: descriptive --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f7bc2926d..93421f139 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1598,7 +1598,7 @@ manager certs. [GH-1137] * builder/amazon/all: `delete_on_termination` set to false will work. * builder/amazon/all: Fix race condition on setting tags. [GH-1367] -* builder/amazon/all: More desctriptive error messages if Amazon only +* builder/amazon/all: More descriptive error messages if Amazon only sends an error code. [GH-1189] * builder/docker: Error if `DOCKER_HOST` is set. * builder/docker: Remove the container during cleanup. [GH-1206] From 60ef3c3374487ff5f0ec5a293505d327bbb73d12 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:37:32 +0000 Subject: [PATCH 23/89] spelling: directories --- builder/hyperv/common/step_create_tempdir.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/hyperv/common/step_create_tempdir.go b/builder/hyperv/common/step_create_tempdir.go index 1a9767fe5..b445a4702 100644 --- a/builder/hyperv/common/step_create_tempdir.go +++ b/builder/hyperv/common/step_create_tempdir.go @@ -11,7 +11,7 @@ import ( ) type StepCreateTempDir struct { - // The user-supplied root directores into which we create subdirectories. + // The user-supplied root directories into which we create subdirectories. TempPath string VhdTempPath string // The subdirectories with the randomly generated name. From 8dfafa6a5eaa14bd0ef2b0fea66f65dc716f3d55 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:38:01 +0000 Subject: [PATCH 24/89] spelling: dispatchable --- packer/build_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packer/build_test.go b/packer/build_test.go index 8fe7bc5af..dd78bf4e7 100644 --- a/packer/build_test.go +++ b/packer/build_test.go @@ -191,7 +191,7 @@ func TestBuild_Run(t *testing.T) { t.Fatal("should be called") } - // Verify hooks are disapatchable + // Verify hooks are dispatchable dispatchHook := builder.RunHook dispatchHook.Run("foo", nil, nil, 42) From 76a7258bb46def460bef316d874ea6311f8d99b4 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:39:36 +0000 Subject: [PATCH 25/89] spelling: documentation --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 93421f139..c99b822be 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2425,7 +2425,7 @@ * Amazon EBS builder can now optionally use a pre-made security group instead of randomly generating one. * DigitalOcean API key and client IDs can now be passed in as - environmental variables. See the documentatin for more details. + environmental variables. See the documentation for more details. * VirtualBox and VMware can now have `floppy_files` specified to attach floppy disks when booting. This allows for unattended Windows installs. * `packer build` has a new `-force` flag that forces the removal of From 83471c8399aa6a9ec2b8e862e1f4129b416dec2f Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:39:58 +0000 Subject: [PATCH 26/89] spelling: doesn't --- builder/lxd/step_lxd_launch.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/lxd/step_lxd_launch.go b/builder/lxd/step_lxd_launch.go index de34a5cb4..7549a408d 100644 --- a/builder/lxd/step_lxd_launch.go +++ b/builder/lxd/step_lxd_launch.go @@ -31,7 +31,7 @@ func (s *stepLxdLaunch) Run(_ context.Context, state multistep.StateBag) multist return multistep.ActionHalt } // TODO: Should we check `lxc info ` for "Running"? - // We have to do this so /tmp doens't get cleared and lose our provisioner scripts. + // We have to do this so /tmp doesn't get cleared and lose our provisioner scripts. time.Sleep(1 * time.Second) return multistep.ActionContinue From e2f279dbaa047bacaccc992b396526357a1925d1 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:40:16 +0000 Subject: [PATCH 27/89] spelling: download --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c99b822be..b584f16a8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2274,11 +2274,11 @@ * builder/amazon-instance: send IAM instance profile data. [GH-294] * builder/digitalocean: API request parameters are properly URL encoded. [GH-281] -* builder/virtualbox: dowload progress won't be shown until download +* builder/virtualbox: download progress won't be shown until download actually starts. [GH-288] * builder/virtualbox: floppy files names of 13 characters are now properly written to the FAT12 filesystem. [GH-285] -* builder/vmware: dowload progress won't be shown until download +* builder/vmware: download progress won't be shown until download actually starts. [GH-288] * builder/vmware: interrupt works while typing commands over VNC. * builder/virtualbox: floppy files names of 13 characters are now properly From 785b42368d234eed985b87834eadd79de477ab97 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:40:52 +0000 Subject: [PATCH 28/89] spelling: easily --- packer/ui_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packer/ui_test.go b/packer/ui_test.go index 76d0cd5b5..ef14985ec 100644 --- a/packer/ui_test.go +++ b/packer/ui_test.go @@ -215,7 +215,7 @@ func TestBasicUi_Ask(t *testing.T) { } for _, testCase := range testCases { - // Because of the internal bufio we can't eaily reset the input, so create a new one each time + // Because of the internal bufio we can't easily reset the input, so create a new one each time bufferUi := testUi() writeReader(bufferUi, testCase.Input) From 9b9ab4c492c417e835917a6c78b26871031e3684 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:41:47 +0000 Subject: [PATCH 29/89] spelling: encrypt --- builder/oracle/oci/client/config_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder/oracle/oci/client/config_test.go b/builder/oracle/oci/client/config_test.go index 154fe1ec2..1be34c5f0 100644 --- a/builder/oracle/oci/client/config_test.go +++ b/builder/oracle/oci/client/config_test.go @@ -144,7 +144,7 @@ func TestParseEncryptedPrivateKeyValidPassword(t *testing.T) { password, cipherType) if err != nil { - t.Fatalf("Unexpected error encryting PEM block: %+v", err) + t.Fatalf("Unexpected error encrypting PEM block: %+v", err) } // Parse private key @@ -195,7 +195,7 @@ func TestParseEncryptedPrivateKeyPKCS8(t *testing.T) { password, cipherType) if err != nil { - t.Fatalf("Unexpected error encryting PEM block: %+v", err) + t.Fatalf("Unexpected error encrypting PEM block: %+v", err) } // Parse private key From 04d6bfc696c5fd2b9e474efe977064a535f983c6 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:41:21 +0000 Subject: [PATCH 30/89] spelling: environment --- CHANGELOG.md | 2 +- builder/azure/arm/config.go | 2 +- examples/alicloud/jenkins/jenkins.sh | 2 +- provisioner/powershell/provisioner.go | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b584f16a8..9707c60cb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2228,7 +2228,7 @@ * core: All HTTP downloads across Packer now support the standard proxy environmental variables (`HTTP_PROXY`, `NO_PROXY`, etc.) [GH-252] * builder/amazon: API requests will use HTTP proxy if specified by - enviromental variables. + environmental variables. * builder/digitalocean: API requests will use HTTP proxy if specified by environmental variables. diff --git a/builder/azure/arm/config.go b/builder/azure/arm/config.go index 5584a15bf..65c276a68 100644 --- a/builder/azure/arm/config.go +++ b/builder/azure/arm/config.go @@ -410,7 +410,7 @@ func setCloudEnvironment(c *Config) error { name := strings.ToUpper(c.CloudEnvironmentName) envName, ok := lookup[name] if !ok { - return fmt.Errorf("There is no cloud envionment matching the name '%s'!", c.CloudEnvironmentName) + return fmt.Errorf("There is no cloud environment matching the name '%s'!", c.CloudEnvironmentName) } env, err := azure.EnvironmentFromName(envName) diff --git a/examples/alicloud/jenkins/jenkins.sh b/examples/alicloud/jenkins/jenkins.sh index af3eb51a3..72972c24e 100644 --- a/examples/alicloud/jenkins/jenkins.sh +++ b/examples/alicloud/jenkins/jenkins.sh @@ -32,7 +32,7 @@ mv $TOMCAT_NAME /opt wget $JENKINS_URL mv jenkins.war $TOMCAT_PATH/webapps/ -#set emvironment +#set environment echo "TOMCAT_PATH=\"$TOMCAT_PATH\"">>/etc/profile echo "JENKINS_HOME=\"$TOMCAT_PATH/webapps/jenkins\"">>/etc/profile echo PATH="\"\$PATH:\$TOMCAT_PATH:\$JENKINS_HOME\"">>/etc/profile diff --git a/provisioner/powershell/provisioner.go b/provisioner/powershell/provisioner.go index 07b10def9..9655f6fed 100644 --- a/provisioner/powershell/provisioner.go +++ b/provisioner/powershell/provisioner.go @@ -338,7 +338,7 @@ func (p *Provisioner) retryable(f func() error) error { } } -// Enviroment variables required within the remote environment are uploaded within a PS script and +// Environment variables required within the remote environment are uploaded within a PS script and // then enabled by 'dot sourcing' the script immediately prior to execution of the main command func (p *Provisioner) prepareEnvVars(elevated bool) (envVarPath string, err error) { // Collate all required env vars into a plain string with required formatting applied From fc99dc25ae710b81ff0f353eefc9ae2fea6ba26f Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:45:13 +0000 Subject: [PATCH 31/89] spelling: error --- communicator/ssh/communicator.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/communicator/ssh/communicator.go b/communicator/ssh/communicator.go index b5b67633c..0e198cb0d 100644 --- a/communicator/ssh/communicator.go +++ b/communicator/ssh/communicator.go @@ -748,7 +748,7 @@ func (c *comm) scpSession(scpCommand string, f func(io.Writer, *bufio.Reader) er err = session.Wait() if err != nil { if exitErr, ok := err.(*ssh.ExitError); ok { - // Otherwise, we have an ExitErorr, meaning we can just read + // Otherwise, we have an ExitError, meaning we can just read // the exit status log.Printf("non-zero exit status: %d", exitErr.ExitStatus()) stdoutB, err := ioutil.ReadAll(stdoutR) From 33bf6de9216503ba9af890604a7609e628481b73 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:46:49 +0000 Subject: [PATCH 32/89] spelling: exceeds --- builder/cloudstack/step_create_instance.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/cloudstack/step_create_instance.go b/builder/cloudstack/step_create_instance.go index 19f6a3c28..343d36c35 100644 --- a/builder/cloudstack/step_create_instance.go +++ b/builder/cloudstack/step_create_instance.go @@ -226,7 +226,7 @@ func (s *stepCreateInstance) generateUserData(userData string, httpGETOnly bool) if len(ud) > maxUD { return "", fmt.Errorf( "The supplied user_data contains %d bytes after encoding, "+ - "this exeeds the limit of %d bytes", len(ud), maxUD) + "this exceeds the limit of %d bytes", len(ud), maxUD) } return ud, nil From 041a115f6598cbb5d7c0a72136ab85df729d33ef Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:15:56 +0000 Subject: [PATCH 33/89] spelling: existent --- CHANGELOG.md | 2 +- builder/parallels/iso/builder_test.go | 2 +- builder/parallels/pvm/config_test.go | 2 +- builder/virtualbox/ovf/config_test.go | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9707c60cb..15368d2c3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -658,7 +658,7 @@ * builder/amazon: Crashes when new EBS vols are used. [GH-4308] * builder/amazon: Fix crash in amazon-instance. [GH-4372] * builder/amazon: fix run volume tagging [GH-4420] -* builder/amazon: fix when using non-existant security\_group\_id. [GH-4425] +* builder/amazon: fix when using non-existent security\_group\_id. [GH-4425] * builder/amazon: Properly error if we don't have the ec2:DescribeSecurityGroups permission. [GH-4304] * builder/amazon: Properly wait for security group to exist. [GH-4369] diff --git a/builder/parallels/iso/builder_test.go b/builder/parallels/iso/builder_test.go index b4b9eb917..88a28144e 100644 --- a/builder/parallels/iso/builder_test.go +++ b/builder/parallels/iso/builder_test.go @@ -86,7 +86,7 @@ func TestBuilderPrepare_FloppyFiles(t *testing.T) { func TestBuilderPrepare_InvalidFloppies(t *testing.T) { var b Builder config := testConfig() - config["floppy_files"] = []string{"nonexistant.bat", "nonexistant.ps1"} + config["floppy_files"] = []string{"nonexistent.bat", "nonexistent.ps1"} b = Builder{} _, errs := b.Prepare(config) if errs == nil { diff --git a/builder/parallels/pvm/config_test.go b/builder/parallels/pvm/config_test.go index c6c36a0b4..8c869c9fd 100644 --- a/builder/parallels/pvm/config_test.go +++ b/builder/parallels/pvm/config_test.go @@ -84,7 +84,7 @@ func TestNewConfig_FloppyFiles(t *testing.T) { func TestNewConfig_InvalidFloppies(t *testing.T) { c := testConfig(t) - c["floppy_files"] = []string{"nonexistant.bat", "nonexistant.ps1"} + c["floppy_files"] = []string{"nonexistent.bat", "nonexistent.ps1"} _, _, errs := NewConfig(c) if errs == nil { t.Fatalf("Nonexistent floppies should trigger multierror") diff --git a/builder/virtualbox/ovf/config_test.go b/builder/virtualbox/ovf/config_test.go index 51412a0c5..e36c44fcf 100644 --- a/builder/virtualbox/ovf/config_test.go +++ b/builder/virtualbox/ovf/config_test.go @@ -73,7 +73,7 @@ func TestNewConfig_sourcePath(t *testing.T) { t.Fatalf("bad: %#v", warns) } if err == nil { - t.Fatalf("Nonexistant file should throw a validation error!") + t.Fatalf("Nonexistent file should throw a validation error!") } // Bad From 466f0d2be415c1c6fe0f957adbb8877d2258a37c Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:49:46 +0000 Subject: [PATCH 34/89] spelling: firewall --- builder/cloudstack/step_configure_networking.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/cloudstack/step_configure_networking.go b/builder/cloudstack/step_configure_networking.go index ff37a540a..4dba63ef7 100644 --- a/builder/cloudstack/step_configure_networking.go +++ b/builder/cloudstack/step_configure_networking.go @@ -187,7 +187,7 @@ func (s *stepSetupNetworking) Cleanup(state multistep.StateBag) { // Create a new parameter struct. p := client.Firewall.NewDeleteFirewallRuleParams(fwRuleID) - ui.Message("Deleting firewal rule...") + ui.Message("Deleting firewall rule...") if _, err := client.Firewall.DeleteFirewallRule(p); err != nil { // This is a very poor way to be told the ID does no longer exist :( if !strings.Contains(err.Error(), fmt.Sprintf( From dc942a0d8ade51a81c64e543d558dacb2cb0b529 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:50:00 +0000 Subject: [PATCH 35/89] spelling: first --- builder/parallels/common/driver_9.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder/parallels/common/driver_9.go b/builder/parallels/common/driver_9.go index cfdee4a5d..b8b697ba1 100644 --- a/builder/parallels/common/driver_9.go +++ b/builder/parallels/common/driver_9.go @@ -43,7 +43,7 @@ func (d *Parallels9Driver) Import(name, srcPath, dstDir string, reassignMAC bool srcMAC := "auto" if !reassignMAC { - srcMAC, err = getFirtsMACAddress(srcPath) + srcMAC, err = getFirstMACAddress(srcPath) if err != nil { return err } @@ -70,7 +70,7 @@ func getVMID(path string) (string, error) { return getConfigValueFromXpath(path, "/ParallelsVirtualMachine/Identification/VmUuid") } -func getFirtsMACAddress(path string) (string, error) { +func getFirstMACAddress(path string) (string, error) { return getConfigValueFromXpath(path, "/ParallelsVirtualMachine/Hardware/NetworkAdapter[@id='0']/MAC") } From b545c6f87e0ec1b617e2d7083d4a5cd586b846be Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:50:25 +0000 Subject: [PATCH 36/89] spelling: flattened --- provisioner/windows-shell/provisioner.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/provisioner/windows-shell/provisioner.go b/provisioner/windows-shell/provisioner.go index 585fa437c..babc9b5ec 100644 --- a/provisioner/windows-shell/provisioner.go +++ b/provisioner/windows-shell/provisioner.go @@ -203,11 +203,11 @@ func (p *Provisioner) Provision(ui packer.Ui, comm packer.Communicator) error { defer f.Close() // Create environment variables to set before executing the command - flattendVars := p.createFlattenedEnvVars() + flattenedVars := p.createFlattenedEnvVars() // Compile the command p.config.ctx.Data = &ExecuteCommandTemplate{ - Vars: flattendVars, + Vars: flattenedVars, Path: p.config.RemotePath, } command, err := interpolate.Render(p.config.ExecuteCommand, &p.config.ctx) From 24b4c36fc9a23b9ded5be57605e3a1dd23d2e481 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:52:02 +0000 Subject: [PATCH 37/89] spelling: function --- builder/ncloud/step_validate_template.go | 4 ++-- provisioner/powershell/provisioner_test.go | 4 ++-- provisioner/windows-shell/provisioner_test.go | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/builder/ncloud/step_validate_template.go b/builder/ncloud/step_validate_template.go index c63c5f04b..f00525e5c 100644 --- a/builder/ncloud/step_validate_template.go +++ b/builder/ncloud/step_validate_template.go @@ -25,7 +25,7 @@ type StepValidateTemplate struct { FeeSystemTypeCode string } -// NewStepValidateTemplate : funciton for Validation a tempalte +// NewStepValidateTemplate : function for Validation a tempalte func NewStepValidateTemplate(conn *ncloud.Conn, ui packer.Ui, config *Config) *StepValidateTemplate { var step = &StepValidateTemplate{ Conn: conn, @@ -249,7 +249,7 @@ func (s *StepValidateTemplate) validateTemplate() error { return s.validateServerProductCode() } -// Run : main funciton for validation a template +// Run : main function for validation a template func (s *StepValidateTemplate) Run(_ context.Context, state multistep.StateBag) multistep.StepAction { s.Say("Validating deployment template ...") diff --git a/provisioner/powershell/provisioner_test.go b/provisioner/powershell/provisioner_test.go index 3c758ae4d..9c8237eb8 100644 --- a/provisioner/powershell/provisioner_test.go +++ b/provisioner/powershell/provisioner_test.go @@ -694,7 +694,7 @@ func TestRetryable(t *testing.T) { err := p.Prepare(config) err = p.retryable(retryMe) if err != nil { - t.Fatalf("should not have error retrying funuction") + t.Fatalf("should not have error retrying function") } count = 0 @@ -702,7 +702,7 @@ func TestRetryable(t *testing.T) { err = p.Prepare(config) err = p.retryable(retryMe) if err == nil { - t.Fatalf("should have error retrying funuction") + t.Fatalf("should have error retrying function") } } diff --git a/provisioner/windows-shell/provisioner_test.go b/provisioner/windows-shell/provisioner_test.go index 1f2ee2cab..e0731da10 100644 --- a/provisioner/windows-shell/provisioner_test.go +++ b/provisioner/windows-shell/provisioner_test.go @@ -434,7 +434,7 @@ func TestRetryable(t *testing.T) { err := p.Prepare(config) err = p.retryable(retryMe) if err != nil { - t.Fatalf("should not have error retrying funuction") + t.Fatalf("should not have error retrying function") } count = 0 @@ -442,7 +442,7 @@ func TestRetryable(t *testing.T) { err = p.Prepare(config) err = p.retryable(retryMe) if err == nil { - t.Fatalf("should have error retrying funuction") + t.Fatalf("should have error retrying function") } } From 210f8e8312a396ccf67e349127335ee0a4eda0d4 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 07:59:00 +0000 Subject: [PATCH 38/89] spelling: hyphen --- builder/azure/arm/artifact_test.go | 2 +- builder/azure/arm/config_test.go | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/builder/azure/arm/artifact_test.go b/builder/azure/arm/artifact_test.go index 4aff7cee6..a86a6353e 100644 --- a/builder/azure/arm/artifact_test.go +++ b/builder/azure/arm/artifact_test.go @@ -235,7 +235,7 @@ func TestAdditionalDiskArtifactProperties(t *testing.T) { } } -func TestArtifactOverHypenatedCaptureUri(t *testing.T) { +func TestArtifactOverHyphenatedCaptureUri(t *testing.T) { template := CaptureTemplate{ Resources: []CaptureResources{ { diff --git a/builder/azure/arm/config_test.go b/builder/azure/arm/config_test.go index c7758fb91..71f3c352d 100644 --- a/builder/azure/arm/config_test.go +++ b/builder/azure/arm/config_test.go @@ -499,7 +499,7 @@ func TestConfigShouldRejectMalformedCaptureNamePrefix(t *testing.T) { wellFormedCaptureNamePrefix := []string{ "packer", "AbcdefghijklmnopqrstuvwX", - "hypen-hypen", + "hyphen-hyphen", "0leading-number", "v1.core.local", } @@ -514,8 +514,8 @@ func TestConfigShouldRejectMalformedCaptureNamePrefix(t *testing.T) { } malformedCaptureNamePrefix := []string{ - "-leading-hypen", - "trailing-hypen-", + "-leading-hyphen", + "trailing-hyphen-", "trailing-period.", "_leading-underscore", "punc-!@#$%^&*()_+-=-punc", @@ -550,7 +550,7 @@ func TestConfigShouldRejectMalformedCaptureContainerName(t *testing.T) { wellFormedCaptureContainerName := []string{ "0leading", "aleading", - "hype-hypen", + "hype-hyphen", "abcdefghijklmnopqrstuvwxyz0123456789-abcdefghijklmnopqrstuvwxyz", // 63 characters } @@ -565,9 +565,9 @@ func TestConfigShouldRejectMalformedCaptureContainerName(t *testing.T) { malformedCaptureContainerName := []string{ "No-Capitals", - "double--hypens", - "-leading-hypen", - "trailing-hypen-", + "double--hyphens", + "-leading-hyphen", + "trailing-hyphen-", "punc-!@#$%^&*()_+-=-punc", "there-are-over-63-characters-in-this-string-and-that-is-a-bad-container-name", } From 57c0e9e4a7f361cd6b38cc6336c47300344d05d8 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:02:43 +0000 Subject: [PATCH 39/89] spelling: illegal --- builder/virtualbox/common/export_config_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/virtualbox/common/export_config_test.go b/builder/virtualbox/common/export_config_test.go index 612bfc01d..6848a9a66 100644 --- a/builder/virtualbox/common/export_config_test.go +++ b/builder/virtualbox/common/export_config_test.go @@ -10,7 +10,7 @@ func TestExportConfigPrepare_BootWait(t *testing.T) { // Bad c = new(ExportConfig) - c.Format = "illega" + c.Format = "illegal" errs = c.Prepare(testConfigTemplate(t)) if len(errs) == 0 { t.Fatalf("bad: %#v", errs) From 3a31baae4f012f0b241669d2dbbf239bb94ae1d5 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:00:05 +0000 Subject: [PATCH 40/89] spelling: incorrect --- builder/alicloud/ecs/step_config_vswitch.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/alicloud/ecs/step_config_vswitch.go b/builder/alicloud/ecs/step_config_vswitch.go index c1494e9d0..4bbb19773 100644 --- a/builder/alicloud/ecs/step_config_vswitch.go +++ b/builder/alicloud/ecs/step_config_vswitch.go @@ -137,7 +137,7 @@ func (s *stepConfigAlicloudVSwitch) Cleanup(state multistep.StateBag) { e, _ := err.(*common.Error) if (e.Code == "IncorrectVSwitchStatus" || e.Code == "DependencyViolation" || e.Code == "DependencyViolation.HaVip" || - e.Code == "IncorretRouteEntryStatus") && time.Now().Before(timeoutPoint) { + e.Code == "IncorrectRouteEntryStatus") && time.Now().Before(timeoutPoint) { time.Sleep(1 * time.Second) continue } From 1e99dce12bda11197a27a75aba4ab407d7c985b5 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:05:14 +0000 Subject: [PATCH 41/89] spelling: inertness --- builder/azure/arm/authenticate_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/azure/arm/authenticate_test.go b/builder/azure/arm/authenticate_test.go index 37d7b0e1b..12791138c 100644 --- a/builder/azure/arm/authenticate_test.go +++ b/builder/azure/arm/authenticate_test.go @@ -8,7 +8,7 @@ import ( // Behavior is the most important thing to assert for ServicePrincipalToken, but // that cannot be done in a unit test because it involves network access. Instead, -// I assert the expected intertness of this class. +// I assert the expected inertness of this class. func TestNewAuthenticate(t *testing.T) { testSubject := NewAuthenticate(azure.PublicCloud, "clientID", "clientString", "tenantID") spn, err := testSubject.getServicePrincipalToken() From 074b04522fd3882580dbf06e65a21d8806c56206 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:04:26 +0000 Subject: [PATCH 42/89] spelling: initializing --- website/source/docs/other/debugging.html.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/source/docs/other/debugging.html.md b/website/source/docs/other/debugging.html.md index b34f1485b..f71e8b5e4 100644 --- a/website/source/docs/other/debugging.html.md +++ b/website/source/docs/other/debugging.html.md @@ -28,7 +28,7 @@ ephemeral key will be deleted at the end of the packer run during cleanup. For a local builder, the SSH session initiated will be visible in the detail provided when `PACKER_LOG=1` environment variable is set prior to a build, and you can connect to the local machine using the userid and password defined -in the kickstart or preseed associated with initialzing the local VM. +in the kickstart or preseed associated with initializing the local VM. ### Windows From 62f59662a34768b83e79116343bcff70b8f0b65d Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:04:40 +0000 Subject: [PATCH 43/89] spelling: installation --- builder/hyperv/common/step_polling_installation.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/builder/hyperv/common/step_polling_installation.go b/builder/hyperv/common/step_polling_installation.go index b9d2984f6..133418ee7 100644 --- a/builder/hyperv/common/step_polling_installation.go +++ b/builder/hyperv/common/step_polling_installation.go @@ -15,10 +15,10 @@ import ( const port string = "13000" -type StepPollingInstalation struct { +type StepPollingInstallation struct { } -func (s *StepPollingInstalation) Run(_ context.Context, state multistep.StateBag) multistep.StepAction { +func (s *StepPollingInstallation) Run(_ context.Context, state multistep.StateBag) multistep.StepAction { ui := state.Get("ui").(packer.Ui) errorMsg := "Error polling VM: %s" @@ -75,6 +75,6 @@ func (s *StepPollingInstalation) Run(_ context.Context, state multistep.StateBag return multistep.ActionContinue } -func (s *StepPollingInstalation) Cleanup(state multistep.StateBag) { +func (s *StepPollingInstallation) Cleanup(state multistep.StateBag) { } From 933ac20e68a9d4d72983889e6df4a45d0075fb79 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:04:50 +0000 Subject: [PATCH 44/89] spelling: instance --- builder/alicloud/ecs/builder.go | 2 +- builder/alicloud/ecs/step_create_instance.go | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/builder/alicloud/ecs/builder.go b/builder/alicloud/ecs/builder.go index 7269bd3f0..e0d7c0d7c 100644 --- a/builder/alicloud/ecs/builder.go +++ b/builder/alicloud/ecs/builder.go @@ -132,7 +132,7 @@ func (b *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (packe RegionId: b.config.AlicloudRegion, InternetChargeType: b.config.InternetChargeType, InternetMaxBandwidthOut: b.config.InternetMaxBandwidthOut, - InstnaceName: b.config.InstanceName, + InstanceName: b.config.InstanceName, ZoneId: b.config.ZoneId, }) if b.chooseNetworkType() == VpcNet { diff --git a/builder/alicloud/ecs/step_create_instance.go b/builder/alicloud/ecs/step_create_instance.go index 5001fe4df..ff41a3df6 100644 --- a/builder/alicloud/ecs/step_create_instance.go +++ b/builder/alicloud/ecs/step_create_instance.go @@ -21,7 +21,7 @@ type stepCreateAlicloudInstance struct { RegionId string InternetChargeType string InternetMaxBandwidthOut int - InstnaceName string + InstanceName string ZoneId string instance *ecs.InstanceAttributesType } @@ -63,7 +63,7 @@ func (s *stepCreateAlicloudInstance) Run(_ context.Context, state multistep.Stat IoOptimized: ioOptimized, VSwitchId: vswitchId, SecurityGroupId: securityGroupId, - InstanceName: s.InstnaceName, + InstanceName: s.InstanceName, Password: password, ZoneId: s.ZoneId, DataDisk: diskDeviceToDiskType(config.AlicloudImageConfig.ECSImagesDiskMappings), @@ -89,7 +89,7 @@ func (s *stepCreateAlicloudInstance) Run(_ context.Context, state multistep.Stat InternetMaxBandwidthOut: s.InternetMaxBandwidthOut, IoOptimized: ioOptimized, SecurityGroupId: securityGroupId, - InstanceName: s.InstnaceName, + InstanceName: s.InstanceName, Password: password, ZoneId: s.ZoneId, DataDisk: diskDeviceToDiskType(config.AlicloudImageConfig.ECSImagesDiskMappings), From eebe2365872d4553321f045ee320d7ee5e1ea857 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:07:31 +0000 Subject: [PATCH 45/89] spelling: keyboard --- communicator/ssh/password_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/communicator/ssh/password_test.go b/communicator/ssh/password_test.go index e513716d0..47a4c7782 100644 --- a/communicator/ssh/password_test.go +++ b/communicator/ssh/password_test.go @@ -15,7 +15,7 @@ func TestPasswordKeyboardInteractive_Impl(t *testing.T) { } } -func TestPasswordKeybardInteractive_Challenge(t *testing.T) { +func TestPasswordKeyboardInteractive_Challenge(t *testing.T) { p := PasswordKeyboardInteractive("foo") result, err := p("foo", "bar", []string{"one", "two"}, nil) if err != nil { From ae4abedfa290875eaacf686cf39c2999415ecb16 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:10:59 +0000 Subject: [PATCH 46/89] spelling: mandatory --- builder/ncloud/config_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/ncloud/config_test.go b/builder/ncloud/config_test.go index 7e2591594..fb7886dbc 100644 --- a/builder/ncloud/config_test.go +++ b/builder/ncloud/config_test.go @@ -113,7 +113,7 @@ func TestEmptyConfig(t *testing.T) { _, _, err := NewConfig(raw) if err == nil { - t.Error("Expected Config to require 'access_key', 'secret_key' and some mendatory fields, but it did not") + t.Error("Expected Config to require 'access_key', 'secret_key' and some mandatory fields, but it did not") } if !strings.Contains(err.Error(), "access_key is required") { From 5c0d0322f0a9972c999e64b371e5f1a34e044b06 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:09:00 +0000 Subject: [PATCH 47/89] spelling: manifest --- website/source/docs/post-processors/manifest.html.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/source/docs/post-processors/manifest.html.md b/website/source/docs/post-processors/manifest.html.md index 8ad53f451..4d5aaa398 100644 --- a/website/source/docs/post-processors/manifest.html.md +++ b/website/source/docs/post-processors/manifest.html.md @@ -67,7 +67,7 @@ An example manifest file looks like: If the build is run again, the new build artifacts will be added to the manifest file rather than replacing it. It is possible to grab specific build artifacts from the manifest by using `packer_run_uuid`. -The above mainfest was generated with this packer.json: +The above manifest was generated with this packer.json: ```json { From 964d5dd55e099a0192f4d9c1804f549398221633 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:09:41 +0000 Subject: [PATCH 48/89] spelling: mapstructure --- builder/virtualbox/common/export_config.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/virtualbox/common/export_config.go b/builder/virtualbox/common/export_config.go index 08dfb267c..b55941943 100644 --- a/builder/virtualbox/common/export_config.go +++ b/builder/virtualbox/common/export_config.go @@ -7,7 +7,7 @@ import ( ) type ExportConfig struct { - Format string `mapstruture:"format"` + Format string `mapstructure:"format"` } func (c *ExportConfig) Prepare(ctx *interpolate.Context) []error { From 73d3d65b84ea426a61d8e9b6cbf686a4527abf6a Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:10:01 +0000 Subject: [PATCH 49/89] spelling: marshal --- builder/azure/pkcs12/pkcs12.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/azure/pkcs12/pkcs12.go b/builder/azure/pkcs12/pkcs12.go index 8279cb572..806246daa 100644 --- a/builder/azure/pkcs12/pkcs12.go +++ b/builder/azure/pkcs12/pkcs12.go @@ -398,7 +398,7 @@ func Encode(derBytes []byte, privateKey interface{}, password string) (pfxBytes return nil, err } - // Marhsal []contentInfo so we can re-constitute the byte stream that will + // Marshal []contentInfo so we can re-constitute the byte stream that will // be suitable for computing the MAC bytes, err := asn1.Marshal(contentInfos) if err != nil { From cab8b6ed68ac08f4e506e2816ebf1bdac7530a6b Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:10:20 +0000 Subject: [PATCH 50/89] spelling: maximum --- builder/hyperv/iso/builder.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/hyperv/iso/builder.go b/builder/hyperv/iso/builder.go index b92e779df..b912ab316 100644 --- a/builder/hyperv/iso/builder.go +++ b/builder/hyperv/iso/builder.go @@ -172,7 +172,7 @@ func (b *Builder) Prepare(raws ...interface{}) ([]string, error) { } if len(b.config.AdditionalDiskSize) > 64 { - err = errors.New("VM's currently support a maximun of 64 additional SCSI attached disks.") + err = errors.New("VM's currently support a maximum of 64 additional SCSI attached disks.") errs = packer.MultiErrorAppend(errs, err) } From abb2faf677d472fe66422c8621914c366f36eae4 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:10:53 +0000 Subject: [PATCH 51/89] spelling: membership --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 15368d2c3..363e39dce 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -411,7 +411,7 @@ * builder/cloudstack: Properly report back errors. [GH-5103] [GH-5123] * builder/docker: Fix windows filepath in docker-toolbox call [GH-4887] * builder/docker: Fix windows filepath in docker-toolbox call. [GH-4887] -* builder/hyperv: Use SID to verify membersip in Admin group, fixing for non- +* builder/hyperv: Use SID to verify membership in Admin group, fixing for non- english users. [GH-5022] * builder/hyperv: Verify membership in the group Hyper-V Administrators by SID not name. [GH-5022] From d987fcefc34bf7d38304828d4ff13067c20c3fbb Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:12:53 +0000 Subject: [PATCH 52/89] spelling: multiples --- builder/vmware/common/vmx.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder/vmware/common/vmx.go b/builder/vmware/common/vmx.go index 1fcdfa35e..631e0106d 100644 --- a/builder/vmware/common/vmx.go +++ b/builder/vmware/common/vmx.go @@ -44,14 +44,14 @@ func EncodeVMX(contents map[string]string) string { } // a list of VMX key fragments that the value must not be quoted - // fragments are used to cover multliples (i.e. multiple disks) + // fragments are used to cover multiples (i.e. multiple disks) // keys are still lowercase at this point, use lower fragments noQuotes := []string{ ".virtualssd", } // a list of VMX key fragments that are case sensitive - // fragments are used to cover multliples (i.e. multiple disks) + // fragments are used to cover multiples (i.e. multiple disks) caseSensitive := []string{ ".virtualSSD", } From e43b8de3b1834a47ceebccca7dd8238d20a5085c Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:14:30 +0000 Subject: [PATCH 53/89] spelling: network --- builder/azure/arm/template_factory.go | 2 +- builder/azure/common/template/template_builder.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builder/azure/arm/template_factory.go b/builder/azure/arm/template_factory.go index 843580fd2..62b25dc26 100644 --- a/builder/azure/arm/template_factory.go +++ b/builder/azure/arm/template_factory.go @@ -86,7 +86,7 @@ func GetVirtualMachineDeployment(config *Config) (*resources.Deployment, error) } if config.VirtualNetworkName != "" && DefaultPrivateVirtualNetworkWithPublicIp != config.PrivateVirtualNetworkWithPublicIp { - builder.SetPrivateVirtualNetworWithPublicIp( + builder.SetPrivateVirtualNetworkWithPublicIp( config.VirtualNetworkResourceGroupName, config.VirtualNetworkName, config.VirtualNetworkSubnetName) diff --git a/builder/azure/common/template/template_builder.go b/builder/azure/common/template/template_builder.go index a05b66ab3..93de89374 100644 --- a/builder/azure/common/template/template_builder.go +++ b/builder/azure/common/template/template_builder.go @@ -274,7 +274,7 @@ func (s *TemplateBuilder) SetVirtualNetwork(virtualNetworkResourceGroup, virtual return nil } -func (s *TemplateBuilder) SetPrivateVirtualNetworWithPublicIp(virtualNetworkResourceGroup, virtualNetworkName, subnetName string) error { +func (s *TemplateBuilder) SetPrivateVirtualNetworkWithPublicIp(virtualNetworkResourceGroup, virtualNetworkName, subnetName string) error { s.setVariable("virtualNetworkResourceGroup", virtualNetworkResourceGroup) s.setVariable("virtualNetworkName", virtualNetworkName) s.setVariable("subnetName", subnetName) From 64aae1c7816e54857a8c19ae7e5983b2f3d9c1c1 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:16:48 +0000 Subject: [PATCH 54/89] spelling: occurring --- helper/multistep/debug_runner.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helper/multistep/debug_runner.go b/helper/multistep/debug_runner.go index 88af01c54..a6760c5f1 100644 --- a/helper/multistep/debug_runner.go +++ b/helper/multistep/debug_runner.go @@ -7,7 +7,7 @@ import ( "sync" ) -// DebugLocation is the location where the pause is occuring when debugging +// DebugLocation is the location where the pause is occurring when debugging // a step sequence. "DebugLocationAfterRun" is after the run of the named // step. "DebugLocationBeforeCleanup" is before the cleanup of the named // step. From 35353faa625303a57c7562ed8ec9749953a43249 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:17:22 +0000 Subject: [PATCH 55/89] spelling: omitted --- website/source/docs/builders/openstack.html.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/website/source/docs/builders/openstack.html.md b/website/source/docs/builders/openstack.html.md index 709d39246..0809b6545 100755 --- a/website/source/docs/builders/openstack.html.md +++ b/website/source/docs/builders/openstack.html.md @@ -81,7 +81,7 @@ builder. cluster will be used. This may be required for some OpenStack clusters. - `cacert` (string) - Custom CA certificate file path. - If ommited the OS\_CACERT environment variable can be used. + If omitted the OS\_CACERT environment variable can be used. - `config_drive` (boolean) - Whether or not nova should use ConfigDrive for cloud-init metadata. @@ -113,7 +113,7 @@ builder. done over an insecure connection. By default this is false. - `key` (string) - Client private key file path for SSL client authentication. - If ommited the OS\_KEY environment variable can be used. + If omitted the OS\_KEY environment variable can be used. - `metadata` (object of key/value strings) - Glance metadata that will be applied to the image. From 61030c0d85b62fd1bda77ec394d18ab43918ca7c Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:27:26 +0000 Subject: [PATCH 56/89] spelling: output --- builder/vmware/common/output_dir_local_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/vmware/common/output_dir_local_test.go b/builder/vmware/common/output_dir_local_test.go index c3197117e..3026c6c66 100644 --- a/builder/vmware/common/output_dir_local_test.go +++ b/builder/vmware/common/output_dir_local_test.go @@ -4,6 +4,6 @@ import ( "testing" ) -func TestLocalOuputDir_impl(t *testing.T) { +func TestLocalOutputDir_impl(t *testing.T) { var _ OutputDir = new(LocalOutputDir) } From 0503e429c38ab5ef3dc58d59b5a17c436e0c3ca8 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:28:26 +0000 Subject: [PATCH 57/89] spelling: override --- fix/fixer_pp_vagrant_override.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fix/fixer_pp_vagrant_override.go b/fix/fixer_pp_vagrant_override.go index 36aadfa46..a0c530728 100644 --- a/fix/fixer_pp_vagrant_override.go +++ b/fix/fixer_pp_vagrant_override.go @@ -4,7 +4,7 @@ import ( "github.com/mitchellh/mapstructure" ) -// FixerVagrantPPOvveride is a Fixer that replaces the provider-specific +// FixerVagrantPPOverride is a Fixer that replaces the provider-specific // overrides for the Vagrant post-processor with the new style introduced // as part of Packer 0.5.0. type FixerVagrantPPOverride struct{} From 6a2ad49feb5b97d62e24aa2b3e193a6d5dbf3fc7 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:30:28 +0000 Subject: [PATCH 58/89] spelling: parameter --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 363e39dce..420424e40 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1352,7 +1352,7 @@ * core: Fix potential panic for post-processor plugin exits. [GH-2098] * core: `PACKER_CONFIG` may point to a non-existent file. [GH-2226] * builder/amazon: Allow spaces in AMI names when using `clean_ami_name` [GH-2182] -* builder/amazon: Remove deprecated ec2-upload-bundle paramger. [GH-1931] +* builder/amazon: Remove deprecated ec2-upload-bundle parameter. [GH-1931] * builder/amazon: Use IAM Profile to upload bundle if provided. [GH-1985] * builder/amazon: Use correct exit code after SSH authentication failed. [GH-2004] * builder/amazon: Retry finding created instance for eventual From 18f51e7338373bfed6176fc7d96891b17954526b Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 08:29:17 +0000 Subject: [PATCH 59/89] spelling: parameters --- builder/oracle/oci/client/image.go | 2 +- builder/oracle/oci/client/instance.go | 2 +- builder/oracle/oci/client/vnic.go | 2 +- builder/oracle/oci/client/vnic_attachment.go | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/builder/oracle/oci/client/image.go b/builder/oracle/oci/client/image.go index 802b4650c..67ada02d5 100644 --- a/builder/oracle/oci/client/image.go +++ b/builder/oracle/oci/client/image.go @@ -56,7 +56,7 @@ type Image struct { TimeCreated time.Time `json:"timeCreated"` } -// GetImageParams are the paramaters available when communicating with the +// GetImageParams are the parameters available when communicating with the // GetImage API endpoint. type GetImageParams struct { ID string `url:"imageId"` diff --git a/builder/oracle/oci/client/instance.go b/builder/oracle/oci/client/instance.go index 30cdbd50b..e81ad3a44 100644 --- a/builder/oracle/oci/client/instance.go +++ b/builder/oracle/oci/client/instance.go @@ -60,7 +60,7 @@ type Instance struct { TimeCreated time.Time `json:"timeCreated"` } -// GetInstanceParams are the paramaters available when communicating with the +// GetInstanceParams are the parameters available when communicating with the // GetInstance API endpoint. type GetInstanceParams struct { ID string `url:"instanceId,omitempty"` diff --git a/builder/oracle/oci/client/vnic.go b/builder/oracle/oci/client/vnic.go index 31b37ec3e..9922d34aa 100644 --- a/builder/oracle/oci/client/vnic.go +++ b/builder/oracle/oci/client/vnic.go @@ -29,7 +29,7 @@ type VNIC struct { TimeCreated time.Time `json:"timeCreated"` } -// GetVNICParams are the paramaters available when communicating with the +// GetVNICParams are the parameters available when communicating with the // ListVNICs API endpoint. type GetVNICParams struct { ID string `url:"vnicId"` diff --git a/builder/oracle/oci/client/vnic_attachment.go b/builder/oracle/oci/client/vnic_attachment.go index 3458f7da1..1e42a0573 100644 --- a/builder/oracle/oci/client/vnic_attachment.go +++ b/builder/oracle/oci/client/vnic_attachment.go @@ -31,7 +31,7 @@ type VNICAttachment struct { VNICID string `json:"vnicId"` } -// ListVnicAttachmentsParams are the paramaters available when communicating +// ListVnicAttachmentsParams are the parameters available when communicating // with the ListVnicAttachments API endpoint. type ListVnicAttachmentsParams struct { AvailabilityDomain string `url:"availabilityDomain,omitempty"` From c14d6af5aaef2e2671e22b78980fb19e0e165062 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Tue, 13 Mar 2018 09:05:56 +0000 Subject: [PATCH 60/89] spelling: persistent --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 420424e40..c43badcb1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1435,7 +1435,7 @@ * builder/googlecompute: Support for ubuntu-os-cloud project * builder/googlecompute: Support for OAuth2 to avoid client secrets file -* builder/googlecompute: GCE image from persistant disk instead of tarball +* builder/googlecompute: GCE image from persistent disk instead of tarball * builder/qemu: Checksum type "none" can be used * provisioner/chef: Generate a node name if none available * provisioner/chef: Added ssl_verify_mode configuration From 8c72bba160088b95acd25794968c5ad9d8d84c76 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 02:14:18 +0000 Subject: [PATCH 61/89] spelling: possible --- builder/lxd/communicator.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/lxd/communicator.go b/builder/lxd/communicator.go index 8ce455268..d016b0990 100644 --- a/builder/lxd/communicator.go +++ b/builder/lxd/communicator.go @@ -90,7 +90,7 @@ func (c *Communicator) UploadDir(dst string, src string, exclude []string) error // Don't use 'z' flag as compressing may take longer and the transfer is likely local. // If this isn't the case, it is possible for the user to compress in another step then transfer. - // It wouldn't be possibe to disable compression, without exposing this option. + // It wouldn't be possible to disable compression, without exposing this option. tar, err := c.CmdWrapper(fmt.Sprintf("tar -cf - -C %s .", src)) if err != nil { return err From 8e36178e5ba3ad113a9b49f5f0b79e9093e3fd93 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 02:14:31 +0000 Subject: [PATCH 62/89] spelling: preemptible --- website/source/docs/builders/googlecompute.html.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/source/docs/builders/googlecompute.html.md b/website/source/docs/builders/googlecompute.html.md index fb006c7ae..d5fd09bce 100644 --- a/website/source/docs/builders/googlecompute.html.md +++ b/website/source/docs/builders/googlecompute.html.md @@ -263,7 +263,7 @@ builder. If preemptible is true this can only be `TERMINATE`. If preemptible is false, it defaults to `MIGRATE` -- `preemptible` (boolean) - If true, launch a preembtible instance. +- `preemptible` (boolean) - If true, launch a preemptible instance. - `region` (string) - The region in which to launch the instance. Defaults to to the region hosting the specified `zone`. From 91ecc80ede958ed26e8c61510c36dfd0a725281f Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 02:14:59 +0000 Subject: [PATCH 63/89] spelling: privileges --- website/source/docs/builders/oracle-classic.html.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/source/docs/builders/oracle-classic.html.md b/website/source/docs/builders/oracle-classic.html.md index 1ea03dc46..30f5bfd5e 100644 --- a/website/source/docs/builders/oracle-classic.html.md +++ b/website/source/docs/builders/oracle-classic.html.md @@ -78,7 +78,7 @@ This builder currently only works with the SSH communicator. - `ssh_username` (string) - The username that Packer will use to SSH into the instance; defaults to `opc`, the default oracle user, which has sudo - priveliges. If you have already configured users on your machine, you may + privileges. If you have already configured users on your machine, you may prompt Packer to use one of those instead. For more detail, see the [documentation](https://docs.oracle.com/en/cloud/iaas/compute-iaas-cloud/stcsg/accessing-oracle-linux-instance-using-ssh.html). From fa36e1d9613c7fd2c025db03f77c9b5ab1dc70e6 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 02:17:22 +0000 Subject: [PATCH 64/89] spelling: processing --- builder/vmware/iso/step_create_vmx.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/builder/vmware/iso/step_create_vmx.go b/builder/vmware/iso/step_create_vmx.go index ffeb724ec..46e5da43a 100644 --- a/builder/vmware/iso/step_create_vmx.go +++ b/builder/vmware/iso/step_create_vmx.go @@ -446,7 +446,7 @@ func (s *stepCreateVMX) Run(_ context.Context, state multistep.StateBag) multist templateData.SCSI_Present = "TRUE" templateData.CDROMType = "scsi" default: - err := fmt.Errorf("Error procesing VMX template: %s", cdromAdapterType) + err := fmt.Errorf("Error processing VMX template: %s", cdromAdapterType) state.Put("error", err) ui.Error(err.Error()) return multistep.ActionHalt @@ -505,7 +505,7 @@ func (s *stepCreateVMX) Run(_ context.Context, state multistep.StateBag) multist } else { serial, err := unformat_serial(config.Serial) if err != nil { - err := fmt.Errorf("Error procesing VMX template: %s", err) + err := fmt.Errorf("Error processing VMX template: %s", err) state.Put("error", err) ui.Error(err.Error()) return multistep.ActionHalt @@ -541,7 +541,7 @@ func (s *stepCreateVMX) Run(_ context.Context, state multistep.StateBag) multist break default: - err := fmt.Errorf("Error procesing VMX template: %v", serial) + err := fmt.Errorf("Error processing VMX template: %v", serial) state.Put("error", err) ui.Error(err.Error()) return multistep.ActionHalt @@ -554,7 +554,7 @@ func (s *stepCreateVMX) Run(_ context.Context, state multistep.StateBag) multist } else { parallel, err := unformat_parallel(config.Parallel) if err != nil { - err := fmt.Errorf("Error procesing VMX template: %s", err) + err := fmt.Errorf("Error processing VMX template: %s", err) state.Put("error", err) ui.Error(err.Error()) return multistep.ActionHalt @@ -578,7 +578,7 @@ func (s *stepCreateVMX) Run(_ context.Context, state multistep.StateBag) multist break default: - err := fmt.Errorf("Error procesing VMX template: %v", parallel) + err := fmt.Errorf("Error processing VMX template: %v", parallel) state.Put("error", err) ui.Error(err.Error()) return multistep.ActionHalt @@ -590,7 +590,7 @@ func (s *stepCreateVMX) Run(_ context.Context, state multistep.StateBag) multist /// render the .vmx template vmxContents, err := interpolate.Render(vmxTemplate, &ctx) if err != nil { - err := fmt.Errorf("Error procesing VMX template: %s", err) + err := fmt.Errorf("Error processing VMX template: %s", err) state.Put("error", err) ui.Error(err.Error()) return multistep.ActionHalt From 06dcad2c33bce7e2c6292d110e493cff7b330d4f Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 02:17:47 +0000 Subject: [PATCH 65/89] spelling: propagating --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c43badcb1..746909496 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2400,7 +2400,7 @@ ### BUG FIXES: * builder/amazon/all: Gracefully handle when AMI appears to not exist - while AWS state is propogating. [GH-207] + while AWS state is propagating. [GH-207] * builder/virtualbox: Trim carriage returns for Windows to properly detect VM state on Windows. [GH-218] * core: build names no longer cause invalid config errors. [GH-197] From 3c60f637384941854f2ffc89afd5c8e9c3157ebc Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 02:17:37 +0000 Subject: [PATCH 66/89] spelling: property --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 746909496..44a7fc8e3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2482,7 +2482,7 @@ * core: Non-200 response codes on downloads now show proper errors. [GH-141] * amazon-ebs: SSH handshake is retried. [GH-130] -* vagrant: The `BuildName` template propery works properly in +* vagrant: The `BuildName` template property works properly in the output path. * vagrant: Properly configure the provider-specific post-processors so things like `vagrantfile_template` work. [GH-129] From d3dc5ba6d3208f3a49901fcd9b2962c600f5fd27 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 02:15:21 +0000 Subject: [PATCH 67/89] spelling: provisioner --- packer/provisioner.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packer/provisioner.go b/packer/provisioner.go index a754f7544..93411808d 100644 --- a/packer/provisioner.go +++ b/packer/provisioner.go @@ -82,7 +82,7 @@ func (h *ProvisionHook) Run(name string, ui Ui, comm Communicator, data interfac return nil } -// Cancels the privisioners that are still running. +// Cancels the provisioners that are still running. func (h *ProvisionHook) Cancel() { h.lock.Lock() defer h.lock.Unlock() From 8294c8bc66add7d8f589782411d1bdbdc00d42b6 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 02:19:01 +0000 Subject: [PATCH 68/89] spelling: receive --- builder/oracle/oci/client/base_client.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/oracle/oci/client/base_client.go b/builder/oracle/oci/client/base_client.go index b2fd31d9b..01d66215a 100644 --- a/builder/oracle/oci/client/base_client.go +++ b/builder/oracle/oci/client/base_client.go @@ -184,7 +184,7 @@ func (c *baseClient) Request() (*http.Request, error) { return req, nil } -// Recieve creates a http request from the client and executes it returning the +// Receive creates a http request from the client and executes it returning the // response. func (c *baseClient) Receive(successV, failureV interface{}) (*http.Response, error) { req, err := c.Request() From 5178dd36e8cf8041f9d9e14951076802b4072207 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 02:19:10 +0000 Subject: [PATCH 69/89] spelling: regular --- common/step_download.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/step_download.go b/common/step_download.go index ac62fa698..5f5bb7dfe 100644 --- a/common/step_download.go +++ b/common/step_download.go @@ -63,7 +63,7 @@ func (s *StepDownload) Run(_ context.Context, state multistep.StateBag) multiste ui.Say(fmt.Sprintf("Downloading or copying %s", s.Description)) // First try to use any already downloaded file - // If it fails, proceed to regualar download logic + // If it fails, proceed to regular download logic var downloadConfigs = make([]*DownloadConfig, len(s.Url)) var finalPath string From 50f097b03d1fde8c338a28c42ce6cc3f4446f91a Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 02:19:20 +0000 Subject: [PATCH 70/89] spelling: repeatedly --- website/source/docs/builders/docker.html.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/website/source/docs/builders/docker.html.md b/website/source/docs/builders/docker.html.md index 23080e3ce..1105e8cf0 100644 --- a/website/source/docs/builders/docker.html.md +++ b/website/source/docs/builders/docker.html.md @@ -357,14 +357,14 @@ shown below: This builder allows you to build Docker images *without* Dockerfiles. -With this builder, you can repeatably create Docker images without the use of a +With this builder, you can repeatedly create Docker images without the use of a Dockerfile. You don't need to know the syntax or semantics of Dockerfiles. Instead, you can just provide shell scripts, Chef recipes, Puppet manifests, etc. to provision your Docker container just like you would a regular virtualized or dedicated machine. While Docker has many features, Packer views Docker simply as an container -runner. To that end, Packer is able to repeatably build these containers +runner. To that end, Packer is able to repeatedly build these containers using portable provisioning scripts. ## Overriding the host directory From aae5b50dabc7902a24802aa2bd4d6a79383c29f5 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 02:19:26 +0000 Subject: [PATCH 71/89] spelling: response --- .../azure/arm/azure_error_response_test.go | 20 +++++++++---------- builder/oracle/oci/client/transport_test.go | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/builder/azure/arm/azure_error_response_test.go b/builder/azure/arm/azure_error_response_test.go index faa429ad1..2e4f7f1ac 100644 --- a/builder/azure/arm/azure_error_response_test.go +++ b/builder/azure/arm/azure_error_response_test.go @@ -12,16 +12,16 @@ const AzureErrorSimple = `{"error":{"code":"ResourceNotFound","message":"The Res const AzureErrorNested = `{"status":"Failed","error":{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-debug for usage details.","details":[{"code":"BadRequest","message":"{\r\n \"error\": {\r\n \"code\": \"InvalidRequestFormat\",\r\n \"message\": \"Cannot parse the request.\",\r\n \"details\": [\r\n {\r\n \"code\": \"InvalidJson\",\r\n \"message\": \"Error converting value \\\"playground\\\" to type 'Microsoft.WindowsAzure.Networking.Nrp.Frontend.Contract.Csm.Public.IpAllocationMethod'. Path 'properties.publicIPAllocationMethod', line 1, position 130.\"\r\n }\r\n ]\r\n }\r\n}"}]}}` func TestAzureErrorSimpleShouldUnmarshal(t *testing.T) { - var azureErrorReponse azureErrorResponse - err := json.Unmarshal([]byte(AzureErrorSimple), &azureErrorReponse) + var azureErrorResponse azureErrorResponse + err := json.Unmarshal([]byte(AzureErrorSimple), &azureErrorResponse) if err != nil { t.Fatal(err) } - if azureErrorReponse.ErrorDetails.Code != "ResourceNotFound" { + if azureErrorResponse.ErrorDetails.Code != "ResourceNotFound" { t.Errorf("Error.Code") } - if azureErrorReponse.ErrorDetails.Message != "The Resource 'Microsoft.Compute/images/PackerUbuntuImage' under resource group 'packer-test00' was not found." { + if azureErrorResponse.ErrorDetails.Message != "The Resource 'Microsoft.Compute/images/PackerUbuntuImage' under resource group 'packer-test00' was not found." { t.Errorf("Error.Message") } } @@ -51,26 +51,26 @@ func TestAzureErrorEmptyShouldFormat(t *testing.T) { } func TestAzureErrorSimpleShouldFormat(t *testing.T) { - var azureErrorReponse azureErrorResponse - err := json.Unmarshal([]byte(AzureErrorSimple), &azureErrorReponse) + var azureErrorResponse azureErrorResponse + err := json.Unmarshal([]byte(AzureErrorSimple), &azureErrorResponse) if err != nil { t.Fatal(err) } - err = approvaltests.VerifyString(t, azureErrorReponse.Error()) + err = approvaltests.VerifyString(t, azureErrorResponse.Error()) if err != nil { t.Fatal(err) } } func TestAzureErrorNestedShouldFormat(t *testing.T) { - var azureErrorReponse azureErrorResponse - err := json.Unmarshal([]byte(AzureErrorNested), &azureErrorReponse) + var azureErrorResponse azureErrorResponse + err := json.Unmarshal([]byte(AzureErrorNested), &azureErrorResponse) if err != nil { t.Fatal(err) } - err = approvaltests.VerifyString(t, azureErrorReponse.Error()) + err = approvaltests.VerifyString(t, azureErrorResponse.Error()) if err != nil { t.Fatal(err) } diff --git a/builder/oracle/oci/client/transport_test.go b/builder/oracle/oci/client/transport_test.go index 2299f3a0e..ebf02040b 100644 --- a/builder/oracle/oci/client/transport_test.go +++ b/builder/oracle/oci/client/transport_test.go @@ -148,7 +148,7 @@ func TestKnownGoodRequests(t *testing.T) { for header, val := range tt.expectedHeaders { if sentReq.Header.Get(header) != val { - t.Fatalf("%s: Header mismatch in responnse,\n\t expecting \"%s\"\n\t got \"%s\"", tt.name, val, sentReq.Header.Get(header)) + t.Fatalf("%s: Header mismatch in response,\n\t expecting \"%s\"\n\t got \"%s\"", tt.name, val, sentReq.Header.Get(header)) } } } From 007930ec2d3f4d50ba1d0c1e1af4276c5dd05bb4 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:20:51 +0000 Subject: [PATCH 72/89] spelling: restricted --- builder/amazon/common/access_config_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/amazon/common/access_config_test.go b/builder/amazon/common/access_config_test.go index e1c44cb89..9c543816a 100644 --- a/builder/amazon/common/access_config_test.go +++ b/builder/amazon/common/access_config_test.go @@ -42,7 +42,7 @@ func TestAccessConfigPrepare_Region(t *testing.T) { } -func TestAccessConfigPrepare_RegionRestrictd(t *testing.T) { +func TestAccessConfigPrepare_RegionRestricted(t *testing.T) { c := testAccessConfig() // Create a Session with a custom region From 6c1654d421ec899f1a172e6a2e680a3793bd2c6f Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:21:38 +0000 Subject: [PATCH 73/89] spelling: separators --- communicator/ssh/communicator.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/communicator/ssh/communicator.go b/communicator/ssh/communicator.go index 0e198cb0d..d81ab750a 100644 --- a/communicator/ssh/communicator.go +++ b/communicator/ssh/communicator.go @@ -591,7 +591,7 @@ func (c *comm) scpUploadSession(path string, input io.Reader, fi *os.FileInfo) e target_file = filepath.Base((*fi).Name()) } - // On windows, filepath.Dir uses backslash seperators (ie. "\tmp"). + // On windows, filepath.Dir uses backslash separators (ie. "\tmp"). // This does not work when the target host is unix. Switch to forward slash // which works for unix and windows target_dir = filepath.ToSlash(target_dir) From 795116ef4ff95777cc0bc270032ad41ad8f6d507 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:21:44 +0000 Subject: [PATCH 74/89] spelling: session --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 44a7fc8e3..1343ea956 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2012,7 +2012,7 @@ * builder/digitalocean: scrub API keys from config debug output. [GH-516] * builder/virtualbox: error if VirtualBox version cant be detected. [GH-488] * builder/virtualbox: detect if vboxdrv isn't properly setup. [GH-488] -* builder/virtualbox: sleep a bit before export to ensure the sesssion +* builder/virtualbox: sleep a bit before export to ensure the session is unlocked. [GH-512] * builder/virtualbox: create SATA drives properly on VirtualBox 4.3. [GH-547] * builder/virtualbox: support user templates in SSH key path. [GH-539] From 5dd9be653aca7650216b413b214ac90ff9f4d895 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:22:32 +0000 Subject: [PATCH 75/89] spelling: should --- packer/core.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packer/core.go b/packer/core.go index 7da3e4510..c8ac2cfb7 100644 --- a/packer/core.go +++ b/packer/core.go @@ -67,7 +67,7 @@ func NewCore(c *CoreConfig) (*Core, error) { return nil, err } - // Go through and interpolate all the build names. We shuld be able + // Go through and interpolate all the build names. We should be able // to do this at this point with the variables. result.builds = make(map[string]*template.Builder) for _, b := range c.Template.Builders { From c7c8ed04f56d1ec2574f56d9675715bc3bd923c8 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:23:02 +0000 Subject: [PATCH 76/89] spelling: specify --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1343ea956..fe2f21796 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2169,7 +2169,7 @@ * builder/virtualbox,vmware: Support SHA512 as a checksum type. [GH-356] * builder/vmware: The root hard drive type can now be specified with "disk_type_id" for advanced users. [GH-328] -* provisioner/salt-masterless: Ability to specfy a minion config. [GH-264] +* provisioner/salt-masterless: Ability to specify a minion config. [GH-264] * provisioner/salt-masterless: Ability to upload pillars. [GH-353] ### IMPROVEMENTS: From c563ef0797347d2402dfd9a0292f1b183996ffdd Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:23:56 +0000 Subject: [PATCH 77/89] spelling: structure --- builder/googlecompute/driver.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/googlecompute/driver.go b/builder/googlecompute/driver.go index 4c07a06cf..11c4eadb9 100644 --- a/builder/googlecompute/driver.go +++ b/builder/googlecompute/driver.go @@ -82,7 +82,7 @@ type InstanceConfig struct { Zone string } -// WindowsPasswordConfig is the data structue that GCE needs to encrypt the created +// WindowsPasswordConfig is the data structure that GCE needs to encrypt the created // windows password. type WindowsPasswordConfig struct { key *rsa.PrivateKey From c49c40ac41e617099044fc4e085c7538a7e982a1 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:24:39 +0000 Subject: [PATCH 78/89] spelling: targeted --- packer/ui_test.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packer/ui_test.go b/packer/ui_test.go index ef14985ec..a1bb0193c 100644 --- a/packer/ui_test.go +++ b/packer/ui_test.go @@ -99,34 +99,34 @@ func TestColoredUi_noColorEnv(t *testing.T) { func TestTargetedUI(t *testing.T) { bufferUi := testUi() - targettedUi := &TargetedUI{ + targetedUi := &TargetedUI{ Target: "foo", Ui: bufferUi, } var actual, expected string - targettedUi.Say("foo") + targetedUi.Say("foo") actual = readWriter(bufferUi) expected = "==> foo: foo\n" if actual != expected { t.Fatalf("bad: %#v", actual) } - targettedUi.Message("foo") + targetedUi.Message("foo") actual = readWriter(bufferUi) expected = " foo: foo\n" if actual != expected { t.Fatalf("bad: %#v", actual) } - targettedUi.Error("bar") + targetedUi.Error("bar") actual = readErrorWriter(bufferUi) expected = "==> foo: bar\n" if actual != expected { t.Fatalf("bad: %#v", actual) } - targettedUi.Say("foo\nbar") + targetedUi.Say("foo\nbar") actual = readWriter(bufferUi) expected = "==> foo: foo\n==> foo: bar\n" if actual != expected { From 5a393d4fac5703762bd426cc2cf537a5f56a7166 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:24:51 +0000 Subject: [PATCH 79/89] spelling: template --- builder/ncloud/step_validate_template.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder/ncloud/step_validate_template.go b/builder/ncloud/step_validate_template.go index f00525e5c..873cd4723 100644 --- a/builder/ncloud/step_validate_template.go +++ b/builder/ncloud/step_validate_template.go @@ -13,7 +13,7 @@ import ( "github.com/olekukonko/tablewriter" ) -//StepValidateTemplate : struct for Validation a tempalte +//StepValidateTemplate : struct for Validation a template type StepValidateTemplate struct { Conn *ncloud.Conn Validate func() error @@ -25,7 +25,7 @@ type StepValidateTemplate struct { FeeSystemTypeCode string } -// NewStepValidateTemplate : function for Validation a tempalte +// NewStepValidateTemplate : function for Validation a template func NewStepValidateTemplate(conn *ncloud.Conn, ui packer.Ui, config *Config) *StepValidateTemplate { var step = &StepValidateTemplate{ Conn: conn, From bf3bf79b8194f2efccaa3eeb785b48235908305e Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:25:12 +0000 Subject: [PATCH 80/89] spelling: timeoutms --- website/source/docs/builders/hyperv-iso.html.md | 2 +- website/source/docs/builders/hyperv-vmcx.html.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/website/source/docs/builders/hyperv-iso.html.md b/website/source/docs/builders/hyperv-iso.html.md index 8e481bcad..3e919c925 100644 --- a/website/source/docs/builders/hyperv-iso.html.md +++ b/website/source/docs/builders/hyperv-iso.html.md @@ -656,7 +656,7 @@ Finish Setup cache proxy during installation --> cmd.exe /c winrm set winrm/config @{MaxTimeoutms="1800000"} - Win RM MaxTimoutms + Win RM MaxTimeoutms 5 true diff --git a/website/source/docs/builders/hyperv-vmcx.html.md b/website/source/docs/builders/hyperv-vmcx.html.md index f43372c65..5ff7b604d 100644 --- a/website/source/docs/builders/hyperv-vmcx.html.md +++ b/website/source/docs/builders/hyperv-vmcx.html.md @@ -651,7 +651,7 @@ Finish Setup cache proxy during installation --> cmd.exe /c winrm set winrm/config @{MaxTimeoutms="1800000"} - Win RM MaxTimoutms + Win RM MaxTimeoutms 5 true From 3b694feabc792db0e5b26cc45ce8dff249dc415d Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:25:35 +0000 Subject: [PATCH 81/89] spelling: transfer --- builder/digitalocean/wait.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builder/digitalocean/wait.go b/builder/digitalocean/wait.go index 2e4bd280c..684955853 100644 --- a/builder/digitalocean/wait.go +++ b/builder/digitalocean/wait.go @@ -198,12 +198,12 @@ func waitForImageState( } }() - log.Printf("Waiting for up to %d seconds for image transter to become %s", timeout/time.Second, desiredState) + log.Printf("Waiting for up to %d seconds for image transfer to become %s", timeout/time.Second, desiredState) select { case err := <-result: return err case <-time.After(timeout): - err := fmt.Errorf("Timeout while waiting to for image transter to become '%s'", desiredState) + err := fmt.Errorf("Timeout while waiting to for image transfer to become '%s'", desiredState) return err } } From 33f90d7783d4fb726536c016a2a1a0545a2dc348 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:27:22 +0000 Subject: [PATCH 82/89] spelling: unmarshalling --- builder/azure/pkcs12/pkcs12.go | 2 +- builder/azure/pkcs12/safebags.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builder/azure/pkcs12/pkcs12.go b/builder/azure/pkcs12/pkcs12.go index 806246daa..c5ce90f0d 100644 --- a/builder/azure/pkcs12/pkcs12.go +++ b/builder/azure/pkcs12/pkcs12.go @@ -92,7 +92,7 @@ const ( ) // unmarshal calls asn1.Unmarshal, but also returns an error if there is any -// trailing data after unmarshaling. +// trailing data after unmarshalling. func unmarshal(in []byte, out interface{}) error { trailing, err := asn1.Unmarshal(in, out) if err != nil { diff --git a/builder/azure/pkcs12/safebags.go b/builder/azure/pkcs12/safebags.go index bbd1526b8..836236da3 100644 --- a/builder/azure/pkcs12/safebags.go +++ b/builder/azure/pkcs12/safebags.go @@ -83,7 +83,7 @@ func decodePkcs8ShroudedKeyBag(asn1Data, password []byte) (privateKey interface{ ret := new(asn1.RawValue) if err = unmarshal(pkData, ret); err != nil { - return nil, errors.New("pkcs12: error unmarshaling decrypted private key: " + err.Error()) + return nil, errors.New("pkcs12: error unmarshalling decrypted private key: " + err.Error()) } if privateKey, err = x509.ParsePKCS8PrivateKey(pkData); err != nil { From b81672c906da1d0c5d9aaf0247ad4435a46227ee Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:28:00 +0000 Subject: [PATCH 83/89] spelling: valid --- builder/googlecompute/private_key.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/googlecompute/private_key.go b/builder/googlecompute/private_key.go index 6bf22a309..cf81cba06 100644 --- a/builder/googlecompute/private_key.go +++ b/builder/googlecompute/private_key.go @@ -19,7 +19,7 @@ func processPrivateKeyFile(privateKeyFile, passphrase string) ([]byte, error) { PEMBlock, _ := pem.Decode(rawPrivateKeyBytes) if PEMBlock == nil { return nil, fmt.Errorf( - "%s does not contain a vaild private key", privateKeyFile) + "%s does not contain a valid private key", privateKeyFile) } if x509.IsEncryptedPEMBlock(PEMBlock) { From ecc3d12340509065d04699d9b265b02248d4505d Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:28:29 +0000 Subject: [PATCH 84/89] spelling: validate --- website/source/docs/templates/engine.html.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/source/docs/templates/engine.html.md b/website/source/docs/templates/engine.html.md index 065e6001b..dd5c9e0fe 100644 --- a/website/source/docs/templates/engine.html.md +++ b/website/source/docs/templates/engine.html.md @@ -67,7 +67,7 @@ Here is a full list of the available functions for reference. This engine does not guarantee that the final image name will match the regex; it will not truncate your name if it exceeds 63 characters, and it - will not valiate that the beginning and end of the engine's output are + will not validate that the beginning and end of the engine's output are valid. For example, `"image_name": {{isotime | clean_image_name}}"` will cause your build to fail because the image name will start with a number, which is why in the From 0171dfc890e4bc7edd2434244aa309b514595ee5 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:28:19 +0000 Subject: [PATCH 85/89] spelling: validating --- builder/amazon/common/run_config.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/amazon/common/run_config.go b/builder/amazon/common/run_config.go index 289a461b9..f647182aa 100644 --- a/builder/amazon/common/run_config.go +++ b/builder/amazon/common/run_config.go @@ -78,7 +78,7 @@ func (c *RunConfig) Prepare(ctx *interpolate.Context) []error { // Validation errs := c.Comm.Prepare(ctx) - // Valadating ssh_interface + // Validating ssh_interface if c.SSHInterface != "public_ip" && c.SSHInterface != "private_ip" && c.SSHInterface != "public_dns" && From aa52f68fda11ddba7f0f9906de3a29e7312873a5 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:28:07 +0000 Subject: [PATCH 86/89] spelling: variable --- website/source/docs/builders/alicloud-ecs.html.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/source/docs/builders/alicloud-ecs.html.md b/website/source/docs/builders/alicloud-ecs.html.md index 5c4330778..df7abbeff 100644 --- a/website/source/docs/builders/alicloud-ecs.html.md +++ b/website/source/docs/builders/alicloud-ecs.html.md @@ -159,7 +159,7 @@ builder. `_` or `-`. It cannot begin with `http://` or `https://`. - `security_token` (string) - STS access token, can be set through template or by exporting - as environment vairalbe such "export SecurityToken=value". + as environment variable such "export SecurityToken=value". - `skip_region_validation` (boolean) - The region validation can be skipped if this value is true, the default value is false. From 27dfe92f1cd5aebf889296a632abfc46e41bd56a Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:29:14 +0000 Subject: [PATCH 87/89] spelling: virtualization --- builder/file/builder.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/file/builder.go b/builder/file/builder.go index f8b52e609..407bfcee5 100644 --- a/builder/file/builder.go +++ b/builder/file/builder.go @@ -2,7 +2,7 @@ package file /* The File builder creates an artifact from a file. Because it does not require -any virutalization or network resources, it's very fast and useful for testing. +any virtualization or network resources, it's very fast and useful for testing. */ import ( From c5482b3e7e77f045480099aa55af6907f42137b3 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:29:50 +0000 Subject: [PATCH 88/89] spelling: warnings --- packer/build_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packer/build_test.go b/packer/build_test.go index dd78bf4e7..a903c9803 100644 --- a/packer/build_test.go +++ b/packer/build_test.go @@ -102,7 +102,7 @@ func TestBuild_Prepare_Twice(t *testing.T) { build.Prepare() } -func TestBuildPrepare_BuilderWarniings(t *testing.T) { +func TestBuildPrepare_BuilderWarnings(t *testing.T) { expected := []string{"foo"} build := testBuild() From 38ffc65c4ec7d9d5df6cbb3fda9560574105d907 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 14 Mar 2018 03:30:07 +0000 Subject: [PATCH 89/89] spelling: whether --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fe2f21796..8d922192d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1569,7 +1569,7 @@ * builder/docker: Can now specify login credentials to pull images. * builder/docker: Support mounting additional volumes. [GH-1430] * builder/parallels/all: Path to tools ISO is calculated automatically. [GH-1455] -* builder/parallels-pvm: `reassign_mac` option to choose wehther or not +* builder/parallels-pvm: `reassign_mac` option to choose whether or not to generate a new MAC address. [GH-1461] * builder/qemu: Can specify "none" acceleration type. [GH-1395] * builder/qemu: Can specify "tcg" acceleration type. [GH-1395]