upstream/packer
1
0
Fork 0
mirror of https://github.com/hashicorp/packer.git synced 2026-04-21 22:26:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

packer: include builder type in HCP name for JSON

Browse source 
JSON templates used only to report the builder's type in HCP builds,
even if the name was specified.

This commit changes this behaviour to include both if they're available,
in a similar fashion as what is done on the HCL2 templates.
This commit is contained in:
Lucas Bajolet 2022-10-20 10:12:32 -04:00 committed by Lucas Bajolet
parent 971340d481
commit 35496e533d
2 changed files with 26 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
command/registry.go
View file

@ -158,7 +158,7 @@ func setupRegistryForPackerCore(cfg *CoreWrapper) hcl.Diagnostics {
cfg.Core.Bucket = bucket
for _, b := range cfg.Core.Template.Builders {
// Get all builds slated within config ignoring any only or exclude flags.
cfg.Core.Bucket.RegisterBuildForComponent(b.Name)
cfg.Core.Bucket.RegisterBuildForComponent(packer.HCPName(b))
}
return diags

28
packer/core.go
View file

@ -293,6 +293,24 @@ func (c *Core) GetBuilds(opts GetBuildsOptions) ([]packersdk.Build, hcl.Diagnost
return builds, diags
}
// HCPName is a helper to get a curated HCP name for a legacy JSON builder.
//
// In order to make the naming scheme between HCL2 and JSON more consistent,
// we implement a similar kind of logic on both template types.
//
// This means that when for HCL2 templates we have a build name formed of
// the source type and the source name, we will do the name here for JSON.
func HCPName(builder *template.Builder) string {
// By default, if the name is unspecified, it will be assigned the type
//
// No need to repeat ourselves here, so we can keep the current behaviour
if builder.Name == builder.Type {
return builder.Name
}
return fmt.Sprintf("%s.%s", builder.Type, builder.Name)
}
// Build returns the Build object for the given name.
func (c *Core) Build(n string) (packersdk.Build, error) {
// Setup the builder
@ -320,6 +338,10 @@ func (c *Core) Build(n string) (packersdk.Build, error) {
// rawName is the uninterpolated name that we use for various lookups
rawName := configBuilder.Name
// hcpName is the name we use for HCP, i.e. a concatenation of type+name
// if both are specified.
hcpName := HCPName(configBuilder)
// Setup the provisioners for this build
provisioners := make([]CoreBuildProvisioner, 0, len(c.Template.Provisioners))
for _, rawP := range c.Template.Provisioners {
@ -379,7 +401,7 @@ func (c *Core) Build(n string) (packersdk.Build, error) {
if c.Bucket != nil {
postProcessor = &RegistryPostProcessor{
BuilderType: n,
BuilderType: hcpName,
ArtifactMetadataPublisher: c.Bucket,
PostProcessor: postProcessor,
}
@ -405,7 +427,7 @@ func (c *Core) Build(n string) (packersdk.Build, error) {
postProcessors = append(postProcessors, []CoreBuildPostProcessor{
{
PostProcessor: &RegistryPostProcessor{
BuilderType: n,
BuilderType: hcpName,
ArtifactMetadataPublisher: c.Bucket,
},
},
@ -416,7 +438,7 @@ func (c *Core) Build(n string) (packersdk.Build, error) {
if c.Bucket != nil {
builder = &RegistryBuilder{
Name: n,
Name: hcpName,
ArtifactMetadataPublisher: c.Bucket,
Builder: builder,
}