upstream/packer
1
0
Fork 0
mirror of https://github.com/hashicorp/packer.git synced 2026-05-28 04:35:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Merge pull request #9318 from hashicorp/fix_build_prepare_failure_handling

Browse source 
move this to after the prepare() is successful so that we don't try t…
This commit is contained in:
Megan Marsh 2020-05-28 12:29:46 -07:00 committed by GitHub
commit 193395d734
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packer/core.go
View file

@ -215,7 +215,6 @@ func (c *Core) GetBuilds(opts GetBuildsOptions) ([]Build, hcl.Diagnostics) {
})
continue
}
builds = append(builds, b)
// Now that build plugin has been launched, call Prepare()
log.Printf("Preparing build: %s", b.Name())
@ -233,6 +232,9 @@ func (c *Core) GetBuilds(opts GetBuildsOptions) ([]Build, hcl.Diagnostics) {
continue
}
// Only append builds to list if the Prepare() is successful.
builds = append(builds, b)
if len(warnings) > 0 {
for _, warning := range warnings {
diags = append(diags, &hcl.Diagnostic{