mirror of
https://github.com/opnsense/src.git
synced 2026-06-19 21:49:14 -04:00
Multiple issues existed within the powerpc FP/VSX save/restore functionality, leading to register corruption and loss of register contents in specific scenarios involving high signal load and use of both floating point and VSX instructions. Issue #1 On little endian systems the PCB used the wrong location for the shadowed FP register within the larger VSX register. This appears to have been an attempt to correct issue #2 without understanding how the vector load/store instructions actually operate. Issue #2 On little endian systems, the VSX state save/restore routines swapped 32-bit words within the 64-bit aliased double word for the associated floating point register. This was due to the use of a word-oriented load/store vs. doubleword oriented load/store. Issue #3 The FPU was turned off in the PCB but not in hardware, leading to a potential race condition if the same thread was scheduled immediately after sigreturn. The triggering codebase for this is Go, which makes heavy use of signals and and generates an unusual mix of floating point and VSX assembler. As a result, when combined with th powerpc lazy FPU restore, a condition was repeatedly hit whereby the thread was interrupted in FP+VSX mode, then restored in FP only mode, thus reliably triggering the issues above. Also clean up the associated asm() style issue flagged by GitHub Actions. Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com> MFC after: 1 week Pull Request: https://github.com/freebsd/freebsd-src/pull/1756
129 lines
4.1 KiB
C
129 lines
4.1 KiB
C
/*-
|
|
* SPDX-License-Identifier: BSD-4-Clause
|
|
*
|
|
* Copyright (C) 1995, 1996 Wolfgang Solfrank.
|
|
* Copyright (C) 1995, 1996 TooLs GmbH.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. All advertising materials mentioning features or use of this software
|
|
* must display the following acknowledgement:
|
|
* This product includes software developed by TooLs GmbH.
|
|
* 4. The name of TooLs GmbH may not be used to endorse or promote products
|
|
* derived from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY TOOLS GMBH ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL TOOLS GMBH BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
|
|
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
|
|
* OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
|
|
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
|
|
* OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
|
|
* ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*
|
|
* $NetBSD: pcb.h,v 1.4 2000/06/04 11:57:17 tsubai Exp $
|
|
*/
|
|
|
|
#ifndef _MACHINE_PCB_H_
|
|
#define _MACHINE_PCB_H_
|
|
|
|
#include <sys/endian.h>
|
|
|
|
#include <machine/setjmp.h>
|
|
|
|
#ifndef _STANDALONE
|
|
struct pcb {
|
|
register_t pcb_context[20]; /* non-volatile r12-r31 */
|
|
register_t pcb_cr; /* Condition register */
|
|
register_t pcb_sp; /* stack pointer */
|
|
register_t pcb_toc; /* toc pointer */
|
|
register_t pcb_lr; /* link register */
|
|
register_t pcb_dscr; /* dscr value */
|
|
register_t pcb_fscr;
|
|
register_t pcb_tar;
|
|
struct pmap *pcb_pm; /* pmap of our vmspace */
|
|
jmp_buf *pcb_onfault; /* For use during
|
|
copyin/copyout */
|
|
int pcb_flags;
|
|
#define PCB_FPU 0x1 /* Process uses FPU */
|
|
#define PCB_FPREGS 0x2 /* Process had FPU registers initialized */
|
|
#define PCB_VEC 0x4 /* Process uses Altivec */
|
|
#define PCB_VSX 0x8 /* Process had VSX initialized */
|
|
#define PCB_CDSCR 0x10 /* Process had Custom DSCR initialized */
|
|
#define PCB_HTM 0x20 /* Process had HTM initialized */
|
|
#define PCB_CFSCR 0x40 /* Process had FSCR updated */
|
|
#define PCB_KERN_FPU 0x80 /* Kernel is using FPU/Vector unit */
|
|
#define PCB_KERN_FPU_NOSAVE 0x100 /* FPU/Vec state not saved for kernel use */
|
|
#define PCB_VECREGS 0x200 /* Process had Altivec registers initialized */
|
|
struct fpu {
|
|
union {
|
|
uint32_t vsr[4];
|
|
double fpr;
|
|
} fpr[32];
|
|
double fpscr; /* FPSCR stored as double for easier access */
|
|
} pcb_fpu; /* Floating point processor */
|
|
unsigned int pcb_fpcpu; /* which CPU had our FPU
|
|
stuff. */
|
|
struct vec {
|
|
uint32_t vr[32][4];
|
|
uint32_t spare[2];
|
|
uint32_t vrsave;
|
|
uint32_t vscr; /* aligned at vector element 3 */
|
|
} pcb_vec __aligned(16); /* Vector processor */
|
|
unsigned int pcb_veccpu; /* which CPU had our vector
|
|
stuff. */
|
|
struct htm {
|
|
uint64_t tfhar;
|
|
uint64_t texasr;
|
|
uint64_t tfiar;
|
|
} pcb_htm;
|
|
|
|
struct ebb {
|
|
uint64_t ebbhr;
|
|
uint64_t ebbrr;
|
|
uint64_t bescr;
|
|
} pcb_ebb;
|
|
|
|
struct lmon {
|
|
uint64_t lmrr;
|
|
uint64_t lmser;
|
|
} pcb_lm;
|
|
|
|
union {
|
|
struct {
|
|
vm_offset_t usr_segm; /* Base address */
|
|
register_t usr_vsid; /* USER_SR segment */
|
|
} aim;
|
|
struct {
|
|
register_t dbcr0;
|
|
} booke;
|
|
} pcb_cpu;
|
|
vm_offset_t pcb_lastill; /* Last illegal instruction */
|
|
};
|
|
#endif
|
|
|
|
#ifdef _KERNEL
|
|
|
|
struct trapframe;
|
|
|
|
#ifndef curpcb
|
|
extern struct pcb *curpcb;
|
|
#endif
|
|
|
|
extern struct pmap *curpm;
|
|
extern struct proc *fpuproc;
|
|
|
|
void makectx(struct trapframe *, struct pcb *);
|
|
void savectx(struct pcb *) __returns_twice;
|
|
|
|
#endif
|
|
#endif /* _MACHINE_PCB_H_ */
|