mirror of
https://github.com/opnsense/src.git
synced 2026-05-19 08:25:22 -04:00
847967bc4e
asomers@ found a problem with the NFS client, where a write to an NFS mounted file done via mmap(2) was lost when fspacectl(2) was done before it. This turned out to be caused by clearing the dirty bit on pages when the client was doing commit RPCs, due to the second argument to vfs_busy_pages() being set to 1. Commit RPCs tell the server to commit previously written data to stable storage. However, Commit RPCs do not write data from the client to the server. As such, if the dirty bit on the page has been set by a mmap'd write to an address in the page, it should not be cleared. Clearing it causes the mmap'd write to by lost. This patch fixes the problem by changing the 2nd argument to vfs_busy_pages() to 0 for this case. I doubt this bug has affected many, since it was inherited from the old NFS client and was in 4.3 FreeBSD twenty years ago. Although fspacectl(2) is FreeBSD 14 specific, a write(2) would cause the same failure. Reviewed by: kib Tested by: asomers PR: 269328 MFC after: 1 week |
||
|---|---|---|
| .. | ||
| nfs.h | ||
| nfs_clbio.c | ||
| nfs_clcomsubs.c | ||
| nfs_clkdtrace.c | ||
| nfs_clkrpc.c | ||
| nfs_clnfsiod.c | ||
| nfs_clnode.c | ||
| nfs_clport.c | ||
| nfs_clrpcops.c | ||
| nfs_clstate.c | ||
| nfs_clsubs.c | ||
| nfs_clvfsops.c | ||
| nfs_clvnops.c | ||
| nfs_kdtrace.h | ||
| nfsmount.h | ||
| nfsnode.h | ||
| nlminfo.h | ||