mirror of
https://github.com/opnsense/src.git
synced 2026-04-04 08:55:18 -04:00
8ac5aef8f3
This change takes capsicum-test from upstream and applies some local changes to make the
tests work on FreeBSD when executed via Kyua.
The local modifications are as follows:
1. Make `OpenatTest.WithFlag` pass with the new dot-dot lookup behavior in FreeBSD 12.x+.
2. capsicum-test references a set of helper binaries: `mini-me`, `mini-me.noexec`, and
`mini-me.setuid`, as part of the execve/fexecve tests, via execve, fexecve, and open.
It achieves this upstream by assuming `mini-me*` is in the current directory, however,
in order for Kyua to execute `capsicum-test`, it needs to provide a full path to
`mini-me*`. In order to achieve this, I made `capsicum-test` cache the executable's
path from argv[0] in main(..) and use the cached value to compute the path to
`mini-me*` as part of the execve/fexecve testcases.
3. The capsicum-test test suite assumes that it's always being run on CAPABILITIES enabled
kernels. However, there's a chance that the test will be run on a host without a
CAPABILITIES enabled kernel, so we must check for the support before running the tests.
The way to achieve this is to add the relevant `feature_present("security_capabilities")`
check to SetupEnvironment::SetUp() and skip the tests when the support is not available.
While here, add a check for `kern.trap_enotcap` being enabled. As noted by markj@ in
https://github.com/google/capsicum-test/issues/23, this sysctl being enabled can trigger
non-deterministic failures. Therefore, the tests should be skipped if this sysctl is
enabled.
All local changes have been submitted to the capsicum-test project
(https://github.com/google/capsicum-test) and are in various stages of review.
Please see the following pull requests for more details:
1. https://github.com/google/capsicum-test/pull/35
2. https://github.com/google/capsicum-test/pull/41
3. https://github.com/google/capsicum-test/pull/42
Reviewed by: asomers
Discussed with: emaste, markj
Approved by: emaste (mentor)
MFC after: 2 months
Differential Revision: https://reviews.freebsd.org/D19758
38 lines
1 KiB
C
38 lines
1 KiB
C
#include <sys/types.h>
|
|
#include <fcntl.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
|
|
int main(int argc, char* argv[]) {
|
|
if (argc == 2 && !strcmp(argv[1], "--pass")) {
|
|
fprintf(stderr,"[%d] %s immediately returning 0\n", getpid(), argv[0]);
|
|
return 0;
|
|
}
|
|
|
|
if (argc == 2 && !strcmp(argv[1], "--fail")) {
|
|
fprintf(stderr,"[%d] %s immediately returning 1\n", getpid(), argv[0]);
|
|
return 1;
|
|
}
|
|
|
|
if (argc == 2 && !strcmp(argv[1], "--checkroot")) {
|
|
int rc = (geteuid() == 0);
|
|
fprintf(stderr,"[uid:%d] %s immediately returning (geteuid() == 0) = %d\n", geteuid(), argv[0], rc);
|
|
return rc;
|
|
}
|
|
|
|
if (argc == 2 && !strcmp(argv[1], "--capmode")) {
|
|
/* Expect to already be in capability mode: check we can't open a file */
|
|
int rc = 0;
|
|
|
|
int fd = open("/etc/passwd", O_RDONLY);
|
|
if (fd > 0) {
|
|
fprintf(stderr,"[%d] %s unexpectedly able to open file\n", getpid(), argv[0]);
|
|
rc = 1;
|
|
}
|
|
fprintf(stderr,"[%d] %s --capmode returning %d\n", getpid(), argv[0], rc);
|
|
return rc;
|
|
}
|
|
|
|
return -1;
|
|
}
|