mirror of
https://github.com/opnsense/src.git
synced 2026-04-04 08:55:18 -04:00
c1a540709a
Merge commit 5033f0793fe6 from llvm git (by Dimitry Andric):
[lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLanguage
When assertions are turned off, the `llvm::Error` value created at the
start of this function is overwritten using the move-assignment
operator, but the success value is never checked. Whenever a TypeSystem
cannot be found or created, this can lead to lldb core dumping with:
Program aborted due to an unhandled Error:
Error value was Success. (Note: Success values must still be checked prior to being destroyed).
Fix this by not creating a `llvm::Error` value in advance, and directly
returning the result of `llvm::make_error` instead, whenever an error is
encountered.
See also: <https://bugs.freebsd.org/253881> and
<https://bugs.freebsd.org/257829>.
Reviewed By: teemperor
Differential Revision: https://reviews.llvm.org/D108088
Reported by: dmgk, ota@j.email.ne.jp
PR: 253881, 257829
MFC after: 3 days
|
||
|---|---|---|
| .. | ||
| API | ||
| Breakpoint | ||
| Commands | ||
| Core | ||
| DataFormatters | ||
| Expression | ||
| Host | ||
| Initialization | ||
| Interpreter | ||
| Plugins | ||
| Symbol | ||
| Target | ||
| Utility | ||
| lldb.cpp | ||