upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-02-19 02:30:08 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions
opnsense-src/sys/dev/ena
History
Gleb Smirnoff a6b55ee6be net: replace IFF_KNOWSEPOCH with IFF_NEEDSEPOCH 
Expect that drivers call into the network stack with the net epoch
entered. This has already been the fact since early 2020. The net
interrupts, that are marked with INTR_TYPE_NET, were entering epoch
since 511d1afb6b. For the taskqueues there is NET_TASK_INIT() and
all drivers that were known back in 2020 we marked with it in
6c3e93cb5a. However in e87c494015 we took conservative approach
and preferred to opt-in rather than opt-out for the epoch.

This change not only reverts e87c494015 but adds a safety belt to
avoid panicing with INVARIANTS if there is a missed driver. With
INVARIANTS we will run in_epoch() check, print a warning and enter
the net epoch.  A driver that prints can be quickly fixed with the
IFF_NEEDSEPOCH flag, but better be augmented to properly enter the
epoch itself.

Note on TCP LRO: it is a backdoor to enter the TCP stack bypassing
some layers of net stack, ignoring either old IFF_KNOWSEPOCH or the
new IFF_NEEDSEPOCH.  But the tcp_lro_flush_all() asserts the presence
of network epoch.  Indeed, all NIC drivers that support LRO already
provide the epoch, either with help of INTR_TYPE_NET or just running
NET_EPOCH_ENTER() in their code.

Reviewed by:		zlei, gallatin, erj
Differential Revision:	https://reviews.freebsd.org/D39510
2023-04-17 09:08:35 -07:00
..
ena.c net: replace IFF_KNOWSEPOCH with IFF_NEEDSEPOCH 2023-04-17 09:08:35 -07:00
ena.h ena: Update driver version to v2.6.2 2023-01-13 17:07:04 +01:00
ena_datapath.c Mechanically convert ena(4) to DrvAPI 2023-01-13 17:09:17 +01:00
ena_datapath.h ena: Fix styling issues 2022-06-30 17:32:04 +02:00
ena_netmap.c Mechanically convert ena(4) to DrvAPI 2023-01-13 17:09:17 +01:00
ena_netmap.h ena: Fix styling issues 2022-06-30 17:32:04 +02:00
ena_rss.c ena: Fix styling issues 2022-06-30 17:32:04 +02:00
ena_rss.h ena: Fix styling issues 2022-06-30 17:32:04 +02:00
ena_sysctl.c ena: Align names of constants 2022-06-30 17:32:13 +02:00
ena_sysctl.h ena: Fix styling issues 2022-06-30 17:32:04 +02:00