mirror of
https://github.com/opnsense/src.git
synced 2026-04-01 15:35:10 -04:00
c2f16c595e
Because the ESP mount point (/boot/efi) is in mtree, tar will attempt to extract a directory at that point post-mount when the system is installed. Normally, this is fine, since tar can happily set whatever properties it wants. For FAT32 file systems, however, like the ESP, tar will attempt to set mtime on the root directory, which FAT does not support, and tar will interpret this as a fatal error, breaking the install (see https://github.com/libarchive/libarchive/issues/1516). This issue would also break scripted installs on bare-metal POWER8, POWER9, and PS3 systems, as well as some ARM systems. This patch solves the problem in two ways: - If stdout is a TTY, use the distextract stage instead of tar, as in interactive installs. distextract solves this problem internally and provides a nicer UI to boot, but requires a TTY. - If stdout is not a TTY, use tar but, as a stopgap for 13.0, exclude boot/efi from tarball extraction and then add it by hand. This is a hack, and better solutions (as in the libarchive ticket above) will obsolete it, but it solves the most common case, leaving only unattended TTY-less installs on a few tier-2 platforms broken. In addition, fix a bug with fstab generation uncovered once the tar issue is fixed that umount(8) can depend on the ordering of lines in fstab in a way that mount(8) does not. The partition editor now writes out fstab in mount order, making sure umount (run at the end of scripted, but not interactive, installs) succeeds. PR: 254395 Reviewed by: gjb, imp MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D29380 |
||
|---|---|---|
| .. | ||
| adduser | ||
| auto | ||
| bootconfig | ||
| checksum | ||
| config | ||
| docsinstall | ||
| entropy | ||
| hardening | ||
| hostname | ||
| jail | ||
| keymap | ||
| Makefile | ||
| Makefile.depend | ||
| mirrorselect | ||
| mount | ||
| netconfig | ||
| netconfig_ipv4 | ||
| netconfig_ipv6 | ||
| rootpass | ||
| script | ||
| services | ||
| time | ||
| umount | ||
| wlanconfig | ||
| zfsboot | ||