mirror of
https://github.com/opnsense/src.git
synced 2026-03-05 14:50:41 -05:00
d41b89cca5
ath kernel module:
sys/dev/ath/ath_hal/ar5212/ar5212_reset.c:2642:7: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
if (abs(lp[0] * EEP_SCALE - target) < EEP_DELTA) {
^
sys/dev/ath/ah_osdep.h:74:18: note: expanded from macro 'abs'
#define abs(_a) __builtin_abs(_a)
^
sys/dev/ath/ath_hal/ar5212/ar5212_reset.c:2642:7: note: remove the call to '__builtin_abs' since unsigned values cannot be negative
sys/dev/ath/ah_osdep.h:74:18: note: expanded from macro 'abs'
#define abs(_a) __builtin_abs(_a)
^
1 error generated.
This warning occurs because both lp[0] and target are unsigned, so the
subtraction expression is also unsigned, and calling abs() is a no-op.
However, the intention was to look at the absolute difference between
the two unsigned quantities. Introduce a small static function to
clarify what we're doing, and call that instead.
Reviewed by: adrian
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D1212
|
||
|---|---|---|
| .. | ||
| ah_regdomain | ||
| ar5210 | ||
| ar5211 | ||
| ar5212 | ||
| ar5312 | ||
| ar5416 | ||
| ar9001 | ||
| ar9002 | ||
| ar9003 | ||
| ah.c | ||
| ah.h | ||
| ah_debug.h | ||
| ah_decode.h | ||
| ah_desc.h | ||
| ah_devid.h | ||
| ah_diagcodes.h | ||
| ah_eeprom.h | ||
| ah_eeprom_9287.c | ||
| ah_eeprom_9287.h | ||
| ah_eeprom_v1.c | ||
| ah_eeprom_v1.h | ||
| ah_eeprom_v3.c | ||
| ah_eeprom_v3.h | ||
| ah_eeprom_v4k.c | ||
| ah_eeprom_v4k.h | ||
| ah_eeprom_v14.c | ||
| ah_eeprom_v14.h | ||
| ah_internal.h | ||
| ah_regdomain.c | ||
| ah_regdomain.h | ||
| ah_soc.h | ||