mirror of
https://github.com/opnsense/src.git
synced 2026-03-30 22:45:13 -04:00
35a1aa5f9c
Summary:
Failure to update the FP / vector state was causing daemon(3) to violate C ABI by failing to preserve nonvolatile registers.
This was causing a weird issue where moused was not working on PowerBook G4s when daemonizing, but was working fine when running it foreground.
Force saving off the same state that cpu_switch() does in cases where we are about to copy a thread.
MFC after: 1 week
Sponsored by: Tag1 Consulting, Inc.
Test Plan:
```
/*
* Test for ABI violation due to side effects of daemon(3).
*
* NOTE: Compile with -O2 to see the effect.
*/
/* Allow compiling for Linux too. */
static double test = 1234.56f;
/*
* This contrivance coerces clang to not bounce the double
* off of memory again in main.
*/
void __attribute__((noinline))
print_double(int j1, int j2, double d)
{
printf("%f\n", d);
}
int
main(int argc, char *argv[])
{
print_double(0, 0, test);
if (daemon(0, 1)) {
}
/* Compiler assumes nonvolatile regs are intact... */
print_double(0, 0, test);
return(0);
}
```
Working output:
```
1234.560059
1234.560059
```
Output in broken case:
```
1234.560059
0.0
```
Reviewers: #powerpc
Subscribers: jhibbits, luporl, alfredo
Tags: #powerpc
Differential Revision: https://reviews.freebsd.org/D29851
91 lines
1.7 KiB
C
91 lines
1.7 KiB
C
/* $NetBSD: reg.h,v 1.4 2000/06/04 09:30:44 tsubai Exp $ */
|
|
/* $FreeBSD$ */
|
|
|
|
#ifndef _POWERPC_REG_H_
|
|
#define _POWERPC_REG_H_
|
|
|
|
/* Must match struct trapframe */
|
|
struct reg {
|
|
register_t fixreg[32];
|
|
register_t lr;
|
|
register_t cr;
|
|
register_t xer;
|
|
register_t ctr;
|
|
register_t pc;
|
|
};
|
|
|
|
struct fpreg {
|
|
double fpreg[32];
|
|
double fpscr;
|
|
};
|
|
|
|
/* Must match pcb.pcb_vec */
|
|
struct vmxreg {
|
|
uint32_t vr[32][4];
|
|
uint32_t pad[2];
|
|
uint32_t vrsave;
|
|
uint32_t vscr;
|
|
};
|
|
|
|
struct dbreg {
|
|
unsigned int junk;
|
|
};
|
|
|
|
#ifdef __LP64__
|
|
/* Must match struct trapframe */
|
|
struct reg32 {
|
|
int32_t fixreg[32];
|
|
int32_t lr;
|
|
int32_t cr;
|
|
int32_t xer;
|
|
int32_t ctr;
|
|
int32_t pc;
|
|
};
|
|
|
|
struct fpreg32 {
|
|
struct fpreg data;
|
|
};
|
|
|
|
struct vmxreg32 {
|
|
struct vmxreg data;
|
|
};
|
|
|
|
struct dbreg32 {
|
|
struct dbreg data;
|
|
};
|
|
|
|
#define __HAVE_REG32
|
|
#endif
|
|
|
|
#ifdef _KERNEL
|
|
/*
|
|
* XXX these interfaces are MI, so they should be declared in a MI place.
|
|
*/
|
|
int fill_regs(struct thread *, struct reg *);
|
|
int set_regs(struct thread *, struct reg *);
|
|
int fill_fpregs(struct thread *, struct fpreg *);
|
|
int set_fpregs(struct thread *, struct fpreg *);
|
|
int fill_dbregs(struct thread *, struct dbreg *);
|
|
int set_dbregs(struct thread *, struct dbreg *);
|
|
|
|
/*
|
|
* MD interfaces.
|
|
*/
|
|
void cpu_save_thread_regs(struct thread *);
|
|
|
|
#ifdef COMPAT_FREEBSD32
|
|
struct image_params;
|
|
|
|
int fill_regs32(struct thread *, struct reg32 *);
|
|
int set_regs32(struct thread *, struct reg32 *);
|
|
void ppc32_setregs(struct thread *, struct image_params *, uintptr_t);
|
|
|
|
#define fill_fpregs32(td, reg) fill_fpregs(td,(struct fpreg *)reg)
|
|
#define set_fpregs32(td, reg) set_fpregs(td,(struct fpreg *)reg)
|
|
#define fill_dbregs32(td, reg) fill_dbregs(td,(struct dbreg *)reg)
|
|
#define set_dbregs32(td, reg) set_dbregs(td,(struct dbreg *)reg)
|
|
#endif
|
|
|
|
#endif
|
|
|
|
#endif /* _POWERPC_REG_H_ */
|