opnsense-src/sys
Andrew Gallatin 3183d0b680 iflib: initialize LRO unconditionally
Changes to the LRO code have exposed a bug in iflib where devices
which are not capable of doing LRO are still calling
tcp_lro_flush_all(), even when they have not initialized the LRO
context. This used to be mostly harmless, but the LRO code now sets
the VNET based on the ifp in the lro context and will try to access it
through a NULL ifp resulting in a panic at boot.

To fix this, we unconditionally initializes LRO so that we have a
valid LRO context when calling tcp_lro_flush_all(). One alternative is
to check the device capabilities before calling tcp_lro_flush_all() or
adding a new state flag in the ctx. However, it seems unwise to add an
extra, mostly useless test for higher performance devices when we can
just initialize LRO for all devices.

Reviewed by: erj, hselasky, markj, olivier
Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D29928
2021-04-23 05:55:20 -04:00
..
amd64 AMD-vi: Fortify IVHD device_identify process 2021-04-19 16:08:13 +08:00
arm arm: Add no-cftconvert for sdma-imx6 files 2021-04-14 15:43:37 +02:00
arm64 arm64: adjust comments in dbg_monitor_exit() 2021-04-13 14:41:31 -03:00
bsm Add aio_writev and aio_readv 2021-01-02 19:57:58 -07:00
cam cam: make sure to clear even more CCBs allocated on the stack 2021-04-11 15:24:22 +01:00
cddl fbt: Remove some handling for multiple CTF containers 2021-04-02 17:49:13 -04:00
compat linuxkpi: reduce number of stray mm_struct allocations 2021-04-19 21:34:08 +03:00
conf newvers.sh: better regexp for the FreeBSD_version line 2021-04-22 11:45:12 -06:00
contrib zfs: use vn_seqc_read_notmodify for racing .. lookups 2021-04-22 13:18:39 +00:00
crypto ossl: Don't encryt/decrypt too much data for chacha20. 2021-04-01 15:49:07 -07:00
ddb ddb: replace watchpoint set/clear functions 2021-03-29 12:05:44 -03:00
dev cxgbe(4): Move the hw-specific parts of VXLAN setup to a separate function. 2021-04-23 00:26:47 -07:00
dts dts: Bump the freebsd branding version to 5.10 2021-03-23 15:02:21 +01:00
fs nfscommon: fix function name in comment 2021-04-19 20:09:46 -07:00
gdb gdb: report specific stop reason for watchpoints 2021-03-30 11:36:41 -03:00
geom gmirror: Pre-allocate the timeout event structure 2021-03-11 15:45:15 -05:00
gnu Remove the old dts imported tree. 2021-01-15 20:09:55 +01:00
i386 Create VM_MEMATTR_DEVICE on all architectures 2021-04-12 06:15:31 +00:00
isa Remove more remnants of sio(4) 2021-04-07 14:33:02 -04:00
kern newbus: style nit (align comments) 2021-04-21 15:37:24 -06:00
kgssapi opencrypto: Introduce crypto_dispatch_async() 2021-02-08 09:19:19 -05:00
libkern x86: remove gcov kernel support 2021-04-02 15:41:51 +03:00
mips OCF: Remove support for asymmetric cryptographic operations. 2021-04-12 14:28:43 -07:00
modules modules: remove stale if_wg reference 2021-04-15 19:59:13 -05:00
net iflib: initialize LRO unconditionally 2021-04-23 05:55:20 -04:00
net80211 net80211: prefix get_random_bytes() with net80211_ 2021-03-24 22:16:09 +00:00
netgraph ng_ubt: Block attachment of uninitialized Intel Wireless 7265 2021-04-15 17:26:32 +03:00
netinet Path MTU discovery hooks for offloaded TCP connections. 2021-04-21 13:00:16 -07:00
netinet6 tcp_input: always request read-locking of PCB for any pure SYN segment. 2021-04-20 10:02:20 -07:00
netipsec Revert "SO_RERROR indicates that receive buffer overflows should be handled as errors." 2021-02-08 22:32:32 +00:00
netpfil Add required checks for unmapped mbufs in ipdivert and ipfw 2021-04-21 15:47:05 -04:00
netsmb
nfs Fix panic when using BOOTP to resolve root path. 2021-03-28 14:02:40 -05:00
nfsclient nfs: Cleanup dead files 2021-03-17 06:16:31 +11:00
nfsserver nfs: Cleanup dead files 2021-03-17 06:16:31 +11:00
nlm
ofed LinuxKPI/OFED: (re)move inetdevice.h implementation 2021-03-30 14:40:46 +00:00
opencrypto OCF: Remove support for asymmetric cryptographic operations. 2021-04-12 14:28:43 -07:00
powerpc opal_console: fix serial console output corruption on powerpc64 2021-04-16 20:10:09 -03:00
riscv riscv: Assert that SUM is not set in SSTATUS for exceptions. 2021-04-21 13:57:20 -07:00
rpc nfsv4 client: do the BindConnectionToSession as required 2021-04-11 14:34:57 -07:00
security tcp_input/syncache: acquire only read lock on PCB for SYN,!ACK packets 2021-04-12 08:25:31 -07:00
sys __FreeBSD_version: update the references to the doc tree 2021-04-22 17:36:22 +08:00
teken loader: implement framebuffer console 2021-01-02 21:41:36 +02:00
tests Add IPv4 fib lookup performance tests with uniform keys. 2021-03-30 14:32:28 +01:00
tools syscalls.master: Add a new syscall type: RESERVED 2021-01-26 18:27:44 +00:00
ufs b_vflags update requries bufobj lock 2021-04-15 15:47:42 +03:00
vm sysctl vm.objects: report backing object and swap use 2021-04-19 21:32:01 +03:00
x86 amd64: Add MD bits for KASAN 2021-04-13 17:42:20 -04:00
xdr
xen xen: move x86-specific xen_vector_callback_enabled to sys/x86 2021-03-15 14:20:21 +01:00
Makefile