upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-02-18 18:20:26 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions
OPNsense - FreeBSD source
292431 commits 28 branches 220 tags 2.1 GiB
C 59.6%
C++ 26.7%
Roff 4.9%
Shell 2.8%
Assembly 1.7%
Other 3.8%
Find a file
Gleb Smirnoff 1bda3fae78 tcp: don't ever return ECONNRESET on close(2) 
The SUS doesn't mention this error code as a possible one [1]. The FreeBSD
manual page specifies a possible ECONNRESET for close(2):

[ECONNRESET]	The underlying object was a stream socket that was
		shut down by the peer before all pending data was
		delivered.

In the past it had been EINVAL (see 21367f630d), and this EINVAL was
added as a safety measure in 623dce13c6.  After conversion to
ECONNRESET it had been documented in the manual page in 78e3a7fdd5, but
I bet wasn't ever tested to actually be ever returned, cause the
tcp-testsuite[2] didn't exist back then.  So documentation is incorrect
since 2006, if my bet wins.  Anyway, in the modern FreeBSD the condition
described above doesn't end up with ECONNRESET error code from close(2).
The error condition is reported via SO_ERROR socket option, though.  This
can be checked using the tcp-testsuite, temporarily disabling the
getsockopt(SO_ERROR) lines using sed command [3].  Most of these
getsockopt(2)s are followed by '+0.00 close(3) = 0', which will confirm
that close(2) doesn't return ECONNRESET even on a socket that has the
error stored, neither it is returned in the case described in the manual
page.  The latter case is covered by multiple tests residing in tcp-
testsuite/state-event-engine/rcv-rst-*.

However, the deleted block of code could be entered in a race condition
between close(2) and processing of incoming packet, when connection had
already been half-closed with shutdown(SHUT_WR) and sits in TCPS_LAST_ACK.
This was reported in the bug 146845.  With the block deleted, we will
continue into tcp_disconnect() which has proper handling of INP_DROPPED.

The race explanation follows.  The connection is in TCPS_LAST_ACK.  The
network input thread acquires the tcpcb lock first, sets INP_DROPPED,
acquires the socket lock in soisdisconnected() and clears SS_ISCONNECTED.
Meanwhile, the syscall thread goes through sodisconnect() which checks for
SS_ISCONNECTED locklessly(!).  The check passes and the thread blocks on
the tcpcb lock in tcp_usr_disconnect().  Once input thread releases the
lock, the syscall thread observes INP_DROPPED and returns ECONNRESET.

- Thread 1: tcp_do_segment()->tcp_close()->in_pcbdrop(),soisdisconnected()
- Thread 2: sys_close()...->soclose()->sodisconnect()->tcp_usr_disconnect()

Note that the lockless operation in sodisconnect() isn't correct, but
enforcing the socket lock there will not fix the problem.

[1] https://pubs.opengroup.org/onlinepubs/9799919799/
[2] https://github.com/freebsd-net/tcp-testsuite
[3] sed -i "" -Ee '/\+0\.00 getsockopt\(3, SOL_SOCKET, SO_ERROR, \[ECONNRESET\]/d' $(grep -lr ECONNRESET tcp-testsuite)

PR:			146845
Reviewed by:		tuexen, rrs, imp
Differential Revision:	https://reviews.freebsd.org/D48148

(cherry picked from commit 053a988497342a6fd0a717cc097d09c23f83e103)
2025-03-31 10:31:21 -07:00
.cirrus-ci Cirrus-CI: add some timing info on pkg install failure 2021-08-04 15:02:00 -04:00
.github CODEOWNERS: Add nuageinit 2024-09-03 09:05:24 +02:00
bin sh(1): Replace recommendation of use of -e with a note 2025-03-15 15:00:17 +01:00
cddl libdtrace: Use designators to initialize the opcode array 2025-02-14 19:25:18 +00:00
contrib contrib/tzdata: import tzdata 2025b 2025-03-26 09:03:52 +08:00
crypto openssl: update ASM and version info for 3.0.16 import 2025-03-25 14:07:59 -07:00
etc mtree: Add missing flua entry 2025-02-17 20:09:00 +00:00
gnu Remove $FreeBSD$: one-line sh pattern 2023-08-16 11:55:03 -06:00
include include: add a userland version of __assert_unreachable 2025-03-18 13:55:24 +01:00
kerberos5 kerberos5: Mitigate the possibility of using an old libcrypto 2024-01-22 07:49:05 -08:00
lib tcp: don't ever return ECONNRESET on close(2) 2025-03-31 10:31:21 -07:00
libexec Revert "ntpd: Use the ntpd -u option in preference to the rc su plumbing" 2025-03-11 10:59:10 -07:00
release Copy the new ia32 loader 2025-03-25 19:28:38 -06:00
rescue zfs: merge openzfs/zfs@32949f256 (zfs-2.2-release) into stable/14 2023-09-03 09:15:24 +02:00
sbin devd: Don't install autofs.conf with WITHOUT_AUTOFS 2025-03-23 16:32:33 +01:00
secure openssl: update ASM and version info for 3.0.16 import 2025-03-25 14:07:59 -07:00
share hier.7: Storage partitions are not filesystems 2025-03-31 13:24:36 -04:00
stand loader: Fix 32-bit compatibility 2025-03-27 10:21:55 -07:00
sys tcp: don't ever return ECONNRESET on close(2) 2025-03-31 10:31:21 -07:00
targets rtlbtfw: Firmware loader for Realtek 87XX/88XX bluetooth USB adaptors 2024-12-22 06:34:35 +03:00
tests tests/sys/fs/fusefs: include iomanip header 2025-03-25 13:25:31 -07:00
tools tools/sysdoc: Chase sysctl rename 2025-03-27 15:15:04 -04:00
usr.bin top: Sync usage and synopsis 2025-03-31 13:26:26 -04:00
usr.sbin pkg: Fix Coverity warnings 2025-03-26 08:48:01 -07:00
.arcconfig arcanist: use FreeBSD/git project repository instead of FreeBSD/svn 2022-08-23 14:16:41 +00:00
.arclint
.cirrus.yml Cirrus-CI: Bump image to (supported) 13.4 2025-03-03 11:24:21 -05:00
.clang-format clang-format: Minor tweaks 2024-05-20 09:42:32 -04:00
.git-blame-ignore-revs git-blame-ignore-revs: OptionalObsoleteFiles.inc sorting commits 2023-12-02 00:56:40 +00:00
.gitattributes Add a basic clang-format configuration file 2019-06-07 15:23:52 +00:00
.gitignore .gitignore: Ignore LSP generated .cache 2023-03-07 10:04:18 -05:00
CONTRIBUTING.md CONTRIBUTING.md: fix typo from commmit to commit 2024-03-22 09:30:30 -04:00
COPYRIGHT Happy New Year 2023! 2023-01-01 13:44:43 +08:00
LOCKS Remove $FreeBSD$: one-line bare tag 2023-08-16 11:55:20 -06:00
MAINTAINERS Remove $FreeBSD$: one-line bare tag 2023-08-16 11:55:20 -06:00
Makefile universe: Permit requesting a specific version of GCC 2025-02-27 13:57:03 -05:00
Makefile.inc1 Makefile.inc1: Conditionalize some package related variables 2025-03-13 14:09:09 -04:00
Makefile.libcompat build{libcompat}: Pass UNIVERSE_TOOLCHAIN_PATH to the _lc_build-tools submake 2023-08-21 21:00:45 -07:00
Makefile.sys.inc Remove $FreeBSD$: one-line sh pattern 2023-08-16 11:55:03 -06:00
ObsoleteFiles.inc caroot: update the root bundle 2025-03-20 11:18:27 +01:00
README.md README.md: link to the list of supported platforms 2022-11-01 12:20:55 -03:00
RELNOTES RELNOTES: Add 960ee80949 note 2025-03-04 16:46:29 +01:00
UPDATING UPDATING: Show plural syntax for PORTS_MODULES 2025-03-26 01:40:42 -04:00

README.md

FreeBSD Source:

This is the top level of the FreeBSD source directory.

FreeBSD is an operating system used to power modern servers, desktops, and embedded platforms. A large community has continually developed it for more than thirty years. Its advanced networking, security, and storage features have made FreeBSD the platform of choice for many of the busiest web sites and most pervasive embedded networking and storage devices.

For copyright information, please see the file COPYRIGHT in this directory. Additional copyright information also exists for some sources in this tree - please see the specific source directories for more information.

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7), config(8), FreeBSD handbook on building userland, and Handbook for kernels for more information, including setting make(1) variables.

For information on the CPU architectures and platforms supported by FreeBSD, see the FreeBSD website's Platforms page.

Source Roadmap:

Directory Description
bin System/user commands.
cddl Various commands and libraries under the Common Development and Distribution License.
contrib Packages contributed by 3rd parties.
crypto Cryptography stuff (see crypto/README).
etc Template files for /etc.
gnu Commands and libraries under the GNU General Public License (GPL) or Lesser General Public License (LGPL). Please see gnu/COPYING and gnu/COPYING.LIB for more information.
include System include files.
kerberos5 Kerberos5 (Heimdal) package.
lib System libraries.
libexec System daemons.
release Release building Makefile & associated tools.
rescue Build system for statically linked /rescue utilities.
sbin System commands.
secure Cryptographic libraries and commands.
share Shared resources.
stand Boot loader sources.
sys Kernel sources (see sys/README.md).
targets Support for experimental DIRDEPS_BUILD
tests Regression tests which can be run by Kyua. See tests/README for additional information.
tools Utilities for regression testing and miscellaneous tasks.
usr.bin User commands.
usr.sbin System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see FreeBSD Handbook.