mirror of
https://github.com/opnsense/src.git
synced 2026-05-28 04:12:45 -04:00
a71853600c
See commit 4f02a7d739b3 for more background.
I cannot see a good reason to continue ignoring mismatching UIDs when
binding to INADDR_ANY. Looking at the sdr.V2.4a7n sources (mentioned in
bugzilla PR 7713), there is a CANT_MCAST_BIND hack wherein the
application binds to INADDR_ANY instead of a multicast address, but
CANT_MCAST_BIND isn't defined for FreeBSD builds.
It seems unlikely that we still have a use-case for allowing sockets
from different UIDs to bind to the same port when binding to the
unspecified address. And, as noted in D47832, applications like sdr
would have been broken by the inverted SO_REUSEPORT check removed in
that revision, apparently without any bug reports. Let's break
compatibility and simply disallow this case outright.
Also, add some comments, remove a hack in a regression test which tests
this funtionality, and add a new regression test to exercise the
remaining checks that were added in commit
|
||
|---|---|---|
| .. | ||
| libalias | ||
| arp.sh | ||
| carp.py | ||
| carp.sh | ||
| divert.sh | ||
| fibs.sh | ||
| fibs_test.sh | ||
| forward.sh | ||
| ip6_v4mapped_test.c | ||
| ip_reass_test.c | ||
| lpm.sh | ||
| Makefile | ||
| Makefile.depend | ||
| output.sh | ||
| redirect.py | ||
| redirect.sh | ||
| so_reuseport_lb_test.c | ||
| socket_afinet.c | ||
| tcp_connect_port_test.c | ||
| tcp_md5_getsockopt.c | ||
| tcp_user_cookie.c | ||
| udp_dontroute.c | ||